Hive
  1. Hive
  2. HIVE-1218

CREATE TABLE t LIKE some_view should create a new empty base table, but instead creates a copy of view

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.7.0
    • Fix Version/s: 0.8.0
    • Component/s: Query Processor
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      In 0.8.0, CREATE TABLE LIKE view_name creates a table by adopting the schema of view_name (fields and partition columns) using defaults for serde and file formats. Before 0.8.0, CREATE TABLE LIKE view_name would make a copy of the view.

      Description

      I think it should copy only the column definitions from the view metadata. Currently it is copying the entire descriptor, resulting in a new view instead of a new base table.

      1. HIVE-1218v0.patch
        17 kB
        Charles Chen
      2. HIVE-1218v2.patch
        23 kB
        Charles Chen
      3. HIVE-1218v3.patch
        41 kB
        Charles Chen
      4. HIVE-1218v4.patch
        19 kB
        Charles Chen
      5. HIVE-1218v5.patch
        37 kB
        Charles Chen
      6. HIVE-1218v6.patch
        37 kB
        Charles Chen
      7. HIVE-1218v7.patch
        37 kB
        Charles Chen
      8. HIVE-1218v8.patch
        37 kB
        Charles Chen

        Issue Links

          Activity

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1057/ ----------------------------------------------------------- Review request for hive. Summary ------- https://issues.apache.org/jira/browse/HIVE-1218 This addresses bug HIVE-1218 . https://issues.apache.org/jira/browse/HIVE-1218 Diffs http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1144394 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1144394 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1144394 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION Diff: https://reviews.apache.org/r/1057/diff Testing ------- Seems to work Thanks, Charles
          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1057/ ----------------------------------------------------------- (Updated 2011-07-11 22:06:40.671325) Review request for hive. Summary (updated) ------- https://issues.apache.org/jira/browse/HIVE-1218 This addresses bug HIVE-1218 . https://issues.apache.org/jira/browse/HIVE-1218 Diffs (updated) http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1145292 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 1145292 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1145292 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1145292 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION Diff: https://reviews.apache.org/r/1057/diff Testing (updated) ------- Thanks, Charles
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1057/#review1039
          -----------------------------------------------------------

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
          <https://reviews.apache.org/r/1057/#comment2112>

          indentation?

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q
          <https://reviews.apache.org/r/1057/#comment2115>

          Can you include a testcase for a partitioned view? I don't see a codepath for that (we agreed the new table should come out with the same partition columns as the view).

          Also add a testcase for create externa table like base_table since you fixed a bug in that existing codepath. You can put that in create_like.q since it doesn't have anything to do with views.

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q
          <https://reviews.apache.org/r/1057/#comment2116>

          Add order by on these queries for determinism.

          • John

          On 2011-07-11 22:06:40, Charles Chen wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1057/

          -----------------------------------------------------------

          (Updated 2011-07-11 22:06:40)

          Review request for hive.

          Summary

          -------

          https://issues.apache.org/jira/browse/HIVE-1218

          This addresses bug HIVE-1218.

          https://issues.apache.org/jira/browse/HIVE-1218

          Diffs

          -----

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1145292

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 1145292

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1145292

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1145292

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION

          Diff: https://reviews.apache.org/r/1057/diff

          Testing

          -------

          Thanks,

          Charles

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1057/#review1039 ----------------------------------------------------------- http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java < https://reviews.apache.org/r/1057/#comment2112 > indentation? http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q < https://reviews.apache.org/r/1057/#comment2115 > Can you include a testcase for a partitioned view? I don't see a codepath for that (we agreed the new table should come out with the same partition columns as the view). Also add a testcase for create externa table like base_table since you fixed a bug in that existing codepath. You can put that in create_like.q since it doesn't have anything to do with views. http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q < https://reviews.apache.org/r/1057/#comment2116 > Add order by on these queries for determinism. John On 2011-07-11 22:06:40, Charles Chen wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1057/ ----------------------------------------------------------- (Updated 2011-07-11 22:06:40) Review request for hive. Summary ------- https://issues.apache.org/jira/browse/HIVE-1218 This addresses bug HIVE-1218 . https://issues.apache.org/jira/browse/HIVE-1218 Diffs ----- http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1145292 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 1145292 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1145292 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1145292 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION Diff: https://reviews.apache.org/r/1057/diff Testing ------- Thanks, Charles
          Hide
          jiraposter@reviews.apache.org added a comment -
          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1057/ ----------------------------------------------------------- (Updated 2011-07-12 23:17:38.731527) Review request for hive. Changes ------- Fixed changes in comments Summary ------- https://issues.apache.org/jira/browse/HIVE-1218 This addresses bug HIVE-1218 . https://issues.apache.org/jira/browse/HIVE-1218 Diffs (updated) http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1145801 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1145801 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1145801 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1145801 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1145801 Diff: https://reviews.apache.org/r/1057/diff Testing (updated) ------- Running tests Thanks, Charles
          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1057/ ----------------------------------------------------------- (Updated 2011-07-13 23:34:26.247370) Review request for hive. Changes ------- Unit tests passed Summary ------- https://issues.apache.org/jira/browse/HIVE-1218 This addresses bug HIVE-1218 . https://issues.apache.org/jira/browse/HIVE-1218 Diffs http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1145801 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1145801 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1145801 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1145801 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1145801 Diff: https://reviews.apache.org/r/1057/diff Testing (updated) ------- Unit tests passed Thanks, Charles
          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1057/ ----------------------------------------------------------- (Updated 2011-07-14 18:54:32.868981) Review request for hive. Changes ------- Fixed dropped unit test Summary ------- https://issues.apache.org/jira/browse/HIVE-1218 This addresses bug HIVE-1218 . https://issues.apache.org/jira/browse/HIVE-1218 Diffs (updated) http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146841 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146841 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146841 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146841 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146841 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION Diff: https://reviews.apache.org/r/1057/diff Testing ------- Unit tests passed Thanks, Charles
          Hide
          John Sichi added a comment -

          Added some comments on review board.

          Show
          John Sichi added a comment - Added some comments on review board.
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1057/#review1062
          -----------------------------------------------------------

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q
          <https://reviews.apache.org/r/1057/#comment2134>

          Why are you doing DESCRIBE FORMATTED twice for these tables?

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out
          <https://reviews.apache.org/r/1057/#comment2135>

          Shouldn't this be EXTERNAL_TABLE?

          • John

          On 2011-07-14 18:54:32, Charles Chen wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1057/

          -----------------------------------------------------------

          (Updated 2011-07-14 18:54:32)

          Review request for hive.

          Summary

          -------

          https://issues.apache.org/jira/browse/HIVE-1218

          This addresses bug HIVE-1218.

          https://issues.apache.org/jira/browse/HIVE-1218

          Diffs

          -----

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146841

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146841

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146841

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146841

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146841

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION

          Diff: https://reviews.apache.org/r/1057/diff

          Testing

          -------

          Unit tests passed

          Thanks,

          Charles

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1057/#review1062 ----------------------------------------------------------- http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q < https://reviews.apache.org/r/1057/#comment2134 > Why are you doing DESCRIBE FORMATTED twice for these tables? http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out < https://reviews.apache.org/r/1057/#comment2135 > Shouldn't this be EXTERNAL_TABLE? John On 2011-07-14 18:54:32, Charles Chen wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1057/ ----------------------------------------------------------- (Updated 2011-07-14 18:54:32) Review request for hive. Summary ------- https://issues.apache.org/jira/browse/HIVE-1218 This addresses bug HIVE-1218 . https://issues.apache.org/jira/browse/HIVE-1218 Diffs ----- http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146841 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146841 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146841 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146841 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146841 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION Diff: https://reviews.apache.org/r/1057/diff Testing ------- Unit tests passed Thanks, Charles
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1057/
          -----------------------------------------------------------

          (Updated 2011-07-14 21:28:29.944878)

          Review request for hive.

          Changes
          -------

          Fix CREATE EXTERNAL TABLE LIKE table

          Summary
          -------

          https://issues.apache.org/jira/browse/HIVE-1218

          This addresses bug HIVE-1218.
          https://issues.apache.org/jira/browse/HIVE-1218

          Diffs (updated)


          http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146883
          http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146883
          http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146883
          http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146883
          http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146883

          Diff: https://reviews.apache.org/r/1057/diff

          Testing
          -------

          Unit tests passed

          Thanks,

          Charles

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1057/ ----------------------------------------------------------- (Updated 2011-07-14 21:28:29.944878) Review request for hive. Changes ------- Fix CREATE EXTERNAL TABLE LIKE table Summary ------- https://issues.apache.org/jira/browse/HIVE-1218 This addresses bug HIVE-1218 . https://issues.apache.org/jira/browse/HIVE-1218 Diffs (updated) http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146883 Diff: https://reviews.apache.org/r/1057/diff Testing ------- Unit tests passed Thanks, Charles
          Hide
          John Sichi added a comment -

          +1. Will commit when tests pass.

          Show
          John Sichi added a comment - +1. Will commit when tests pass.
          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1057/ ----------------------------------------------------------- (Updated 2011-07-14 22:11:41.745504) Review request for hive. Changes ------- whoops dropped create_like_view.q Summary ------- https://issues.apache.org/jira/browse/HIVE-1218 This addresses bug HIVE-1218 . https://issues.apache.org/jira/browse/HIVE-1218 Diffs (updated) http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION Diff: https://reviews.apache.org/r/1057/diff Testing ------- Unit tests passed Thanks, Charles
          Hide
          John Sichi added a comment -

          Some tests failed due to the explicit addition of the EXTERNAL property in some cases.

          Show
          John Sichi added a comment - Some tests failed due to the explicit addition of the EXTERNAL property in some cases.
          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1057/ ----------------------------------------------------------- (Updated 2011-07-15 21:23:11.221099) Review request for hive. Changes ------- Remove "EXTERNAL" parameter for not-external tables, reset owner and creation time. Summary ------- https://issues.apache.org/jira/browse/HIVE-1218 This addresses bug HIVE-1218 . https://issues.apache.org/jira/browse/HIVE-1218 Diffs (updated) http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION Diff: https://reviews.apache.org/r/1057/diff Testing ------- Unit tests passed Thanks, Charles
          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1057/ ----------------------------------------------------------- (Updated 2011-07-15 23:23:25.099707) Review request for hive. Summary ------- https://issues.apache.org/jira/browse/HIVE-1218 This addresses bug HIVE-1218 . https://issues.apache.org/jira/browse/HIVE-1218 Diffs (updated) http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION Diff: https://reviews.apache.org/r/1057/diff Testing ------- Unit tests passed Thanks, Charles
          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1057/ ----------------------------------------------------------- (Updated 2011-07-16 22:51:22.078393) Review request for hive. Changes ------- Regenerated unit tests that had EXTERNAL : FALSE Summary ------- https://issues.apache.org/jira/browse/HIVE-1218 This addresses bug HIVE-1218 . https://issues.apache.org/jira/browse/HIVE-1218 Diffs (updated) http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION Diff: https://reviews.apache.org/r/1057/diff Testing ------- Unit tests passed Thanks, Charles
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1057/#review1096
          -----------------------------------------------------------

          r9 passes unit tests

          • Charles

          On 2011-07-16 22:51:22, Charles Chen wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1057/

          -----------------------------------------------------------

          (Updated 2011-07-16 22:51:22)

          Review request for hive.

          Summary

          -------

          https://issues.apache.org/jira/browse/HIVE-1218

          This addresses bug HIVE-1218.

          https://issues.apache.org/jira/browse/HIVE-1218

          Diffs

          -----

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146883

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146883

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146883

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146883

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146883

          http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION

          Diff: https://reviews.apache.org/r/1057/diff

          Testing

          -------

          Unit tests passed

          Thanks,

          Charles

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1057/#review1096 ----------------------------------------------------------- r9 passes unit tests Charles On 2011-07-16 22:51:22, Charles Chen wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1057/ ----------------------------------------------------------- (Updated 2011-07-16 22:51:22) Review request for hive. Summary ------- https://issues.apache.org/jira/browse/HIVE-1218 This addresses bug HIVE-1218 . https://issues.apache.org/jira/browse/HIVE-1218 Diffs ----- http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146883 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION Diff: https://reviews.apache.org/r/1057/diff Testing ------- Unit tests passed Thanks, Charles
          Hide
          John Sichi added a comment -

          Committed. Thanks Charles!

          Show
          John Sichi added a comment - Committed. Thanks Charles!
          Hide
          Hudson added a comment -

          Integrated in Hive-trunk-h0.21 #833 (See https://builds.apache.org/job/Hive-trunk-h0.21/833/)
          HIVE-1218. CREATE TABLE t LIKE some_view should create a new empty base table,
          but instead creates a copy of view
          (Charles Chen via jvs)

          jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148005
          Files :

          • /hive/trunk/ql/src/test/queries/clientpositive/create_like.q
          • /hive/trunk/ql/src/test/results/clientpositive/create_like.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
          • /hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
          Show
          Hudson added a comment - Integrated in Hive-trunk-h0.21 #833 (See https://builds.apache.org/job/Hive-trunk-h0.21/833/ ) HIVE-1218 . CREATE TABLE t LIKE some_view should create a new empty base table, but instead creates a copy of view (Charles Chen via jvs) jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148005 Files : /hive/trunk/ql/src/test/queries/clientpositive/create_like.q /hive/trunk/ql/src/test/results/clientpositive/create_like.q.out /hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java /hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
          Hide
          John Sichi added a comment -

          Can you fill in the release note field with the behavior change? Click the Edit button to see it.

          Show
          John Sichi added a comment - Can you fill in the release note field with the behavior change? Click the Edit button to see it.

            People

            • Assignee:
              Charles Chen
              Reporter:
              John Sichi
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development