Hive
  1. Hive
  2. HIVE-1182

Fix TestCliDriver too many open file error

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.5.0
    • Component/s: Testing Infrastructure
    • Labels:
      None

      Description

      There is a bug in TestCliDriver that loads all .q files for each of the .q test.
      We only need to load the .q file for that particular .q test.

      1. HIVE-1182.1.patch
        5 kB
        Zheng Shao
      2. HIVE-1182.1.branch-0.4.patch
        5 kB
        Zheng Shao
      3. HIVE-1182.1.branch-0.5.patch
        5 kB
        Zheng Shao
      4. HIVE-1182.2.patch
        4 kB
        Zheng Shao
      5. HIVE-1182.2.branch-0.5.patch
        4 kB
        Zheng Shao
      6. HIVE-1182.2.branch-0.4.patch
        4 kB
        Zheng Shao

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        15m 18s 1 Zheng Shao 19/Feb/10 20:36
        Patch Available Patch Available Resolved Resolved
        7h 27m 1 Ning Zhang 20/Feb/10 04:03
        Resolved Resolved Closed Closed
        664d 20h 2m 1 Carl Steinbach 17/Dec/11 00:06
        Carl Steinbach made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Carl Steinbach made changes -
        Issue Type Improvement [ 4 ] Bug [ 1 ]
        Fix Version/s 0.4.2 [ 12314523 ]
        Fix Version/s 0.6.0 [ 12314524 ]
        Affects Version/s 0.5.0 [ 12314156 ]
        Affects Version/s 0.4.1 [ 12314225 ]
        Affects Version/s 0.6.0 [ 12314524 ]
        Component/s Testing Infrastructure [ 12312590 ]
        Ning Zhang made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Ning Zhang added a comment -

        committed to branch 0.4, 0.5 and trunk. Thanks Zheng!

        Show
        Ning Zhang added a comment - committed to branch 0.4, 0.5 and trunk. Thanks Zheng!
        Hide
        Ning Zhang added a comment -

        +1. Will commit after tests.

        Show
        Ning Zhang added a comment - +1. Will commit after tests.
        Zheng Shao made changes -
        Attachment HIVE-1182.2.patch [ 12436376 ]
        Attachment HIVE-1182.2.branch-0.5.patch [ 12436377 ]
        Attachment HIVE-1182.2.branch-0.4.patch [ 12436378 ]
        Hide
        Zheng Shao added a comment -

        Adopted Ning's suggestions.

        Show
        Zheng Shao added a comment - Adopted Ning's suggestions.
        Hide
        Ning Zhang added a comment -

        template file changes look fine. but I'm sure about the changes to SessionState.start(session). This function now returns the old session and previously it returns the new session. It is called in other places as well. Can you make sure that this change of semantics doesn't break our design and other use cases? If what we need here is to be able to get the current session and close it, we can do it without changing the semantics of SessionState.start(session).

        Show
        Ning Zhang added a comment - template file changes look fine. but I'm sure about the changes to SessionState.start(session). This function now returns the old session and previously it returns the new session. It is called in other places as well. Can you make sure that this change of semantics doesn't break our design and other use cases? If what we need here is to be able to get the current session and close it, we can do it without changing the semantics of SessionState.start(session).
        Zheng Shao made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 0.4.1 [ 12314225 ]
        Fix Version/s 0.4.2 [ 12314523 ]
        Fix Version/s 0.5.0 [ 12314156 ]
        Fix Version/s 0.6.0 [ 12314524 ]
        Zheng Shao made changes -
        Attachment HIVE-1182.1.branch-0.4.patch [ 12436370 ]
        Attachment HIVE-1182.1.branch-0.5.patch [ 12436371 ]
        Hide
        Zheng Shao added a comment -

        Patches for 0.4 and 0.5.

        Show
        Zheng Shao added a comment - Patches for 0.4 and 0.5.
        Zheng Shao made changes -
        Field Original Value New Value
        Attachment HIVE-1182.1.patch [ 12436369 ]
        Hide
        Zheng Shao added a comment -

        This patch fixes the problem.

        Show
        Zheng Shao added a comment - This patch fixes the problem.
        Zheng Shao created issue -

          People

          • Assignee:
            Zheng Shao
            Reporter:
            Zheng Shao
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development