Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-1182

Fix TestCliDriver too many open file error

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.5.0
    • Component/s: Testing Infrastructure
    • Labels:
      None

      Description

      There is a bug in TestCliDriver that loads all .q files for each of the .q test.
      We only need to load the .q file for that particular .q test.

      1. HIVE-1182.2.patch
        4 kB
        Zheng Shao
      2. HIVE-1182.2.branch-0.5.patch
        4 kB
        Zheng Shao
      3. HIVE-1182.2.branch-0.4.patch
        4 kB
        Zheng Shao
      4. HIVE-1182.1.patch
        5 kB
        Zheng Shao
      5. HIVE-1182.1.branch-0.5.patch
        5 kB
        Zheng Shao
      6. HIVE-1182.1.branch-0.4.patch
        5 kB
        Zheng Shao

        Activity

        Hide
        zshao Zheng Shao added a comment -

        This patch fixes the problem.

        Show
        zshao Zheng Shao added a comment - This patch fixes the problem.
        Hide
        zshao Zheng Shao added a comment -

        Patches for 0.4 and 0.5.

        Show
        zshao Zheng Shao added a comment - Patches for 0.4 and 0.5.
        Hide
        nzhang Ning Zhang added a comment -

        template file changes look fine. but I'm sure about the changes to SessionState.start(session). This function now returns the old session and previously it returns the new session. It is called in other places as well. Can you make sure that this change of semantics doesn't break our design and other use cases? If what we need here is to be able to get the current session and close it, we can do it without changing the semantics of SessionState.start(session).

        Show
        nzhang Ning Zhang added a comment - template file changes look fine. but I'm sure about the changes to SessionState.start(session). This function now returns the old session and previously it returns the new session. It is called in other places as well. Can you make sure that this change of semantics doesn't break our design and other use cases? If what we need here is to be able to get the current session and close it, we can do it without changing the semantics of SessionState.start(session).
        Hide
        zshao Zheng Shao added a comment -

        Adopted Ning's suggestions.

        Show
        zshao Zheng Shao added a comment - Adopted Ning's suggestions.
        Hide
        nzhang Ning Zhang added a comment -

        +1. Will commit after tests.

        Show
        nzhang Ning Zhang added a comment - +1. Will commit after tests.
        Hide
        nzhang Ning Zhang added a comment -

        committed to branch 0.4, 0.5 and trunk. Thanks Zheng!

        Show
        nzhang Ning Zhang added a comment - committed to branch 0.4, 0.5 and trunk. Thanks Zheng!

          People

          • Assignee:
            zshao Zheng Shao
            Reporter:
            zshao Zheng Shao
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development