[HIVE-11544] LazyInteger should avoid throwing NumberFormatException

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.14.0, 1.2.0, 1.3.0, 2.0.0
• Fix Version/s: 1.3.0, 2.0.0
• Component/s: Serializers/Deserializers
• Labels: Performance
• Release Note: Improve LazySimpleSerDe null data handling for Byte, Short, Integer, Float, Long and Double.
• Assignee: Gopal Vijayaraghavan
• Reporter: William Slacum
• Created: 13/Aug/15 03:10
• Updated: 09/Apr/16 22:51
• Resolved: 15/Sep/15 01:17

Description

LazyInteger#parseInt will throw a NumberFormatException under these conditions:

1. bytes are null
2. radix is invalid
3. length is 0
4. the string is '+' or '-'
5. LazyInteger#parse throws a NumberFormatException

Most of the time, such as in LazyInteger#init and LazyByte#init, the exception is caught, swallowed, and isNull is set to true.

This is generally a bad workflow, as exception creation is a performance bottleneck, and potentially repeating for many rows in a query can have a drastic performance consequence.

It would be better if this method returned an Optional<Integer>, which would provide similar functionality with a higher throughput rate.

I've tested against 0.14.0, and saw that the logic is unchanged in 1.2.0, so I've marked those as affected. Any version in between would also suffer from this.

Issue Links

• is related to: HIVE-13320 Apply HIVE-11544 to explicit conversions as well as implicit ones