Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-11469

Update doc for InstanceCache to clearly define the contract on the SeedObject

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Labels:
      None

      Description

      With HIVE-11288, we started using InstanceCache as a key. However it doesn't seem like the class actually implements the equals or hashcode methods which can potentially lead to inaccurate results.

        Activity

        Hide
        ashutoshc Ashutosh Chauhan added a comment -

        Pushed to master. Thanks, Swarnim Kulkarni

        Show
        ashutoshc Ashutosh Chauhan added a comment - Pushed to master. Thanks, Swarnim Kulkarni
        Hide
        ashutoshc Ashutosh Chauhan added a comment -

        +1 Swarnim Kulkarni Can you also update title of this jira to reflect changes in the patch?

        Show
        ashutoshc Ashutosh Chauhan added a comment - +1 Swarnim Kulkarni Can you also update title of this jira to reflect changes in the patch?
        Hide
        hiveqa Hive QA added a comment -

        Overall: -1 at least one tests failed

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12749306/HIVE-11469.1.patch.txt

        ERROR: -1 due to 1 failed/errored test(s), 9344 tests executed
        Failed tests:

        org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchEmptyCommit
        

        Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4880/testReport
        Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4880/console
        Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4880/

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        Tests exited with: TestsFailedException: 1 tests failed
        

        This message is automatically generated.

        ATTACHMENT ID: 12749306 - PreCommit-HIVE-TRUNK-Build

        Show
        hiveqa Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12749306/HIVE-11469.1.patch.txt ERROR: -1 due to 1 failed/errored test(s), 9344 tests executed Failed tests: org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchEmptyCommit Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4880/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4880/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4880/ Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed This message is automatically generated. ATTACHMENT ID: 12749306 - PreCommit-HIVE-TRUNK-Build
        Hide
        swarnim Swarnim Kulkarni added a comment -
        Show
        swarnim Swarnim Kulkarni added a comment - Review board: https://reviews.apache.org/r/37223/
        Hide
        swarnim Swarnim Kulkarni added a comment -

        Turned out to be simpler than what I was expecting it to be. Patch attached.

        Show
        swarnim Swarnim Kulkarni added a comment - Turned out to be simpler than what I was expecting it to be. Patch attached.

          People

          • Assignee:
            swarnim Swarnim Kulkarni
            Reporter:
            swarnim Swarnim Kulkarni
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development