Hive
  1. Hive
  2. HIVE-1137

Fix build.xml for references to IVY_HOME

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.0
    • Component/s: Build Infrastructure
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The build references env.IVY_HOME, but doesn't actually import env as it should (via <property environment="env"/>).

      It's not clear what the IVY_HOME reference is for since the build doesn't even use ivy.home (instead, it installs under the build/ivy directory).

      It looks like someone copied bits and pieces from the "Automatically" section here:

      http://ant.apache.org/ivy/history/latest-milestone/install.html

      1. HIVE-1137.patch
        3 kB
        Carl Steinbach

        Activity

        Hide
        John Sichi added a comment -

        svn annotate shows this originating with HIVE-990, so I'll assign to Carl to take a look.

        Also, Carl, what is the reason for putting the ivy download under build? Was that necessitated by checkstyle?

        Show
        John Sichi added a comment - svn annotate shows this originating with HIVE-990 , so I'll assign to Carl to take a look. Also, Carl, what is the reason for putting the ivy download under build? Was that necessitated by checkstyle?
        Hide
        Carl Steinbach added a comment -
        • Removed the reference to IVY_HOME in build-common.xml
          • ivy.home is always set to $ {user.home}

            /.ant unless the user overrides ivy.home.

        • Removed ivy/get_ivy.xml which was not being used (this is handled by the ivy-download target in build-common.xml)
        Show
        Carl Steinbach added a comment - Removed the reference to IVY_HOME in build-common.xml ivy.home is always set to $ {user.home} /.ant unless the user overrides ivy.home. Removed ivy/get_ivy.xml which was not being used (this is handled by the ivy-download target in build-common.xml)
        Hide
        John Sichi added a comment -

        +1

        Show
        John Sichi added a comment - +1
        Hide
        Zheng Shao added a comment -

        Committed. Thanks Carl!

        Show
        Zheng Shao added a comment - Committed. Thanks Carl!

          People

          • Assignee:
            Carl Steinbach
            Reporter:
            John Sichi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development