Hive
  1. Hive
  2. HIVE-1136

Add type-checking setters for HiveConf class to match existing getters

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.0
    • Component/s: Configuration
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This is a followup from HIVE-1129.

      1. HIVE-1136.1.patch
        4 kB
        John Sichi
      2. HIVE-1136.2.patch
        7 kB
        John Sichi

        Activity

        John Sichi created issue -
        John Sichi made changes -
        Field Original Value New Value
        Attachment HIVE-1136.1.patch [ 12435735 ]
        John Sichi made changes -
        Attachment HIVE-1136.1.patch [ 12435735 ]
        John Sichi made changes -
        Attachment HIVE-1136.1.patch [ 12435736 ]
        John Sichi made changes -
        Attachment HIVE-1136.1.patch [ 12435736 ]
        Hide
        John Sichi added a comment -

        Finally uploaded the right patch.

        Show
        John Sichi added a comment - Finally uploaded the right patch.
        John Sichi made changes -
        Attachment HIVE-1136.1.patch [ 12435741 ]
        Hide
        John Sichi added a comment -

        This passed tests so I'm submitting it as ready.

        Show
        John Sichi added a comment - This passed tests so I'm submitting it as ready.
        John Sichi made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Zheng Shao added a comment -

        +1
        Will test and commit.

        Show
        Zheng Shao added a comment - +1 Will test and commit.
        Hide
        Zheng Shao added a comment -

        It seems that the following function is not in hadoop 0.17.
        What about convert it to a string first? (and put a comment saying we did this for compatibility for hadoop 0.17)

        common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:303: cannot find symbol
            [javac] symbol  : method setFloat(java.lang.String,float)
            [javac] location: class org.apache.hadoop.conf.Configuration
            [javac]     conf.setFloat(var.varname, val);
            [javac]         ^
        
        Show
        Zheng Shao added a comment - It seems that the following function is not in hadoop 0.17. What about convert it to a string first? (and put a comment saying we did this for compatibility for hadoop 0.17) common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:303: cannot find symbol [javac] symbol : method setFloat(java.lang. String , float ) [javac] location: class org.apache.hadoop.conf.Configuration [javac] conf.setFloat( var .varname, val); [javac] ^
        Zheng Shao made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        John Sichi made changes -
        Attachment HIVE-1136.2.patch [ 12436062 ]
        Hide
        John Sichi added a comment -

        Per discussion with Zheng, added a new shim method to deal with the incompabitibility.

        Show
        John Sichi added a comment - Per discussion with Zheng, added a new shim method to deal with the incompabitibility.
        Hide
        Zheng Shao added a comment -

        +1. Will test and commit.

        Show
        Zheng Shao added a comment - +1. Will test and commit.
        Hide
        Zheng Shao added a comment -

        Committed. Thanks John!

        Show
        Zheng Shao added a comment - Committed. Thanks John!
        Zheng Shao made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Release Note HIVE-1136. Add type-checking setters for HiveConf class. (John Sichi via zshao)
        Resolution Fixed [ 1 ]
        Carl Steinbach made changes -
        Summary add type-checking setters for HiveConf class to match existing getters Add type-checking setters for HiveConf class to match existing getters
        Release Note HIVE-1136. Add type-checking setters for HiveConf class. (John Sichi via zshao)
        Affects Version/s 0.6.0 [ 12314524 ]
        Carl Steinbach made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        10d 20h 23m 1 John Sichi 16/Feb/10 21:26
        Patch Available Patch Available Open Open
        1h 10m 1 Zheng Shao 16/Feb/10 22:36
        Open Open Resolved Resolved
        23h 29m 1 Zheng Shao 17/Feb/10 22:06
        Resolved Resolved Closed Closed
        667d 1h 57m 1 Carl Steinbach 17/Dec/11 00:03

          People

          • Assignee:
            John Sichi
            Reporter:
            John Sichi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development