ashutoshc, I added some additional comments to the patch.
About the pieces from SemanticAnalyzer, the problem is that here we are doing something very specific of the return path: the predicates in the join come expressed in terms of the input/output columns, but the filters which are not on joining columns need to be expressed wrt to the output of the RS. In SemanticAnalyzer, we do not need to worry about this. Plus in addition, some of the data structures are generated from the QBJoinTree (e.g. filterMap), while here we need to generate them from the Calcite plan. Please, let me know if you had something specific in mind.
Overall: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12744179/HIVE-11206.patch
SUCCESS: +1 9136 tests passed
Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4538/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4538/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4538/
Messages:
This message is automatically generated.
ATTACHMENT ID: 12744179 - PreCommit-HIVE-TRUNK-Build