Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-10674

jars should not be checked in to the source control repo

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.3.0
    • Fix Version/s: 1.2.1
    • Component/s: None
    • Labels:
      None

      Description

      The 2 jars added by HIVE-9302 run afoul of the source package generation as part of the 1.2 release, since a source package is not supposed to contain any binaries. If we have binaries, they're supposed to be brought in as a download step during the compile or test-compile phase from a well-known published location such as a maven repository. The postgres jar we can depend on as a download, and it is an open source product that is compatible with the Apache License, but DummyDriver is worse, because there is no source attached to it either, which makes it not okay to include in the binary release of hive either.

      Thus, for branch-1.2, I am going to do a git rm of those two jars right away. This, unfortunately, might cause a few tests added here to fail for branch-1.2, but this should be acceptable for the time being.

      I'm opening this jira to track the following:

      a) git rm of the postgres and DummyDriver jar from master
      b) adding source code for DummyDriver into master, and changing the build so we depend on it being compiled, rather than included from test-resources.
      c) changing the postgres inclusion to a download.

      This should also be applied to branch-1.2 after release, preferably before 1.2.1, so that future updates of 1.2 have this fixed as well.

      Note: In addition, there are two more jars added by HIVE-7553 which also need to have this same fix applied to them : ql/src/test/resources/SessionStateTest.jar.v1 and ql/src/test/resources/SessionStateTest.jar.v1 . These are included in a similar manner, for tests, but are binaries without source code attached.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                sushanth Sushanth Sowmyan
                Reporter:
                sushanth Sushanth Sowmyan
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: