[HIVE-10190] CBO: AST mode checks for TABLESAMPLE with AST.toString().contains("TOK_TABLESPLITSAMPLE")

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.2.0
• Fix Version/s: 1.3.0, 2.0.0
• Component/s: CBO
• Labels: perfomance
• Assignee: Reuben Kuhnert
• Reporter: Gopal Vijayaraghavan
• Created: 02/Apr/15 03:12
• Updated: 16/Feb/16 23:52
• Resolved: 18/May/15 15:07

Description

public static boolean validateASTForUnsupportedTokens(ASTNode ast) {
    String astTree = ast.toStringTree();
    // if any of following tokens are present in AST, bail out
    String[] tokens = { "TOK_CHARSETLITERAL", "TOK_TABLESPLITSAMPLE" };
    for (String token : tokens) {
      if (astTree.contains(token)) {
        return false;
      }
    }
    return true;
  }

This is an issue for a SQL query which is bigger in AST form than in text (~700kb).

Issue Links

• links to: Review Board