[HIVE-10178] DateWritable incorrectly calculates daysSinceEpoch for negative Unix time

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.12.0, 0.13.0, 0.14.0, 1.0.0
• Fix Version/s: 1.0.2, 1.2.0
• Component/s: Types
• Assignee: Alexander Pivovarov
• Reporter: Alexander Pivovarov
• Created: 01/Apr/15 07:29
• Updated: 15/Oct/15 17:09
• Resolved: 07/Apr/15 22:18

Description

For example:

select cast(cast('1966-01-01 00:00:01' as timestamp) as date);
1966-01-02

Another example:

select last_day(cast('1966-01-31 00:00:01' as timestamp));
OK
1966-02-28

more details:
Date: 1966-01-01 00:00:01
unix time UTC: -126230399

daysSinceEpoch=−126230399000 / 86400000 = -1460.999988
int daysSinceEpoch = -1460
DateWritable having daysSinceEpoch=-1460 is 1966-01-02

daysSinceEpoch should be -1461 instead (1966-01-01)

Issue Links

• links to: https://reviews.apache.org/r/32715/