Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9942

Add an HTrace span when refreshing the groups for a username

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      We should add an HTrace span when refreshing the groups for a username. This can be an expensive operation in some cases, and it's good to know if it delayed a request.

      1. HDFS-9942.001.patch
        1 kB
        Colin P. McCabe

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 52s trunk passed
        +1 compile 9m 40s trunk passed with JDK v1.8.0_74
        +1 compile 7m 28s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 20s trunk passed
        +1 mvnsite 0m 58s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 34s trunk passed
        +1 javadoc 1m 1s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 11s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 46s the patch passed
        +1 compile 8m 31s the patch passed with JDK v1.8.0_74
        +1 javac 8m 31s the patch passed
        +1 compile 7m 35s the patch passed with JDK v1.7.0_95
        +1 javac 7m 35s the patch passed
        +1 checkstyle 0m 20s the patch passed
        +1 mvnsite 0m 58s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 54s the patch passed
        +1 javadoc 1m 5s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 18s the patch passed with JDK v1.7.0_95
        +1 unit 10m 47s hadoop-common in the patch passed with JDK v1.8.0_74.
        +1 unit 9m 52s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 28s Patch does not generate ASF License warnings.
        76m 31s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12792618/HDFS-9942.001.patch
        JIRA Issue HDFS-9942
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 144a6f6d6ab8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e01c6ea
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14787/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14787/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 52s trunk passed +1 compile 9m 40s trunk passed with JDK v1.8.0_74 +1 compile 7m 28s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 34s trunk passed +1 javadoc 1m 1s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 11s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 46s the patch passed +1 compile 8m 31s the patch passed with JDK v1.8.0_74 +1 javac 8m 31s the patch passed +1 compile 7m 35s the patch passed with JDK v1.7.0_95 +1 javac 7m 35s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 54s the patch passed +1 javadoc 1m 5s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 18s the patch passed with JDK v1.7.0_95 +1 unit 10m 47s hadoop-common in the patch passed with JDK v1.8.0_74. +1 unit 9m 52s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 28s Patch does not generate ASF License warnings. 76m 31s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12792618/HDFS-9942.001.patch JIRA Issue HDFS-9942 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 144a6f6d6ab8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e01c6ea Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14787/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14787/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        iwasakims Masatake Iwasaki added a comment -

        +1

        BTW, this looks like the use case of NullTracer being discussed in HTRACE-275.

        Show
        iwasakims Masatake Iwasaki added a comment - +1 BTW, this looks like the use case of NullTracer being discussed in HTRACE-275 .
        Hide
        cmccabe Colin P. McCabe added a comment -
        Show
        cmccabe Colin P. McCabe added a comment - Thanks, Masatake Iwasaki .

          People

          • Assignee:
            cmccabe Colin P. McCabe
            Reporter:
            cmccabe Colin P. McCabe
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development