Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9886

Configuration properties for hedged read is broken

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      HdfsClientConfigKeys.java
        /** dfs.client.hedged.read configuration properties */
        interface HedgedRead {
          String  THRESHOLD_MILLIS_KEY = PREFIX + "threshold.millis";
          long    THRESHOLD_MILLIS_DEFAULT = 500;
          String  THREADPOOL_SIZE_KEY = PREFIX + "threadpool.size";
          int     THREADPOOL_SIZE_DEFAULT = 0;
        }
      

      PREFIX is not defined in the interface, so "dfs.client" is used as PREFIX. Therefore, the properties are "dfs.client.threshold.millis" and "dfs.client.threadpool.size". They should be "dfs.client.hedged.read.threshold.millis" and "dfs.client.hedged.read.threadpool.size".

      1. HDFS-9886.01.patch
        0.8 kB
        Akira Ajisaka

        Issue Links

          Activity

          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Nice catch Akira Ajisaka, +1 (non-binding).

          Show
          brahmareddy Brahma Reddy Battula added a comment - Nice catch Akira Ajisaka , +1 (non-binding).
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 49s trunk passed
          +1 compile 0m 26s trunk passed with JDK v1.8.0_72
          +1 compile 0m 29s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 16s trunk passed
          +1 mvnsite 0m 33s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 38s trunk passed
          +1 javadoc 0m 19s trunk passed with JDK v1.8.0_72
          +1 javadoc 0m 24s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 31s the patch passed
          +1 compile 0m 23s the patch passed with JDK v1.8.0_72
          +1 javac 0m 23s the patch passed
          +1 compile 0m 27s the patch passed with JDK v1.7.0_95
          +1 javac 0m 27s the patch passed
          +1 checkstyle 0m 14s the patch passed
          +1 mvnsite 0m 31s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 49s the patch passed
          +1 javadoc 0m 16s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 21s the patch passed with JDK v1.7.0_95
          +1 unit 0m 48s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72.
          +1 unit 0m 53s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 18s Patch does not generate ASF License warnings.
          19m 55s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790896/HDFS-9886.01.patch
          JIRA Issue HDFS-9886
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux dff003b6c99f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 27e0681
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14684/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14684/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 49s trunk passed +1 compile 0m 26s trunk passed with JDK v1.8.0_72 +1 compile 0m 29s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 33s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 38s trunk passed +1 javadoc 0m 19s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 24s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 31s the patch passed +1 compile 0m 23s the patch passed with JDK v1.8.0_72 +1 javac 0m 23s the patch passed +1 compile 0m 27s the patch passed with JDK v1.7.0_95 +1 javac 0m 27s the patch passed +1 checkstyle 0m 14s the patch passed +1 mvnsite 0m 31s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 49s the patch passed +1 javadoc 0m 16s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 21s the patch passed with JDK v1.7.0_95 +1 unit 0m 48s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72. +1 unit 0m 53s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 19m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790896/HDFS-9886.01.patch JIRA Issue HDFS-9886 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dff003b6c99f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 27e0681 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14684/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14684/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          zhz Zhe Zhang added a comment -

          Good catch Akira Ajisaka! +1 on the patch.

          Show
          zhz Zhe Zhang added a comment - Good catch Akira Ajisaka ! +1 on the patch.
          Hide
          cnauroth Chris Nauroth added a comment -

          Agreed, great catch! Thanks very much, Akira Ajisaka. +1.

          Show
          cnauroth Chris Nauroth added a comment - Agreed, great catch! Thanks very much, Akira Ajisaka . +1.
          Hide
          zhz Zhe Zhang added a comment -

          Committed to trunk, branch-2, branch-2.8. Thanks Akira for the fix!

          Show
          zhz Zhe Zhang added a comment - Committed to trunk, branch-2, branch-2.8. Thanks Akira for the fix!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9413 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9413/)
          HDFS-9886. Configuration properties for hedged read is broken. (zhz: rev 67880ccae6568516ff3d13185fd7f250b234a2cf)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9413 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9413/ ) HDFS-9886 . Configuration properties for hedged read is broken. (zhz: rev 67880ccae6568516ff3d13185fd7f250b234a2cf) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java

            People

            • Assignee:
              ajisakaa Akira Ajisaka
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development