Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9801

ReconfigurableBase should update the cached configuration

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: datanode
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      ReconfigurableBase#startReconfigurationTask does not update its cached configuration after a property is reconfigured. This means that configuration values queried via getConf().get(...) can be outdated. One way to fix it is ReconfigurableBase#reconfigurePropertyImpl returns the new effective value of the config setting and caller i.e. ReconfigurableBase will use it to update the configuration.

      See discussion on HDFS-7035 for more background.

      1. HADOOP-12476.02.patch
        22 kB
        Arpit Agarwal
      2. HADOOP-12746.01.patch
        22 kB
        Arpit Agarwal
      3. HADOOP-12746.03.patch
        26 kB
        Arpit Agarwal
      4. HADOOP-12746.04.patch
        28 kB
        Arpit Agarwal

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user arp7 opened a pull request:

        https://github.com/apache/hadoop/pull/73

        HADOOP-12746. ReconfigurableBase should update the cached configuration

        Initial patch to have ReconfigurableBase#ReconfigurationThread update parent's cached configuration.

        The effective value may be different from the passed in newVal so this patch also updates ReconfigurableBase#reconfigurePropertyImpl to return the effective config value. This idea was suggested by Lei (Eddy) Xu on https://issues.apache.org/jira/secure/EditComment!default.jspa?id=12740232&commentId=15118434

        Will likely add more unit tests for this.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/arp7/hadoop HADOOP-12476

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/hadoop/pull/73.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #73


        commit 942b4eecbb344549f5ad3d16e97e83a381ef960c
        Author: Arpit Agarwal <arp@apache.org>
        Date: 2016-02-06T00:54:02Z

        HADOOP-12746. ReconfigurableBase should update the cached configuration


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user arp7 opened a pull request: https://github.com/apache/hadoop/pull/73 HADOOP-12746 . ReconfigurableBase should update the cached configuration Initial patch to have ReconfigurableBase#ReconfigurationThread update parent's cached configuration. The effective value may be different from the passed in newVal so this patch also updates ReconfigurableBase#reconfigurePropertyImpl to return the effective config value. This idea was suggested by Lei (Eddy) Xu on https://issues.apache.org/jira/secure/EditComment!default.jspa?id=12740232&commentId=15118434 Will likely add more unit tests for this. You can merge this pull request into a Git repository by running: $ git pull https://github.com/arp7/hadoop HADOOP-12476 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/73.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #73 commit 942b4eecbb344549f5ad3d16e97e83a381ef960c Author: Arpit Agarwal <arp@apache.org> Date: 2016-02-06T00:54:02Z HADOOP-12746 . ReconfigurableBase should update the cached configuration
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Lei (Eddy) Xu, here's an initial patch based on the discussion in HDFS-7035. I'd really appreciate your review. Thanks.

        Show
        arpitagarwal Arpit Agarwal added a comment - Lei (Eddy) Xu , here's an initial patch based on the discussion in HDFS-7035 . I'd really appreciate your review. Thanks.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 27s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
        0 mvndep 0m 24s Maven dependency ordering for branch
        +1 mvninstall 7m 23s trunk passed
        +1 compile 6m 50s trunk passed with JDK v1.8.0_72
        +1 compile 7m 34s trunk passed with JDK v1.7.0_95
        +1 checkstyle 1m 14s trunk passed
        +1 mvnsite 2m 7s trunk passed
        +1 mvneclipse 0m 30s trunk passed
        +1 findbugs 3m 37s trunk passed
        +1 javadoc 2m 9s trunk passed with JDK v1.8.0_72
        +1 javadoc 3m 10s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 18s Maven dependency ordering for patch
        +1 mvninstall 1m 39s the patch passed
        +1 compile 6m 47s the patch passed with JDK v1.8.0_72
        +1 javac 6m 47s the patch passed
        +1 compile 7m 59s the patch passed with JDK v1.7.0_95
        +1 javac 7m 59s the patch passed
        -1 checkstyle 1m 13s root: patch generated 56 new + 125 unchanged - 4 fixed = 181 total (was 129)
        +1 mvnsite 2m 8s the patch passed
        +1 mvneclipse 0m 32s the patch passed
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 4m 15s the patch passed
        +1 javadoc 2m 1s the patch passed with JDK v1.8.0_72
        +1 javadoc 3m 2s the patch passed with JDK v1.7.0_95
        -1 unit 22m 2s hadoop-common in the patch failed with JDK v1.8.0_72.
        +1 unit 64m 44s hadoop-hdfs in the patch passed with JDK v1.8.0_72.
        -1 unit 7m 2s hadoop-common in the patch failed with JDK v1.7.0_95.
        -1 unit 73m 4s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 29s Patch does not generate ASF License warnings.
        234m 9s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.conf.TestReconfiguration
        JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle
        JDK v1.7.0_95 Failed junit tests hadoop.conf.TestReconfiguration
          hadoop.hdfs.web.TestWebHDFS
          hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
          hadoop.hdfs.server.datanode.TestBlockReplacement



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Issue HADOOP-12746
        GITHUB PR https://github.com/apache/hadoop/pull/73
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux cbfb5d4bb732 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / cfa8513
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/artifact/patchprocess/diff-checkstyle-root.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Max memory used 77MB
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 27s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 24s Maven dependency ordering for branch +1 mvninstall 7m 23s trunk passed +1 compile 6m 50s trunk passed with JDK v1.8.0_72 +1 compile 7m 34s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 14s trunk passed +1 mvnsite 2m 7s trunk passed +1 mvneclipse 0m 30s trunk passed +1 findbugs 3m 37s trunk passed +1 javadoc 2m 9s trunk passed with JDK v1.8.0_72 +1 javadoc 3m 10s trunk passed with JDK v1.7.0_95 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 1m 39s the patch passed +1 compile 6m 47s the patch passed with JDK v1.8.0_72 +1 javac 6m 47s the patch passed +1 compile 7m 59s the patch passed with JDK v1.7.0_95 +1 javac 7m 59s the patch passed -1 checkstyle 1m 13s root: patch generated 56 new + 125 unchanged - 4 fixed = 181 total (was 129) +1 mvnsite 2m 8s the patch passed +1 mvneclipse 0m 32s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 4m 15s the patch passed +1 javadoc 2m 1s the patch passed with JDK v1.8.0_72 +1 javadoc 3m 2s the patch passed with JDK v1.7.0_95 -1 unit 22m 2s hadoop-common in the patch failed with JDK v1.8.0_72. +1 unit 64m 44s hadoop-hdfs in the patch passed with JDK v1.8.0_72. -1 unit 7m 2s hadoop-common in the patch failed with JDK v1.7.0_95. -1 unit 73m 4s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 29s Patch does not generate ASF License warnings. 234m 9s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.conf.TestReconfiguration JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle JDK v1.7.0_95 Failed junit tests hadoop.conf.TestReconfiguration   hadoop.hdfs.web.TestWebHDFS   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.server.datanode.TestBlockReplacement Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Issue HADOOP-12746 GITHUB PR https://github.com/apache/hadoop/pull/73 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cbfb5d4bb732 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cfa8513 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8557/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Thanks Arpit Agarwal for the patch! Overall, it's good.
        Could you explain why
        The behavior of ReconfigurableBase#ReconfigurationThread#run

        133	          String effectiveValue =
        134	              parent.reconfigurePropertyImpl(change.prop, change.newVal);
        135	          if (change.newVal != null) {
        136	            oldConf.set(change.prop, effectiveValue);
        137	          }
        

        is inconsistent with that of ReconfigurableBase#reconfigureProperty

                if (newVal != null) {
                  getConf().set(property, effectiveValue);
                } else {
                  getConf().unset(property);
                }
        

        BTW, many checkstyle should be fixed. Thanks!

        Show
        xiaobingo Xiaobing Zhou added a comment - Thanks Arpit Agarwal for the patch! Overall, it's good. Could you explain why The behavior of ReconfigurableBase#ReconfigurationThread#run 133 String effectiveValue = 134 parent.reconfigurePropertyImpl(change.prop, change.newVal); 135 if (change.newVal != null) { 136 oldConf.set(change.prop, effectiveValue); 137 } is inconsistent with that of ReconfigurableBase#reconfigureProperty if (newVal != null) { getConf().set(property, effectiveValue); } else { getConf().unset(property); } BTW, many checkstyle should be fixed. Thanks!
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Thanks for the review Xiaobing Zhou. v02 patch Fixes the issue you pointed out. Also fixed a unit test failure and couple of checkstyle issues. The checkstyle indentation and brace warnings are bogus.

        Show
        arpitagarwal Arpit Agarwal added a comment - Thanks for the review Xiaobing Zhou . v02 patch Fixes the issue you pointed out. Also fixed a unit test failure and couple of checkstyle issues. The checkstyle indentation and brace warnings are bogus.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
        0 mvndep 0m 15s Maven dependency ordering for branch
        +1 mvninstall 7m 28s trunk passed
        +1 compile 7m 29s trunk passed with JDK v1.8.0_72
        +1 compile 7m 51s trunk passed with JDK v1.7.0_95
        +1 checkstyle 1m 18s trunk passed
        +1 mvnsite 2m 19s trunk passed
        +1 mvneclipse 0m 31s trunk passed
        +1 findbugs 3m 55s trunk passed
        +1 javadoc 1m 57s trunk passed with JDK v1.8.0_72
        +1 javadoc 2m 47s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 14s Maven dependency ordering for patch
        +1 mvninstall 1m 27s the patch passed
        +1 compile 5m 57s the patch passed with JDK v1.8.0_72
        +1 javac 5m 57s the patch passed
        +1 compile 6m 51s the patch passed with JDK v1.7.0_95
        +1 javac 6m 51s the patch passed
        -1 checkstyle 1m 8s root: patch generated 56 new + 125 unchanged - 4 fixed = 181 total (was 129)
        +1 mvnsite 2m 1s the patch passed
        +1 mvneclipse 0m 29s the patch passed
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 4m 33s the patch passed
        +1 javadoc 2m 15s the patch passed with JDK v1.8.0_72
        +1 javadoc 3m 1s the patch passed with JDK v1.7.0_95
        -1 unit 6m 45s hadoop-common in the patch failed with JDK v1.8.0_72.
        -1 unit 0m 28s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
        +1 unit 7m 32s hadoop-common in the patch passed with JDK v1.7.0_95.
        -1 unit 0m 32s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        81m 7s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.ipc.TestRPC



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Issue HADOOP-12746
        GITHUB PR https://github.com/apache/hadoop/pull/73
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3c2760011bef 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a0fb2ef
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8582/artifact/patchprocess/diff-checkstyle-root.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8582/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8582/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8582/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8582/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8582/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8582/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Max memory used 76MB
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8582/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 7m 28s trunk passed +1 compile 7m 29s trunk passed with JDK v1.8.0_72 +1 compile 7m 51s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 18s trunk passed +1 mvnsite 2m 19s trunk passed +1 mvneclipse 0m 31s trunk passed +1 findbugs 3m 55s trunk passed +1 javadoc 1m 57s trunk passed with JDK v1.8.0_72 +1 javadoc 2m 47s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 27s the patch passed +1 compile 5m 57s the patch passed with JDK v1.8.0_72 +1 javac 5m 57s the patch passed +1 compile 6m 51s the patch passed with JDK v1.7.0_95 +1 javac 6m 51s the patch passed -1 checkstyle 1m 8s root: patch generated 56 new + 125 unchanged - 4 fixed = 181 total (was 129) +1 mvnsite 2m 1s the patch passed +1 mvneclipse 0m 29s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 4m 33s the patch passed +1 javadoc 2m 15s the patch passed with JDK v1.8.0_72 +1 javadoc 3m 1s the patch passed with JDK v1.7.0_95 -1 unit 6m 45s hadoop-common in the patch failed with JDK v1.8.0_72. -1 unit 0m 28s hadoop-hdfs in the patch failed with JDK v1.8.0_72. +1 unit 7m 32s hadoop-common in the patch passed with JDK v1.7.0_95. -1 unit 0m 32s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 81m 7s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.ipc.TestRPC Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Issue HADOOP-12746 GITHUB PR https://github.com/apache/hadoop/pull/73 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3c2760011bef 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a0fb2ef Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8582/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8582/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8582/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8582/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8582/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8582/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8582/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Max memory used 76MB Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8582/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        v02 LGTM, +1. Thanks.

        Show
        xiaobingo Xiaobing Zhou added a comment - v02 LGTM, +1. Thanks.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        The v03 patch adds more unit tests.

        Show
        arpitagarwal Arpit Agarwal added a comment - The v03 patch adds more unit tests.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        v04 patch adds two more unit tests.

        Show
        arpitagarwal Arpit Agarwal added a comment - v04 patch adds two more unit tests.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
        0 mvndep 0m 48s Maven dependency ordering for branch
        +1 mvninstall 7m 18s trunk passed
        +1 compile 6m 57s trunk passed with JDK v1.8.0_66
        +1 compile 7m 19s trunk passed with JDK v1.7.0_91
        +1 checkstyle 1m 11s trunk passed
        +1 mvnsite 2m 5s trunk passed
        +1 mvneclipse 0m 28s trunk passed
        +1 findbugs 3m 47s trunk passed
        +1 javadoc 2m 5s trunk passed with JDK v1.8.0_66
        +1 javadoc 3m 1s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 15s Maven dependency ordering for patch
        +1 mvninstall 1m 34s the patch passed
        +1 compile 6m 42s the patch passed with JDK v1.8.0_66
        +1 javac 6m 42s the patch passed
        +1 compile 7m 17s the patch passed with JDK v1.7.0_91
        +1 javac 7m 17s the patch passed
        -1 checkstyle 1m 10s root: patch generated 56 new + 125 unchanged - 4 fixed = 181 total (was 129)
        +1 mvnsite 2m 2s the patch passed
        +1 mvneclipse 0m 28s the patch passed
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 4m 19s the patch passed
        +1 javadoc 2m 8s the patch passed with JDK v1.8.0_66
        +1 javadoc 3m 9s the patch passed with JDK v1.7.0_91
        -1 unit 8m 5s hadoop-common in the patch failed with JDK v1.8.0_66.
        -1 unit 60m 14s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        +1 unit 8m 24s hadoop-common in the patch passed with JDK v1.7.0_91.
        -1 unit 59m 32s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 28s Patch does not generate ASF License warnings.
        202m 26s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag
          hadoop.ha.TestZKFailoverController
          hadoop.security.ssl.TestReloadingX509TrustManager
          hadoop.hdfs.server.datanode.TestBlockScanner
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Issue HADOOP-12746
        GITHUB PR https://github.com/apache/hadoop/pull/73
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 450d81d8069b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9b959f3
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/artifact/patchprocess/diff-checkstyle-root.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Max memory used 76MB
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 48s Maven dependency ordering for branch +1 mvninstall 7m 18s trunk passed +1 compile 6m 57s trunk passed with JDK v1.8.0_66 +1 compile 7m 19s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 11s trunk passed +1 mvnsite 2m 5s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 47s trunk passed +1 javadoc 2m 5s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 1s trunk passed with JDK v1.7.0_91 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 34s the patch passed +1 compile 6m 42s the patch passed with JDK v1.8.0_66 +1 javac 6m 42s the patch passed +1 compile 7m 17s the patch passed with JDK v1.7.0_91 +1 javac 7m 17s the patch passed -1 checkstyle 1m 10s root: patch generated 56 new + 125 unchanged - 4 fixed = 181 total (was 129) +1 mvnsite 2m 2s the patch passed +1 mvneclipse 0m 28s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 4m 19s the patch passed +1 javadoc 2m 8s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 9s the patch passed with JDK v1.7.0_91 -1 unit 8m 5s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 60m 14s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 8m 24s hadoop-common in the patch passed with JDK v1.7.0_91. -1 unit 59m 32s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 28s Patch does not generate ASF License warnings. 202m 26s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag   hadoop.ha.TestZKFailoverController   hadoop.security.ssl.TestReloadingX509TrustManager   hadoop.hdfs.server.datanode.TestBlockScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Issue HADOOP-12746 GITHUB PR https://github.com/apache/hadoop/pull/73 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 450d81d8069b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9b959f3 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Max memory used 76MB Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8606/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
        0 mvndep 0m 16s Maven dependency ordering for branch
        +1 mvninstall 7m 38s trunk passed
        +1 compile 6m 38s trunk passed with JDK v1.8.0_72
        +1 compile 7m 17s trunk passed with JDK v1.7.0_95
        +1 checkstyle 1m 13s trunk passed
        +1 mvnsite 2m 12s trunk passed
        +1 mvneclipse 0m 32s trunk passed
        +1 findbugs 3m 42s trunk passed
        +1 javadoc 2m 18s trunk passed with JDK v1.8.0_72
        +1 javadoc 3m 7s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 1m 51s the patch passed
        +1 compile 6m 57s the patch passed with JDK v1.8.0_72
        +1 javac 6m 57s the patch passed
        +1 compile 7m 35s the patch passed with JDK v1.7.0_95
        +1 javac 7m 35s the patch passed
        -1 checkstyle 1m 6s root: patch generated 56 new + 125 unchanged - 4 fixed = 181 total (was 129)
        +1 mvnsite 1m 51s the patch passed
        +1 mvneclipse 0m 28s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 3m 51s the patch passed
        +1 javadoc 1m 59s the patch passed with JDK v1.8.0_72
        +1 javadoc 2m 47s the patch passed with JDK v1.7.0_95
        -1 unit 21m 1s hadoop-common in the patch failed with JDK v1.8.0_72.
        +1 unit 64m 13s hadoop-hdfs in the patch passed with JDK v1.8.0_72.
        +1 unit 7m 36s hadoop-common in the patch passed with JDK v1.7.0_95.
        -1 unit 66m 8s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        224m 48s



        Reason Tests
        JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.TestFileTruncate
          hadoop.hdfs.TestRollingUpgrade



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Issue HADOOP-12746
        GITHUB PR https://github.com/apache/hadoop/pull/73
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6841610003c0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9b959f3
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8607/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8607/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8607/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8607/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8607/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8607/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Max memory used 76MB
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8607/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 7m 38s trunk passed +1 compile 6m 38s trunk passed with JDK v1.8.0_72 +1 compile 7m 17s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 13s trunk passed +1 mvnsite 2m 12s trunk passed +1 mvneclipse 0m 32s trunk passed +1 findbugs 3m 42s trunk passed +1 javadoc 2m 18s trunk passed with JDK v1.8.0_72 +1 javadoc 3m 7s trunk passed with JDK v1.7.0_95 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 51s the patch passed +1 compile 6m 57s the patch passed with JDK v1.8.0_72 +1 javac 6m 57s the patch passed +1 compile 7m 35s the patch passed with JDK v1.7.0_95 +1 javac 7m 35s the patch passed -1 checkstyle 1m 6s root: patch generated 56 new + 125 unchanged - 4 fixed = 181 total (was 129) +1 mvnsite 1m 51s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 51s the patch passed +1 javadoc 1m 59s the patch passed with JDK v1.8.0_72 +1 javadoc 2m 47s the patch passed with JDK v1.7.0_95 -1 unit 21m 1s hadoop-common in the patch failed with JDK v1.8.0_72. +1 unit 64m 13s hadoop-hdfs in the patch passed with JDK v1.8.0_72. +1 unit 7m 36s hadoop-common in the patch passed with JDK v1.7.0_95. -1 unit 66m 8s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 224m 48s Reason Tests JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.TestRollingUpgrade Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Issue HADOOP-12746 GITHUB PR https://github.com/apache/hadoop/pull/73 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6841610003c0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9b959f3 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8607/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8607/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8607/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8607/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8607/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8607/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Max memory used 76MB Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8607/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
        0 mvndep 0m 37s Maven dependency ordering for branch
        +1 mvninstall 7m 51s trunk passed
        +1 compile 8m 36s trunk passed with JDK v1.8.0_72
        +1 compile 7m 47s trunk passed with JDK v1.7.0_95
        +1 checkstyle 1m 11s trunk passed
        +1 mvnsite 2m 7s trunk passed
        +1 mvneclipse 0m 28s trunk passed
        +1 findbugs 3m 39s trunk passed
        +1 javadoc 2m 22s trunk passed with JDK v1.8.0_72
        +1 javadoc 3m 13s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 17s Maven dependency ordering for patch
        +1 mvninstall 1m 42s the patch passed
        +1 compile 8m 52s the patch passed with JDK v1.8.0_72
        +1 javac 8m 52s the patch passed
        +1 compile 8m 9s the patch passed with JDK v1.7.0_95
        +1 javac 8m 9s the patch passed
        -1 checkstyle 1m 9s root: patch generated 56 new + 125 unchanged - 4 fixed = 181 total (was 129)
        +1 mvnsite 2m 9s the patch passed
        +1 mvneclipse 0m 28s the patch passed
        -1 whitespace 0m 1s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 4m 13s the patch passed
        +1 javadoc 2m 26s the patch passed with JDK v1.8.0_72
        +1 javadoc 3m 11s the patch passed with JDK v1.7.0_95
        -1 unit 20m 35s hadoop-common in the patch failed with JDK v1.8.0_72.
        -1 unit 84m 35s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
        +1 unit 9m 52s hadoop-common in the patch passed with JDK v1.7.0_95.
        -1 unit 79m 54s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 28s Patch does not generate ASF License warnings.
        267m 59s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.TestRollingUpgrade
          hadoop.hdfs.server.namenode.ha.TestHAAppend
        JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.shortcircuit.TestShortCircuitCache
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
          hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
          hadoop.hdfs.server.datanode.TestDirectoryScanner



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Issue HADOOP-12746
        GITHUB PR https://github.com/apache/hadoop/pull/73
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 89ba7b7d94b3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9b959f3
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/artifact/patchprocess/diff-checkstyle-root.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Max memory used 77MB
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 37s Maven dependency ordering for branch +1 mvninstall 7m 51s trunk passed +1 compile 8m 36s trunk passed with JDK v1.8.0_72 +1 compile 7m 47s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 11s trunk passed +1 mvnsite 2m 7s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 39s trunk passed +1 javadoc 2m 22s trunk passed with JDK v1.8.0_72 +1 javadoc 3m 13s trunk passed with JDK v1.7.0_95 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 42s the patch passed +1 compile 8m 52s the patch passed with JDK v1.8.0_72 +1 javac 8m 52s the patch passed +1 compile 8m 9s the patch passed with JDK v1.7.0_95 +1 javac 8m 9s the patch passed -1 checkstyle 1m 9s root: patch generated 56 new + 125 unchanged - 4 fixed = 181 total (was 129) +1 mvnsite 2m 9s the patch passed +1 mvneclipse 0m 28s the patch passed -1 whitespace 0m 1s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 4m 13s the patch passed +1 javadoc 2m 26s the patch passed with JDK v1.8.0_72 +1 javadoc 3m 11s the patch passed with JDK v1.7.0_95 -1 unit 20m 35s hadoop-common in the patch failed with JDK v1.8.0_72. -1 unit 84m 35s hadoop-hdfs in the patch failed with JDK v1.8.0_72. +1 unit 9m 52s hadoop-common in the patch passed with JDK v1.7.0_95. -1 unit 79m 54s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 28s Patch does not generate ASF License warnings. 267m 59s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.namenode.ha.TestHAAppend JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Issue HADOOP-12746 GITHUB PR https://github.com/apache/hadoop/pull/73 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 89ba7b7d94b3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9b959f3 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8608/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jingzhao Jing Zhao added a comment -

        Thanks for working on this, Arpit! The patch looks good to me. +1.

        The patch also makes some change on DataNode.java. Do you think we should move the jira to HDFS?

        Show
        jingzhao Jing Zhao added a comment - Thanks for working on this, Arpit! The patch looks good to me. +1. The patch also makes some change on DataNode.java. Do you think we should move the jira to HDFS?
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Thanks for the code review Jing Zhao. I moved this to HDFS.

        The checkstyle issues are bogus. I will rerun all the failed tests locally to make sure they are unrelated and commit this shortly.

        Show
        arpitagarwal Arpit Agarwal added a comment - Thanks for the code review Jing Zhao . I moved this to HDFS. The checkstyle issues are bogus. I will rerun all the failed tests locally to make sure they are unrelated and commit this shortly.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Committed for 2.8.0. Thank you for the code reviews Jing and Xiaobing.

        Show
        arpitagarwal Arpit Agarwal added a comment - Committed for 2.8.0. Thank you for the code reviews Jing and Xiaobing.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user arp7 closed the pull request at:

        https://github.com/apache/hadoop/pull/73

        Show
        githubbot ASF GitHub Bot added a comment - Github user arp7 closed the pull request at: https://github.com/apache/hadoop/pull/73
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9298 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9298/)
        HDFS-9801. ReconfigurableBase should update the cached configuration. (arp: rev 1de1641f17f890059e85e57304ce33c7070a08de)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeHotSwapVolumes.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Reconfigurable.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestReconfiguration.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureReporting.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurableBase.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9298 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9298/ ) HDFS-9801 . ReconfigurableBase should update the cached configuration. (arp: rev 1de1641f17f890059e85e57304ce33c7070a08de) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeHotSwapVolumes.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Reconfigurable.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestReconfiguration.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureReporting.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurableBase.java
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
        0 mvndep 0m 33s Maven dependency ordering for branch
        +1 mvninstall 7m 2s trunk passed
        +1 compile 7m 44s trunk passed with JDK v1.8.0_72
        +1 compile 6m 58s trunk passed with JDK v1.7.0_95
        +1 checkstyle 1m 3s trunk passed
        +1 mvnsite 1m 52s trunk passed
        +1 mvneclipse 0m 25s trunk passed
        +1 findbugs 3m 22s trunk passed
        +1 javadoc 2m 15s trunk passed with JDK v1.8.0_72
        +1 javadoc 3m 16s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 15s Maven dependency ordering for patch
        +1 mvninstall 1m 33s the patch passed
        +1 compile 10m 53s the patch passed with JDK v1.8.0_72
        +1 javac 10m 53s the patch passed
        +1 compile 9m 49s the patch passed with JDK v1.7.0_95
        +1 javac 9m 49s the patch passed
        -1 checkstyle 1m 4s root: patch generated 56 new + 126 unchanged - 4 fixed = 182 total (was 130)
        +1 mvnsite 1m 55s the patch passed
        +1 mvneclipse 0m 25s the patch passed
        -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 4m 30s the patch passed
        +1 javadoc 2m 20s the patch passed with JDK v1.8.0_72
        +1 javadoc 4m 49s the patch passed with JDK v1.7.0_95
        -1 unit 13m 24s hadoop-common in the patch failed with JDK v1.8.0_72.
        -1 unit 66m 39s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
        +1 unit 8m 1s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 unit 55m 26s hadoop-hdfs in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        217m 42s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.ha.TestZKFailoverController
          hadoop.hdfs.TestFileAppend
          hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Issue HDFS-9801
        GITHUB PR https://github.com/apache/hadoop/pull/73
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 74a12f0b07ef 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9fdfb54
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14483/artifact/patchprocess/diff-checkstyle-root.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14483/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14483/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14483/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14483/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14483/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14483/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14483/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 33s Maven dependency ordering for branch +1 mvninstall 7m 2s trunk passed +1 compile 7m 44s trunk passed with JDK v1.8.0_72 +1 compile 6m 58s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 3s trunk passed +1 mvnsite 1m 52s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 3m 22s trunk passed +1 javadoc 2m 15s trunk passed with JDK v1.8.0_72 +1 javadoc 3m 16s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 33s the patch passed +1 compile 10m 53s the patch passed with JDK v1.8.0_72 +1 javac 10m 53s the patch passed +1 compile 9m 49s the patch passed with JDK v1.7.0_95 +1 javac 9m 49s the patch passed -1 checkstyle 1m 4s root: patch generated 56 new + 126 unchanged - 4 fixed = 182 total (was 130) +1 mvnsite 1m 55s the patch passed +1 mvneclipse 0m 25s the patch passed -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 4m 30s the patch passed +1 javadoc 2m 20s the patch passed with JDK v1.8.0_72 +1 javadoc 4m 49s the patch passed with JDK v1.7.0_95 -1 unit 13m 24s hadoop-common in the patch failed with JDK v1.8.0_72. -1 unit 66m 39s hadoop-hdfs in the patch failed with JDK v1.8.0_72. +1 unit 8m 1s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 55m 26s hadoop-hdfs in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 217m 42s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.hdfs.TestFileAppend   hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Issue HDFS-9801 GITHUB PR https://github.com/apache/hadoop/pull/73 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 74a12f0b07ef 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9fdfb54 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14483/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14483/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14483/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14483/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14483/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14483/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14483/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14483/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            arpitagarwal Arpit Agarwal
            Reporter:
            arpitagarwal Arpit Agarwal
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development