Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9777

Fix typos in DFSAdmin command line and documentation

    Details

    • Hadoop Flags:
      Reviewed

      Description

      I am seeing multiple typos "covert" (instead of convert, although covert is also a correct English word) here and there, especially in comments. But I caught a "covert" typo in a dfsadmin error message as well as its documentation.

      1. HDFS-9777.001.patch
        2 kB
        Wei-Chiu Chuang

        Activity

        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Rev01: there are three "covert" typos related to DFSAdmin. One of them is a command line error message. Is this an incompatible change? Some tools may rely on the error message.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Rev01: there are three "covert" typos related to DFSAdmin. One of them is a command line error message. Is this an incompatible change? Some tools may rely on the error message.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 12m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 26s Maven dependency ordering for branch
        +1 mvninstall 6m 38s trunk passed
        +1 compile 1m 16s trunk passed with JDK v1.8.0_72
        +1 compile 1m 19s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 1m 25s trunk passed
        +1 mvneclipse 0m 26s trunk passed
        +1 findbugs 3m 32s trunk passed
        +1 javadoc 1m 25s trunk passed with JDK v1.8.0_72
        +1 javadoc 2m 11s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 17s Maven dependency ordering for patch
        +1 mvninstall 1m 15s the patch passed
        +1 compile 1m 13s the patch passed with JDK v1.8.0_72
        +1 javac 1m 13s the patch passed
        +1 compile 1m 18s the patch passed with JDK v1.7.0_95
        +1 javac 1m 18s the patch passed
        +1 checkstyle 0m 26s the patch passed
        +1 mvnsite 1m 21s the patch passed
        +1 mvneclipse 0m 22s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 3m 56s the patch passed
        +1 javadoc 1m 21s the patch passed with JDK v1.8.0_72
        +1 javadoc 2m 7s the patch passed with JDK v1.7.0_95
        +1 unit 0m 48s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72.
        -1 unit 54m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
        +1 unit 0m 56s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
        -1 unit 49m 58s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        153m 29s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.shortcircuit.TestShortCircuitCache
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.TestFSEditLogLoader



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786829/HDFS-9777.001.patch
        JIRA Issue HDFS-9777
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux b26f8edc1dc7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d37eb82
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14426/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14426/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14426/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14426/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14426/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Max memory used 77MB
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14426/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 12m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 26s Maven dependency ordering for branch +1 mvninstall 6m 38s trunk passed +1 compile 1m 16s trunk passed with JDK v1.8.0_72 +1 compile 1m 19s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 25s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 32s trunk passed +1 javadoc 1m 25s trunk passed with JDK v1.8.0_72 +1 javadoc 2m 11s trunk passed with JDK v1.7.0_95 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 15s the patch passed +1 compile 1m 13s the patch passed with JDK v1.8.0_72 +1 javac 1m 13s the patch passed +1 compile 1m 18s the patch passed with JDK v1.7.0_95 +1 javac 1m 18s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvnsite 1m 21s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 56s the patch passed +1 javadoc 1m 21s the patch passed with JDK v1.8.0_72 +1 javadoc 2m 7s the patch passed with JDK v1.7.0_95 +1 unit 0m 48s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72. -1 unit 54m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_72. +1 unit 0m 56s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 49m 58s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 153m 29s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.shortcircuit.TestShortCircuitCache JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.TestFSEditLogLoader Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786829/HDFS-9777.001.patch JIRA Issue HDFS-9777 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux b26f8edc1dc7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d37eb82 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14426/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14426/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14426/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14426/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14426/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14426/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        Thanks for catching them.
        +1 committing

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - Thanks for catching them. +1 committing
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        Committed to trunk, branch-2 and 2.8. Thanks for the contribution.

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - Committed to trunk, branch-2 and 2.8. Thanks for the contribution.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9263 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9263/)
        HDFS-9777. Fix typos in DFSAdmin command line and (uma.gangumalla: rev bffaa38a91b26920206a3350bf1cd60ec950aa74)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
        • hadoop-hdfs-project/hadoop-hdfs/dev-support/jdiff/Apache_Hadoop_HDFS_2.6.0.xml
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9263 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9263/ ) HDFS-9777 . Fix typos in DFSAdmin command line and (uma.gangumalla: rev bffaa38a91b26920206a3350bf1cd60ec950aa74) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java hadoop-hdfs-project/hadoop-hdfs/dev-support/jdiff/Apache_Hadoop_HDFS_2.6.0.xml hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Thanks Uma Maheswara Rao G for the quick review and commit!

        Show
        jojochuang Wei-Chiu Chuang added a comment - Thanks Uma Maheswara Rao G for the quick review and commit!

          People

          • Assignee:
            jojochuang Wei-Chiu Chuang
            Reporter:
            jojochuang Wei-Chiu Chuang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development