Details
-
Type:
Bug
-
Status: Resolved
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 2.8.0, 3.0.0-alpha1
-
Component/s: distcp
-
Labels:None
-
Hadoop Flags:Reviewed
Description
numListstatusThreads is missing from DistCpOption code:
public String toString() { return "DistCpOptions{" + "atomicCommit=" + atomicCommit + ", syncFolder=" + syncFolder + ", deleteMissing=" + deleteMissing + ", ignoreFailures=" + ignoreFailures + ", maxMaps=" + maxMaps + ", sslConfigurationFile='" + sslConfigurationFile + '\'' + ", copyStrategy='" + copyStrategy + '\'' + ", sourceFileListing=" + sourceFileListing + ", sourcePaths=" + sourcePaths + ", targetPath=" + targetPath + ", targetPathExists=" + targetPathExists + ", preserveRawXattrs=" + preserveRawXattrs + ", filtersFile='" + filtersFile + '\'' + '}'; }
Issue Links
- is related to
-
HDFS-9774
Update distcp command line options in the documentation
-
- Patch Available
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Rev01: updated toString() based on the copy constructor. Also updated the test case.
 +1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 1m 7s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
| 0 | mvndep | 0m 35s | Maven dependency ordering for branch |
| +1 | mvninstall | 9m 25s | trunk passed |
| +1 | compile | 0m 24s | trunk passed with JDK v1.8.0_66 |
| +1 | compile | 0m 23s | trunk passed with JDK v1.7.0_91 |
| +1 | checkstyle | 0m 19s | trunk passed |
| +1 | mvnsite | 0m 31s | trunk passed |
| +1 | mvneclipse | 0m 27s | trunk passed |
| +1 | findbugs | 0m 39s | trunk passed |
| +1 | javadoc | 0m 21s | trunk passed with JDK v1.8.0_66 |
| +1 | javadoc | 0m 20s | trunk passed with JDK v1.7.0_91 |
| 0 | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 | mvninstall | 0m 23s | the patch passed |
| +1 | compile | 0m 22s | the patch passed with JDK v1.8.0_66 |
| +1 | javac | 0m 22s | the patch passed |
| +1 | compile | 0m 20s | the patch passed with JDK v1.7.0_91 |
| +1 | javac | 0m 20s | the patch passed |
| +1 | checkstyle | 0m 16s | the patch passed |
| +1 | mvnsite | 0m 27s | the patch passed |
| +1 | mvneclipse | 0m 14s | the patch passed |
| +1 | whitespace | 0m 0s | Patch has no whitespace issues. |
| +1 | findbugs | 0m 51s | the patch passed |
| +1 | javadoc | 0m 17s | the patch passed with JDK v1.8.0_66 |
| +1 | javadoc | 0m 17s | the patch passed with JDK v1.7.0_91 |
| +1 | unit | 8m 44s | hadoop-distcp in the patch passed with JDK v1.8.0_66. |
| +1 | unit | 8m 23s | hadoop-distcp in the patch passed with JDK v1.7.0_91. |
| +1 | asflicense | 0m 25s | Patch does not generate ASF License warnings. |
| 36m 58s |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:0ca8df7 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12786401/HDFS-9764.001.patch |
| JIRA Issue | |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
| uname | Linux 0f471f8a8481 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 1bcfab8 |
| Default Java | 1.7.0_91 |
| Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 |
| findbugs | v3.0.0 |
| JDK v1.7.0_91 Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/14399/testReport/ |
| modules | C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp |
| Max memory used | 77MB |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/14399/console |
| Powered by | Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
+1 on the patch, will commit soon, Thanks.
Committed to trunk, branch-2, branch-2.8.
Thanks Wei-Chiu for the contribution.
FAILURE: Integrated in Hadoop-trunk-Commit #9330 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9330/)
HDFS-9764. DistCp doesn't print value for several arguments including (yzhang: rev ba1c9d484a8d6a18b4b7365c49d09635d24e579a)
- hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestOptionsParser.java
- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
- hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpOptions.java
Thanks Yongjun Zhang for reporting this. I am assigning this to myself. In addition to numListstatusThreads, there are other options that can be stringfied: overwrite, append, useDiff, skipCRC, mapBandwidth, and more.