Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9740

Use a reasonable limit in DFSTestUtil.waitForMetric()

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If test is detecting a bug, it will probably hit the long surefire timeout because the max is Integer.MAX_VALUE. Use something more realistic. The default jmx update interval is 10 seconds, so something like 60 seconds should be more than enough.

      1. HDFS-9740-branch-2.patch
        1 kB
        Vinayakumar B
      2. HDFS-9740-branch-2.7.patch
        2 kB
        Vinayakumar B
      3. HDFS-9740.patch
        0.6 kB
        Chang Li

        Activity

        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Closing the JIRA as part of 2.7.3 release.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9236 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9236/)
        HDFS-9740. Use a reasonable limit in DFSTestUtil.waitForMetric() (vinayakumarb: rev eb2fb943fd97c191fd7c4f5333087a28ee5c87d8)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9236 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9236/ ) HDFS-9740 . Use a reasonable limit in DFSTestUtil.waitForMetric() (vinayakumarb: rev eb2fb943fd97c191fd7c4f5333087a28ee5c87d8) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
        Hide
        vinayrpet Vinayakumar B added a comment -

        Branch-2 and branch-2.7 committed patches.

        Show
        vinayrpet Vinayakumar B added a comment - Branch-2 and branch-2.7 committed patches.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Committed to trunk, branch-2, branch-2.8 and branch-2.7

        There were some line differences while cherry-picking to branch-2 and branch-2.7. Resolved them. Will attach the committed patches.

        Thanks Chang Li and Kihwal Lee

        Show
        vinayrpet Vinayakumar B added a comment - Committed to trunk, branch-2, branch-2.8 and branch-2.7 There were some line differences while cherry-picking to branch-2 and branch-2.7. Resolved them. Will attach the committed patches. Thanks Chang Li and Kihwal Lee
        Hide
        vinayrpet Vinayakumar B added a comment -

        +1
        Will commit shortly

        Show
        vinayrpet Vinayakumar B added a comment - +1 Will commit shortly
        Hide
        lichangleo Chang Li added a comment -

        testRemoveVolumeBeingWritten in TestFsDatasetImpl are tracked by HDFS-9310. Rest tests failures are not related by my change and can not be reproduced on my local machine

        Show
        lichangleo Chang Li added a comment - testRemoveVolumeBeingWritten in TestFsDatasetImpl are tracked by HDFS-9310 . Rest tests failures are not related by my change and can not be reproduced on my local machine
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 9s Maven dependency ordering for branch
        +1 mvninstall 7m 33s trunk passed
        +1 compile 0m 46s trunk passed with JDK v1.8.0_66
        +1 compile 0m 43s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 22s trunk passed
        +1 mvnsite 0m 58s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 57s trunk passed
        +1 javadoc 1m 17s trunk passed with JDK v1.8.0_66
        +1 javadoc 2m 5s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 0m 53s the patch passed
        +1 compile 0m 50s the patch passed with JDK v1.8.0_66
        +1 javac 0m 50s the patch passed
        +1 compile 0m 46s the patch passed with JDK v1.7.0_91
        +1 javac 0m 46s the patch passed
        +1 checkstyle 0m 22s the patch passed
        +1 mvnsite 1m 0s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 8s the patch passed
        +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 45s the patch passed with JDK v1.7.0_91
        -1 unit 59m 25s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 52m 36s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 22s Patch does not generate ASF License warnings.
        140m 5s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork
          hadoop.hdfs.TestRenameWhileOpen
          hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
          hadoop.hdfs.server.datanode.TestBlockScanner
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockManager
          hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
          hadoop.hdfs.TestDFSUpgradeFromImage



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785800/HDFS-9740.patch
        JIRA Issue HDFS-9740
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 85417d17d670 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 700a176
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14346/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14346/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14346/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14346/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14346/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14346/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 7m 33s trunk passed +1 compile 0m 46s trunk passed with JDK v1.8.0_66 +1 compile 0m 43s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 57s trunk passed +1 javadoc 1m 17s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 5s trunk passed with JDK v1.7.0_91 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 0m 53s the patch passed +1 compile 0m 50s the patch passed with JDK v1.8.0_66 +1 javac 0m 50s the patch passed +1 compile 0m 46s the patch passed with JDK v1.7.0_91 +1 javac 0m 46s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 8s the patch passed +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 45s the patch passed with JDK v1.7.0_91 -1 unit 59m 25s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 52m 36s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 140m 5s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork   hadoop.hdfs.TestRenameWhileOpen   hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation   hadoop.hdfs.server.datanode.TestBlockScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.TestDFSUpgradeFromImage Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785800/HDFS-9740.patch JIRA Issue HDFS-9740 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 85417d17d670 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 700a176 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14346/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14346/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14346/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14346/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14346/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14346/console This message was automatically generated.
        Hide
        lichangleo Chang Li added a comment -

        Kihwal Lee uploaded a patch to change wait time to 60 seconds

        Show
        lichangleo Chang Li added a comment - Kihwal Lee uploaded a patch to change wait time to 60 seconds

          People

          • Assignee:
            lichangleo Chang Li
            Reporter:
            kihwal Kihwal Lee
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development