Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: datanode
    • Labels:
      None

      Description

      The IBR code currently is mainly in BPServiceActor. The JIRA is to refactor it to a new class.

      1. h9726_20160131.patch
        30 kB
        Tsz Wo Nicholas Sze
      2. h9726_20160201.patch
        30 kB
        Tsz Wo Nicholas Sze
      3. h9726_20160203.patch
        30 kB
        Tsz Wo Nicholas Sze
      4. h9726_20160204.patch
        30 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          h9726_20160131.patch: 1st patch.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - h9726_20160131.patch: 1st patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 13m 55s trunk passed
          +1 compile 2m 27s trunk passed with JDK v1.8.0_66
          +1 compile 1m 23s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 36s trunk passed
          +1 mvnsite 1m 41s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          +1 findbugs 3m 42s trunk passed
          +1 javadoc 2m 55s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 5s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 46s the patch passed
          +1 compile 2m 20s the patch passed with JDK v1.8.0_66
          +1 javac 2m 20s the patch passed
          +1 compile 1m 31s the patch passed with JDK v1.7.0_91
          +1 javac 1m 31s the patch passed
          -1 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: patch generated 2 new + 44 unchanged - 4 fixed = 46 total (was 48)
          +1 mvnsite 1m 28s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 3m 14s the patch passed
          +1 javadoc 1m 53s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 48s the patch passed with JDK v1.7.0_91
          -1 unit 129m 49s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 115m 32s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 27s Patch does not generate ASF License warnings.
          296m 44s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.hdfs.TestRecoverStripedFile
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.TestLocalDFS
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.tools.TestDFSAdminWithHA
            hadoop.hdfs.TestDatanodeRegistration
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.datanode.TestDirectoryScanner
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
            hadoop.tracing.TestTracing
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.TestLocalDFS
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.server.datanode.TestDirectoryScanner
          JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785362/h9726_20160131.patch
          JIRA Issue HDFS-9726
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b028fa348686 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 772ea7b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14302/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14302/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14302/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14302/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14302/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14302/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14302/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14302/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 13m 55s trunk passed +1 compile 2m 27s trunk passed with JDK v1.8.0_66 +1 compile 1m 23s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 36s trunk passed +1 mvnsite 1m 41s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 42s trunk passed +1 javadoc 2m 55s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 5s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 46s the patch passed +1 compile 2m 20s the patch passed with JDK v1.8.0_66 +1 javac 2m 20s the patch passed +1 compile 1m 31s the patch passed with JDK v1.7.0_91 +1 javac 1m 31s the patch passed -1 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: patch generated 2 new + 44 unchanged - 4 fixed = 46 total (was 48) +1 mvnsite 1m 28s the patch passed +1 mvneclipse 0m 15s the patch passed -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 3m 14s the patch passed +1 javadoc 1m 53s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 48s the patch passed with JDK v1.7.0_91 -1 unit 129m 49s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 115m 32s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 27s Patch does not generate ASF License warnings. 296m 44s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestLocalDFS   hadoop.hdfs.TestFileAppend   hadoop.hdfs.tools.TestDFSAdminWithHA   hadoop.hdfs.TestDatanodeRegistration   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.tracing.TestTracing   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.TestLocalDFS   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785362/h9726_20160131.patch JIRA Issue HDFS-9726 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b028fa348686 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 772ea7b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14302/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14302/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14302/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14302/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14302/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14302/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14302/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14302/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 12m 57s trunk passed
          +1 compile 1m 39s trunk passed with JDK v1.8.0_66
          +1 compile 1m 11s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 1m 25s trunk passed
          +1 mvneclipse 0m 17s trunk passed
          +1 findbugs 2m 46s trunk passed
          +1 javadoc 1m 50s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 56s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 17s the patch passed
          +1 compile 1m 41s the patch passed with JDK v1.8.0_66
          +1 javac 1m 41s the patch passed
          +1 compile 1m 24s the patch passed with JDK v1.7.0_91
          +1 javac 1m 24s the patch passed
          -1 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: patch generated 2 new + 44 unchanged - 4 fixed = 46 total (was 48)
          +1 mvnsite 1m 31s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 3m 42s the patch passed
          +1 javadoc 2m 53s the patch passed with JDK v1.8.0_66
          +1 javadoc 4m 7s the patch passed with JDK v1.7.0_91
          -1 unit 141m 37s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 109m 39s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          299m 36s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.hdfs.TestRecoverStripedFile
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.TestCrcCorruption
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.fs.TestSymlinkHdfsFileContext
            hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
            hadoop.hdfs.server.datanode.TestDirectoryScanner
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
            hadoop.hdfs.server.datanode.TestDirectoryScanner



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785362/h9726_20160131.patch
          JIRA Issue HDFS-9726
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 48dee0cb15a2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 772ea7b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14303/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14303/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14303/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14303/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14303/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14303/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14303/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14303/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 12m 57s trunk passed +1 compile 1m 39s trunk passed with JDK v1.8.0_66 +1 compile 1m 11s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 25s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 2m 46s trunk passed +1 javadoc 1m 50s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 56s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 17s the patch passed +1 compile 1m 41s the patch passed with JDK v1.8.0_66 +1 javac 1m 41s the patch passed +1 compile 1m 24s the patch passed with JDK v1.7.0_91 +1 javac 1m 24s the patch passed -1 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: patch generated 2 new + 44 unchanged - 4 fixed = 46 total (was 48) +1 mvnsite 1m 31s the patch passed +1 mvneclipse 0m 15s the patch passed -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 3m 42s the patch passed +1 javadoc 2m 53s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 7s the patch passed with JDK v1.7.0_91 -1 unit 141m 37s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 109m 39s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 299m 36s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.namenode.TestFSImageWithSnapshot   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785362/h9726_20160131.patch JIRA Issue HDFS-9726 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 48dee0cb15a2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 772ea7b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14303/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14303/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14303/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14303/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14303/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14303/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14303/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14303/console This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          h9726_20160201.patch: reverts some changes for retaining the original logic.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - h9726_20160201.patch: reverts some changes for retaining the original logic.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 9m 53s trunk passed
          +1 compile 1m 21s trunk passed with JDK v1.8.0_66
          +1 compile 1m 5s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 1m 19s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 2m 38s trunk passed
          +1 javadoc 1m 48s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 30s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 9s the patch passed
          +1 compile 1m 17s the patch passed with JDK v1.8.0_66
          +1 javac 1m 17s the patch passed
          +1 compile 0m 58s the patch passed with JDK v1.7.0_91
          +1 javac 0m 58s the patch passed
          -1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: patch generated 2 new + 44 unchanged - 4 fixed = 46 total (was 48)
          +1 mvnsite 1m 13s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 2m 59s the patch passed
          +1 javadoc 1m 36s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 28s the patch passed with JDK v1.7.0_91
          -1 unit 110m 41s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 98m 49s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          247m 16s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.hdfs.TestDataTransferKeepalive
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.fs.TestSymlinkHdfsFileContext
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider
            hadoop.hdfs.server.namenode.TestCacheDirectives
            hadoop.hdfs.TestEncryptionZonesWithKMS
            hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
            hadoop.hdfs.server.datanode.TestDirectoryScanner
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.server.namenode.TestFileTruncate
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
            hadoop.hdfs.TestEncryptionZonesWithKMS
            hadoop.hdfs.server.datanode.TestDirectoryScanner



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785414/h9726_20160201.patch
          JIRA Issue HDFS-9726
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 2f7ebfe5672f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 772ea7b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14306/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14306/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14306/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14306/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14306/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14306/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14306/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14306/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 9m 53s trunk passed +1 compile 1m 21s trunk passed with JDK v1.8.0_66 +1 compile 1m 5s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 26s trunk passed +1 mvnsite 1m 19s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 2m 38s trunk passed +1 javadoc 1m 48s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 30s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 9s the patch passed +1 compile 1m 17s the patch passed with JDK v1.8.0_66 +1 javac 1m 17s the patch passed +1 compile 0m 58s the patch passed with JDK v1.7.0_91 +1 javac 0m 58s the patch passed -1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: patch generated 2 new + 44 unchanged - 4 fixed = 46 total (was 48) +1 mvnsite 1m 13s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 2m 59s the patch passed +1 javadoc 1m 36s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 28s the patch passed with JDK v1.7.0_91 -1 unit 110m 41s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 98m 49s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 247m 16s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.TestDataTransferKeepalive   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider   hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.hdfs.TestEncryptionZonesWithKMS   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.blockmanagement.TestReplicationPolicy   hadoop.hdfs.TestEncryptionZonesWithKMS   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785414/h9726_20160201.patch JIRA Issue HDFS-9726 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2f7ebfe5672f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 772ea7b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14306/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14306/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14306/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14306/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14306/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14306/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14306/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14306/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 10m 41s trunk passed
          +1 compile 1m 23s trunk passed with JDK v1.8.0_66
          +1 compile 1m 7s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 31s trunk passed
          +1 mvnsite 1m 22s trunk passed
          +1 mvneclipse 0m 19s trunk passed
          +1 findbugs 2m 53s trunk passed
          +1 javadoc 1m 48s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 51s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 12s Maven dependency ordering for patch
          +1 mvninstall 1m 14s the patch passed
          +1 compile 1m 22s the patch passed with JDK v1.8.0_66
          +1 javac 1m 22s the patch passed
          +1 compile 1m 0s the patch passed with JDK v1.7.0_91
          +1 javac 1m 0s the patch passed
          -1 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: patch generated 2 new + 44 unchanged - 4 fixed = 46 total (was 48)
          +1 mvnsite 1m 20s the patch passed
          +1 mvneclipse 0m 17s the patch passed
          -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 3m 2s the patch passed
          +1 javadoc 1m 51s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 56s the patch passed with JDK v1.7.0_91
          -1 unit 97m 57s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 88m 13s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 29s Patch does not generate ASF License warnings.
          227m 21s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestRecoverStripedFile
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.security.TestDelegationTokenForProxyUser



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785414/h9726_20160201.patch
          JIRA Issue HDFS-9726
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f8c068bd395c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 772ea7b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14310/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14310/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14310/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14310/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14310/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14310/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14310/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14310/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 10m 41s trunk passed +1 compile 1m 23s trunk passed with JDK v1.8.0_66 +1 compile 1m 7s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 31s trunk passed +1 mvnsite 1m 22s trunk passed +1 mvneclipse 0m 19s trunk passed +1 findbugs 2m 53s trunk passed +1 javadoc 1m 48s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 51s trunk passed with JDK v1.7.0_91 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 1m 14s the patch passed +1 compile 1m 22s the patch passed with JDK v1.8.0_66 +1 javac 1m 22s the patch passed +1 compile 1m 0s the patch passed with JDK v1.7.0_91 +1 javac 1m 0s the patch passed -1 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: patch generated 2 new + 44 unchanged - 4 fixed = 46 total (was 48) +1 mvnsite 1m 20s the patch passed +1 mvneclipse 0m 17s the patch passed -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 3m 2s the patch passed +1 javadoc 1m 51s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 56s the patch passed with JDK v1.7.0_91 -1 unit 97m 57s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 88m 13s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 29s Patch does not generate ASF License warnings. 227m 21s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.TestFileAppend   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.security.TestDelegationTokenForProxyUser JDK v1.7.0_91 Failed junit tests hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.security.TestDelegationTokenForProxyUser Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785414/h9726_20160201.patch JIRA Issue HDFS-9726 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f8c068bd395c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 772ea7b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14310/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14310/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14310/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14310/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14310/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14310/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14310/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14310/console This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          The failed tests seem unrelated. They all passed in my machine.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - The failed tests seem unrelated. They all passed in my machine.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Thanks for working on this, Tsz Wo Nicholas Sze. I think this is good improvement making datanode's code clearer.

          The patch looks good to me overall. Unit tests passed on my environment. Found some nits.

          • IncrementalBlockReportManager#addRDBI should be VisibleForTesting and IncrementalBlockReportManager#sendImmediately is not.
          • notifyNamenodeBlock: I felt the meanings of send and now are not clear from the variable name. How about immediate and notify respectively?
          Show
          iwasakims Masatake Iwasaki added a comment - Thanks for working on this, Tsz Wo Nicholas Sze . I think this is good improvement making datanode's code clearer. The patch looks good to me overall. Unit tests passed on my environment. Found some nits. IncrementalBlockReportManager#addRDBI should be VisibleForTesting and IncrementalBlockReportManager#sendImmediately is not. notifyNamenodeBlock : I felt the meanings of send and now are not clear from the variable name. How about immediate and notify respectively?
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Thanks Masatake Iwasaki for the comments. For send and now, let's rename them to readyToSend and triggerIBR. Here is new patch.

          h9726_20160203.patch

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Thanks Masatake Iwasaki for the comments. For send and now, let's rename them to readyToSend and triggerIBR. Here is new patch. h9726_20160203.patch
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 8s Maven dependency ordering for branch
          +1 mvninstall 6m 35s trunk passed
          +1 compile 0m 43s trunk passed with JDK v1.8.0_66
          +1 compile 0m 42s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 20s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 54s trunk passed
          +1 javadoc 1m 6s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 45s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 0m 44s the patch passed
          +1 compile 0m 36s the patch passed with JDK v1.8.0_66
          +1 javac 0m 36s the patch passed
          +1 compile 0m 38s the patch passed with JDK v1.7.0_91
          +1 javac 0m 38s the patch passed
          -1 checkstyle 0m 19s hadoop-hdfs-project/hadoop-hdfs: patch generated 3 new + 43 unchanged - 4 fixed = 46 total (was 47)
          +1 mvnsite 0m 50s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 5s the patch passed
          +1 javadoc 1m 3s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 44s the patch passed with JDK v1.7.0_91
          -1 unit 160m 0s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 153m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          339m 12s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
            hadoop.hdfs.server.namenode.TestReconstructStripedBlocks
            hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer
            hadoop.fs.TestSymlinkHdfsFileSystem
            hadoop.fs.TestSymlinkHdfsFileContext
            hadoop.hdfs.TestClientProtocolForPipelineRecovery
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.server.mover.TestStorageMover
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.TestEncryptedTransfer
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.fs.contract.hdfs.TestHDFSContractSeek
            hadoop.hdfs.server.namenode.TestListCorruptFileBlocks
            hadoop.hdfs.TestWriteConfigurationToDFS
            hadoop.hdfs.TestPersistBlocks
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure110
            hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality
            hadoop.hdfs.TestParallelRead
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.TestDecommission
            hadoop.hdfs.server.datanode.TestTriggerBlockReport
            hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication
            hadoop.hdfs.server.namenode.TestCacheDirectives
            hadoop.hdfs.server.datanode.TestIncrementalBlockReports
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks
            hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
            hadoop.hdfs.TestGetFileChecksum
            hadoop.hdfs.TestBlockStoragePolicy
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles
            hadoop.hdfs.server.namenode.ha.TestHASafeMode
            hadoop.hdfs.TestReadStripedFileWithDecoding
            hadoop.hdfs.TestFetchImage
            hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
            hadoop.hdfs.server.namenode.TestCheckPointForSecurityTokens
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.namenode.snapshot.TestSetQuotaWithSnapshot
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
            org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract
            org.apache.hadoop.hdfs.TestHDFSFileSystemContract
            org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshot
            org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
            org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite
            org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
            hadoop.hdfs.server.namenode.TestReconstructStripedBlocks
            hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer
            hadoop.fs.TestSymlinkHdfsFileSystem
            hadoop.fs.TestSymlinkHdfsFileContext
            hadoop.hdfs.server.mover.TestStorageMover
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.TestEncryptedTransfer
            hadoop.hdfs.TestParallelShortCircuitReadUnCached
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.namenode.TestListCorruptFileBlocks
            hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
            hadoop.hdfs.TestWriteConfigurationToDFS
            hadoop.hdfs.TestPersistBlocks
            hadoop.hdfs.TestErasureCodingPolicyWithSnapshot
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure110
            hadoop.hdfs.TestSafeMode
            hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality
            hadoop.hdfs.TestParallelRead
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.server.datanode.TestTriggerBlockReport
            hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
            hadoop.hdfs.TestDFSRemove
            hadoop.hdfs.server.datanode.TestIncrementalBlockReports
            hadoop.hdfs.TestErasureCodeBenchmarkThroughput
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks
            hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
            hadoop.hdfs.TestGetFileChecksum
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles
            hadoop.hdfs.server.namenode.ha.TestHASafeMode
            hadoop.hdfs.server.namenode.snapshot.TestSnapshot
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040
            hadoop.hdfs.TestDatanodeDeath
            hadoop.hdfs.TestReadStripedFileWithDecoding
            hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.TestReplaceDatanodeOnFailure
          JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
            org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract
            org.apache.hadoop.hdfs.TestHDFSFileSystemContract
            org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
            org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite
            org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
            org.apache.hadoop.cli.TestHDFSCLI



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785974/h9726_20160203.patch
          JIRA Issue HDFS-9726
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 178794a02a78 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / eb2fb94
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14360/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14360/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14360/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14360/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14360/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14360/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14360/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 6m 35s trunk passed +1 compile 0m 43s trunk passed with JDK v1.8.0_66 +1 compile 0m 42s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 54s trunk passed +1 javadoc 1m 6s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 45s trunk passed with JDK v1.7.0_91 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 0m 44s the patch passed +1 compile 0m 36s the patch passed with JDK v1.8.0_66 +1 javac 0m 36s the patch passed +1 compile 0m 38s the patch passed with JDK v1.7.0_91 +1 javac 0m 38s the patch passed -1 checkstyle 0m 19s hadoop-hdfs-project/hadoop-hdfs: patch generated 3 new + 43 unchanged - 4 fixed = 46 total (was 47) +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 5s the patch passed +1 javadoc 1m 3s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 44s the patch passed with JDK v1.7.0_91 -1 unit 160m 0s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 153m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 339m 12s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead   hadoop.hdfs.server.namenode.TestReconstructStripedBlocks   hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer   hadoop.fs.TestSymlinkHdfsFileSystem   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.TestClientProtocolForPipelineRecovery   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.mover.TestStorageMover   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap   hadoop.hdfs.TestFileAppend   hadoop.hdfs.TestEncryptedTransfer   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.fs.contract.hdfs.TestHDFSContractSeek   hadoop.hdfs.server.namenode.TestListCorruptFileBlocks   hadoop.hdfs.TestWriteConfigurationToDFS   hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure110   hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality   hadoop.hdfs.TestParallelRead   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.TestDecommission   hadoop.hdfs.server.datanode.TestTriggerBlockReport   hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs   hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication   hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.hdfs.server.datanode.TestIncrementalBlockReports   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.TestGetFileChecksum   hadoop.hdfs.TestBlockStoragePolicy   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles   hadoop.hdfs.server.namenode.ha.TestHASafeMode   hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.TestFetchImage   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.server.namenode.TestCheckPointForSecurityTokens   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.snapshot.TestSetQuotaWithSnapshot JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete   org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract   org.apache.hadoop.hdfs.TestHDFSFileSystemContract   org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshot   org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite   org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics JDK v1.7.0_91 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead   hadoop.hdfs.server.namenode.TestReconstructStripedBlocks   hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer   hadoop.fs.TestSymlinkHdfsFileSystem   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.server.mover.TestStorageMover   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.TestFileAppend   hadoop.hdfs.TestEncryptedTransfer   hadoop.hdfs.TestParallelShortCircuitReadUnCached   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.namenode.TestListCorruptFileBlocks   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.TestWriteConfigurationToDFS   hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.TestErasureCodingPolicyWithSnapshot   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure110   hadoop.hdfs.TestSafeMode   hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality   hadoop.hdfs.TestParallelRead   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.server.datanode.TestTriggerBlockReport   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs   hadoop.hdfs.TestDFSRemove   hadoop.hdfs.server.datanode.TestIncrementalBlockReports   hadoop.hdfs.TestErasureCodeBenchmarkThroughput   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.TestGetFileChecksum   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles   hadoop.hdfs.server.namenode.ha.TestHASafeMode   hadoop.hdfs.server.namenode.snapshot.TestSnapshot   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040   hadoop.hdfs.TestDatanodeDeath   hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.TestReplaceDatanodeOnFailure JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete   org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract   org.apache.hadoop.hdfs.TestHDFSFileSystemContract   org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite   org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics   org.apache.hadoop.cli.TestHDFSCLI Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785974/h9726_20160203.patch JIRA Issue HDFS-9726 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 178794a02a78 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / eb2fb94 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14360/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14360/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14360/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14360/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14360/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14360/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14360/console This message was automatically generated.
          Hide
          jingzhao Jing Zhao added a comment -

          Thanks for the refactoring, Nicholas! The patch looks good to me. +1

          One optional change can be: instead of using two boolean variable (ready2Send and triggerIBR) to indicate what to do in notifyNamenodeBlock, maybe we can create an enum to indicate the 3 types of action.

          The test failures should be unrelated. I just re-triggered Jenkins.

          Show
          jingzhao Jing Zhao added a comment - Thanks for the refactoring, Nicholas! The patch looks good to me. +1 One optional change can be: instead of using two boolean variable (ready2Send and triggerIBR) to indicate what to do in notifyNamenodeBlock , maybe we can create an enum to indicate the 3 types of action. The test failures should be unrelated. I just re-triggered Jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 11s Maven dependency ordering for branch
          +1 mvninstall 8m 52s trunk passed
          +1 compile 1m 9s trunk passed with JDK v1.8.0_66
          +1 compile 0m 56s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 1m 8s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 2m 22s trunk passed
          +1 javadoc 1m 51s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 46s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 1m 16s the patch passed
          +1 compile 1m 29s the patch passed with JDK v1.8.0_66
          +1 javac 1m 29s the patch passed
          +1 compile 1m 1s the patch passed with JDK v1.7.0_91
          +1 javac 1m 1s the patch passed
          -1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: patch generated 3 new + 43 unchanged - 4 fixed = 46 total (was 47)
          +1 mvnsite 1m 18s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 55s the patch passed
          +1 javadoc 1m 37s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 38s the patch passed with JDK v1.7.0_91
          -1 unit 167m 15s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 168m 34s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          372m 42s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestReadStripedFileWithDecoding
            hadoop.hdfs.TestDecommission
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.fs.viewfs.TestViewFsWithXAttrs
            hadoop.fs.TestHDFSFileContextMainOperations
            hadoop.hdfs.server.blockmanagement.TestBlockManager
            hadoop.hdfs.TestFileAppend2
            hadoop.hdfs.server.mover.TestStorageMover
            hadoop.hdfs.TestGetFileChecksum
            hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles
            hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
            hadoop.hdfs.server.datanode.TestTriggerBlockReport
            hadoop.hdfs.server.mover.TestMover
            hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.fs.TestSymlinkHdfsFileContext
            hadoop.hdfs.server.namenode.TestReconstructStripedBlocks
            hadoop.fs.TestUrlStreamHandler
            hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.fs.TestSymlinkHdfsFileSystem
            hadoop.hdfs.TestReconstructStripedFile
            hadoop.fs.viewfs.TestViewFsHdfs
            hadoop.fs.viewfs.TestViewFsWithAcls
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
            hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.blockmanagement.TestPendingReplication
            hadoop.fs.TestFcHdfsPermission
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.server.namenode.TestNameNodeMXBean
            hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
            hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
            hadoop.fs.TestEnhancedByteBufferAccess
            hadoop.hdfs.TestPersistBlocks
            hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
            hadoop.fs.viewfs.TestViewFileSystemHdfs
            hadoop.fs.viewfs.TestViewFileSystemWithAcls
            hadoop.hdfs.server.datanode.TestIncrementalBlockReports
            hadoop.fs.TestFcHdfsSetUMask
            hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.blockmanagement.TestBlockReportRateLimiting
            hadoop.hdfs.TestWriteConfigurationToDFS
            hadoop.hdfs.TestBlockStoragePolicy
            hadoop.hdfs.TestEncryptedTransfer
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.namenode.TestListCorruptFileBlocks
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
            org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract
            org.apache.hadoop.hdfs.TestHDFSFileSystemContract
            org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshot
            org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
            org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite
            org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestReadStripedFileWithDecoding
            hadoop.hdfs.server.namenode.ha.TestHASafeMode
            hadoop.hdfs.TestDecommission
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.TestEncryptionZones
            hadoop.fs.viewfs.TestViewFsWithXAttrs
            hadoop.fs.TestSWebHdfsFileContextMainOperations
            hadoop.fs.TestHDFSFileContextMainOperations
            hadoop.hdfs.server.blockmanagement.TestBlockManager
            hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
            hadoop.hdfs.server.mover.TestStorageMover
            hadoop.hdfs.TestGetFileChecksum
            hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles
            hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
            hadoop.hdfs.server.datanode.TestTriggerBlockReport
            hadoop.hdfs.server.mover.TestMover
            hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.fs.TestSymlinkHdfsFileContext
            hadoop.hdfs.server.namenode.TestReconstructStripedBlocks
            hadoop.fs.TestUrlStreamHandler
            hadoop.fs.TestSymlinkHdfsFileSystem
            hadoop.hdfs.TestReconstructStripedFile
            hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
            hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.fs.viewfs.TestViewFsHdfs
            hadoop.fs.TestFcHdfsCreateMkdir
            hadoop.fs.viewfs.TestViewFsWithAcls
            hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
            hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.blockmanagement.TestPendingReplication
            hadoop.fs.TestFcHdfsPermission
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.server.namenode.TestCacheDirectives
            hadoop.hdfs.server.namenode.TestNameNodeMXBean
            hadoop.fs.TestEnhancedByteBufferAccess
            hadoop.hdfs.TestPersistBlocks
            hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
            hadoop.fs.viewfs.TestViewFileSystemHdfs
            hadoop.fs.viewfs.TestViewFileSystemWithAcls
            hadoop.hdfs.server.datanode.TestIncrementalBlockReports
            hadoop.fs.TestFcHdfsSetUMask
            hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.TestWriteConfigurationToDFS
            hadoop.hdfs.TestBlockStoragePolicy
            hadoop.hdfs.TestEncryptedTransfer
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.namenode.TestListCorruptFileBlocks
          JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
            org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract
            org.apache.hadoop.hdfs.TestHDFSFileSystemContract
            org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshot
            org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
            org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite
            org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785974/h9726_20160203.patch
          JIRA Issue HDFS-9726
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0b7fa7d2efa4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1adb64e
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14366/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14366/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14366/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14366/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14366/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14366/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14366/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 8m 52s trunk passed +1 compile 1m 9s trunk passed with JDK v1.8.0_66 +1 compile 0m 56s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 8s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 22s trunk passed +1 javadoc 1m 51s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 46s trunk passed with JDK v1.7.0_91 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 16s the patch passed +1 compile 1m 29s the patch passed with JDK v1.8.0_66 +1 javac 1m 29s the patch passed +1 compile 1m 1s the patch passed with JDK v1.7.0_91 +1 javac 1m 1s the patch passed -1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: patch generated 3 new + 43 unchanged - 4 fixed = 46 total (was 47) +1 mvnsite 1m 18s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 55s the patch passed +1 javadoc 1m 37s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 38s the patch passed with JDK v1.7.0_91 -1 unit 167m 15s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 168m 34s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 372m 42s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.TestDecommission   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.fs.viewfs.TestViewFsWithXAttrs   hadoop.fs.TestHDFSFileContextMainOperations   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.TestFileAppend2   hadoop.hdfs.server.mover.TestStorageMover   hadoop.hdfs.TestGetFileChecksum   hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.server.datanode.TestTriggerBlockReport   hadoop.hdfs.server.mover.TestMover   hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.server.namenode.TestReconstructStripedBlocks   hadoop.fs.TestUrlStreamHandler   hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.fs.TestSymlinkHdfsFileSystem   hadoop.hdfs.TestReconstructStripedFile   hadoop.fs.viewfs.TestViewFsHdfs   hadoop.fs.viewfs.TestViewFsWithAcls   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead   hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.blockmanagement.TestPendingReplication   hadoop.fs.TestFcHdfsPermission   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.namenode.TestNameNodeMXBean   hadoop.hdfs.server.namenode.TestFSImageWithSnapshot   hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped   hadoop.fs.TestEnhancedByteBufferAccess   hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.fs.viewfs.TestViewFileSystemHdfs   hadoop.fs.viewfs.TestViewFileSystemWithAcls   hadoop.hdfs.server.datanode.TestIncrementalBlockReports   hadoop.fs.TestFcHdfsSetUMask   hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.blockmanagement.TestBlockReportRateLimiting   hadoop.hdfs.TestWriteConfigurationToDFS   hadoop.hdfs.TestBlockStoragePolicy   hadoop.hdfs.TestEncryptedTransfer   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.TestListCorruptFileBlocks JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete   org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract   org.apache.hadoop.hdfs.TestHDFSFileSystemContract   org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshot   org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite   org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.server.namenode.ha.TestHASafeMode   hadoop.hdfs.TestDecommission   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestEncryptionZones   hadoop.fs.viewfs.TestViewFsWithXAttrs   hadoop.fs.TestSWebHdfsFileContextMainOperations   hadoop.fs.TestHDFSFileContextMainOperations   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.server.mover.TestStorageMover   hadoop.hdfs.TestGetFileChecksum   hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.server.datanode.TestTriggerBlockReport   hadoop.hdfs.server.mover.TestMover   hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.server.namenode.TestReconstructStripedBlocks   hadoop.fs.TestUrlStreamHandler   hadoop.fs.TestSymlinkHdfsFileSystem   hadoop.hdfs.TestReconstructStripedFile   hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.fs.viewfs.TestViewFsHdfs   hadoop.fs.TestFcHdfsCreateMkdir   hadoop.fs.viewfs.TestViewFsWithAcls   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead   hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.blockmanagement.TestPendingReplication   hadoop.fs.TestFcHdfsPermission   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.hdfs.server.namenode.TestNameNodeMXBean   hadoop.fs.TestEnhancedByteBufferAccess   hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.fs.viewfs.TestViewFileSystemHdfs   hadoop.fs.viewfs.TestViewFileSystemWithAcls   hadoop.hdfs.server.datanode.TestIncrementalBlockReports   hadoop.fs.TestFcHdfsSetUMask   hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.TestWriteConfigurationToDFS   hadoop.hdfs.TestBlockStoragePolicy   hadoop.hdfs.TestEncryptedTransfer   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.TestListCorruptFileBlocks JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete   org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract   org.apache.hadoop.hdfs.TestHDFSFileSystemContract   org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshot   org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite   org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785974/h9726_20160203.patch JIRA Issue HDFS-9726 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0b7fa7d2efa4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1adb64e Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14366/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14366/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14366/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14366/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14366/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14366/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14366/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 8s Maven dependency ordering for branch
          +1 mvninstall 6m 38s trunk passed
          +1 compile 0m 39s trunk passed with JDK v1.8.0_66
          +1 compile 0m 40s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 0m 49s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 53s trunk passed
          +1 javadoc 1m 5s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 41s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 37s the patch passed with JDK v1.8.0_66
          +1 javac 0m 37s the patch passed
          +1 compile 0m 38s the patch passed with JDK v1.7.0_91
          +1 javac 0m 38s the patch passed
          -1 checkstyle 0m 18s hadoop-hdfs-project/hadoop-hdfs: patch generated 3 new + 43 unchanged - 4 fixed = 46 total (was 47)
          +1 mvnsite 0m 48s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 3s the patch passed
          +1 javadoc 1m 3s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 42s the patch passed with JDK v1.7.0_91
          -1 unit 155m 35s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 159m 38s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 37s Patch does not generate ASF License warnings.
          340m 23s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
            hadoop.hdfs.TestSafeModeWithStripedFile
            hadoop.hdfs.server.namenode.TestReconstructStripedBlocks
            hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer
            hadoop.fs.TestSymlinkHdfsFileSystem
            hadoop.fs.TestSymlinkHdfsFileContext
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.server.mover.TestStorageMover
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.TestEncryptedTransfer
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.TestBlockMissingException
            hadoop.fs.contract.hdfs.TestHDFSContractSeek
            hadoop.hdfs.server.namenode.TestListCorruptFileBlocks
            hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
            hadoop.hdfs.TestWriteConfigurationToDFS
            hadoop.hdfs.TestPersistBlocks
            hadoop.hdfs.TestSeekBug
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.TestDecommission
            hadoop.hdfs.server.datanode.TestTriggerBlockReport
            hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
            hadoop.hdfs.server.datanode.TestIncrementalBlockReports
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.TestDFSInputStream
            hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks
            hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
            hadoop.hdfs.TestGetFileChecksum
            hadoop.hdfs.TestBlockStoragePolicy
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles
            hadoop.hdfs.server.namenode.ha.TestHASafeMode
            hadoop.hdfs.server.namenode.snapshot.TestSnapshot
            hadoop.hdfs.TestReadStripedFileWithDecoding
            hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
            org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract
            org.apache.hadoop.hdfs.TestHDFSFileSystemContract
            org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
            org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite
            org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
            org.apache.hadoop.cli.TestHDFSCLI
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
            hadoop.hdfs.TestConnCache
            hadoop.hdfs.server.namenode.TestReconstructStripedBlocks
            hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer
            hadoop.fs.TestSymlinkHdfsFileSystem
            hadoop.fs.TestSymlinkHdfsFileContext
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.TestEncryptedTransfer
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.namenode.TestListCorruptFileBlocks
            hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
            hadoop.hdfs.TestWriteConfigurationToDFS
            hadoop.hdfs.TestPersistBlocks
            hadoop.hdfs.TestSafeMode
            hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality
            hadoop.hdfs.TestParallelRead
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
            hadoop.hdfs.server.datanode.TestTriggerBlockReport
            hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
            hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.server.datanode.TestIncrementalBlockReports
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks
            hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
            hadoop.hdfs.TestGetFileChecksum
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles
            hadoop.hdfs.server.namenode.ha.TestHASafeMode
            hadoop.hdfs.server.namenode.snapshot.TestSnapshot
            hadoop.hdfs.TestReadStripedFileWithDecoding
            hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
            hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.TestReconstructStripedFile
          JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
            org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract
            org.apache.hadoop.hdfs.TestHDFSFileSystemContract
            org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
            org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite
            org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
            org.apache.hadoop.cli.TestHDFSCLI



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785974/h9726_20160203.patch
          JIRA Issue HDFS-9726
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 5c936a42b54b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / fa328e2
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14374/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14374/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14374/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14374/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14374/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14374/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14374/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 6m 38s trunk passed +1 compile 0m 39s trunk passed with JDK v1.8.0_66 +1 compile 0m 40s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 49s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 53s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 41s trunk passed with JDK v1.7.0_91 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 45s the patch passed +1 compile 0m 37s the patch passed with JDK v1.8.0_66 +1 javac 0m 37s the patch passed +1 compile 0m 38s the patch passed with JDK v1.7.0_91 +1 javac 0m 38s the patch passed -1 checkstyle 0m 18s hadoop-hdfs-project/hadoop-hdfs: patch generated 3 new + 43 unchanged - 4 fixed = 46 total (was 47) +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 3s the patch passed +1 javadoc 1m 3s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 42s the patch passed with JDK v1.7.0_91 -1 unit 155m 35s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 159m 38s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 37s Patch does not generate ASF License warnings. 340m 23s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead   hadoop.hdfs.TestSafeModeWithStripedFile   hadoop.hdfs.server.namenode.TestReconstructStripedBlocks   hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer   hadoop.fs.TestSymlinkHdfsFileSystem   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.mover.TestStorageMover   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.TestFileAppend   hadoop.hdfs.TestEncryptedTransfer   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestBlockMissingException   hadoop.fs.contract.hdfs.TestHDFSContractSeek   hadoop.hdfs.server.namenode.TestListCorruptFileBlocks   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.TestWriteConfigurationToDFS   hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.TestSeekBug   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.TestDecommission   hadoop.hdfs.server.datanode.TestTriggerBlockReport   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs   hadoop.hdfs.server.datanode.TestIncrementalBlockReports   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.TestDFSInputStream   hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.TestGetFileChecksum   hadoop.hdfs.TestBlockStoragePolicy   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles   hadoop.hdfs.server.namenode.ha.TestHASafeMode   hadoop.hdfs.server.namenode.snapshot.TestSnapshot   hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete   org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract   org.apache.hadoop.hdfs.TestHDFSFileSystemContract   org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite   org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics   org.apache.hadoop.cli.TestHDFSCLI JDK v1.7.0_91 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead   hadoop.hdfs.TestConnCache   hadoop.hdfs.server.namenode.TestReconstructStripedBlocks   hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer   hadoop.fs.TestSymlinkHdfsFileSystem   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap   hadoop.hdfs.TestFileAppend   hadoop.hdfs.TestEncryptedTransfer   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.namenode.TestListCorruptFileBlocks   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.TestWriteConfigurationToDFS   hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.TestSafeMode   hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality   hadoop.hdfs.TestParallelRead   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation   hadoop.hdfs.server.datanode.TestTriggerBlockReport   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.datanode.TestIncrementalBlockReports   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.TestGetFileChecksum   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles   hadoop.hdfs.server.namenode.ha.TestHASafeMode   hadoop.hdfs.server.namenode.snapshot.TestSnapshot   hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.TestReconstructStripedFile JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete   org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract   org.apache.hadoop.hdfs.TestHDFSFileSystemContract   org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite   org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics   org.apache.hadoop.cli.TestHDFSCLI Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785974/h9726_20160203.patch JIRA Issue HDFS-9726 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5c936a42b54b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fa328e2 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14374/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14374/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14374/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14374/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14374/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14374/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14374/console This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          > One optional change can be: instead of using two boolean variable (ready2Send and triggerIBR) to indicate what to do in notifyNamenodeBlock, maybe we can create an enum to indicate the 3 types of action.

          We actually don't need these two parameters since we can use rdbi.getStatus(). Here is a new patch.

          h9726_20160204.patch

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - > One optional change can be: instead of using two boolean variable (ready2Send and triggerIBR) to indicate what to do in notifyNamenodeBlock, maybe we can create an enum to indicate the 3 types of action. We actually don't need these two parameters since we can use rdbi.getStatus(). Here is a new patch. h9726_20160204.patch
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 22s Maven dependency ordering for branch
          +1 mvninstall 9m 53s trunk passed
          +1 compile 1m 18s trunk passed with JDK v1.8.0_66
          +1 compile 0m 57s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 1m 11s trunk passed
          +1 mvneclipse 0m 17s trunk passed
          +1 findbugs 2m 27s trunk passed
          +1 javadoc 1m 34s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 33s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 1s the patch passed
          +1 compile 1m 13s the patch passed with JDK v1.8.0_66
          +1 javac 1m 13s the patch passed
          +1 compile 0m 53s the patch passed with JDK v1.7.0_91
          +1 javac 0m 53s the patch passed
          -1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: patch generated 2 new + 43 unchanged - 4 fixed = 45 total (was 47)
          +1 mvnsite 1m 9s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 42s the patch passed
          +1 javadoc 1m 37s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 31s the patch passed with JDK v1.7.0_91
          -1 unit 86m 3s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 68m 53s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          191m 33s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
            hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
            hadoop.hdfs.TestSafeModeWithStripedFile
            hadoop.hdfs.server.datanode.TestBlockScanner
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider
            hadoop.hdfs.server.datanode.TestBlockScanner



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786259/h9726_20160204.patch
          JIRA Issue HDFS-9726
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 15a6a17f8244 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 22a2b22
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14382/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14382/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14382/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14382/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14382/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14382/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14382/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 22s Maven dependency ordering for branch +1 mvninstall 9m 53s trunk passed +1 compile 1m 18s trunk passed with JDK v1.8.0_66 +1 compile 0m 57s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 27s trunk passed +1 mvnsite 1m 11s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 2m 27s trunk passed +1 javadoc 1m 34s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 33s trunk passed with JDK v1.7.0_91 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 1s the patch passed +1 compile 1m 13s the patch passed with JDK v1.8.0_66 +1 javac 1m 13s the patch passed +1 compile 0m 53s the patch passed with JDK v1.7.0_91 +1 javac 0m 53s the patch passed -1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: patch generated 2 new + 43 unchanged - 4 fixed = 45 total (was 47) +1 mvnsite 1m 9s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 42s the patch passed +1 javadoc 1m 37s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 31s the patch passed with JDK v1.7.0_91 -1 unit 86m 3s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 68m 53s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 191m 33s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.TestSafeModeWithStripedFile   hadoop.hdfs.server.datanode.TestBlockScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider   hadoop.hdfs.server.datanode.TestBlockScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786259/h9726_20160204.patch JIRA Issue HDFS-9726 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 15a6a17f8244 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 22a2b22 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14382/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14382/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14382/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14382/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14382/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14382/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14382/console This message was automatically generated.
          Hide
          jingzhao Jing Zhao added a comment -

          Thanks for updating the patch, Nicholas. The latest patch looks good to me. The failed tests should be unrelated. +1.

          Show
          jingzhao Jing Zhao added a comment - Thanks for updating the patch, Nicholas. The latest patch looks good to me. The failed tests should be unrelated. +1.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Thanks for checking the tests. I agree the failures are not related. All of them passed in my machine.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Thanks for checking the tests. I agree the failures are not related. All of them passed in my machine.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          I have committed this.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - I have committed this.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9247 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9247/)
          HDFS-9726. Refactor IBR code to a new class. (szetszwo: rev 4e5e1c0f9938e51699c0437731e7b2eef699d6da)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestTriggerBlockReport.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestIncrementalBlockReports.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/IncrementalBlockReportManager.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9247 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9247/ ) HDFS-9726 . Refactor IBR code to a new class. (szetszwo: rev 4e5e1c0f9938e51699c0437731e7b2eef699d6da) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestTriggerBlockReport.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestIncrementalBlockReports.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/IncrementalBlockReportManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java

            People

            • Assignee:
              szetszwo Tsz Wo Nicholas Sze
              Reporter:
              szetszwo Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development