[HDFS-9713] DataXceiver#copyBlock should return if block is pinned

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7.2
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: datanode
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Uma Maheswara Rao G
• Reporter: Uma Maheswara Rao G
• Created: 27/Jan/16 22:00
• Updated: 12/May/16 18:16
• Resolved: 08/Feb/16 05:01

Description

in DataXceiver#copyBlock

  if (datanode.data.getPinning(block)) {
      String msg = "Not able to copy block " + block.getBlockId() + " " +
          "to " + peer.getRemoteAddressString() + " because it's pinned ";
      LOG.info(msg);
      sendResponse(ERROR, msg);
    }

I think we should return back instead of proceeding to send block.as we already sent ERROR here.