[HDFS-9693] Trim the user config of `dfs.ha.namenode.id`

• Type: Bug
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.7.1
• Component/s: ha
• Assignee: Unassigned
• Reporter: Tianyin Xu
• Created: 25/Jan/16 10:12
• Updated: 25/Jan/16 14:14

Description

In hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java, we trim the config value of parameter dfs.ha.namenode.id in one place but not the other.

  public static String getNameNodeId(Configuration conf, String nsId) {
    String namenodeId = conf.getTrimmed(DFS_HA_NAMENODE_ID_KEY);
    ...  

  public static List<String> getNameNodeIdOfOtherNodes(Configuration conf, String nsId) {
    ...
    String myNNId = conf.get(DFSConfigKeys.DFS_HA_NAMENODE_ID_KEY);
    ...

The latter one would cause problem if the user's configs contains extra space.