Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-968

s/StringBuffer/StringBuilder - as necessary

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Activity

      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12435491/HDFS-968.patch
      against trunk revision 908628.

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed core unit tests.

      -1 contrib tests. The patch failed contrib unit tests.

      Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/229/testReport/
      Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/229/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
      Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/229/artifact/trunk/build/test/checkstyle-errors.html
      Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/229/console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12435491/HDFS-968.patch against trunk revision 908628. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/229/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/229/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/229/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/229/console This message is automatically generated.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12435491/HDFS-968.patch
      against trunk revision 908628.

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed core unit tests.

      -1 contrib tests. The patch failed contrib unit tests.

      Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/116/testReport/
      Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/116/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
      Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/116/artifact/trunk/build/test/checkstyle-errors.html
      Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/116/console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12435491/HDFS-968.patch against trunk revision 908628. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/116/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/116/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/116/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/116/console This message is automatically generated.
      Hide
      Karthik K added a comment -

      Test failed with -

      org.apache.hadoop.hdfs.security.TestDelegationToken.testDelegationTokenWithRealUser (from TestDelegationToken)

      Error Message

      User: RealUser is not allowed to impersonate proxyUser
      Stacktrace

      org.apache.hadoop.ipc.RemoteException: User: RealUser is not allowed to impersonate proxyUser
      at org.apache.hadoop.ipc.Client.call(Client.java:887)
      at org.apache.hadoop.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:198)
      at $Proxy7.getProtocolVersion(Unknown Source)
      at org.apache.hadoop.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:228)
      at org.apache.hadoop.ipc.RPC.getProxy(RPC.java:220)
      at org.apache.hadoop.hdfs.DFSClient.createRPCNamenode(DFSClient.java:151)
      at org.apache.hadoop.hdfs.DFSClient.<init>(DFSClient.java:250)
      at org.apache.hadoop.hdfs.DFSClient.<init>(DFSClient.java:217)
      at org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:87)
      at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:1747)
      at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:69)
      at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:1775)
      at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:1763)
      at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:193)
      at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:101)
      at org.apache.hadoop.hdfs.MiniDFSCluster.getFileSystem(MiniDFSCluster.java:813)
      at org.apache.hadoop.hdfs.security.TestDelegationToken$1.run(TestDelegationToken.java:147)
      at org.apache.hadoop.hdfs.security.TestDelegationToken$1.run(TestDelegationToken.java:145)
      at java.security.AccessController.doPrivileged(Native Method)
      at javax.security.auth.Subject.doAs(Subject.java:396)
      at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:706)
      at org.apache.hadoop.hdfs.security.TestDelegationToken.testDelegationTokenWithRealUser(TestDelegationToken.java:144)

      I don't think it has anything to do with this patch though.

      Show
      Karthik K added a comment - Test failed with - org.apache.hadoop.hdfs.security.TestDelegationToken.testDelegationTokenWithRealUser (from TestDelegationToken) Error Message User: RealUser is not allowed to impersonate proxyUser Stacktrace org.apache.hadoop.ipc.RemoteException: User: RealUser is not allowed to impersonate proxyUser at org.apache.hadoop.ipc.Client.call(Client.java:887) at org.apache.hadoop.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:198) at $Proxy7.getProtocolVersion(Unknown Source) at org.apache.hadoop.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:228) at org.apache.hadoop.ipc.RPC.getProxy(RPC.java:220) at org.apache.hadoop.hdfs.DFSClient.createRPCNamenode(DFSClient.java:151) at org.apache.hadoop.hdfs.DFSClient.<init>(DFSClient.java:250) at org.apache.hadoop.hdfs.DFSClient.<init>(DFSClient.java:217) at org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:87) at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:1747) at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:69) at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:1775) at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:1763) at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:193) at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:101) at org.apache.hadoop.hdfs.MiniDFSCluster.getFileSystem(MiniDFSCluster.java:813) at org.apache.hadoop.hdfs.security.TestDelegationToken$1.run(TestDelegationToken.java:147) at org.apache.hadoop.hdfs.security.TestDelegationToken$1.run(TestDelegationToken.java:145) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:396) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:706) at org.apache.hadoop.hdfs.security.TestDelegationToken.testDelegationTokenWithRealUser(TestDelegationToken.java:144) I don't think it has anything to do with this patch though.
      Hide
      Suresh Srinivas added a comment -

      +1 for the patch.

      Show
      Suresh Srinivas added a comment - +1 for the patch.
      Hide
      Karthik K added a comment -

      Thanks. If so, would be nice to get this committed before this gets out of sync with the tree.

      Show
      Karthik K added a comment - Thanks. If so, would be nice to get this committed before this gets out of sync with the tree.
      Hide
      Suresh Srinivas added a comment -

      I committed the patch. Thanks you Kay Kay.

      Show
      Suresh Srinivas added a comment - I committed the patch. Thanks you Kay Kay.
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk-Commit #215 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/215/)
      . Use StringBuilder instead of StringBuffer for better performance. Contributed by Kay Kay.

      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #215 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/215/ ) . Use StringBuilder instead of StringBuffer for better performance. Contributed by Kay Kay.
      Hide
      Hudson added a comment -

      Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #146 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/146/)

      Show
      Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #146 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/146/ )
      Hide
      Hudson added a comment -

      Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #302 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/302/)

      Show
      Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #302 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/302/ )
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk #275 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/275/)

      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #275 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/275/ )

        People

        • Assignee:
          Karthik K
          Reporter:
          Karthik K
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development