Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: distcp
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      DistCp in Hadoop 3.0 no longer supports -mapredSSLConf option. Use global ssl-client.xml configuration file for swebhdfs file systems instead.

      Description

      Per discussion in HDFS-9638,
      after HDFS-5570, hftp/hsftp are removed from Hadoop 3.0.0. But DistCp still makes reference to hsftp via parameter -mapredSslConf. This parameter would be useless after Hadoop 3.0.0; therefore it should be removed, and then document the changes.

      This JIRA is intended to track the status of the code/docs change involving the removal of hsftp in DistCp.

      1. HDFS-9640.003.patch
        19 kB
        Wei-Chiu Chuang
      2. HDFS-9640.002.patch
        18 kB
        Wei-Chiu Chuang
      3. HDFS-9640.001.patch
        18 kB
        Wei-Chiu Chuang

        Issue Links

          Activity

          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Seems to me that if hftp/hsftp is removed, DistCp should use webhdfs/swebhdfs instead.

          To use swebhdfs with DistCp, the curent implementation must have ssl-client.xml in class path (such as /etc/hadoop/conf) http://www.cloudera.com/content/www/en-us/documentation/enterprise/latest/topics/cdh_admin_distcp_data_cluster_migrate.html
          Without it, distcp throws an SSLHandshakeException, and adding -mapredSslConf does not help because the exception is thrown before checking -mapredSslConf.

          I think we can do either
          (1) keep the current behavior, remove -mapredSslConf
          (2) repurpose -mapredSslConf and use it to specify ssl-client.xml for SSL over WebHDFS (swebhdfs)

          Any suggestions?

          Show
          jojochuang Wei-Chiu Chuang added a comment - Seems to me that if hftp/hsftp is removed, DistCp should use webhdfs/swebhdfs instead. To use swebhdfs with DistCp, the curent implementation must have ssl-client.xml in class path (such as /etc/hadoop/conf) http://www.cloudera.com/content/www/en-us/documentation/enterprise/latest/topics/cdh_admin_distcp_data_cluster_migrate.html Without it, distcp throws an SSLHandshakeException, and adding -mapredSslConf does not help because the exception is thrown before checking -mapredSslConf. I think we can do either (1) keep the current behavior, remove -mapredSslConf (2) repurpose -mapredSslConf and use it to specify ssl-client.xml for SSL over WebHDFS (swebhdfs) Any suggestions?
          Hide
          wheat9 Haohui Mai added a comment -

          +1 on removing -mapredSslConf. SSL certificates are usually treated as global properties in operating systems. We probably should do the same thing here.

          Show
          wheat9 Haohui Mai added a comment - +1 on removing -mapredSslConf. SSL certificates are usually treated as global properties in operating systems. We probably should do the same thing here.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Rev01: removed all references to hsftp in distcp documentation, removed all code related to -mapredSSLConf, and all code related to SSL config in distcp (distcp should use the global ssl-client.xml for SSL configurations), fixed related tests.

          The patch passed all distcp-related tests in my local environment.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Rev01: removed all references to hsftp in distcp documentation, removed all code related to -mapredSSLConf, and all code related to SSL config in distcp (distcp should use the global ssl-client.xml for SSL configurations), fixed related tests. The patch passed all distcp-related tests in my local environment.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 11m 36s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 1s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 13s trunk passed
          +1 compile 0m 15s trunk passed with JDK v1.8.0_72
          +1 compile 0m 16s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 15s trunk passed
          +1 mvnsite 0m 22s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 29s trunk passed
          +1 javadoc 0m 13s trunk passed with JDK v1.8.0_72
          +1 javadoc 0m 14s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 18s the patch passed
          +1 compile 0m 14s the patch passed with JDK v1.8.0_72
          +1 javac 1m 38s hadoop-tools_hadoop-distcp-jdk1.8.0_72 with JDK v1.8.0_72 generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4)
          +1 javac 0m 14s hadoop-distcp in the patch passed with JDK v1.8.0_72.
          +1 compile 0m 14s the patch passed with JDK v1.7.0_95
          +1 javac 0m 14s the patch passed
          -1 checkstyle 0m 13s hadoop-tools/hadoop-distcp: patch generated 5 new + 141 unchanged - 14 fixed = 146 total (was 155)
          +1 mvnsite 0m 20s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 39s the patch passed
          +1 javadoc 0m 11s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 12s the patch passed with JDK v1.7.0_95
          +1 unit 7m 22s hadoop-distcp in the patch passed with JDK v1.8.0_72.
          +1 unit 7m 6s hadoop-distcp in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 18s Patch does not generate ASF License warnings.
          39m 18s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788480/HDFS-9640.001.patch
          JIRA Issue HDFS-9640
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux fe8762ad5056 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e78d8e6
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14527/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-distcp.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14527/testReport/
          modules C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14527/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 11m 36s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 1s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 13s trunk passed +1 compile 0m 15s trunk passed with JDK v1.8.0_72 +1 compile 0m 16s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 22s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 29s trunk passed +1 javadoc 0m 13s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 14s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 18s the patch passed +1 compile 0m 14s the patch passed with JDK v1.8.0_72 +1 javac 1m 38s hadoop-tools_hadoop-distcp-jdk1.8.0_72 with JDK v1.8.0_72 generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4) +1 javac 0m 14s hadoop-distcp in the patch passed with JDK v1.8.0_72. +1 compile 0m 14s the patch passed with JDK v1.7.0_95 +1 javac 0m 14s the patch passed -1 checkstyle 0m 13s hadoop-tools/hadoop-distcp: patch generated 5 new + 141 unchanged - 14 fixed = 146 total (was 155) +1 mvnsite 0m 20s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 39s the patch passed +1 javadoc 0m 11s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 12s the patch passed with JDK v1.7.0_95 +1 unit 7m 22s hadoop-distcp in the patch passed with JDK v1.8.0_72. +1 unit 7m 6s hadoop-distcp in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 39m 18s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788480/HDFS-9640.001.patch JIRA Issue HDFS-9640 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fe8762ad5056 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e78d8e6 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14527/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-distcp.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14527/testReport/ modules C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14527/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Need to rebase/resolve conflicts due to HDFS-9764.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Need to rebase/resolve conflicts due to HDFS-9764 .
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Rev02: (1) fixed check style issues. (2) rebased and fixed conflicts.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Rev02: (1) fixed check style issues. (2) rebased and fixed conflicts.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 8s trunk passed
          +1 compile 0m 17s trunk passed with JDK v1.8.0_72
          +1 compile 0m 16s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 15s trunk passed
          +1 mvnsite 0m 23s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 33s trunk passed
          +1 javadoc 0m 20s trunk passed with JDK v1.8.0_72
          +1 javadoc 0m 20s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 24s the patch passed
          +1 compile 0m 21s the patch passed with JDK v1.8.0_72
          +1 javac 2m 13s hadoop-tools_hadoop-distcp-jdk1.8.0_72 with JDK v1.8.0_72 generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4)
          +1 javac 0m 21s hadoop-distcp in the patch passed with JDK v1.8.0_72.
          +1 compile 0m 18s the patch passed with JDK v1.7.0_95
          +1 javac 0m 18s the patch passed
          +1 checkstyle 0m 13s hadoop-tools/hadoop-distcp: patch generated 0 new + 141 unchanged - 14 fixed = 141 total (was 155)
          +1 mvnsite 0m 22s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 40s the patch passed
          +1 javadoc 0m 13s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 13s the patch passed with JDK v1.7.0_95
          +1 unit 7m 59s hadoop-distcp in the patch passed with JDK v1.8.0_72.
          -1 unit 7m 46s hadoop-distcp in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 17s Patch does not generate ASF License warnings.
          31m 4s



          Reason Tests
          JDK v1.7.0_95 Failed junit tests hadoop.tools.util.TestProducerConsumer



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788829/HDFS-9640.002.patch
          JIRA Issue HDFS-9640
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c3d15fbaa362 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d5abd29
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14550/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-distcp-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14550/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-distcp-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14550/testReport/
          modules C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14550/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 8s trunk passed +1 compile 0m 17s trunk passed with JDK v1.8.0_72 +1 compile 0m 16s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 23s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 33s trunk passed +1 javadoc 0m 20s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 20s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 24s the patch passed +1 compile 0m 21s the patch passed with JDK v1.8.0_72 +1 javac 2m 13s hadoop-tools_hadoop-distcp-jdk1.8.0_72 with JDK v1.8.0_72 generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4) +1 javac 0m 21s hadoop-distcp in the patch passed with JDK v1.8.0_72. +1 compile 0m 18s the patch passed with JDK v1.7.0_95 +1 javac 0m 18s the patch passed +1 checkstyle 0m 13s hadoop-tools/hadoop-distcp: patch generated 0 new + 141 unchanged - 14 fixed = 141 total (was 155) +1 mvnsite 0m 22s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 40s the patch passed +1 javadoc 0m 13s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 13s the patch passed with JDK v1.7.0_95 +1 unit 7m 59s hadoop-distcp in the patch passed with JDK v1.8.0_72. -1 unit 7m 46s hadoop-distcp in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 31m 4s Reason Tests JDK v1.7.0_95 Failed junit tests hadoop.tools.util.TestProducerConsumer Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788829/HDFS-9640.002.patch JIRA Issue HDFS-9640 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c3d15fbaa362 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d5abd29 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14550/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-distcp-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14550/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-distcp-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14550/testReport/ modules C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14550/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1. The test failure looks unrelated to the patch.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1. The test failure looks unrelated to the patch.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Cancelling my +1. Hi Wei-Chiu Chuang, would you remove unused parameters from DistCpConstants.java?

          Show
          ajisakaa Akira Ajisaka added a comment - Cancelling my +1. Hi Wei-Chiu Chuang , would you remove unused parameters from DistCpConstants.java?
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Good catch! Thanks Akira Ajisaka for reviewing the patch,
          I found three unused parameters in DistCpConstants.

          I've also verified again there are no other unused parameters/variables/imports introduced by this patch.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Good catch! Thanks Akira Ajisaka for reviewing the patch, I found three unused parameters in DistCpConstants. I've also verified again there are no other unused parameters/variables/imports introduced by this patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 49s trunk passed
          +1 compile 0m 16s trunk passed with JDK v1.8.0_74
          +1 compile 0m 17s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 14s trunk passed
          +1 mvnsite 0m 22s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 29s trunk passed
          +1 javadoc 0m 13s trunk passed with JDK v1.8.0_74
          +1 javadoc 0m 14s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 18s the patch passed
          +1 compile 0m 15s the patch passed with JDK v1.8.0_74
          +1 javac 1m 41s hadoop-tools_hadoop-distcp-jdk1.8.0_74 with JDK v1.8.0_74 generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4)
          +1 javac 0m 15s hadoop-distcp in the patch passed with JDK v1.8.0_74.
          +1 compile 0m 16s the patch passed with JDK v1.7.0_95
          +1 javac 0m 16s the patch passed
          +1 checkstyle 0m 12s hadoop-tools/hadoop-distcp: patch generated 0 new + 127 unchanged - 13 fixed = 127 total (was 140)
          +1 mvnsite 0m 21s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 37s the patch passed
          +1 javadoc 0m 10s the patch passed with JDK v1.8.0_74
          +1 javadoc 0m 13s the patch passed with JDK v1.7.0_95
          +1 unit 8m 31s hadoop-distcp in the patch passed with JDK v1.8.0_74.
          +1 unit 7m 42s hadoop-distcp in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 17s Patch does not generate ASF License warnings.
          29m 23s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795397/HDFS-9640.003.patch
          JIRA Issue HDFS-9640
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f596502ee8ea 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2c268cc
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14938/testReport/
          modules C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14938/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 49s trunk passed +1 compile 0m 16s trunk passed with JDK v1.8.0_74 +1 compile 0m 17s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 22s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 29s trunk passed +1 javadoc 0m 13s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 14s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 18s the patch passed +1 compile 0m 15s the patch passed with JDK v1.8.0_74 +1 javac 1m 41s hadoop-tools_hadoop-distcp-jdk1.8.0_74 with JDK v1.8.0_74 generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4) +1 javac 0m 15s hadoop-distcp in the patch passed with JDK v1.8.0_74. +1 compile 0m 16s the patch passed with JDK v1.7.0_95 +1 javac 0m 16s the patch passed +1 checkstyle 0m 12s hadoop-tools/hadoop-distcp: patch generated 0 new + 127 unchanged - 13 fixed = 127 total (was 140) +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 37s the patch passed +1 javadoc 0m 10s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 13s the patch passed with JDK v1.7.0_95 +1 unit 8m 31s hadoop-distcp in the patch passed with JDK v1.8.0_74. +1 unit 7m 42s hadoop-distcp in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 29m 23s Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795397/HDFS-9640.003.patch JIRA Issue HDFS-9640 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f596502ee8ea 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2c268cc Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14938/testReport/ modules C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14938/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, committing this.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, committing this.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed to trunk. Thanks Wei-Chiu Chuang for the contribution!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed to trunk. Thanks Wei-Chiu Chuang for the contribution!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9508 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9508/)
          HDFS-9640. Remove hsftp from DistCp in trunk. Contributed by Wei-Chiu (aajisaka: rev 18c7e582839ea0b550463569b18b5827d23f8849)

          • hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/OptionsParser.java
          • hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpOptions.java
          • hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpOptionSwitch.java
          • hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpConstants.java
          • hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyMapper.java
          • hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java
          • hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestOptionsParser.java
          • hadoop-tools/hadoop-distcp/src/site/markdown/DistCp.md.vm
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9508 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9508/ ) HDFS-9640 . Remove hsftp from DistCp in trunk. Contributed by Wei-Chiu (aajisaka: rev 18c7e582839ea0b550463569b18b5827d23f8849) hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/OptionsParser.java hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpOptions.java hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpOptionSwitch.java hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpConstants.java hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyMapper.java hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestOptionsParser.java hadoop-tools/hadoop-distcp/src/site/markdown/DistCp.md.vm
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks a lot!

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks a lot!

            People

            • Assignee:
              jojochuang Wei-Chiu Chuang
              Reporter:
              jojochuang Wei-Chiu Chuang
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development