Details

    • Hadoop Flags:
      Reviewed

      Description

      For example,
      -mapredSslConf <arg> Configuration for ssl config file, to use with
      hftps://

      But this ssl config file should be in the classpath, which is not clearly stated.

      http://hadoop.apache.org/docs/current/hadoop-distcp/DistCp.html
      "When using the hsftp protocol with a source, the security- related properties may be specified in a config-file and passed to DistCp. <ssl_conf_file> needs to be in the classpath. "

      It is also not clear from the context if this ssl_conf_file should be at the client issuing the command. (I think the answer is yes)

      Also, in: http://hadoop.apache.org/docs/current/hadoop-distcp/DistCp.html
      "The following is an example of the contents of the contents of a SSL Configuration file:"
      there's an extra "of the contents of the contents "

      1. HDFS-9638.001.patch
        4 kB
        Wei-Chiu Chuang
      2. HDFS-9638.002.patch
        5 kB
        Wei-Chiu Chuang

        Issue Links

          Activity

          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks Yongjun Zhang for commit and Kai Zheng for reviews and suggestions improving it!

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks Yongjun Zhang for commit and Kai Zheng for reviews and suggestions improving it!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9210 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9210/)
          HDFS-9638. Improve DistCp Help and documentation. (Wei-Chiu Chuang via (yzhang: rev eddd823cd6246ddc66218eb01009c44b0236eaaa)

          • hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpOptionSwitch.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestOptionsParser.java
          • hadoop-tools/hadoop-distcp/src/site/markdown/DistCp.md.vm
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9210 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9210/ ) HDFS-9638 . Improve DistCp Help and documentation. (Wei-Chiu Chuang via (yzhang: rev eddd823cd6246ddc66218eb01009c44b0236eaaa) hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpOptionSwitch.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestOptionsParser.java hadoop-tools/hadoop-distcp/src/site/markdown/DistCp.md.vm
          Hide
          yzhangal Yongjun Zhang added a comment -

          Committed to trunk, branch-2, branch-2.8.

          Thanks Wei-Chiu Chuang for the contribution, and Kai Zheng for the review.

          Show
          yzhangal Yongjun Zhang added a comment - Committed to trunk, branch-2, branch-2.8. Thanks Wei-Chiu Chuang for the contribution, and Kai Zheng for the review.
          Hide
          yzhangal Yongjun Zhang added a comment -

          +1 on rev 02. Will commit soon.

          Show
          yzhangal Yongjun Zhang added a comment - +1 on rev 02. Will commit soon.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 32s trunk passed
          +1 compile 0m 14s trunk passed with JDK v1.8.0_66
          +1 compile 0m 16s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 9s trunk passed
          +1 mvnsite 0m 23s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 0m 28s trunk passed
          +1 javadoc 0m 12s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 15s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 18s the patch passed
          +1 compile 0m 11s the patch passed with JDK v1.8.0_66
          +1 javac 0m 11s the patch passed
          +1 compile 0m 14s the patch passed with JDK v1.7.0_91
          +1 javac 0m 14s the patch passed
          +1 checkstyle 0m 9s the patch passed
          +1 mvnsite 0m 20s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 34s the patch passed
          +1 javadoc 0m 9s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 12s the patch passed with JDK v1.7.0_91
          +1 unit 6m 34s hadoop-distcp in the patch passed with JDK v1.8.0_66.
          +1 unit 6m 32s hadoop-distcp in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 18s Patch does not generate ASF License warnings.
          26m 27s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781731/HDFS-9638.002.patch
          JIRA Issue HDFS-9638
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6a2ec9403f43 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 30c7dfd
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14103/testReport/
          modules C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
          Max memory used 75MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14103/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 32s trunk passed +1 compile 0m 14s trunk passed with JDK v1.8.0_66 +1 compile 0m 16s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 9s trunk passed +1 mvnsite 0m 23s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 0m 28s trunk passed +1 javadoc 0m 12s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 15s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 18s the patch passed +1 compile 0m 11s the patch passed with JDK v1.8.0_66 +1 javac 0m 11s the patch passed +1 compile 0m 14s the patch passed with JDK v1.7.0_91 +1 javac 0m 14s the patch passed +1 checkstyle 0m 9s the patch passed +1 mvnsite 0m 20s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 34s the patch passed +1 javadoc 0m 9s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 12s the patch passed with JDK v1.7.0_91 +1 unit 6m 34s hadoop-distcp in the patch passed with JDK v1.8.0_66. +1 unit 6m 32s hadoop-distcp in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 26m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781731/HDFS-9638.002.patch JIRA Issue HDFS-9638 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6a2ec9403f43 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 30c7dfd Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14103/testReport/ modules C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14103/console This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Rev02: I noticed that HADOOP-11009 did not include the test for preserving timestamp. Not sure if it's appropriate to be include in this JIRA, but here it is:

          Show
          jojochuang Wei-Chiu Chuang added a comment - Rev02: I noticed that HADOOP-11009 did not include the test for preserving timestamp. Not sure if it's appropriate to be include in this JIRA, but here it is:
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Rev01: work in progress. Added description of several command line parameters.

          TODO: check if there are other missing parameter descriptions.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Rev01: work in progress. Added description of several command line parameters. TODO: check if there are other missing parameter descriptions.
          Hide
          drankye Kai Zheng added a comment -

          Sounds good to get this focus on the DistCp documentation improvement as there are so many aspects to update. Thanks Wei-Chiu!

          Show
          drankye Kai Zheng added a comment - Sounds good to get this focus on the DistCp documentation improvement as there are so many aspects to update. Thanks Wei-Chiu!
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          I think we should file a separate JIRA to remove -mapredSslConf code and docs entirely from hadoop 3.0.0, and make this JIRA entirely documentation improvement. Because the end of hsftp support is an incompatible change in hadoop 3.0.0

          Show
          jojochuang Wei-Chiu Chuang added a comment - I think we should file a separate JIRA to remove -mapredSslConf code and docs entirely from hadoop 3.0.0, and make this JIRA entirely documentation improvement. Because the end of hsftp support is an incompatible change in hadoop 3.0.0
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks for the suggestion! Kai Zheng
          I looked at trunk, and DistCp.md.vm does not mention -diff, -numListstatus -p[t].

          It also does not explain -skipcrccheck well.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks for the suggestion! Kai Zheng I looked at trunk, and DistCp.md.vm does not mention -diff, -numListstatus -p [t] . It also does not explain -skipcrccheck well.
          Hide
          drankye Kai Zheng added a comment -

          Good to have this to improve and update the documentation.

          In the mailing list I had some comments as below.

          I read the doc at the following link and regard it as the latest revision that corresponds with the trunk codebase.
          http://hadoop.apache.org/docs/current/hadoop-distcp/DistCp.html
          If that’s right, then we may need to complement it with the following important features because I don’t see they are mentioned in the doc.
          1. –diff option, use snapshot diff report to identify the differences between source and target to compute the copying list.
          2. –numListstatusThreads option, number of threads to concurrently compute the copying list.
          3. –p t, to preserve timestamps.
          As above features are great things for user to use in order to speed up the time consuming inter or intra cluster sync, not only to add these options in the table of command line options, but also better to document them well as we did for other functions.

          Would be good to check and address the questions here as well. Thanks.

          Show
          drankye Kai Zheng added a comment - Good to have this to improve and update the documentation. In the mailing list I had some comments as below. I read the doc at the following link and regard it as the latest revision that corresponds with the trunk codebase. http://hadoop.apache.org/docs/current/hadoop-distcp/DistCp.html If that’s right, then we may need to complement it with the following important features because I don’t see they are mentioned in the doc. 1. –diff option, use snapshot diff report to identify the differences between source and target to compute the copying list. 2. –numListstatusThreads option, number of threads to concurrently compute the copying list. 3. –p t, to preserve timestamps. As above features are great things for user to use in order to speed up the time consuming inter or intra cluster sync, not only to add these options in the table of command line options, but also better to document them well as we did for other functions. Would be good to check and address the questions here as well. Thanks.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Additionally, hsftp is deprecated by HDFS-5570. We should also update the documentation. It is unclear if the parameter -mapredSslConf is still valid.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Additionally, hsftp is deprecated by HDFS-5570 . We should also update the documentation. It is unclear if the parameter -mapredSslConf is still valid.

            People

            • Assignee:
              jojochuang Wei-Chiu Chuang
              Reporter:
              jojochuang Wei-Chiu Chuang
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development