Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9629

Update the footer of Web UI to show year 2016

    Details

    • Hadoop Flags:
      Reviewed
    1. HDFS-9629.01.patch
      4 kB
      Xiao Chen
    2. HDFS-9629.02.patch
      3 kB
      Xiao Chen
    3. HDFS-9629.03.patch
      5 kB
      Xiao Chen
    4. HDFS-9629.04.patch
      4 kB
      Vinayakumar B
    5. HDFS-9629.05.patch
      3 kB
      Xiao Chen
    6. HDFS-9629.06.patch
      3 kB
      Xiao Chen
    7. HDFS-9629.07.patch
      4 kB
      Vinayakumar B

      Issue Links

        Activity

        Hide
        xiaochen Xiao Chen added a comment -

        HDFS-8149 changed the trademark year from 2014 to 2015 last year.

        For this year, I think maybe we should let the UI to dynamically get the current year info, to save future work.

        1 problem of course, after this change future user will always see current year when browsing web ui, (e.g. in 2050 if a user is still running Hadoop installed in 2016, the web ui will say 'Hadoop, 2050' although all software is 2016.) If this is a big concern then I'll just update them to hard-coded 2016.

        I'm not very sure about the trademark stuff, so any advice is very appreciated. Thanks!

        Show
        xiaochen Xiao Chen added a comment - HDFS-8149 changed the trademark year from 2014 to 2015 last year. For this year, I think maybe we should let the UI to dynamically get the current year info, to save future work. 1 problem of course, after this change future user will always see current year when browsing web ui, (e.g. in 2050 if a user is still running Hadoop installed in 2016, the web ui will say 'Hadoop, 2050' although all software is 2016.) If this is a big concern then I'll just update them to hard-coded 2016. I'm not very sure about the trademark stuff, so any advice is very appreciated. Thanks!
        Hide
        xiaochen Xiao Chen added a comment -

        Patch 1 tries to show the year dynamically.

        Ping Akira Ajisaka and Brahma Reddy Battula for review and advice on this, since you guys worked on HDFS-8149. Thanks very much in advance!

        Show
        xiaochen Xiao Chen added a comment - Patch 1 tries to show the year dynamically. Ping Akira Ajisaka and Brahma Reddy Battula for review and advice on this, since you guys worked on HDFS-8149 . Thanks very much in advance!
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        0m 52s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781689/HDFS-9629.01.patch
        JIRA Issue HDFS-9629
        Optional Tests asflicense
        uname Linux bb38c745f844 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / b8942be
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 29MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14095/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s Patch has no whitespace issues. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 0m 52s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781689/HDFS-9629.01.patch JIRA Issue HDFS-9629 Optional Tests asflicense uname Linux bb38c745f844 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b8942be modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 29MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14095/console This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Xiao Chen thanks for working on this,IMHO,better to keep the hard coded value.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Xiao Chen thanks for working on this,IMHO,better to keep the hard coded value.
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks Brahma Reddy Battula for the input. Patch 2 hard codes 2016.

        Show
        xiaochen Xiao Chen added a comment - Thanks Brahma Reddy Battula for the input. Patch 2 hard codes 2016.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 asflicense 0m 17s Patch does not generate ASF License warnings.
        0m 35s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782904/HDFS-9629.02.patch
        JIRA Issue HDFS-9629
        Optional Tests asflicense
        uname Linux b3cecc53768b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d40859f
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 30MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14148/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s Patch has no whitespace issues. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 0m 35s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782904/HDFS-9629.02.patch JIRA Issue HDFS-9629 Optional Tests asflicense uname Linux b3cecc53768b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d40859f modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 30MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14148/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        I'm +1 for hard-coding the year because Xiao's concern is big.
        I thought that we can set the year dynamically by showing the year when the source code is built. However, it is not a good idea because if you get a source code released in 2016 and built it in 2017, the UI shows 2017. It is confusing.

        By the way, can we add a parameter and use this value instead of changing 5 files every year?

        Show
        ajisakaa Akira Ajisaka added a comment - I'm +1 for hard-coding the year because Xiao's concern is big. I thought that we can set the year dynamically by showing the year when the source code is built. However, it is not a good idea because if you get a source code released in 2016 and built it in 2017, the UI shows 2017. It is confusing. By the way, can we add a parameter and use this value instead of changing 5 files every year?
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks Akira Ajisaka for the comment and suggestion!

        can we add a parameter and use this value instead of changing 5 files every year?

        Patch 3 attached works this way. A static js file is loaded into those 5 htmls, populating the year info from a variable. The variable itself is still hard coded, so we still need to change that every year. I didn't find a good existing js to do this, so created a new file. I'm not very knowledgable on html/javascript though, so please advice if you think we can do better.

        Maybe we can setup a jenkins job to run yearly and commit the year info? But if this is the only thing to update I guess it's probably an overkill.....

        Show
        xiaochen Xiao Chen added a comment - Thanks Akira Ajisaka for the comment and suggestion! can we add a parameter and use this value instead of changing 5 files every year? Patch 3 attached works this way. A static js file is loaded into those 5 htmls, populating the year info from a variable. The variable itself is still hard coded, so we still need to change that every year. I didn't find a good existing js to do this, so created a new file. I'm not very knowledgable on html/javascript though, so please advice if you think we can do better. Maybe we can setup a jenkins job to run yearly and commit the year info? But if this is the only thing to update I guess it's probably an overkill.....
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Xiao Chen for updating the patch. Looks good to me.

        I guess it's probably an overkill.....

        I agree with you.

        Haohui Mai, do you have any good idea?

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Xiao Chen for updating the patch. Looks good to me. I guess it's probably an overkill..... I agree with you. Haohui Mai , do you have any good idea?
        Hide
        vinayrpet Vinayakumar B added a comment - - edited

        How about keeping 'year' as a variable in each html file, and replacing it with actual year at the time of building.

        Almost similar to 'common-version-info.properties', which doesnt have actual values. But a file with actual values will be created inside target/classes by hadoop-maven-plugin.

        Same way, while copying these html files from 'src/main/webapps' directory to 'target/webapps' variable can be changed to actual year.

        In this way nothing needs to be changed later.
        Any thoughts?

        Show
        vinayrpet Vinayakumar B added a comment - - edited How about keeping 'year' as a variable in each html file, and replacing it with actual year at the time of building. Almost similar to 'common-version-info.properties', which doesnt have actual values. But a file with actual values will be created inside target/classes by hadoop-maven-plugin. Same way, while copying these html files from 'src/main/webapps' directory to 'target/webapps' variable can be changed to actual year. In this way nothing needs to be changed later. Any thoughts?
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 asflicense 0m 19s Patch does not generate ASF License warnings.
        0m 36s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783038/HDFS-9629.03.patch
        JIRA Issue HDFS-9629
        Optional Tests asflicense
        uname Linux 6d7e3f40c48b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 57d0a94
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 30MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14173/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s Patch has no whitespace issues. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 0m 36s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783038/HDFS-9629.03.patch JIRA Issue HDFS-9629 Optional Tests asflicense uname Linux 6d7e3f40c48b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 57d0a94 modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 30MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14173/console This message was automatically generated.
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks Vinayakumar B for the comment!
        As Akira mentioned:

        I thought that we can set the year dynamically by showing the year when the source code is built. However, it is not a good idea because if you get a source code released in 2016 and built it in 2017, the UI shows 2017. It is confusing.

        I understand that generally we want things to be as automated as possible. But I don't have a strong opinion in this case, mostly because I'm unsure what's the best practice for these year info with the trademark.
        One step back, looking at the Apache license header in java files, we don't even have year info in there...

        Show
        xiaochen Xiao Chen added a comment - Thanks Vinayakumar B for the comment! As Akira mentioned: I thought that we can set the year dynamically by showing the year when the source code is built. However, it is not a good idea because if you get a source code released in 2016 and built it in 2017, the UI shows 2017. It is confusing. I understand that generally we want things to be as automated as possible. But I don't have a strong opinion in this case, mostly because I'm unsure what's the best practice for these year info with the trademark. One step back, looking at the Apache license header in java files, we don't even have year info in there...
        Hide
        wheat9 Haohui Mai added a comment -

        The clean way to do this is through generating templates through maven. Having a JavaScript just for displaying this seems overkill. Maybe there's some information in NN's JMX as well.

        Show
        wheat9 Haohui Mai added a comment - The clean way to do this is through generating templates through maven. Having a JavaScript just for displaying this seems overkill. Maybe there's some information in NN's JMX as well.
        Hide
        drankye Kai Zheng added a comment -

        The clean way to do this is through generating templates through maven.

        Quite agree. maven might directly generate a json file with such info (we can add more similar to this in future) and all the HTML files include the json data file to reference.

        Show
        drankye Kai Zheng added a comment - The clean way to do this is through generating templates through maven. Quite agree. maven might directly generate a json file with such info (we can add more similar to this in future) and all the HTML files include the json data file to reference.
        Hide
        drankye Kai Zheng added a comment -

        Sorry I take back what I said. Generating a json data file for simply showing the year 2016 is even overkill than having a javascript!

        Show
        drankye Kai Zheng added a comment - Sorry I take back what I said. Generating a json data file for simply showing the year 2016 is even overkill than having a javascript!
        Hide
        vinayrpet Vinayakumar B added a comment -

        Attached the patch to change footer during build.

        Show
        vinayrpet Vinayakumar B added a comment - Attached the patch to change footer during build.
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks Haohui Mai, Kai Zheng for the comments, and Vinayakumar B for the new patch!

        So the consensus here is that we can have the displayed year on the UI to be the software's build year, and if someone build a version released in 2016 today, the UI showing 2017 is acceptable, am I right?

        Show
        xiaochen Xiao Chen added a comment - Thanks Haohui Mai , Kai Zheng for the comments, and Vinayakumar B for the new patch! So the consensus here is that we can have the displayed year on the UI to be the software's build year, and if someone build a version released in 2016 today, the UI showing 2017 is acceptable, am I right?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 13m 7s trunk passed
        +1 compile 1m 47s trunk passed with JDK v1.8.0_66
        +1 compile 1m 6s trunk passed with JDK v1.7.0_91
        +1 mvnsite 1m 13s trunk passed
        +1 mvneclipse 0m 18s trunk passed
        +1 javadoc 1m 47s trunk passed with JDK v1.8.0_66
        +1 javadoc 2m 36s trunk passed with JDK v1.7.0_91
        +1 mvninstall 1m 8s the patch passed
        +1 compile 1m 23s the patch passed with JDK v1.8.0_66
        +1 javac 1m 23s the patch passed
        +1 compile 1m 0s the patch passed with JDK v1.7.0_91
        +1 javac 1m 0s the patch passed
        +1 mvnsite 1m 14s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 javadoc 1m 49s the patch passed with JDK v1.8.0_66
        +1 javadoc 2m 35s the patch passed with JDK v1.7.0_91
        -1 unit 127m 29s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 104m 51s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 22s Patch does not generate ASF License warnings.
        267m 37s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.TestLocalDFS
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.fs.TestSymlinkHdfsFileContext
          hadoop.hdfs.server.namenode.TestDecommissioningStatus
          hadoop.hdfs.qjournal.TestSecureNNWithQJM
          hadoop.hdfs.TestEncryptionZones
          hadoop.hdfs.server.datanode.TestDirectoryScanner
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.balancer.TestBalancer
          hadoop.hdfs.server.namenode.TestSecurityTokenEditLog
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.namenode.TestFileTruncate
          hadoop.hdfs.TestEncryptionZones
          hadoop.hdfs.TestDFSClientRetries
          hadoop.hdfs.server.datanode.TestDirectoryScanner



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783623/HDFS-9629.04.patch
        JIRA Issue HDFS-9629
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux 03c8f92f4388 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 468a53b
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14188/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14188/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14188/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14188/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14188/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14188/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 77MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14188/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 7s trunk passed +1 compile 1m 47s trunk passed with JDK v1.8.0_66 +1 compile 1m 6s trunk passed with JDK v1.7.0_91 +1 mvnsite 1m 13s trunk passed +1 mvneclipse 0m 18s trunk passed +1 javadoc 1m 47s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 36s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 8s the patch passed +1 compile 1m 23s the patch passed with JDK v1.8.0_66 +1 javac 1m 23s the patch passed +1 compile 1m 0s the patch passed with JDK v1.7.0_91 +1 javac 1m 0s the patch passed +1 mvnsite 1m 14s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 1m 49s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 35s the patch passed with JDK v1.7.0_91 -1 unit 127m 29s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 104m 51s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 267m 37s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestLocalDFS   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.namenode.TestSecurityTokenEditLog   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783623/HDFS-9629.04.patch JIRA Issue HDFS-9629 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 03c8f92f4388 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 468a53b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14188/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14188/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14188/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14188/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14188/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14188/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14188/console This message was automatically generated.
        Hide
        xiaochen Xiao Chen added a comment -

        Patch 5 to fix whitespace.

        Show
        xiaochen Xiao Chen added a comment - Patch 5 to fix whitespace.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 34s trunk passed
        +1 compile 0m 39s trunk passed with JDK v1.8.0_66
        +1 compile 0m 41s trunk passed with JDK v1.7.0_91
        +1 mvnsite 0m 52s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 javadoc 1m 12s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 45s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 36s the patch passed with JDK v1.8.0_66
        +1 javac 0m 36s the patch passed
        +1 compile 0m 38s the patch passed with JDK v1.7.0_91
        +1 javac 0m 38s the patch passed
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 0s The patch has no ill-formed XML file.
        +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 45s the patch passed with JDK v1.7.0_91
        -1 unit 52m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        +1 unit 50m 41s hadoop-hdfs in the patch passed with JDK v1.7.0_91.
        +1 asflicense 0m 20s Patch does not generate ASF License warnings.
        124m 14s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
          hadoop.hdfs.server.namenode.TestCacheDirectives



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783708/HDFS-9629.05.patch
        JIRA Issue HDFS-9629
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux 2a4728b9e370 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f3427d3
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14194/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14194/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14194/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 77MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14194/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 34s trunk passed +1 compile 0m 39s trunk passed with JDK v1.8.0_66 +1 compile 0m 41s trunk passed with JDK v1.7.0_91 +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 14s trunk passed +1 javadoc 1m 12s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 45s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 45s the patch passed +1 compile 0m 36s the patch passed with JDK v1.8.0_66 +1 javac 0m 36s the patch passed +1 compile 0m 38s the patch passed with JDK v1.7.0_91 +1 javac 0m 38s the patch passed +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 45s the patch passed with JDK v1.7.0_91 -1 unit 52m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 50m 41s hadoop-hdfs in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 124m 14s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark   hadoop.hdfs.server.namenode.TestCacheDirectives Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783708/HDFS-9629.05.patch JIRA Issue HDFS-9629 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 2a4728b9e370 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f3427d3 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14194/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14194/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14194/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14194/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        So the consensus here is that we can have the displayed year on the UI to be the software's build year, and if someone build a version released in 2016 today, the UI showing 2017 is acceptable, am I right?

        Okay.

        Show
        ajisakaa Akira Ajisaka added a comment - So the consensus here is that we can have the displayed year on the UI to be the software's build year, and if someone build a version released in 2016 today, the UI showing 2017 is acceptable, am I right? Okay.
        Hide
        yzhangal Yongjun Zhang added a comment -

        HI Guys,

        Thanks Xiao for working on this and all for the discussion here.

        Sorry for jumping in late. It seems a bit confusing to me to display the year of build rather than the year of the release. What about displaying both years, as "Release" and "Build"?

        Thanks.

        Show
        yzhangal Yongjun Zhang added a comment - HI Guys, Thanks Xiao for working on this and all for the discussion here. Sorry for jumping in late. It seems a bit confusing to me to display the year of build rather than the year of the release. What about displaying both years, as "Release" and "Build"? Thanks.
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks Yongjun Zhang for the input.

        My intention of this JIRA was just to update the 2015->2016, and probably in a more automatic way. So far seems like using the build time is automatic and simple enough, and has some acceptance.

        I understand build and release are 2 different things. I think for most of the case, when people get a released package, the year will be shown as the year when the release was built, which in most of the case is the same as release year. So I propose to use this jira as an automation enhancement, and add the Release/Build in a separate JIRA (and if needed, probably some other copyright/license lines). Does this make sense to you?

        Show
        xiaochen Xiao Chen added a comment - Thanks Yongjun Zhang for the input. My intention of this JIRA was just to update the 2015->2016, and probably in a more automatic way. So far seems like using the build time is automatic and simple enough, and has some acceptance. I understand build and release are 2 different things. I think for most of the case, when people get a released package, the year will be shown as the year when the release was built, which in most of the case is the same as release year. So I propose to use this jira as an automation enhancement, and add the Release/Build in a separate JIRA (and if needed, probably some other copyright/license lines). Does this make sense to you?
        Hide
        yzhangal Yongjun Zhang added a comment -

        Thanks Xiao, agree.

        Show
        yzhangal Yongjun Zhang added a comment - Thanks Xiao, agree.
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks Yongjun, created HDFS-9707 for the above.

        Show
        xiaochen Xiao Chen added a comment - Thanks Yongjun, created HDFS-9707 for the above.
        Hide
        yzhangal Yongjun Zhang added a comment -

        Hi Xiao Chen,

        Patch rev 05 looks good to me, one minor thing is, I think it'd be more clear to replace "year" in the patch with "build-year". I wonder what you and other folks think.

        Thanks.

        Show
        yzhangal Yongjun Zhang added a comment - Hi Xiao Chen , Patch rev 05 looks good to me, one minor thing is, I think it'd be more clear to replace "year" in the patch with "build-year". I wonder what you and other folks think. Thanks.
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks Yongjun Zhang for the input.

        Patch 6 renames the place holder from year to specifically hdfs-build-year. Hopefully this will clear things out for someone new reading the html - at least they can search for this text and reach to the pom.

        Show
        xiaochen Xiao Chen added a comment - Thanks Yongjun Zhang for the input. Patch 6 renames the place holder from year to specifically hdfs-build-year . Hopefully this will clear things out for someone new reading the html - at least they can search for this text and reach to the pom.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 10m 42s trunk passed
        +1 compile 1m 37s trunk passed with JDK v1.8.0_66
        +1 compile 1m 8s trunk passed with JDK v1.7.0_91
        +1 mvnsite 1m 34s trunk passed
        +1 mvneclipse 0m 20s trunk passed
        +1 javadoc 1m 58s trunk passed with JDK v1.8.0_66
        +1 javadoc 2m 54s trunk passed with JDK v1.7.0_91
        +1 mvninstall 1m 13s the patch passed
        +1 compile 1m 25s the patch passed with JDK v1.8.0_66
        +1 javac 1m 25s the patch passed
        +1 compile 1m 5s the patch passed with JDK v1.7.0_91
        +1 javac 1m 5s the patch passed
        +1 mvnsite 1m 22s the patch passed
        +1 mvneclipse 0m 16s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 javadoc 1m 55s the patch passed with JDK v1.8.0_66
        +1 javadoc 2m 54s the patch passed with JDK v1.7.0_91
        -1 unit 90m 3s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 86m 38s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        -1 asflicense 0m 32s Patch generated 1 ASF License warnings.
        211m 53s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
          hadoop.hdfs.qjournal.TestSecureNNWithQJM
          hadoop.hdfs.shortcircuit.TestShortCircuitCache
          hadoop.hdfs.TestDFSUpgradeFromImage
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
          hadoop.hdfs.server.namenode.TestNameNodeMXBean
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
        JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure180
          org.apache.hadoop.hdfs.util.TestBestEffortLongFile
          org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
          org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage
          hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.hdfs.security.TestDelegationTokenForProxyUser



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785375/HDFS-9629.06.patch
        JIRA Issue HDFS-9629
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux c3b1b51125a8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 772ea7b
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14304/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14304/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14304/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14304/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14304/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14304/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14304/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 10m 42s trunk passed +1 compile 1m 37s trunk passed with JDK v1.8.0_66 +1 compile 1m 8s trunk passed with JDK v1.7.0_91 +1 mvnsite 1m 34s trunk passed +1 mvneclipse 0m 20s trunk passed +1 javadoc 1m 58s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 54s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 13s the patch passed +1 compile 1m 25s the patch passed with JDK v1.8.0_66 +1 javac 1m 25s the patch passed +1 compile 1m 5s the patch passed with JDK v1.7.0_91 +1 javac 1m 5s the patch passed +1 mvnsite 1m 22s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 1m 55s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 54s the patch passed with JDK v1.7.0_91 -1 unit 90m 3s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 86m 38s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 32s Patch generated 1 ASF License warnings. 211m 53s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock   hadoop.hdfs.server.namenode.TestNameNodeMXBean   hadoop.hdfs.security.TestDelegationTokenForProxyUser JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure180   org.apache.hadoop.hdfs.util.TestBestEffortLongFile   org.apache.hadoop.hdfs.TestDFSStorageStateRecovery   org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.security.TestDelegationTokenForProxyUser Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785375/HDFS-9629.06.patch JIRA Issue HDFS-9629 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux c3b1b51125a8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 772ea7b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14304/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14304/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14304/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14304/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14304/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14304/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14304/console This message was automatically generated.
        Hide
        yzhangal Yongjun Zhang added a comment -

        Thanks Xiao Chen for the new rev.

        Hi Akira Ajisaka, Brahma Reddy Battula, Haohui Mai, Kai Zheng, Vinayakumar B,

        Thanks for your earlier review and comments. I gave some more thoughts about this issue. Xiao's original attempt was to make it easier to change the year when needed, however, due to lack of a convenient way (one option is to write a javascript), the latest patches use build time in place the original release time, which is confusing.

        Currently a release is done in a few steps:
        1. create release branch,
        2. add additional important fixes
        3. change the hardcoded release name right before the final build such as removing "_SNAPSHOT" from "x.y.x-SNAPSHOT"

        For step 3, the release name is involved in lot of pom.xml files all over the places. Ideally we could have a single place to hold the release name variable, and refer it in all relevant pom.xml files, so whenever we need to make a change, we only change the single place. But we did not do that, because it's not as straightforward as defining a constant in a computer language.

        For this jira, I'd propose to add another step to the release steps
        4. change the hardcoded year in the several involved files.

        Although this is similar to what's done in HDFS-8149, what I would like emphasize is, adding step 4 to the release process, as a guideline, which should be documented somewhere.

        As a matter of fact, step 3 and step 4 could be done by a script altogether in the release process.

        What do you think?

        Thanks.

        Show
        yzhangal Yongjun Zhang added a comment - Thanks Xiao Chen for the new rev. Hi Akira Ajisaka , Brahma Reddy Battula , Haohui Mai , Kai Zheng , Vinayakumar B , Thanks for your earlier review and comments. I gave some more thoughts about this issue. Xiao's original attempt was to make it easier to change the year when needed, however, due to lack of a convenient way (one option is to write a javascript), the latest patches use build time in place the original release time, which is confusing. Currently a release is done in a few steps: 1. create release branch, 2. add additional important fixes 3. change the hardcoded release name right before the final build such as removing "_SNAPSHOT" from "x.y.x-SNAPSHOT" For step 3, the release name is involved in lot of pom.xml files all over the places. Ideally we could have a single place to hold the release name variable, and refer it in all relevant pom.xml files, so whenever we need to make a change, we only change the single place. But we did not do that, because it's not as straightforward as defining a constant in a computer language. For this jira, I'd propose to add another step to the release steps 4. change the hardcoded year in the several involved files. Although this is similar to what's done in HDFS-8149 , what I would like emphasize is, adding step 4 to the release process, as a guideline, which should be documented somewhere. As a matter of fact, step 3 and step 4 could be done by a script altogether in the release process. What do you think? Thanks.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1 for adding another step to https://wiki.apache.org/hadoop/HowToRelease. Thanks Yongjun Zhang.

        Show
        ajisakaa Akira Ajisaka added a comment - +1 for adding another step to https://wiki.apache.org/hadoop/HowToRelease . Thanks Yongjun Zhang .
        Hide
        yzhangal Yongjun Zhang added a comment -

        Thanks a lot Akira Ajisaka!

        I'm proposing to change the following section in https://wiki.apache.org/hadoop/HowToRelease:

        Creating the release candidate (X.Y.Z-RC<N>)
        These steps need to be performed to create the Nth RC for X.Y.Z, where N starts from 0.
        1. Run mvn rat-check and fix any errors
        ...
        

        to

        Creating the release candidate (X.Y.Z-RC<N>)
        
        These steps need to be performed to create the Nth RC for X.Y.Z, where N starts from 0.
        
        1. Change the release year in the footer of the Web UI in relevant files.
            NOTE, the following steps are example, and are subject to examination of the current code base.
            1.1 find the relevant files
              $ find . -name "*html" -exec grep "<p>Hadoop," {} \; -print
                <div class="col-xs-2"><p>Hadoop, 2014.</p></div>
             ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
                <div class="col-xs-2"><p>Hadoop, 2014.</p></div>
             ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html
                <div class="col-xs-2"><p>Hadoop, 2014.</p></div>
             ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary/status.html
                <div class="col-xs-2"><p>Hadoop, 2014.</p></div>
             ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/journal/index.html
                <div class="col-xs-2"><p>Hadoop, 2014.</p></div>
             ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode/index.html
           1.2 If the year in the above search result is up-to-date, skip the rest of the 1.x steps, otherwise replace the year with current year
              $ sed -i 's/<p>Hadoop, 2014/<p>Hadoop, 2016/g' `find . -name "*html" -exec grep "<p>Hadoop, " {} \; -print | grep html`
           1.3 check result
               $ find . -name "*html" -exec grep "<p>Hadoop," {} \; -print
                <div class="col-xs-2"><p>Hadoop, 2016.</p></div>
              ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
                <div class="col-xs-2"><p>Hadoop, 2016.</p></div>
              ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html
                <div class="col-xs-2"><p>Hadoop, 2016.</p></div>
             ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary/status.html
                <div class="col-xs-2"><p>Hadoop, 2016.</p></div>
             ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/journal/index.html
                <div class="col-xs-2"><p>Hadoop, 2016.</p></div>
             ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode/index.html
            1.4 commit the change
               git commit -a -m "Update release year in the footer of the Web UI"
        
        2. Run mvn rat-check and fix any errors
        ...
        

        What do you think?

        Thanks.

        Show
        yzhangal Yongjun Zhang added a comment - Thanks a lot Akira Ajisaka ! I'm proposing to change the following section in https://wiki.apache.org/hadoop/HowToRelease: Creating the release candidate (X.Y.Z-RC<N>) These steps need to be performed to create the Nth RC for X.Y.Z, where N starts from 0. 1. Run mvn rat-check and fix any errors ... to Creating the release candidate (X.Y.Z-RC<N>) These steps need to be performed to create the Nth RC for X.Y.Z, where N starts from 0. 1. Change the release year in the footer of the Web UI in relevant files. NOTE, the following steps are example, and are subject to examination of the current code base. 1.1 find the relevant files $ find . -name "*html" -exec grep "<p>Hadoop," {} \; -print <div class= "col-xs-2" ><p>Hadoop, 2014.</p></div> ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html <div class= "col-xs-2" ><p>Hadoop, 2014.</p></div> ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html <div class= "col-xs-2" ><p>Hadoop, 2014.</p></div> ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary/status.html <div class= "col-xs-2" ><p>Hadoop, 2014.</p></div> ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/journal/index.html <div class= "col-xs-2" ><p>Hadoop, 2014.</p></div> ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode/index.html 1.2 If the year in the above search result is up-to-date, skip the rest of the 1.x steps, otherwise replace the year with current year $ sed -i 's/<p>Hadoop, 2014/<p>Hadoop, 2016/g' `find . -name "*html" -exec grep "<p>Hadoop, " {} \; -print | grep html` 1.3 check result $ find . -name "*html" -exec grep "<p>Hadoop," {} \; -print <div class= "col-xs-2" ><p>Hadoop, 2016.</p></div> ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html <div class= "col-xs-2" ><p>Hadoop, 2016.</p></div> ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html <div class= "col-xs-2" ><p>Hadoop, 2016.</p></div> ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary/status.html <div class= "col-xs-2" ><p>Hadoop, 2016.</p></div> ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/journal/index.html <div class= "col-xs-2" ><p>Hadoop, 2016.</p></div> ./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode/index.html 1.4 commit the change git commit -a -m "Update release year in the footer of the Web UI" 2. Run mvn rat-check and fix any errors ... What do you think? Thanks.
        Hide
        vinayrpet Vinayakumar B added a comment -

        What do you think?

        Instead, How about combine this with the patch.
        In current patch, year is determined from current date, instead lets take as a property, which can be overridden if required during build.
        Release manager only has to take care of changing at one place, instead of everywhere.
        1. Idea is to have a system property in root pom.xml,

          <properties>
            <release-year>2016</release-year>
          </properties>

        2. In all html replace the footer as below.

        <div class="col-xs-2"><p>Hadoop, {release-year-token}.</p></div>

        3. And replace this token in all html files during build. (In Future, may be some other components also might need same treatment otherwise)

                        <replace dir="${project.build.directory}/webapps" value="${release-year}">
        	                  <include name="**/*.html"/>
        	                  <replacetoken>{release-year-token}</replacetoken>
        	                </replace>

        Just, extra step for ReleaseManager is to replace 2016 with year of release, at the time of changing version from *-SNAPSHOT.

        Show
        vinayrpet Vinayakumar B added a comment - What do you think? Instead, How about combine this with the patch. In current patch, year is determined from current date, instead lets take as a property, which can be overridden if required during build. Release manager only has to take care of changing at one place, instead of everywhere. 1. Idea is to have a system property in root pom.xml, <properties> <release-year> 2016 </release-year> </properties> 2. In all html replace the footer as below. <div class= "col-xs-2" ><p>Hadoop, {release-year-token}.</p></div> 3. And replace this token in all html files during build. (In Future, may be some other components also might need same treatment otherwise) <replace dir= "${project.build.directory}/webapps" value= "${release-year}" > <include name= "**/*.html" /> <replacetoken>{release-year-token}</replacetoken> </replace> Just, extra step for ReleaseManager is to replace 2016 with year of release, at the time of changing version from *-SNAPSHOT.
        Hide
        yzhangal Yongjun Zhang added a comment -

        That'd be lovely Vinayakumar B, thanks a lot!

        This kind of solution is what I look for. Wonder if similar thing can be done for the release name, which is scattered around in many pom.xml files.

        Show
        yzhangal Yongjun Zhang added a comment - That'd be lovely Vinayakumar B , thanks a lot! This kind of solution is what I look for. Wonder if similar thing can be done for the release name, which is scattered around in many pom.xml files.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Updated the patch as mentioned.

        Show
        vinayrpet Vinayakumar B added a comment - Updated the patch as mentioned.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 14s Maven dependency ordering for branch
        +1 mvninstall 6m 26s trunk passed
        +1 compile 5m 48s trunk passed with JDK v1.8.0_66
        +1 compile 6m 55s trunk passed with JDK v1.7.0_91
        +1 mvnsite 1m 4s trunk passed
        +1 mvneclipse 0m 23s trunk passed
        +1 javadoc 1m 23s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 59s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 13s Maven dependency ordering for patch
        +1 mvninstall 0m 53s the patch passed
        +1 compile 7m 59s the patch passed with JDK v1.8.0_66
        +1 javac 7m 59s the patch passed
        +1 compile 6m 42s the patch passed with JDK v1.7.0_91
        +1 javac 6m 42s the patch passed
        +1 mvnsite 1m 3s the patch passed
        +1 mvneclipse 0m 24s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 javadoc 1m 14s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 54s the patch passed with JDK v1.7.0_91
        +1 unit 0m 9s hadoop-project in the patch passed with JDK v1.8.0_66.
        -1 unit 53m 16s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        +1 unit 0m 10s hadoop-project in the patch passed with JDK v1.7.0_91.
        -1 unit 63m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 25s Patch does not generate ASF License warnings.
        164m 41s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestFileCreationDelete
          hadoop.hdfs.TestDFSUpgradeFromImage
          hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestReconstructStripedFile
          hadoop.hdfs.TestMissingBlocksAlert
          hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
        JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785996/HDFS-9629.07.patch
        JIRA Issue HDFS-9629
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux 790cdbe95848 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / eb2fb94
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14361/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14361/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14361/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14361/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14361/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-project U: .
        Max memory used 77MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14361/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 26s trunk passed +1 compile 5m 48s trunk passed with JDK v1.8.0_66 +1 compile 6m 55s trunk passed with JDK v1.7.0_91 +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 23s trunk passed +1 javadoc 1m 23s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 59s trunk passed with JDK v1.7.0_91 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 0m 53s the patch passed +1 compile 7m 59s the patch passed with JDK v1.8.0_66 +1 javac 7m 59s the patch passed +1 compile 6m 42s the patch passed with JDK v1.7.0_91 +1 javac 6m 42s the patch passed +1 mvnsite 1m 3s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 1m 14s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 54s the patch passed with JDK v1.7.0_91 +1 unit 0m 9s hadoop-project in the patch passed with JDK v1.8.0_66. -1 unit 53m 16s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 0m 10s hadoop-project in the patch passed with JDK v1.7.0_91. -1 unit 63m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 164m 41s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestFileCreationDelete   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestReconstructStripedFile   hadoop.hdfs.TestMissingBlocksAlert   hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785996/HDFS-9629.07.patch JIRA Issue HDFS-9629 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 790cdbe95848 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / eb2fb94 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14361/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14361/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14361/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14361/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14361/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-project U: . Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14361/console This message was automatically generated.
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks guys for the discussions and the new patch! Sorry I wasn't able to get to this sooner.
        I love the final solution of extracting the year but hard code it in the pom, so we only have 1 place to change, and without the confusion between build/release years.

        I also created account on the wiki and asked permission to update the HowToRelease page. Will update that after this change is finalized and committed.

        Show
        xiaochen Xiao Chen added a comment - Thanks guys for the discussions and the new patch! Sorry I wasn't able to get to this sooner. I love the final solution of extracting the year but hard code it in the pom, so we only have 1 place to change, and without the confusion between build/release years. I also created account on the wiki and asked permission to update the HowToRelease page. Will update that after this change is finalized and committed.
        Hide
        yzhangal Yongjun Zhang added a comment -

        Thanks Vinayakumar B for patch rev 07, I tested it out and it works nicely. +1.

        Show
        yzhangal Yongjun Zhang added a comment - Thanks Vinayakumar B for patch rev 07, I tested it out and it works nicely. +1.
        Hide
        yzhangal Yongjun Zhang added a comment -

        Created HDFS-9751 for release process documentation change.

        HI Akira Ajisaka, wonder if you'd like to take a look on the latest patch. I plan to commit it soon. Thanks much.

        Show
        yzhangal Yongjun Zhang added a comment - Created HDFS-9751 for release process documentation change. HI Akira Ajisaka , wonder if you'd like to take a look on the latest patch. I plan to commit it soon. Thanks much.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, I tested the patch and confirmed the footer is updated to "Hadoop, 2016.".

        Show
        ajisakaa Akira Ajisaka added a comment - +1, I tested the patch and confirmed the footer is updated to "Hadoop, 2016.".
        Hide
        vinayrpet Vinayakumar B added a comment -

        Committed this to
        trunk, branch-2, branch-2.8, branch-2.7 and branch-2.6

        Thanks everyone for the contributions.
        Anyway, Release process need not be changed at-least for one year.

        Show
        vinayrpet Vinayakumar B added a comment - Committed this to trunk, branch-2, branch-2.8, branch-2.7 and branch-2.6 Thanks everyone for the contributions. Anyway, Release process need not be changed at-least for one year.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9244 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9244/)
        HDFS-9629. Update the footer of Web UI to show year 2016 (Contributed by (vinayakumarb: rev a6728a013e5ed9f4c92120bf462afd6a730e5b29)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html
        • hadoop-hdfs-project/hadoop-hdfs/pom.xml
        • hadoop-project/pom.xml
        • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary/status.html
        • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode/index.html
        • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/journal/index.html
        • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9244 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9244/ ) HDFS-9629 . Update the footer of Web UI to show year 2016 (Contributed by (vinayakumarb: rev a6728a013e5ed9f4c92120bf462afd6a730e5b29) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html hadoop-hdfs-project/hadoop-hdfs/pom.xml hadoop-project/pom.xml hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary/status.html hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode/index.html hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/journal/index.html hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        yzhangal Yongjun Zhang added a comment -

        Thanks all!

        Let's still add the extra step to the release process document when it's fresh, so we don't forget. Though no real action is needed for this extra step in 2016

        Since changing the release process is sensitive, before we make this change, let me throw an email discussion thread to bring that to other folks' attention.

        Thanks.

        Show
        yzhangal Yongjun Zhang added a comment - Thanks all! Let's still add the extra step to the release process document when it's fresh, so we don't forget. Though no real action is needed for this extra step in 2016 Since changing the release process is sensitive, before we make this change, let me throw an email discussion thread to bring that to other folks' attention. Thanks.
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks all for the discussions + review + testing, and Vinay for the patch! I'm flushed to have this JIRA under my name....
        Also thanks to Yongjun for proposing to start the email thread. I'll follow it there and update the docs accordingly in HADOOP-12768.

        Show
        xiaochen Xiao Chen added a comment - Thanks all for the discussions + review + testing, and Vinay for the patch! I'm flushed to have this JIRA under my name.... Also thanks to Yongjun for proposing to start the email thread. I'll follow it there and update the docs accordingly in HADOOP-12768 .
        Hide
        djp Junping Du added a comment -

        Add 2.7.3 and 2.8.0 in fix version given it is already land on branch-2.7 and branch-2.8.

        Show
        djp Junping Du added a comment - Add 2.7.3 and 2.8.0 in fix version given it is already land on branch-2.7 and branch-2.8.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Closing the JIRA as part of 2.7.3 release.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

          People

          • Assignee:
            xiaochen Xiao Chen
            Reporter:
            xiaochen Xiao Chen
          • Votes:
            0 Vote for this issue
            Watchers:
            11 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development