[HDFS-9596] Remove Shuffle Method From DFSUtil

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Hadoop Flags: Reviewed
• Flags: Patch
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 23/Dec/15 18:57
• Updated: 18/Feb/19 23:44
• Resolved: 18/Feb/19 23:30

Description

DFSUtil contains a "shuffle" routine that shuffles arrays. With a little wrapping, Java Collections class can shuffle. This code is superfluous and undocumented. The method returns an array, though it does not specify if it returns the same array or a new, copy, array of shuffled items.

It is only used in one place, so it is better to simply remove and substitute this implementation with the java Collections implementation.