[HDFS-9569] Log the name of the fsimage being loaded for better supportability

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
• Component/s: namenode
• Labels: supportability
• Hadoop Flags: Reviewed
• Assignee: Yongjun Zhang
• Reporter: Yongjun Zhang
• Created: 17/Dec/15 02:29
• Updated: 06/Jan/17 01:55
• Resolved: 12/Jan/16 18:04

Description

When NN starts to load fsimage, it does

 void loadFSImageFile(FSNamesystem target, MetaRecoveryContext recovery,
      FSImageFile imageFile, StartupOption startupOption) throws IOException {
      LOG.debug("Planning to load image :\n" + imageFile);
      ......
    long txId = loader.getLoadedImageTxId();
    LOG.info("Loaded image for txid " + txId + " from " + curFile);

A debug msg is issued at the beginning with the fsimage file name, then at the end an info msg is issued after loading.

If the fsimage loading failed due to corrupted fsimage (see HDFS-9406), we don't see the first msg. It'd be helpful to always be able to see from NN logs what fsimage file it's loading.

Two improvements:

1. Change the above debug to info
2. If exception happens when loading fsimage, be sure to report the fsimage name being loaded in the error message.

Issue Links

• breaks: HDFS-9652 TestStartup.testImageChecksum is broken by HDFS-9569
• breaks: HDFS-9648 TestStartup.testImageChecksum is broken by HDFS-9569's message change