[HDFS-9565] TestDistributedFileSystem.testLocatedFileStatusStorageIdsTypes is flaky due to race condition

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha1
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: fs, test

Environment

Jenkins

• Hadoop Flags: Reviewed
• Assignee: Wei-Chiu Chuang
• Reporter: Wei-Chiu Chuang
• Created: 16/Dec/15 20:29
• Updated: 02/Oct/19 17:14
• Resolved: 17/Dec/15 18:39

Description

TestDistributedFileSystem.testLocatedFileStatusStorageIdsTypes occasionally fails with the following error:
https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/699/testReport/org.apache.hadoop.hdfs/TestDistributedFileSystem/testLocatedFileStatusStorageIdsTypes/

FAILED:  org.apache.hadoop.hdfs.TestDistributedFileSystem.testLocatedFileStatusStorageIdsTypes

Error Message:
Unexpected num storage ids expected:<2> but was:<1>

Stack Trace:
java.lang.AssertionError: Unexpected num storage ids expected:<2> but was:<1>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:743)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at org.junit.Assert.assertEquals(Assert.java:555)
	at org.apache.hadoop.hdfs.TestDistributedFileSystem.testLocatedFileStatusStorageIdsTypes(TestDistributedFileSystem.java:855)

It appears that this test failed due to race condition: it does not wait for the file replication to finish, before checking the file's status.

This flaky test can be fixed by using DFSTestUtil.waitForReplication()