[HDFS-9516] truncate file fails with data dirs on multiple disks

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7.1
• Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
• Component/s: datanode
• Target Version/s: 2.8.0, 2.7.3
• Hadoop Flags: Reviewed
• Assignee: Plamen Jeliazkov
• Reporter: Bogdan Raducanu
• Created: 07/Dec/15 16:34
• Updated: 06/Jan/17 01:44
• Resolved: 15/Dec/15 08:46

Description

FileSystem.truncate returns false (no exception) but the file is never closed and not writable after this.

It seems to be because of copy on truncate which is used because the system is in upgrade state. In this case a rename between devices is attempted.
See attached log and repro code.
Probably also affects truncate snapshotted file when copy on truncate is also used.
Possibly it affects not only truncate but any block recovery.

I think the problem is in updateReplicaUnderRecovery

ReplicaBeingWritten newReplicaInfo = new ReplicaBeingWritten(
            newBlockId, recoveryId, rur.getVolume(), blockFile.getParentFile(),
            newlength);

blockFile is created with copyReplicaWithNewBlockIdAndGS which is allowed to choose any volume so rur.getVolume() is not where the block is located.

Issue Links

• is related to: HDFS-3107 HDFS truncate