Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9514

TestDistributedFileSystem.testDFSClientPeerWriteTimeout failing; exception being swallowed

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: hdfs-client, test
    • Labels:
      None
    • Environment:

      jenkins

    • Hadoop Flags:
      Reviewed

      Description

      TestDistributedFileSystem.testDFSClientPeerWriteTimeout is failing with the wrong exception being raised...reporter isn't using the GenericTestUtils code and so losing the details

      1. HDFS-9514.001.patch
        3 kB
        Wei-Chiu Chuang
      2. HDFS-9514.002.patch
        3 kB
        Wei-Chiu Chuang
      3. HDFS-9514.003.patch
        2 kB
        Wei-Chiu Chuang

        Issue Links

          Activity

          Hide
          stevel@apache.org Steve Loughran added a comment -
          Error Message
          
          wrong exception:java.lang.AssertionError: write should timeout
          Stacktrace
          
          java.lang.AssertionError: wrong exception:java.lang.AssertionError: write should timeout
          	at org.junit.Assert.fail(Assert.java:88)
          	at org.apache.hadoop.hdfs.TestDistributedFileSystem.testDFSClientPeerWriteTimeout(TestDistributedFileSystem.java:1148)
          
          Show
          stevel@apache.org Steve Loughran added a comment - Error Message wrong exception:java.lang.AssertionError: write should timeout Stacktrace java.lang.AssertionError: wrong exception:java.lang.AssertionError: write should timeout at org.junit.Assert.fail(Assert.java:88) at org.apache.hadoop.hdfs.TestDistributedFileSystem.testDFSClientPeerWriteTimeout(TestDistributedFileSystem.java:1148)
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks for reporting the issue. I would like to work on it. There are also a few other similar cases where a Throwable is thrown but swallowed.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks for reporting the issue. I would like to work on it. There are also a few other similar cases where a Throwable is thrown but swallowed.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Throw a new IOException which contains the cause of the exception.

          Both testDFSClientPeerReadTimeout() and testDFSClientPeerWriteTimeout() have the same exception handling logic, so I made the patch for both methods.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Throw a new IOException which contains the cause of the exception. Both testDFSClientPeerReadTimeout() and testDFSClientPeerWriteTimeout() have the same exception handling logic, so I made the patch for both methods.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 10m 11s trunk passed
          +1 compile 1m 9s trunk passed with JDK v1.8.0_66
          +1 compile 0m 54s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 20s trunk passed
          +1 mvnsite 1m 10s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 2m 28s trunk passed
          +1 javadoc 1m 35s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 22s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 6s the patch passed
          +1 compile 1m 7s the patch passed with JDK v1.8.0_66
          +1 javac 1m 7s the patch passed
          +1 compile 0m 58s the patch passed with JDK v1.7.0_91
          +1 javac 0m 58s the patch passed
          +1 checkstyle 0m 21s the patch passed
          +1 mvnsite 1m 10s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 42s the patch passed
          +1 javadoc 1m 33s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 32s the patch passed with JDK v1.7.0_91
          -1 unit 72m 57s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 69m 42s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 24s Patch generated 58 ASF License warnings.
          179m 3s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.hdfs.TestRollingUpgrade
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
            hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.TestDistributedFileSystem
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.server.mover.TestStorageMover
            org.apache.hadoop.hdfs.server.balancer.TestBalancer
            org.apache.hadoop.hdfs.server.mover.TestMover
            org.apache.hadoop.hdfs.TestEncryptedTransfer
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork
            hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
            hadoop.hdfs.TestDistributedFileSystem
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776083/HDFS-9514.001.patch
          JIRA Issue HDFS-9514
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6579d5758520 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 01a641b
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13791/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13791/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13791/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13791/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13791/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13791/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 75MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13791/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 10m 11s trunk passed +1 compile 1m 9s trunk passed with JDK v1.8.0_66 +1 compile 0m 54s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 20s trunk passed +1 mvnsite 1m 10s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 2m 28s trunk passed +1 javadoc 1m 35s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 22s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 6s the patch passed +1 compile 1m 7s the patch passed with JDK v1.8.0_66 +1 javac 1m 7s the patch passed +1 compile 0m 58s the patch passed with JDK v1.7.0_91 +1 javac 0m 58s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 1m 10s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 42s the patch passed +1 javadoc 1m 33s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 32s the patch passed with JDK v1.7.0_91 -1 unit 72m 57s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 69m 42s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 24s Patch generated 58 ASF License warnings. 179m 3s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.TestDistributedFileSystem JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.server.mover.TestStorageMover   org.apache.hadoop.hdfs.server.balancer.TestBalancer   org.apache.hadoop.hdfs.server.mover.TestMover   org.apache.hadoop.hdfs.TestEncryptedTransfer JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork   hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776083/HDFS-9514.001.patch JIRA Issue HDFS-9514 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6579d5758520 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 01a641b findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13791/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13791/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13791/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13791/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13791/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13791/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13791/console This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          The test only modified TestDistributedFileSystem and therefore the test failures appear unrelated.

          Show
          jojochuang Wei-Chiu Chuang added a comment - The test only modified TestDistributedFileSystem and therefore the test failures appear unrelated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Sorry there are a few TestDistributedFileSystem failures. I'll work out an update.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Sorry there are a few TestDistributedFileSystem failures. I'll work out an update.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Rev02: fixed test logic.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Rev02: fixed test logic.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 9m 59s trunk passed
          +1 compile 1m 13s trunk passed with JDK v1.8.0_66
          +1 compile 0m 57s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 1m 10s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          +1 findbugs 2m 31s trunk passed
          +1 javadoc 1m 33s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 30s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 5s the patch passed
          +1 compile 1m 9s the patch passed with JDK v1.8.0_66
          +1 javac 1m 9s the patch passed
          +1 compile 0m 57s the patch passed with JDK v1.7.0_91
          +1 javac 0m 57s the patch passed
          +1 checkstyle 0m 20s the patch passed
          +1 mvnsite 1m 10s the patch passed
          +1 mvneclipse 0m 17s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 36s the patch passed
          +1 javadoc 1m 40s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 29s the patch passed with JDK v1.7.0_91
          -1 unit 83m 7s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 70m 17s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 21s Patch generated 56 ASF License warnings.
          189m 30s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.TestRollingUpgrade
            hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
            hadoop.hdfs.TestReadStripedFileWithDecoding
            hadoop.hdfs.TestRecoverStripedFile
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestRecoverStripedBlocks
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776118/HDFS-9514.002.patch
          JIRA Issue HDFS-9514
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b3524da9ed3c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 01a641b
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13793/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13793/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13793/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13793/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13793/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13793/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13793/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 59s trunk passed +1 compile 1m 13s trunk passed with JDK v1.8.0_66 +1 compile 0m 57s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 10s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 2m 31s trunk passed +1 javadoc 1m 33s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 30s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 5s the patch passed +1 compile 1m 9s the patch passed with JDK v1.8.0_66 +1 javac 1m 9s the patch passed +1 compile 0m 57s the patch passed with JDK v1.7.0_91 +1 javac 0m 57s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 1m 10s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 36s the patch passed +1 javadoc 1m 40s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 29s the patch passed with JDK v1.7.0_91 -1 unit 83m 7s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 70m 17s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 21s Patch generated 56 ASF License warnings. 189m 30s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots   hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestRecoverStripedBlocks   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776118/HDFS-9514.002.patch JIRA Issue HDFS-9514 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b3524da9ed3c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 01a641b findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13793/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13793/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13793/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13793/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13793/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13793/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13793/console This message was automatically generated.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks Steve Loughran for reporting the issue and Wei-Chiu Chuang for the patch.

          One comment, the following block (two occurences):

               catch (Throwable t) {
                  Assert.fail("wrong exception:" + t.toString() +
                      ExceptionUtils.getStackTrace(t));
                }
          

          can be dropped, since the test itself would print out the exception info including the stack.

          Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks Steve Loughran for reporting the issue and Wei-Chiu Chuang for the patch. One comment, the following block (two occurences): catch (Throwable t) { Assert.fail( "wrong exception:" + t.toString() + ExceptionUtils.getStackTrace(t)); } can be dropped, since the test itself would print out the exception info including the stack. Thanks.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks Yongjun for the review. Logging a Throwable in fail() only prints the error message, but does not print the stack trace at which the Throwable is thrown.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks Yongjun for the review. Logging a Throwable in fail() only prints the error message, but does not print the stack trace at which the Throwable is thrown.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Rev03: Remove fail() in catch. It is redundant. Just let it throw exceptions.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Rev03: Remove fail() in catch. It is redundant. Just let it throw exceptions.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks Wei-Chiu, +1 on rev3 pending jenkins.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks Wei-Chiu, +1 on rev3 pending jenkins.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Jenkins did not initiate. Re-submit to kick off another Jenkins job.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Jenkins did not initiate. Re-submit to kick off another Jenkins job.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 11m 16s trunk passed
          +1 compile 1m 23s trunk passed with JDK v1.8.0_66
          +1 compile 1m 4s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 1m 19s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          +1 findbugs 2m 43s trunk passed
          +1 javadoc 1m 50s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 49s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 11s the patch passed
          +1 compile 1m 19s the patch passed with JDK v1.8.0_66
          +1 javac 1m 19s the patch passed
          +1 compile 1m 4s the patch passed with JDK v1.7.0_91
          +1 javac 1m 4s the patch passed
          +1 checkstyle 0m 22s the patch passed
          +1 mvnsite 1m 16s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 52s the patch passed
          +1 javadoc 1m 52s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 45s the patch passed with JDK v1.7.0_91
          -1 unit 94m 34s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 73m 58s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 25s Patch generated 56 ASF License warnings.
          208m 55s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestCrcCorruption
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot
            hadoop.fs.TestSymlinkHdfsFileContext
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
            hadoop.hdfs.server.namenode.TestStartup
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStream
            hadoop.hdfs.tools.TestDFSAdminWithHA
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.TestWriteReadStripedFile
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
            hadoop.hdfs.web.TestWebHdfsFileSystemContract
            hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776898/HDFS-9514.003.patch
          JIRA Issue HDFS-9514
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a6388ae45364 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a483017
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13833/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13833/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13833/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13833/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13833/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13833/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus 0.1.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13833/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 11m 16s trunk passed +1 compile 1m 23s trunk passed with JDK v1.8.0_66 +1 compile 1m 4s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 23s trunk passed +1 mvnsite 1m 19s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 2m 43s trunk passed +1 javadoc 1m 50s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 49s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 11s the patch passed +1 compile 1m 19s the patch passed with JDK v1.8.0_66 +1 javac 1m 19s the patch passed +1 compile 1m 4s the patch passed with JDK v1.7.0_91 +1 javac 1m 4s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 1m 16s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 52s the patch passed +1 javadoc 1m 52s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 45s the patch passed with JDK v1.7.0_91 -1 unit 94m 34s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 73m 58s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 25s Patch generated 56 ASF License warnings. 208m 55s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.namenode.TestStartup JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStream   hadoop.hdfs.tools.TestDFSAdminWithHA   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestWriteReadStripedFile   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery   hadoop.hdfs.web.TestWebHdfsFileSystemContract   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776898/HDFS-9514.003.patch JIRA Issue HDFS-9514 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a6388ae45364 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a483017 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13833/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13833/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13833/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13833/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13833/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13833/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.1.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13833/console This message was automatically generated.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8960 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8960/)
          HDFS-9514. TestDistributedFileSystem.testDFSClientPeerWriteTimeout (yzhang: rev bf5295b118a24e762f21bb2b9054e5e0c1d1d14a)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8960 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8960/ ) HDFS-9514 . TestDistributedFileSystem.testDFSClientPeerWriteTimeout (yzhang: rev bf5295b118a24e762f21bb2b9054e5e0c1d1d14a) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java
          Hide
          yzhangal Yongjun Zhang added a comment -

          Committed to trunk, branch-2, and branch-2.8.

          Thanks Steve Loughran for reporting the issue and Wei-Chiu Chuang for the contribution.

          Show
          yzhangal Yongjun Zhang added a comment - Committed to trunk, branch-2, and branch-2.8. Thanks Steve Loughran for reporting the issue and Wei-Chiu Chuang for the contribution.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #690 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/690/)
          HDFS-9514. TestDistributedFileSystem.testDFSClientPeerWriteTimeout (yzhang: rev bf5295b118a24e762f21bb2b9054e5e0c1d1d14a)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #690 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/690/ ) HDFS-9514 . TestDistributedFileSystem.testDFSClientPeerWriteTimeout (yzhang: rev bf5295b118a24e762f21bb2b9054e5e0c1d1d14a) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks Yongjun Zhang for the review and commit, and Steve Loughran for reporting the issue!

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks Yongjun Zhang for the review and commit, and Steve Loughran for reporting the issue!

            People

            • Assignee:
              jojochuang Wei-Chiu Chuang
              Reporter:
              stevel@apache.org Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development