[HDFS-9485] Make BlockManager#removeFromExcessReplicateMap accept BlockInfo instead of Block

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: namenode
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Mingliang Liu
• Reporter: Mingliang Liu
• Created: 30/Nov/15 22:56
• Updated: 30/Aug/16 01:22
• Resolved: 01/Dec/15 21:12

Description

The BlockManager#removeFromExcessReplicateMap() method accepts a Block which is to remove from excessReplicateMap. However the excessReplicateMap maps a StorageID to the set of BlockInfo that are "extra" for the DataNode of the StorageID. Deleting a sub-class object from a collection provided a base-class object happens to work here.

Alternatively, we can make the removeFromExcessReplicateMap accept a BlockInfo object. As the current call stack is passing BlockInfo object mostly, the code change should be safe.

Issue Links

• is required by: HDFS-9442 Move block replication logic from BlockManager to a new class ReplicationManager