[HDFS-9484] NNThroughputBenchmark$BlockReportStats should not send empty block reports

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: test
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Mingliang Liu
• Reporter: Mingliang Liu
• Created: 30/Nov/15 19:13
• Updated: 30/Aug/16 01:22
• Resolved: 03/Dec/15 23:12

Description

There are two potential bugs that make the NNThroughputBenchmark$BlockReportStats send empty block reports.

1. In NNThroughputBenchmark$BlockReportStats#formBlockReport(), the blockReportList is always BlockListAsLongs.EMPTY. We should construct the block report list by encoding generated blocks in test.
2. TinyDatanode#blocks is an empty ArrayList with initial capacity. In TinyDatanode#addBlock() first statement, the if(nrBlocks == blocks.size()) { will always be true. We should either fill the blocks with dummy report in TinyDatanode() constructor, or use initial capacity instead of blocks.size() in the above if statement (we should replace ArrayList#set with ArrayList#add as well).

Issue Links

• is broken by: HDFS-7435 PB encoding of block reports is very inefficient