Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9474

TestPipelinesFailover should not fail when printing debug message

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      HDFS-6693 introduced some debug message to debug why when TestPipelinesFailover fails.

      HDFS-9438 restricted the debug message to Linux/Mac/Solaris. However, the test would fail when printing debug message if "ifconfig" command is not available in certain environment.

      This is not quite right. The test should not fail due to the debug message printing. We should catch any exception thrown from the code that prints debug message, and issue a warning message.

      Suggest to make this change.

      1. HDFS-9474.001.patch
        3 kB
        John Zhuge
      2. HDFS-9474.002.patch
        3 kB
        John Zhuge

        Issue Links

          Activity

          Hide
          yzhangal Yongjun Zhang added a comment -

          Hi John, would you please take a look? thanks.

          Show
          yzhangal Yongjun Zhang added a comment - Hi John, would you please take a look? thanks.
          Hide
          jzhuge John Zhuge added a comment -

          Sure

          John

          Show
          jzhuge John Zhuge added a comment - Sure John
          Hide
          yzhangal Yongjun Zhang added a comment -

          Hi John,

          Thanks for the patch. Two minor:

          1. Suggest to switch from System.println to LOG.info, LOG.warn, etc.
          2. For the stack trace printing, suggest to do LOG.warn("Error when running " + scmd, e)

          Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - Hi John, Thanks for the patch. Two minor: Suggest to switch from System.println to LOG.info , LOG.warn , etc. For the stack trace printing, suggest to do LOG.warn("Error when running " + scmd, e) Thanks.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks for the new rev John. +1 on rev 002 pending jenkins.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks for the new rev John. +1 on rev 002 pending jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 9m 15s trunk passed
          +1 compile 0m 54s trunk passed with JDK v1.8.0_66
          +1 compile 0m 50s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 19s trunk passed
          +1 mvnsite 1m 5s trunk passed
          +1 mvneclipse 0m 19s trunk passed
          +1 findbugs 2m 29s trunk passed
          +1 javadoc 1m 35s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 25s trunk passed with JDK v1.7.0_85
          +1 mvninstall 1m 6s the patch passed
          +1 compile 1m 0s the patch passed with JDK v1.8.0_66
          +1 javac 1m 0s the patch passed
          +1 compile 0m 55s the patch passed with JDK v1.7.0_85
          +1 javac 0m 55s the patch passed
          +1 checkstyle 0m 20s the patch passed
          +1 mvnsite 1m 10s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 37s the patch passed
          +1 javadoc 1m 32s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 22s the patch passed with JDK v1.7.0_85
          -1 unit 80m 33s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 77m 0s hadoop-hdfs in the patch failed with JDK v1.7.0_85.
          -1 asflicense 0m 29s Patch generated 59 ASF License warnings.
          192m 31s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestRecoverStripedFile
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.util.TestStripedBlockUtil
            org.apache.hadoop.hdfs.TestDecommission
            org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure060
          JDK v1.7.0_85 Failed junit tests hadoop.hdfs.TestRecoverStripedFile
            hadoop.hdfs.TestDFSUpgradeFromImage



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774865/HDFS-9474.002.patch
          JIRA Issue HDFS-9474
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 5101f41e36f0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9b8e50b
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13696/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13696/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13696/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13696/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13696/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13696/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13696/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 15s trunk passed +1 compile 0m 54s trunk passed with JDK v1.8.0_66 +1 compile 0m 50s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 19s trunk passed +1 mvnsite 1m 5s trunk passed +1 mvneclipse 0m 19s trunk passed +1 findbugs 2m 29s trunk passed +1 javadoc 1m 35s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 25s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 6s the patch passed +1 compile 1m 0s the patch passed with JDK v1.8.0_66 +1 javac 1m 0s the patch passed +1 compile 0m 55s the patch passed with JDK v1.7.0_85 +1 javac 0m 55s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 1m 10s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 37s the patch passed +1 javadoc 1m 32s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 22s the patch passed with JDK v1.7.0_85 -1 unit 80m 33s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 77m 0s hadoop-hdfs in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 29s Patch generated 59 ASF License warnings. 192m 31s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.util.TestStripedBlockUtil   org.apache.hadoop.hdfs.TestDecommission   org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure060 JDK v1.7.0_85 Failed junit tests hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.TestDFSUpgradeFromImage Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774865/HDFS-9474.002.patch JIRA Issue HDFS-9474 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5101f41e36f0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9b8e50b findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13696/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13696/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13696/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13696/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13696/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13696/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13696/console This message was automatically generated.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Committed to trunk, branch-2 and branch-2.8. Thanks John for the contribution.

          Show
          yzhangal Yongjun Zhang added a comment - Committed to trunk, branch-2 and branch-2.8. Thanks John for the contribution.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8924 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8924/)
          HDFS-9474. TestPipelinesFailover should not fail when printing debug (yzhang: rev 59dbe8b3e96d13c2322cabd87c7f893c5a3812ba)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8924 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8924/ ) HDFS-9474 . TestPipelinesFailover should not fail when printing debug (yzhang: rev 59dbe8b3e96d13c2322cabd87c7f893c5a3812ba) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #666 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/666/)
          HDFS-9474. TestPipelinesFailover should not fail when printing debug (yzhang: rev 59dbe8b3e96d13c2322cabd87c7f893c5a3812ba)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #666 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/666/ ) HDFS-9474 . TestPipelinesFailover should not fail when printing debug (yzhang: rev 59dbe8b3e96d13c2322cabd87c7f893c5a3812ba) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

            People

            • Assignee:
              jzhuge John Zhuge
              Reporter:
              yzhangal Yongjun Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development