[HDFS-9466] TestShortCircuitCache#testDataXceiverCleansUpSlotsOnFailure is flaky

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: fs, hdfs-client
• Target Version/s: 2.8.0
• Assignee: Wei-Chiu Chuang
• Reporter: Wei-Chiu Chuang
• Created: 25/Nov/15 02:33
• Updated: 30/Aug/16 01:22
• Resolved: 16/Jun/16 20:54

Description

This test is flaky and fails quite frequently in trunk.
Error Message
expected:<1> but was:<2>
Stacktrace

java.lang.AssertionError: expected:<1> but was:<2>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:743)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at org.junit.Assert.assertEquals(Assert.java:555)
	at org.junit.Assert.assertEquals(Assert.java:542)
	at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitCache$17.accept(TestShortCircuitCache.java:636)
	at org.apache.hadoop.hdfs.server.datanode.ShortCircuitRegistry.visit(ShortCircuitRegistry.java:395)
	at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitCache.checkNumberOfSegmentsAndSlots(TestShortCircuitCache.java:631)
	at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitCache.testDataXceiverCleansUpSlotsOnFailure(TestShortCircuitCache.java:684)

Thanks to Xiao Chen for identifying the issue.

Issue Links

• breaks: HDFS-7915 The DataNode can sometimes allocate a ShortCircuitShm slot and fail to tell the DFSClient about it because of a network error