Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9458

TestBackupNode always binds to port 50070, which can cause bind failures.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      TestBackupNode does not override port settings to use a dynamically selected port for the NameNode HTTP server. It uses the default of 50070 defined in hdfs-default.xml. This should be changed to select a dynamic port to avoid bind errors.

      1. HDFS-9458.001.patch
        1 kB
        Xiao Chen
      2. HDFS-9458.002.patch
        2 kB
        Xiao Chen

        Issue Links

          Activity

          Hide
          cnauroth Chris Nauroth added a comment -

          I first noticed the problem in a pre-commit run for HDFS-9451. The JDK 8 run showed a failure in TestBackupNode#startBackupNodeWithIncorrectAuthentication. Browsing the code, it looks like it overrides the BackupNode HTTP address, but not the main NameNode HTTP address. Maybe there are similar problems with the RPC ports too. It would be worth a full code review of that suite to check for problems like this.

          https://builds.apache.org/job/PreCommit-HDFS-Build/13631/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt

          Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 29.939 sec <<< FAILURE! - in org.apache.hadoop.hdfs.server.namenode.TestBackupNode
          startBackupNodeWithIncorrectAuthentication(org.apache.hadoop.hdfs.server.namenode.TestBackupNode)  Time elapsed: 0.127 sec  <<< ERROR!
          java.net.BindException: Port in use: 0.0.0.0:50070
          	at sun.nio.ch.Net.bind0(Native Method)
          	at sun.nio.ch.Net.bind(Net.java:433)
          	at sun.nio.ch.Net.bind(Net.java:425)
          	at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
          	at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
          	at org.mortbay.jetty.nio.SelectChannelConnector.open(SelectChannelConnector.java:216)
          	at org.apache.hadoop.http.HttpServer2.openListeners(HttpServer2.java:901)
          	at org.apache.hadoop.http.HttpServer2.start(HttpServer2.java:843)
          	at org.apache.hadoop.hdfs.server.namenode.NameNodeHttpServer.start(NameNodeHttpServer.java:142)
          	at org.apache.hadoop.hdfs.server.namenode.NameNode.startHttpServer(NameNode.java:821)
          	at org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(NameNode.java:675)
          	at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:883)
          	at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:862)
          	at org.apache.hadoop.hdfs.server.namenode.NameNode.createNameNode(NameNode.java:1564)
          	at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.startBackupNodeWithIncorrectAuthentication(TestBackupNode.java:169)
          
          Show
          cnauroth Chris Nauroth added a comment - I first noticed the problem in a pre-commit run for HDFS-9451 . The JDK 8 run showed a failure in TestBackupNode#startBackupNodeWithIncorrectAuthentication . Browsing the code, it looks like it overrides the BackupNode HTTP address, but not the main NameNode HTTP address. Maybe there are similar problems with the RPC ports too. It would be worth a full code review of that suite to check for problems like this. https://builds.apache.org/job/PreCommit-HDFS-Build/13631/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 29.939 sec <<< FAILURE! - in org.apache.hadoop.hdfs.server.namenode.TestBackupNode startBackupNodeWithIncorrectAuthentication(org.apache.hadoop.hdfs.server.namenode.TestBackupNode) Time elapsed: 0.127 sec <<< ERROR! java.net.BindException: Port in use: 0.0.0.0:50070 at sun.nio.ch.Net.bind0(Native Method) at sun.nio.ch.Net.bind(Net.java:433) at sun.nio.ch.Net.bind(Net.java:425) at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223) at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74) at org.mortbay.jetty.nio.SelectChannelConnector.open(SelectChannelConnector.java:216) at org.apache.hadoop.http.HttpServer2.openListeners(HttpServer2.java:901) at org.apache.hadoop.http.HttpServer2.start(HttpServer2.java:843) at org.apache.hadoop.hdfs.server.namenode.NameNodeHttpServer.start(NameNodeHttpServer.java:142) at org.apache.hadoop.hdfs.server.namenode.NameNode.startHttpServer(NameNode.java:821) at org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(NameNode.java:675) at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:883) at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:862) at org.apache.hadoop.hdfs.server.namenode.NameNode.createNameNode(NameNode.java:1564) at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.startBackupNodeWithIncorrectAuthentication(TestBackupNode.java:169)
          Hide
          yzhangal Yongjun Zhang added a comment -

          HI Chris Nauroth,

          Thanks for creating this jira. I posted patch for a similar issue (a different testcase) at HDFS-6054 a while back, if you could help review, I'd really appreciate it. Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - HI Chris Nauroth , Thanks for creating this jira. I posted patch for a similar issue (a different testcase) at HDFS-6054 a while back, if you could help review, I'd really appreciate it. Thanks.
          Hide
          xiaochen Xiao Chen added a comment -

          First, thanks Chris Nauroth for pointing me to this JIRA from HDFS-9512. My initial search didn't land me here. Yongjun Zhang's HDFS-6054 seems to be another case so I think we can do it in parallel.

          I took Chris' advice in the comment, and reviewed around TestBackupNode, didn't find similar problems other than the NN http port. I did see that NN backup http port was unnecessarily set twice. Attached patch 1 to reflex the change.
          Locally tested with nc -l 50070 to make sure the test fails without the fix, passes with. Also tried with the configured rpc port 1234, and the test can pass. Please help review. Thanks!

          BTW, looks like Xiaobing Zhou accidentally assigned this to me, so I'd take the coincidence for now.

          Show
          xiaochen Xiao Chen added a comment - First, thanks Chris Nauroth for pointing me to this JIRA from HDFS-9512 . My initial search didn't land me here. Yongjun Zhang 's HDFS-6054 seems to be another case so I think we can do it in parallel. I took Chris' advice in the comment, and reviewed around TestBackupNode , didn't find similar problems other than the NN http port. I did see that NN backup http port was unnecessarily set twice. Attached patch 1 to reflex the change. Locally tested with nc -l 50070 to make sure the test fails without the fix, passes with. Also tried with the configured rpc port 1234, and the test can pass. Please help review. Thanks! BTW, looks like Xiaobing Zhou accidentally assigned this to me, so I'd take the coincidence for now.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 10m 35s trunk passed
          +1 compile 1m 2s trunk passed with JDK v1.8.0_66
          +1 compile 0m 56s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 20s trunk passed
          +1 mvnsite 1m 11s trunk passed
          +1 mvneclipse 0m 17s trunk passed
          +1 findbugs 2m 26s trunk passed
          +1 javadoc 1m 31s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 29s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 3s the patch passed
          +1 compile 1m 3s the patch passed with JDK v1.8.0_66
          +1 javac 1m 3s the patch passed
          +1 compile 0m 56s the patch passed with JDK v1.7.0_91
          +1 javac 0m 56s the patch passed
          +1 checkstyle 0m 20s the patch passed
          +1 mvnsite 1m 9s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 37s the patch passed
          +1 javadoc 1m 34s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 28s the patch passed with JDK v1.7.0_91
          -1 unit 79m 17s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 70m 1s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 24s Patch generated 56 ASF License warnings.
          198m 51s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure200
            hadoop.hdfs.server.datanode.TestDataNodeMetrics
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
            hadoop.hdfs.TestEncryptionZones
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776481/HDFS-9458.001.patch
          JIRA Issue HDFS-9458
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3c80bb3ec69e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 15c3e7f
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13810/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13810/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13810/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13810/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13810/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13810/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13810/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 10m 35s trunk passed +1 compile 1m 2s trunk passed with JDK v1.8.0_66 +1 compile 0m 56s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 20s trunk passed +1 mvnsite 1m 11s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 2m 26s trunk passed +1 javadoc 1m 31s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 29s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 3s the patch passed +1 compile 1m 3s the patch passed with JDK v1.8.0_66 +1 javac 1m 3s the patch passed +1 compile 0m 56s the patch passed with JDK v1.7.0_91 +1 javac 0m 56s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 1m 9s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 37s the patch passed +1 javadoc 1m 34s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 28s the patch passed with JDK v1.7.0_91 -1 unit 79m 17s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 70m 1s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 24s Patch generated 56 ASF License warnings. 198m 51s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure200   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock   hadoop.hdfs.TestEncryptionZones JDK v1.7.0_91 Failed junit tests hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776481/HDFS-9458.001.patch JIRA Issue HDFS-9458 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3c80bb3ec69e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 15c3e7f findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13810/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13810/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13810/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13810/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13810/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13810/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13810/console This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -

          The test failures and license warnings are unrelated to this patch.

          Show
          xiaochen Xiao Chen added a comment - The test failures and license warnings are unrelated to this patch.
          Hide
          cnauroth Chris Nauroth added a comment -

          Xiao Chen, thank you for the patch.

          I think we still need to keep the line that sets DFS_NAMENODE_HTTP_ADDRESS_KEY. This test starts both a regular NameNode and a BackupNode. We'll want to avoid binding to default ports for both of those.

          It's also problematic that the NameNode RPC port is hard-coded to 1234 (FS_DEFAULT_NAME_KEY). I recommend that we change that to 0 too.

          Show
          cnauroth Chris Nauroth added a comment - Xiao Chen , thank you for the patch. I think we still need to keep the line that sets DFS_NAMENODE_HTTP_ADDRESS_KEY . This test starts both a regular NameNode and a BackupNode. We'll want to avoid binding to default ports for both of those. It's also problematic that the NameNode RPC port is hard-coded to 1234 ( FS_DEFAULT_NAME_KEY ). I recommend that we change that to 0 too.
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks Chris Nauroth for the comments! Attached patch 2.

          I think we still need to keep the line that sets DFS_NAMENODE_HTTP_ADDRESS_KEY. This test starts both a regular NameNode and a BackupNode. We'll want to avoid binding to default ports for both of those.

          I think you meant to say we need DFS_NAMENODE_BACKUP_HTTP_ADDRESS_KEY? This was unnecessarily set twice. I kept the line that sets it at line 161 (line # in trunk), the patch removed the first one.

          It's also problematic that the NameNode RPC port is hard-coded to 1234 (FS_DEFAULT_NAME_KEY). I recommend that we change that to 0 too.

          We can't set it to 0 here because in BackupNode#initialize where handshake is invoked, rpc address is read from configuration. Thus we need to set it to a port numer. I have just learnt that we have a util to get a usable ephemeral port, so updated patch 2 to use ServerSocketUtil#getport.

          Show
          xiaochen Xiao Chen added a comment - Thanks Chris Nauroth for the comments! Attached patch 2. I think we still need to keep the line that sets DFS_NAMENODE_HTTP_ADDRESS_KEY . This test starts both a regular NameNode and a BackupNode. We'll want to avoid binding to default ports for both of those. I think you meant to say we need DFS_NAMENODE_BACKUP_HTTP_ADDRESS_KEY ? This was unnecessarily set twice. I kept the line that sets it at line 161 (line # in trunk), the patch removed the first one. It's also problematic that the NameNode RPC port is hard-coded to 1234 (FS_DEFAULT_NAME_KEY). I recommend that we change that to 0 too. We can't set it to 0 here because in BackupNode#initialize where handshake is invoked, rpc address is read from configuration. Thus we need to set it to a port numer. I have just learnt that we have a util to get a usable ephemeral port, so updated patch 2 to use ServerSocketUtil#getport .
          Hide
          cnauroth Chris Nauroth added a comment -

          Xiao Chen, thank you for clarifying. Patch v002 looks good to me. +1, pending another Jenkins run.

          Show
          cnauroth Chris Nauroth added a comment - Xiao Chen , thank you for clarifying. Patch v002 looks good to me. +1, pending another Jenkins run.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 6s trunk passed
          +1 compile 0m 45s trunk passed with JDK v1.8.0_66
          +1 compile 0m 43s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 17s trunk passed
          +1 mvnsite 0m 56s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 2m 4s trunk passed
          +1 javadoc 1m 10s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 52s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 52s the patch passed
          +1 compile 0m 44s the patch passed with JDK v1.8.0_66
          +1 javac 0m 44s the patch passed
          +1 compile 0m 44s the patch passed with JDK v1.7.0_91
          +1 javac 0m 44s the patch passed
          +1 checkstyle 0m 17s the patch passed
          +1 mvnsite 0m 55s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 16s the patch passed
          +1 javadoc 1m 10s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 55s the patch passed with JDK v1.7.0_91
          -1 unit 61m 17s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 54m 47s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 30s Patch does not generate ASF License warnings.
          144m 36s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.TestMiniDFSCluster
            hadoop.hdfs.TestGetFileChecksum
            hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.namenode.ha.TestHAMetrics
            hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.server.namenode.TestNNThroughputBenchmark



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778923/HDFS-9458.002.patch
          JIRA Issue HDFS-9458
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c6f2f3a981e0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a0de702
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13966/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13966/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13966/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13966/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13966/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13966/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 6s trunk passed +1 compile 0m 45s trunk passed with JDK v1.8.0_66 +1 compile 0m 43s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 17s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 2m 4s trunk passed +1 javadoc 1m 10s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 52s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 52s the patch passed +1 compile 0m 44s the patch passed with JDK v1.8.0_66 +1 javac 0m 44s the patch passed +1 compile 0m 44s the patch passed with JDK v1.7.0_91 +1 javac 0m 44s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 16s the patch passed +1 javadoc 1m 10s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 55s the patch passed with JDK v1.7.0_91 -1 unit 61m 17s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 54m 47s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 30s Patch does not generate ASF License warnings. 144m 36s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.TestMiniDFSCluster   hadoop.hdfs.TestGetFileChecksum   hadoop.hdfs.server.namenode.TestFSImageWithSnapshot   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.namenode.ha.TestHAMetrics   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778923/HDFS-9458.002.patch JIRA Issue HDFS-9458 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c6f2f3a981e0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a0de702 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13966/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13966/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13966/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13966/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13966/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13966/console This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -

          Thank you Chris Nauroth!
          The failed tests look unrelated to this patch.

          Show
          xiaochen Xiao Chen added a comment - Thank you Chris Nauroth ! The failed tests look unrelated to this patch.
          Hide
          cnauroth Chris Nauroth added a comment -

          I have committed this to trunk, branch-2 and branch-2.8. Xiao, thank you for the patch.

          Show
          cnauroth Chris Nauroth added a comment - I have committed this to trunk, branch-2 and branch-2.8. Xiao, thank you for the patch.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9014 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9014/)
          HDFS-9458. TestBackupNode always binds to port 50070, which can cause (cnauroth: rev 5c0ff69618fa303078c0f9afef4c93a864ab6cb7)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9014 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9014/ ) HDFS-9458 . TestBackupNode always binds to port 50070, which can cause (cnauroth: rev 5c0ff69618fa303078c0f9afef4c93a864ab6cb7) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
          Hide
          xiaochen Xiao Chen added a comment -

          Thank you for the review and commit Chris.

          Show
          xiaochen Xiao Chen added a comment - Thank you for the review and commit Chris.

            People

            • Assignee:
              xiaochen Xiao Chen
              Reporter:
              cnauroth Chris Nauroth
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development