Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9444

Add utility to find set of available ephemeral ports to ServerSocketUtil

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Unit tests using MiniDFSCluster with namanode-ha enabled need set of port numbers in advance. Because namenodes talk to each other, we can not set ipc port to 0 in configuration to make namenodes decide port number on its own. ServerSocketUtil should provide utility to find set of available ephemeral port numbers for this.

      For example, TestEditLogTailer could fail due to java.net.BindException: Address already in use.

      https://builds.apache.org/job/Hadoop-Hdfs-trunk/2556/testReport/

      java.net.BindException: Problem binding to [localhost:42477] java.net.BindException: Address already in use; For more details see:  http://wiki.apache.org/hadoop/BindException
      	at sun.nio.ch.Net.bind0(Native Method)
      	at sun.nio.ch.Net.bind(Net.java:444)
      	at sun.nio.ch.Net.bind(Net.java:436)
      	at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:214)
      	at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
      	at org.apache.hadoop.ipc.Server.bind(Server.java:469)
      	at org.apache.hadoop.ipc.Server$Listener.<init>(Server.java:695)
      	at org.apache.hadoop.ipc.Server.<init>(Server.java:2464)
      	at org.apache.hadoop.ipc.RPC$Server.<init>(RPC.java:945)
      	at org.apache.hadoop.ipc.ProtobufRpcEngine$Server.<init>(ProtobufRpcEngine.java:535)
      	at org.apache.hadoop.ipc.ProtobufRpcEngine.getServer(ProtobufRpcEngine.java:510)
      	at org.apache.hadoop.ipc.RPC$Builder.build(RPC.java:787)
      	at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.<init>(NameNodeRpcServer.java:390)
      	at org.apache.hadoop.hdfs.server.namenode.NameNode.createRpcServer(NameNode.java:742)
      	at org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(NameNode.java:680)
      	at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:883)
      	at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:862)
      	at org.apache.hadoop.hdfs.server.namenode.NameNode.createNameNode(NameNode.java:1564)
      	at org.apache.hadoop.hdfs.MiniDFSCluster.createNameNode(MiniDFSCluster.java:1247)
      	at org.apache.hadoop.hdfs.MiniDFSCluster.configureNameService(MiniDFSCluster.java:1016)
      	at org.apache.hadoop.hdfs.MiniDFSCluster.createNameNodesAndSetConf(MiniDFSCluster.java:891)
      	at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:823)
      	at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:482)
      	at org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:441)
      	at org.apache.hadoop.hdfs.server.namenode.ha.TestEditLogTailer.testStandbyTriggersLogRolls(TestEditLogTailer.java:139)
      	at org.apache.hadoop.hdfs.server.namenode.ha.TestEditLogTailer.testNN1TriggersLogRolls(TestEditLogTailer.java:114)
      
      1. HDFS-9444-branch-2.007.patch
        7 kB
        Masatake Iwasaki
      2. HDFS-9444-branch-2.006.patch
        6 kB
        Masatake Iwasaki
      3. HDFS-9444.006.patch
        7 kB
        Xiao Chen
      4. HDFS-9444.005.patch
        7 kB
        Xiao Chen
      5. HDFS-9444.004.patch
        7 kB
        Masatake Iwasaki
      6. HDFS-9444.003.patch
        4 kB
        Masatake Iwasaki
      7. HDFS-9444.002.patch
        4 kB
        Masatake Iwasaki
      8. HDFS-9444.001.patch
        3 kB
        Masatake Iwasaki

        Issue Links

          Activity

          Hide
          iwasakims Masatake Iwasaki added a comment -

          There is no way to prevent other processes from using the port given by ServerSocketUtil#getPort before binding it. Because each namenodes must know addresses of other namenodes on startup, making namenodes decide ipc port on its own (by setting port to 0 in conf) does not work here. Making NameNode reconfigurable just for unit test is overkill. I think adding retries on starting up mini cluster is reasonable solution here, if this is not so rare situation.

          Show
          iwasakims Masatake Iwasaki added a comment - There is no way to prevent other processes from using the port given by ServerSocketUtil#getPort before binding it. Because each namenodes must know addresses of other namenodes on startup, making namenodes decide ipc port on its own (by setting port to 0 in conf) does not work here. Making NameNode reconfigurable just for unit test is overkill. I think adding retries on starting up mini cluster is reasonable solution here, if this is not so rare situation.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          FWIW, the technique I use for finding > 1 free port is to allocate all the server sockets before releasing any of them, in the scala code FreePortFinder. A version in Hadoop would address this problem

          Show
          stevel@apache.org Steve Loughran added a comment - FWIW, the technique I use for finding > 1 free port is to allocate all the server sockets before releasing any of them, in the scala code FreePortFinder . A version in Hadoop would address this problem
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Thanks for the input, Steve Loughran. I think the ports given by the findUniquePorts is still possible to be used other process in parallel testing environment but it improve the situation. I'm attaching 002 which adds Java equivalent.

          Show
          iwasakims Masatake Iwasaki added a comment - Thanks for the input, Steve Loughran . I think the ports given by the findUniquePorts is still possible to be used other process in parallel testing environment but it improve the situation. I'm attaching 002 which adds Java equivalent.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 42s trunk passed
          +1 compile 7m 59s trunk passed with JDK v1.8.0_66
          +1 compile 8m 55s trunk passed with JDK v1.7.0_85
          +1 checkstyle 1m 0s trunk passed
          +1 mvnsite 1m 54s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          +1 findbugs 3m 45s trunk passed
          +1 javadoc 2m 0s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 51s trunk passed with JDK v1.7.0_85
          +1 mvninstall 2m 26s the patch passed
          +1 compile 8m 28s the patch passed with JDK v1.8.0_66
          +1 javac 8m 27s the patch passed
          +1 compile 8m 45s the patch passed with JDK v1.7.0_85
          +1 javac 8m 45s the patch passed
          +1 checkstyle 0m 57s the patch passed
          +1 mvnsite 1m 54s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 4m 6s the patch passed
          +1 javadoc 2m 0s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 57s the patch passed with JDK v1.7.0_85
          +1 unit 7m 35s hadoop-common in the patch passed with JDK v1.8.0_66.
          -1 unit 51m 25s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          +1 unit 7m 22s hadoop-common in the patch passed with JDK v1.7.0_85.
          +1 unit 48m 57s hadoop-hdfs in the patch passed with JDK v1.7.0_85.
          -1 asflicense 0m 20s Patch generated 58 ASF License warnings.
          185m 32s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMetrics
            hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774642/HDFS-9444.002.patch
          JIRA Issue HDFS-9444
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 50d79a84e22c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9f256d1
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13683/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13683/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13683/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13683/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13683/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Max memory used 75MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13683/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 42s trunk passed +1 compile 7m 59s trunk passed with JDK v1.8.0_66 +1 compile 8m 55s trunk passed with JDK v1.7.0_85 +1 checkstyle 1m 0s trunk passed +1 mvnsite 1m 54s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 3m 45s trunk passed +1 javadoc 2m 0s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 51s trunk passed with JDK v1.7.0_85 +1 mvninstall 2m 26s the patch passed +1 compile 8m 28s the patch passed with JDK v1.8.0_66 +1 javac 8m 27s the patch passed +1 compile 8m 45s the patch passed with JDK v1.7.0_85 +1 javac 8m 45s the patch passed +1 checkstyle 0m 57s the patch passed +1 mvnsite 1m 54s the patch passed +1 mvneclipse 0m 26s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 4m 6s the patch passed +1 javadoc 2m 0s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 57s the patch passed with JDK v1.7.0_85 +1 unit 7m 35s hadoop-common in the patch passed with JDK v1.8.0_66. -1 unit 51m 25s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 7m 22s hadoop-common in the patch passed with JDK v1.7.0_85. +1 unit 48m 57s hadoop-hdfs in the patch passed with JDK v1.7.0_85. -1 asflicense 0m 20s Patch generated 58 ASF License warnings. 185m 32s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774642/HDFS-9444.002.patch JIRA Issue HDFS-9444 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 50d79a84e22c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9f256d1 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13683/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13683/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13683/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13683/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13683/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13683/console This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks Masatake Iwasaki for working on this. I agree with you that it's still possible for the ports to conflict but improves this test. 2 minor comments:

          • Could you add more details to the javadoc of ServerSocketUtil#getPorts? Something similar to the scala comments would do.
          • Also, shall we mark ServerSocketUtil#getPorts as @VisibleForTesting? Not sure if you plan to address similar issues in other places.
          Show
          xiaochen Xiao Chen added a comment - Thanks Masatake Iwasaki for working on this. I agree with you that it's still possible for the ports to conflict but improves this test. 2 minor comments: Could you add more details to the javadoc of ServerSocketUtil#getPorts ? Something similar to the scala comments would do. Also, shall we mark ServerSocketUtil#getPorts as @VisibleForTesting ? Not sure if you plan to address similar issues in other places.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Thanks for the comments, Xiao Chen.

          Could you add more details to the javadoc of ServerSocketUtil#getPorts? Something similar to the scala comments would do.

          Sure. I added comments.

          shall we mark ServerSocketUtil#getPorts as @VisibleForTesting? Not sure if you plan to address similar issues in other places.

          I think we don't need @VisibleForTesting here because the ServerSocketUtil.java is under src/test and getPorts is intended to be used by other tests.

          Show
          iwasakims Masatake Iwasaki added a comment - Thanks for the comments, Xiao Chen . Could you add more details to the javadoc of ServerSocketUtil#getPorts? Something similar to the scala comments would do. Sure. I added comments. shall we mark ServerSocketUtil#getPorts as @VisibleForTesting? Not sure if you plan to address similar issues in other places. I think we don't need @VisibleForTesting here because the ServerSocketUtil.java is under src/test and getPorts is intended to be used by other tests.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 41s trunk passed
          +1 compile 11m 36s trunk passed with JDK v1.8.0_66
          +1 compile 11m 0s trunk passed with JDK v1.7.0_85
          +1 checkstyle 1m 15s trunk passed
          +1 mvnsite 2m 26s trunk passed
          +1 mvneclipse 0m 34s trunk passed
          +1 findbugs 4m 41s trunk passed
          +1 javadoc 2m 42s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 41s trunk passed with JDK v1.7.0_85
          +1 mvninstall 2m 55s the patch passed
          +1 compile 11m 23s the patch passed with JDK v1.8.0_66
          +1 javac 11m 23s the patch passed
          +1 compile 11m 8s the patch passed with JDK v1.7.0_85
          +1 javac 11m 8s the patch passed
          +1 checkstyle 1m 15s the patch passed
          +1 mvnsite 2m 20s the patch passed
          +1 mvneclipse 0m 33s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 5m 12s the patch passed
          +1 javadoc 2m 44s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 47s the patch passed with JDK v1.7.0_85
          -1 unit 8m 8s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 65m 2s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          +1 unit 16m 2s hadoop-common in the patch passed with JDK v1.7.0_85.
          -1 unit 58m 31s hadoop-hdfs in the patch failed with JDK v1.7.0_85.
          -1 asflicense 0m 20s Patch generated 56 ASF License warnings.
          237m 36s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestIPC
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
          JDK v1.7.0_85 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache
            hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774963/HDFS-9444.003.patch
          JIRA Issue HDFS-9444
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 040d827f733f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1c05393
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13703/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13703/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13703/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13703/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13703/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13703/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13703/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13703/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13703/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 41s trunk passed +1 compile 11m 36s trunk passed with JDK v1.8.0_66 +1 compile 11m 0s trunk passed with JDK v1.7.0_85 +1 checkstyle 1m 15s trunk passed +1 mvnsite 2m 26s trunk passed +1 mvneclipse 0m 34s trunk passed +1 findbugs 4m 41s trunk passed +1 javadoc 2m 42s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 41s trunk passed with JDK v1.7.0_85 +1 mvninstall 2m 55s the patch passed +1 compile 11m 23s the patch passed with JDK v1.8.0_66 +1 javac 11m 23s the patch passed +1 compile 11m 8s the patch passed with JDK v1.7.0_85 +1 javac 11m 8s the patch passed +1 checkstyle 1m 15s the patch passed +1 mvnsite 2m 20s the patch passed +1 mvneclipse 0m 33s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 5m 12s the patch passed +1 javadoc 2m 44s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 47s the patch passed with JDK v1.7.0_85 -1 unit 8m 8s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 65m 2s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 16m 2s hadoop-common in the patch passed with JDK v1.7.0_85. -1 unit 58m 31s hadoop-hdfs in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 20s Patch generated 56 ASF License warnings. 237m 36s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestIPC   hadoop.hdfs.security.TestDelegationTokenForProxyUser JDK v1.7.0_85 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774963/HDFS-9444.003.patch JIRA Issue HDFS-9444 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 040d827f733f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1c05393 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13703/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13703/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13703/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13703/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13703/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13703/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13703/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13703/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13703/console This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks Masatake Iwasaki, yeah I think that's fine. IMO it'd be nice to fix other tests (only found TestNameNodeMXBean#testNNDirectorySize) here though. That may be off the topic of this JIRA title, but why not fixing it since we found it - we can always update the JIRA title. +1 (non-binding) after that.

          Show
          xiaochen Xiao Chen added a comment - Thanks Masatake Iwasaki , yeah I think that's fine. IMO it'd be nice to fix other tests (only found TestNameNodeMXBean#testNNDirectorySize ) here though. That may be off the topic of this JIRA title, but why not fixing it since we found it - we can always update the JIRA title. +1 (non-binding) after that.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          I added fix to TestNameNodeMXBean and updated summary. Thanks for the suggestion, Xiao Chen.

          Show
          iwasakims Masatake Iwasaki added a comment - I added fix to TestNameNodeMXBean and updated summary. Thanks for the suggestion, Xiao Chen .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 8m 2s trunk passed
          +1 compile 9m 0s trunk passed with JDK v1.8.0_66
          +1 compile 9m 42s trunk passed with JDK v1.7.0_85
          +1 checkstyle 1m 3s trunk passed
          +1 mvnsite 2m 2s trunk passed
          +1 mvneclipse 0m 30s trunk passed
          +1 findbugs 3m 56s trunk passed
          +1 javadoc 2m 6s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 0s trunk passed with JDK v1.7.0_85
          +1 mvninstall 2m 34s the patch passed
          +1 compile 8m 32s the patch passed with JDK v1.8.0_66
          +1 javac 8m 32s the patch passed
          +1 compile 9m 15s the patch passed with JDK v1.7.0_85
          +1 javac 9m 15s the patch passed
          +1 checkstyle 1m 3s the patch passed
          +1 mvnsite 2m 1s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 23s the patch passed
          +1 javadoc 2m 8s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 0s the patch passed with JDK v1.7.0_85
          -1 unit 7m 44s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 54m 26s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 7m 55s hadoop-common in the patch failed with JDK v1.7.0_85.
          +1 unit 52m 37s hadoop-hdfs in the patch passed with JDK v1.7.0_85.
          -1 asflicense 0m 19s Patch generated 56 ASF License warnings.
          197m 5s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.security.ssl.TestReloadingX509TrustManager
            hadoop.fs.TestFsShellReturnCode
            hadoop.hdfs.TestRollingUpgrade
            hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.server.balancer.TestBalancer
          JDK v1.7.0_85 Failed junit tests hadoop.fs.TestLocalFsFCStatistics



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775520/HDFS-9444.004.patch
          JIRA Issue HDFS-9444
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux dcbb9ca596b4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3857fed2
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13750/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13750/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13750/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13750/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13750/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13750/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13750/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13750/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13750/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 8m 2s trunk passed +1 compile 9m 0s trunk passed with JDK v1.8.0_66 +1 compile 9m 42s trunk passed with JDK v1.7.0_85 +1 checkstyle 1m 3s trunk passed +1 mvnsite 2m 2s trunk passed +1 mvneclipse 0m 30s trunk passed +1 findbugs 3m 56s trunk passed +1 javadoc 2m 6s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 0s trunk passed with JDK v1.7.0_85 +1 mvninstall 2m 34s the patch passed +1 compile 8m 32s the patch passed with JDK v1.8.0_66 +1 javac 8m 32s the patch passed +1 compile 9m 15s the patch passed with JDK v1.7.0_85 +1 javac 9m 15s the patch passed +1 checkstyle 1m 3s the patch passed +1 mvnsite 2m 1s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 23s the patch passed +1 javadoc 2m 8s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 0s the patch passed with JDK v1.7.0_85 -1 unit 7m 44s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 54m 26s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 7m 55s hadoop-common in the patch failed with JDK v1.7.0_85. +1 unit 52m 37s hadoop-hdfs in the patch passed with JDK v1.7.0_85. -1 asflicense 0m 19s Patch generated 56 ASF License warnings. 197m 5s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.security.ssl.TestReloadingX509TrustManager   hadoop.fs.TestFsShellReturnCode   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.balancer.TestBalancer JDK v1.7.0_85 Failed junit tests hadoop.fs.TestLocalFsFCStatistics Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775520/HDFS-9444.004.patch JIRA Issue HDFS-9444 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dcbb9ca596b4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3857fed2 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13750/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13750/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13750/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13750/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13750/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13750/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13750/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13750/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13750/console This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -

          Found this jira, and would love to see the ServerSocketUtil enhancement.
          Patch doesn't apply to trunk anymore, attaching a rebased one.

          Show
          xiaochen Xiao Chen added a comment - Found this jira, and would love to see the ServerSocketUtil enhancement. Patch doesn't apply to trunk anymore, attaching a rebased one.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 1m 32s Maven dependency ordering for branch
          +1 mvninstall 7m 7s trunk passed
          +1 compile 6m 55s trunk passed
          +1 checkstyle 1m 27s trunk passed
          +1 mvnsite 1m 47s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 3m 0s trunk passed
          +1 javadoc 1m 39s trunk passed
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 33s the patch passed
          +1 compile 8m 2s the patch passed
          +1 javac 8m 2s the patch passed
          -0 checkstyle 1m 33s root: The patch generated 2 new + 25 unchanged - 3 fixed = 27 total (was 28)
          +1 mvnsite 2m 1s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 45s the patch passed
          +1 javadoc 1m 47s the patch passed
          +1 unit 8m 42s hadoop-common in the patch passed.
          +1 unit 66m 42s hadoop-hdfs in the patch passed.
          +1 asflicense 0m 28s The patch does not generate ASF License warnings.
          120m 11s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-9444
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829963/HDFS-9444.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 2150bbd7d340 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5ffd4b7
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16836/artifact/patchprocess/diff-checkstyle-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16836/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16836/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 1m 32s Maven dependency ordering for branch +1 mvninstall 7m 7s trunk passed +1 compile 6m 55s trunk passed +1 checkstyle 1m 27s trunk passed +1 mvnsite 1m 47s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 3m 0s trunk passed +1 javadoc 1m 39s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 33s the patch passed +1 compile 8m 2s the patch passed +1 javac 8m 2s the patch passed -0 checkstyle 1m 33s root: The patch generated 2 new + 25 unchanged - 3 fixed = 27 total (was 28) +1 mvnsite 2m 1s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 45s the patch passed +1 javadoc 1m 47s the patch passed +1 unit 8m 42s hadoop-common in the patch passed. +1 unit 66m 42s hadoop-hdfs in the patch passed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 120m 11s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-9444 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829963/HDFS-9444.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2150bbd7d340 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5ffd4b7 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16836/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16836/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16836/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -

          Attaching a patch 006 to fix checkstyle.

          Masatake Iwasaki, could you take a look? Thanks.

          Show
          xiaochen Xiao Chen added a comment - Attaching a patch 006 to fix checkstyle. Masatake Iwasaki , could you take a look? Thanks.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 7m 58s trunk passed
          +1 compile 7m 53s trunk passed
          +1 checkstyle 1m 32s trunk passed
          +1 mvnsite 2m 4s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          +1 findbugs 3m 14s trunk passed
          +1 javadoc 1m 49s trunk passed
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 42s the patch passed
          +1 compile 8m 14s the patch passed
          +1 javac 8m 14s the patch passed
          +1 checkstyle 1m 34s root: The patch generated 0 new + 25 unchanged - 3 fixed = 25 total (was 28)
          +1 mvnsite 1m 56s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 53s the patch passed
          +1 javadoc 1m 53s the patch passed
          +1 unit 8m 40s hadoop-common in the patch passed.
          -1 unit 64m 15s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          119m 34s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeLifeline
            hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-9444
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830095/HDFS-9444.006.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 02f3812e2e39 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 74b3dd5
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16844/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16844/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16844/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 7m 58s trunk passed +1 compile 7m 53s trunk passed +1 checkstyle 1m 32s trunk passed +1 mvnsite 2m 4s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 3m 14s trunk passed +1 javadoc 1m 49s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 42s the patch passed +1 compile 8m 14s the patch passed +1 javac 8m 14s the patch passed +1 checkstyle 1m 34s root: The patch generated 0 new + 25 unchanged - 3 fixed = 25 total (was 28) +1 mvnsite 1m 56s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 53s the patch passed +1 javadoc 1m 53s the patch passed +1 unit 8m 40s hadoop-common in the patch passed. -1 unit 64m 15s hadoop-hdfs in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 119m 34s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeLifeline   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-9444 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830095/HDFS-9444.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 02f3812e2e39 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 74b3dd5 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/16844/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16844/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16844/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          thanks Masatake Iwasaki and Xiao Chen for great work here..Overall patch looks good to me..

          one minor nit :

          can we change methode name like getFreePorts..? what do you think..?

          Show
          brahmareddy Brahma Reddy Battula added a comment - thanks Masatake Iwasaki and Xiao Chen for great work here..Overall patch looks good to me.. one minor nit : can we change methode name like getFreePorts..? what do you think..?
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Thanks for the update, Xiao Chen. The 006 looks good to me.

          can we change methode name like getFreePorts..? what do you think..?

          Both getPorts and getFreePorts is fine to me. Ideally ServerSocketUtils#getPort should have consistent naming but it is already used in many tests. I don't think it's worth to deprecate it.

          Show
          iwasakims Masatake Iwasaki added a comment - Thanks for the update, Xiao Chen . The 006 looks good to me. can we change methode name like getFreePorts..? what do you think..? Both getPorts and getFreePorts is fine to me. Ideally ServerSocketUtils#getPort should have consistent naming but it is already used in many tests. I don't think it's worth to deprecate it.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          I thought only for new method which is following..it's ok to me keep consistency with ServerSocketUtils#getPort

          public static int[] getPorts(int numPorts) throws IOException {
          116	    ServerSocket[] sockets = new ServerSocket[numPorts];
          117	    int[] ports = new int[numPorts];
          118	    for (int i = 0; i < numPorts; i++) {
          119	      ServerSocket sock = new ServerSocket(0);
          120	      sockets[i] = sock;
          121	      ports[i] = sock.getLocalPort();
          122	    }
          123	    for (ServerSocket sock : sockets) {
          124	      sock.close();
          125	    }
          126	    return ports;
          127	  }
          

          will wait for commit till Xiao Chen gives his view on this comment..

          Show
          brahmareddy Brahma Reddy Battula added a comment - I thought only for new method which is following..it's ok to me keep consistency with ServerSocketUtils#getPort public static int [] getPorts( int numPorts) throws IOException { 116 ServerSocket[] sockets = new ServerSocket[numPorts]; 117 int [] ports = new int [numPorts]; 118 for ( int i = 0; i < numPorts; i++) { 119 ServerSocket sock = new ServerSocket(0); 120 sockets[i] = sock; 121 ports[i] = sock.getLocalPort(); 122 } 123 for (ServerSocket sock : sockets) { 124 sock.close(); 125 } 126 return ports; 127 } will wait for commit till Xiao Chen gives his view on this comment..
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks for the reviews Masatake Iwasaki and Brahma Reddy Battula.

          I also feel naming consistency with getPort is more important, to indicate this new method is the same intention but returns multiple ports.

          Show
          xiaochen Xiao Chen added a comment - Thanks for the reviews Masatake Iwasaki and Brahma Reddy Battula . I also feel naming consistency with getPort is more important, to indicate this new method is the same intention but returns multiple ports.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Ok.. will commit..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Ok.. will commit..
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Committed to trunk...Masatake Iwasaki patch will not directly apply branch-2, there is a conflict in TestEditLogTailer . can you upload branch-2 patch..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Committed to trunk... Masatake Iwasaki patch will not directly apply branch-2, there is a conflict in TestEditLogTailer . can you upload branch-2 patch..
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10492 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10492/)
          HDFS-9444. Add utility to find set of available ephemeral ports to (brahma: rev edf0d0f8b2115d4edb5d4932b5ecb15430d94c40)

          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/ServerSocketUtil.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestEditLogTailer.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10492 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10492/ ) HDFS-9444 . Add utility to find set of available ephemeral ports to (brahma: rev edf0d0f8b2115d4edb5d4932b5ecb15430d94c40) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/ServerSocketUtil.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestEditLogTailer.java
          Hide
          iwasakims Masatake Iwasaki added a comment -

          I attached branch-2 patch. Thanks, Brahma Reddy Battula.

          Show
          iwasakims Masatake Iwasaki added a comment - I attached branch-2 patch. Thanks, Brahma Reddy Battula .
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Masatake Iwasaki thanks for uploading the branch-2 patch..

          following import is required in TestEditLogTailer.java
          import static org.junit.Assert.fail;. can you check once..?

          Show
          brahmareddy Brahma Reddy Battula added a comment - Masatake Iwasaki thanks for uploading the branch-2 patch.. following import is required in TestEditLogTailer.java import static org.junit.Assert.fail; . can you check once..?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 13m 31s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 50s Maven dependency ordering for branch
          +1 mvninstall 7m 13s branch-2 passed
          +1 compile 6m 31s branch-2 passed with JDK v1.8.0_101
          +1 compile 7m 4s branch-2 passed with JDK v1.7.0_111
          +1 checkstyle 1m 29s branch-2 passed
          +1 mvnsite 1m 55s branch-2 passed
          +1 mvneclipse 0m 32s branch-2 passed
          +1 findbugs 3m 47s branch-2 passed
          +1 javadoc 1m 49s branch-2 passed with JDK v1.8.0_101
          +1 javadoc 2m 39s branch-2 passed with JDK v1.7.0_111
          0 mvndep 0m 15s Maven dependency ordering for patch
          -1 mvninstall 0m 32s hadoop-hdfs in the patch failed.
          -1 compile 1m 38s root in the patch failed with JDK v1.8.0_101.
          -1 javac 1m 38s root in the patch failed with JDK v1.8.0_101.
          -1 compile 1m 49s root in the patch failed with JDK v1.7.0_111.
          -1 javac 1m 49s root in the patch failed with JDK v1.7.0_111.
          -0 checkstyle 1m 24s root: The patch generated 2 new + 17 unchanged - 11 fixed = 19 total (was 28)
          -1 mvnsite 0m 34s hadoop-hdfs in the patch failed.
          +1 mvneclipse 0m 28s the patch passed
          -1 whitespace 0m 0s The patch has 47 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 findbugs 0m 16s hadoop-hdfs in the patch failed.
          +1 javadoc 1m 39s the patch passed with JDK v1.8.0_101
          +1 javadoc 2m 28s the patch passed with JDK v1.7.0_111
          +1 unit 8m 30s hadoop-common in the patch passed with JDK v1.7.0_111.
          -1 unit 0m 34s hadoop-hdfs in the patch failed with JDK v1.7.0_111.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          81m 57s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue HDFS-9444
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830470/HDFS-9444-branch-2.006.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b51e37ca6f89 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 5737d04
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/patch-compile-root-jdk1.8.0_101.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/patch-compile-root-jdk1.8.0_101.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/patch-compile-root-jdk1.7.0_111.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/patch-compile-root-jdk1.7.0_111.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/diff-checkstyle-root.txt
          mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/whitespace-eol.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16878/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16878/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 13m 31s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 50s Maven dependency ordering for branch +1 mvninstall 7m 13s branch-2 passed +1 compile 6m 31s branch-2 passed with JDK v1.8.0_101 +1 compile 7m 4s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 1m 29s branch-2 passed +1 mvnsite 1m 55s branch-2 passed +1 mvneclipse 0m 32s branch-2 passed +1 findbugs 3m 47s branch-2 passed +1 javadoc 1m 49s branch-2 passed with JDK v1.8.0_101 +1 javadoc 2m 39s branch-2 passed with JDK v1.7.0_111 0 mvndep 0m 15s Maven dependency ordering for patch -1 mvninstall 0m 32s hadoop-hdfs in the patch failed. -1 compile 1m 38s root in the patch failed with JDK v1.8.0_101. -1 javac 1m 38s root in the patch failed with JDK v1.8.0_101. -1 compile 1m 49s root in the patch failed with JDK v1.7.0_111. -1 javac 1m 49s root in the patch failed with JDK v1.7.0_111. -0 checkstyle 1m 24s root: The patch generated 2 new + 17 unchanged - 11 fixed = 19 total (was 28) -1 mvnsite 0m 34s hadoop-hdfs in the patch failed. +1 mvneclipse 0m 28s the patch passed -1 whitespace 0m 0s The patch has 47 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 findbugs 0m 16s hadoop-hdfs in the patch failed. +1 javadoc 1m 39s the patch passed with JDK v1.8.0_101 +1 javadoc 2m 28s the patch passed with JDK v1.7.0_111 +1 unit 8m 30s hadoop-common in the patch passed with JDK v1.7.0_111. -1 unit 0m 34s hadoop-hdfs in the patch failed with JDK v1.7.0_111. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 81m 57s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-9444 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830470/HDFS-9444-branch-2.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b51e37ca6f89 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 5737d04 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/patch-compile-root-jdk1.8.0_101.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/patch-compile-root-jdk1.8.0_101.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/patch-compile-root-jdk1.7.0_111.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/patch-compile-root-jdk1.7.0_111.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/diff-checkstyle-root.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/whitespace-eol.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16878/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16878/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16878/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          branch-2.006.patch was incomplete.. I attached updated patch as branch-2.007.

          Show
          iwasakims Masatake Iwasaki added a comment - branch-2.006.patch was incomplete.. I attached updated patch as branch-2.007.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 19s Maven dependency ordering for branch
          +1 mvninstall 6m 48s branch-2 passed
          +1 compile 5m 57s branch-2 passed with JDK v1.8.0_101
          +1 compile 6m 37s branch-2 passed with JDK v1.7.0_111
          +1 checkstyle 1m 26s branch-2 passed
          +1 mvnsite 1m 52s branch-2 passed
          +1 mvneclipse 0m 31s branch-2 passed
          +1 findbugs 3m 35s branch-2 passed
          +1 javadoc 1m 44s branch-2 passed with JDK v1.8.0_101
          +1 javadoc 2m 36s branch-2 passed with JDK v1.7.0_111
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 28s the patch passed
          +1 compile 5m 49s the patch passed with JDK v1.8.0_101
          +1 javac 5m 49s the patch passed
          +1 compile 6m 30s the patch passed with JDK v1.7.0_111
          +1 javac 6m 30s the patch passed
          +1 checkstyle 1m 23s root: The patch generated 0 new + 25 unchanged - 3 fixed = 25 total (was 28)
          +1 mvnsite 1m 49s the patch passed
          +1 mvneclipse 0m 30s the patch passed
          -1 whitespace 0m 0s The patch has 47 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 findbugs 4m 0s the patch passed
          +1 javadoc 1m 36s the patch passed with JDK v1.8.0_101
          +1 javadoc 2m 30s the patch passed with JDK v1.7.0_111
          -1 unit 7m 32s hadoop-common in the patch failed with JDK v1.7.0_111.
          +1 unit 49m 5s hadoop-hdfs in the patch passed with JDK v1.7.0_111.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          176m 25s



          Reason Tests
          JDK v1.7.0_111 Failed junit tests hadoop.net.TestClusterTopology
            hadoop.net.TestDNS



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue HDFS-9444
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830519/HDFS-9444-branch-2.007.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux dbd488c9cd2b 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / b3c0656
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16881/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16881/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16881/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16881/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 19s Maven dependency ordering for branch +1 mvninstall 6m 48s branch-2 passed +1 compile 5m 57s branch-2 passed with JDK v1.8.0_101 +1 compile 6m 37s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 1m 26s branch-2 passed +1 mvnsite 1m 52s branch-2 passed +1 mvneclipse 0m 31s branch-2 passed +1 findbugs 3m 35s branch-2 passed +1 javadoc 1m 44s branch-2 passed with JDK v1.8.0_101 +1 javadoc 2m 36s branch-2 passed with JDK v1.7.0_111 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 28s the patch passed +1 compile 5m 49s the patch passed with JDK v1.8.0_101 +1 javac 5m 49s the patch passed +1 compile 6m 30s the patch passed with JDK v1.7.0_111 +1 javac 6m 30s the patch passed +1 checkstyle 1m 23s root: The patch generated 0 new + 25 unchanged - 3 fixed = 25 total (was 28) +1 mvnsite 1m 49s the patch passed +1 mvneclipse 0m 30s the patch passed -1 whitespace 0m 0s The patch has 47 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 4m 0s the patch passed +1 javadoc 1m 36s the patch passed with JDK v1.8.0_101 +1 javadoc 2m 30s the patch passed with JDK v1.7.0_111 -1 unit 7m 32s hadoop-common in the patch failed with JDK v1.7.0_111. +1 unit 49m 5s hadoop-hdfs in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 176m 25s Reason Tests JDK v1.7.0_111 Failed junit tests hadoop.net.TestClusterTopology   hadoop.net.TestDNS Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-9444 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830519/HDFS-9444-branch-2.007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dbd488c9cd2b 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / b3c0656 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16881/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16881/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16881/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16881/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -

          Thank you both for the work.
          Whitespace looks unrelated, +1 on branch-2.007.

          Show
          xiaochen Xiao Chen added a comment - Thank you both for the work. Whitespace looks unrelated, +1 on branch-2.007 .
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          pushed to branch-2 and branch-2.8..Thanks to Masatake Iwasaki for contribution and Xiao Chen for review

          Show
          brahmareddy Brahma Reddy Battula added a comment - pushed to branch-2 and branch-2.8..Thanks to Masatake Iwasaki for contribution and Xiao Chen for review
          Hide
          zhz Zhe Zhang added a comment -

          Thanks for the work. I think this is a good addition to branch-2.7 and just did the backport.

          Show
          zhz Zhe Zhang added a comment - Thanks for the work. I think this is a good addition to branch-2.7 and just did the backport.

            People

            • Assignee:
              iwasakims Masatake Iwasaki
              Reporter:
              brahmareddy Brahma Reddy Battula
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development