Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Environment:

      Solaris

    • Hadoop Flags:
      Reviewed

      Description

      TestPipelinesFailover.java contains the following:

          scmd = new String[] {"ifconfig"};
          sce = new ShellCommandExecutor(scmd);
          sce.execute();
          System.out.println("'ifconfig' output:\n" + sce.getOutput());
      

      That assumes the Linux ifconfig command. If the flag "-a" is added, the same invocation should work on both Linux and Solaris - the output is only displayed for debugging purposes so the fact that the output of ifconfig is different on Linux and Solaris shouldn't matter.

      1. HDFS-9438-hdfs-9438.001.patch
        2 kB
        John Zhuge
      2. HDFS-9438-hdfs-9438.002.patch
        2 kB
        John Zhuge
      3. HDFS-9438-hdfs-9438.003.patch
        2 kB
        John Zhuge
      4. HDFS-9438-hdfs-9438.004.patch
        3 kB
        John Zhuge
      5. HDFS-9438-hdfs-9438.005.patch
        3 kB
        John Zhuge

        Issue Links

          Activity

          Hide
          aw Allen Wittenauer added a comment -

          ... and ifconfig is deprecated on Linux anyway. :/

          Show
          aw Allen Wittenauer added a comment - ... and ifconfig is deprecated on Linux anyway. :/
          Hide
          alanburlison Alan Burlison added a comment -

          It's semi-deprecated on Solaris as well, ipadm & dladm are the replacements. However I can't see ifconfig going away from either platform any time soon, so it's probably OK to leave for now as it's just used for test diagnostics.

          Show
          alanburlison Alan Burlison added a comment - It's semi-deprecated on Solaris as well, ipadm & dladm are the replacements. However I can't see ifconfig going away from either platform any time soon, so it's probably OK to leave for now as it's just used for test diagnostics.
          Hide
          cnauroth Chris Nauroth added a comment -

          Alan Burlison, thank you for reporting this. It won't work on Windows either.

          The ifconfig call was part of a temporary debugging patch documented in HDFS-6694. I've just commented on that issue asking if it's time to revert it.

          Show
          cnauroth Chris Nauroth added a comment - Alan Burlison , thank you for reporting this. It won't work on Windows either. The ifconfig call was part of a temporary debugging patch documented in HDFS-6694 . I've just commented on that issue asking if it's time to revert it.
          Hide
          alanburlison Alan Burlison added a comment -

          Removing it works for me

          Show
          alanburlison Alan Burlison added a comment - Removing it works for me
          Hide
          alanburlison Alan Burlison added a comment -

          Assigned as requested

          Show
          alanburlison Alan Burlison added a comment - Assigned as requested
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks John Zhuge for looking into this.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks John Zhuge for looking into this.
          Hide
          jzhuge John Zhuge added a comment -
          diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java
          index 3da37f5..1cba792 100644
          --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java
          +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java
          @@ -429,6 +429,11 @@ public void testPipelineRecoveryStress() throws Exception {
               // The following section of code is to help debug HDFS-6694 about
               // this test that fails from time to time due to "too many open files".
               //
          +    if (!Shell.LINUX && !Shell.SOLARIS) {
          +        System.out.println("Unsupport OS. Skip HDFS-6694 Debug Data");
          +        return;
          +    }
          +
               String[] scmd = new String[] {"/bin/sh", "-c", "ulimit -a"};
               ShellCommandExecutor sce = new ShellCommandExecutor(scmd);
               sce.execute();
          @@ -441,7 +446,7 @@ public void testPipelineRecoveryStress() throws Exception {
               sce.execute();
               System.out.println("'hostname' output:\n" + sce.getOutput());
           
          -    scmd = new String[] {"ifconfig"};
          +    scmd = new String[] {"ifconfig -a"};
               sce = new ShellCommandExecutor(scmd);
               sce.execute();
               System.out.println("'ifconfig' output:\n" + sce.getOutput());
          
          Show
          jzhuge John Zhuge added a comment - diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java index 3da37f5..1cba792 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java @@ -429,6 +429,11 @@ public void testPipelineRecoveryStress() throws Exception { // The following section of code is to help debug HDFS-6694 about // this test that fails from time to time due to "too many open files" . // + if (!Shell.LINUX && !Shell.SOLARIS) { + System .out.println( "Unsupport OS. Skip HDFS-6694 Debug Data" ); + return ; + } + String [] scmd = new String [] { "/bin/sh" , "-c" , "ulimit -a" }; ShellCommandExecutor sce = new ShellCommandExecutor(scmd); sce.execute(); @@ -441,7 +446,7 @@ public void testPipelineRecoveryStress() throws Exception { sce.execute(); System .out.println( "'hostname' output:\n" + sce.getOutput()); - scmd = new String [] { "ifconfig" }; + scmd = new String [] { "ifconfig -a" }; sce = new ShellCommandExecutor(scmd); sce.execute(); System .out.println( "'ifconfig' output:\n" + sce.getOutput());
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Hi John Zhuge thanks for the patch and welcome to contribute to HDFS!

          Just one comment: you can use assumeTrue() to replace if(!Shell.INUX && !Shell.SOLARIS)
          For example,
          assumeTrue( Shell.LNUX || Shell.SOLARIS );

          (You can search for assumeTrue in other test cases for its common usage)
          Using this, a test case will be skipped if it's not running under both LINUX or SOLARIS.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Hi John Zhuge thanks for the patch and welcome to contribute to HDFS! Just one comment: you can use assumeTrue() to replace if(!Shell.INUX && !Shell.SOLARIS) For example, assumeTrue( Shell.LNUX || Shell.SOLARIS ); (You can search for assumeTrue in other test cases for its common usage) Using this, a test case will be skipped if it's not running under both LINUX or SOLARIS.
          Hide
          liuml07 Mingliang Liu added a comment -

          Agreed. Ignoring the test instead of failing is preferred.

          Show
          liuml07 Mingliang Liu added a comment - Agreed. Ignoring the test instead of failing is preferred.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 9m 24s trunk passed
          +1 compile 0m 59s trunk passed with JDK v1.8.0_66
          +1 compile 0m 53s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 19s trunk passed
          +1 mvnsite 1m 4s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 2m 22s trunk passed
          +1 javadoc 1m 23s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 7s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 58s the patch passed
          +1 compile 0m 52s the patch passed with JDK v1.8.0_66
          +1 javac 0m 52s the patch passed
          +1 compile 0m 50s the patch passed with JDK v1.7.0_85
          +1 javac 0m 50s the patch passed
          +1 checkstyle 0m 19s the patch passed
          +1 mvnsite 1m 2s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 27s the patch passed
          +1 javadoc 1m 25s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 10s the patch passed with JDK v1.7.0_85
          -1 unit 78m 26s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 74m 39s hadoop-hdfs in the patch failed with JDK v1.7.0_85.
          -1 asflicense 0m 23s Patch generated 58 ASF License warnings.
          185m 57s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
            hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
            hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
            hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure100
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.TestRollingUpgrade
            hadoop.security.TestPermission
          JDK v1.7.0_85 Failed junit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.hdfs.TestRollingUpgrade
            hadoop.security.TestPermission
            hadoop.hdfs.server.namenode.TestQuotaWithStripedBlocks



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773920/HDFS-9438-hdfs-9438.001.patch
          JIRA Issue HDFS-9438
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 81796f667ac0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4bff073
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13625/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13625/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13625/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13625/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13625/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13625/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 78MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13625/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 24s trunk passed +1 compile 0m 59s trunk passed with JDK v1.8.0_66 +1 compile 0m 53s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 19s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 2m 22s trunk passed +1 javadoc 1m 23s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 7s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 58s the patch passed +1 compile 0m 52s the patch passed with JDK v1.8.0_66 +1 javac 0m 52s the patch passed +1 compile 0m 50s the patch passed with JDK v1.7.0_85 +1 javac 0m 50s the patch passed +1 checkstyle 0m 19s the patch passed +1 mvnsite 1m 2s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 27s the patch passed +1 javadoc 1m 25s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 10s the patch passed with JDK v1.7.0_85 -1 unit 78m 26s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 74m 39s hadoop-hdfs in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 23s Patch generated 58 ASF License warnings. 185m 57s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure100   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.TestRollingUpgrade   hadoop.security.TestPermission JDK v1.7.0_85 Failed junit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.TestRollingUpgrade   hadoop.security.TestPermission   hadoop.hdfs.server.namenode.TestQuotaWithStripedBlocks Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773920/HDFS-9438-hdfs-9438.001.patch JIRA Issue HDFS-9438 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 81796f667ac0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4bff073 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13625/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13625/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13625/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13625/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13625/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13625/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 78MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13625/console This message was automatically generated.
          Hide
          jzhuge John Zhuge added a comment -

          Use "/sbin/ifconfig" instead of "ifconfig" on Linux and Mac.
          Use "/usr/sbin/ifconfig" on Solaris.

          Show
          jzhuge John Zhuge added a comment - Use "/sbin/ifconfig" instead of "ifconfig" on Linux and Mac. Use "/usr/sbin/ifconfig" on Solaris.
          Hide
          jzhuge John Zhuge added a comment -

          I probably should not have clicked "Resolve Issue" because the 2nd patch still needs to be tested.

          Show
          jzhuge John Zhuge added a comment - I probably should not have clicked "Resolve Issue" because the 2nd patch still needs to be tested.
          Hide
          jzhuge John Zhuge added a comment -

          Uploaded the 2nd patch

          Show
          jzhuge John Zhuge added a comment - Uploaded the 2nd patch
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 5s trunk passed
          +1 compile 0m 48s trunk passed with JDK v1.8.0_66
          +1 compile 0m 45s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 18s trunk passed
          +1 mvnsite 0m 56s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 2m 4s trunk passed
          +1 javadoc 1m 14s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 51s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 54s the patch passed
          +1 compile 0m 47s the patch passed with JDK v1.8.0_66
          +1 javac 0m 47s the patch passed
          +1 compile 0m 46s the patch passed with JDK v1.7.0_85
          +1 javac 0m 46s the patch passed
          +1 checkstyle 0m 17s the patch passed
          +1 mvnsite 0m 57s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 14s the patch passed
          +1 javadoc 1m 14s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 54s the patch passed with JDK v1.7.0_85
          -1 unit 58m 42s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 57m 16s hadoop-hdfs in the patch failed with JDK v1.7.0_85.
          -1 asflicense 0m 21s Patch generated 58 ASF License warnings.
          144m 43s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.security.TestPermission
            hadoop.hdfs.TestDFSStorageStateRecovery
            hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
          JDK v1.7.0_85 Failed junit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.security.TestPermission
            hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
            hadoop.hdfs.TestPread
            hadoop.hdfs.TestDFSClientRetries



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773967/HDFS-9438-hdfs-9438.002.patch
          JIRA Issue HDFS-9438
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 33aeb20a49ac 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 411e2b2
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13629/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13629/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13629/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13629/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13629/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13629/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13629/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 5s trunk passed +1 compile 0m 48s trunk passed with JDK v1.8.0_66 +1 compile 0m 45s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 4s trunk passed +1 javadoc 1m 14s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 51s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 54s the patch passed +1 compile 0m 47s the patch passed with JDK v1.8.0_66 +1 javac 0m 47s the patch passed +1 compile 0m 46s the patch passed with JDK v1.7.0_85 +1 javac 0m 46s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 14s the patch passed +1 javadoc 1m 14s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 54s the patch passed with JDK v1.7.0_85 -1 unit 58m 42s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 57m 16s hadoop-hdfs in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 21s Patch generated 58 ASF License warnings. 144m 43s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.security.TestPermission   hadoop.hdfs.TestDFSStorageStateRecovery   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes JDK v1.7.0_85 Failed junit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.security.TestPermission   hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics   hadoop.hdfs.TestPread   hadoop.hdfs.TestDFSClientRetries Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773967/HDFS-9438-hdfs-9438.002.patch JIRA Issue HDFS-9438 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 33aeb20a49ac 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 411e2b2 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13629/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13629/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13629/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13629/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13629/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13629/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13629/console This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          If the OS is Solaris, the command for ShellCommandExecutor should be like:

          scmd = new String[] {"/usr/sbin/ifconfig", "-a"};
          

          Separate each parameters from the command.

          Show
          jojochuang Wei-Chiu Chuang added a comment - If the OS is Solaris, the command for ShellCommandExecutor should be like: scmd = new String[] {"/usr/sbin/ifconfig", "-a"}; Separate each parameters from the command.
          Hide
          jzhuge John Zhuge added a comment -

          Thanks Wei-Chiu for catching this problem.

          And I will refrain from specifying full path for ifconfig because different flavors of Linux place ifconfig in different directories: /usr/sbin for Centos, /sbin for Ubuntu. The node should have path configured properly to run ifconfig.

          We might want to consider switching to "ip" tool since ifconfig is deprecated.

          Show
          jzhuge John Zhuge added a comment - Thanks Wei-Chiu for catching this problem. And I will refrain from specifying full path for ifconfig because different flavors of Linux place ifconfig in different directories: /usr/sbin for Centos, /sbin for Ubuntu. The node should have path configured properly to run ifconfig. We might want to consider switching to "ip" tool since ifconfig is deprecated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 11m 43s trunk passed
          +1 compile 1m 26s trunk passed with JDK v1.8.0_66
          +1 compile 1m 7s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 1m 19s trunk passed
          +1 mvneclipse 0m 20s trunk passed
          +1 findbugs 2m 46s trunk passed
          +1 javadoc 1m 56s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 45s trunk passed with JDK v1.7.0_85
          +1 mvninstall 1m 6s the patch passed
          +1 compile 1m 10s the patch passed with JDK v1.8.0_66
          +1 javac 1m 10s the patch passed
          +1 compile 0m 58s the patch passed with JDK v1.7.0_85
          +1 javac 0m 58s the patch passed
          +1 checkstyle 0m 22s the patch passed
          +1 mvnsite 1m 12s the patch passed
          +1 mvneclipse 0m 17s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 45s the patch passed
          +1 javadoc 1m 37s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 37s the patch passed with JDK v1.7.0_85
          -1 unit 85m 50s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 75m 22s hadoop-hdfs in the patch failed with JDK v1.7.0_85.
          -1 asflicense 0m 24s Patch generated 56 ASF License warnings.
          201m 18s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.security.TestPermission
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010
            hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.tools.TestDFSZKFailoverController
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.namenode.TestStartup
          JDK v1.7.0_85 Failed junit tests hadoop.security.TestPermission
            hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.namenode.TestCacheDirectives
            hadoop.hdfs.qjournal.client.TestQuorumJournalManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774084/HDFS-9438-hdfs-9438.003.patch
          JIRA Issue HDFS-9438
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f4d09b42de54 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 28dfe72
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13634/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13634/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13634/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13634/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13634/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13634/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 75MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13634/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 11m 43s trunk passed +1 compile 1m 26s trunk passed with JDK v1.8.0_66 +1 compile 1m 7s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 19s trunk passed +1 mvneclipse 0m 20s trunk passed +1 findbugs 2m 46s trunk passed +1 javadoc 1m 56s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 45s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 6s the patch passed +1 compile 1m 10s the patch passed with JDK v1.8.0_66 +1 javac 1m 10s the patch passed +1 compile 0m 58s the patch passed with JDK v1.7.0_85 +1 javac 0m 58s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 1m 12s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 45s the patch passed +1 javadoc 1m 37s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 37s the patch passed with JDK v1.7.0_85 -1 unit 85m 50s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 75m 22s hadoop-hdfs in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 24s Patch generated 56 ASF License warnings. 201m 18s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.security.TestPermission   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.TestStartup JDK v1.7.0_85 Failed junit tests hadoop.security.TestPermission   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.hdfs.qjournal.client.TestQuorumJournalManager Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774084/HDFS-9438-hdfs-9438.003.patch JIRA Issue HDFS-9438 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f4d09b42de54 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 28dfe72 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13634/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13634/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13634/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13634/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13634/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13634/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13634/console This message was automatically generated.
          Hide
          yzhangal Yongjun Zhang added a comment -

          HI John Zhuge,

          Thanks for working on this issue. The patch looks good, one small thing, assumeTrue would stop the run of this whole test, which means it will fail on windows. I'd suggest that we make it work this way:

          if (Shell.LINUX || Shell.SOLARIS || Shell.MAC) {
             // Debug code for HDFS-6694
             ......
          }
          

          And we can create a new infra jira to request making ifconfig available in the exe path. If ifconfig is totally obsoleted, we can replace ifconifg with the new command later.

          Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - HI John Zhuge , Thanks for working on this issue. The patch looks good, one small thing, assumeTrue would stop the run of this whole test, which means it will fail on windows. I'd suggest that we make it work this way: if (Shell.LINUX || Shell.SOLARIS || Shell.MAC) { // Debug code for HDFS-6694 ...... } And we can create a new infra jira to request making ifconfig available in the exe path. If ifconfig is totally obsoleted, we can replace ifconifg with the new command later. Thanks.
          Hide
          jzhuge John Zhuge added a comment -

          The method has "debug" section and the test section. What we actually want is to skip only the debug section, so can't use assumeTrue.

          Show
          jzhuge John Zhuge added a comment - The method has "debug" section and the test section. What we actually want is to skip only the debug section, so can't use assumeTrue.
          Hide
          aw Allen Wittenauer added a comment -

          Do we actually need whoami support? I don't think any part of hadoop-proper actually does that anymore, just some test cases that likely haven't been touched in a while. (Although we should probably remove that in a follow-up)

          Also: RE: ifconfig

          It most definitely needs to be unqualified in order for it to work across more than just Linux. Additionally, any switch to ip would need to be in a Linux-specific block.

          Show
          aw Allen Wittenauer added a comment - Do we actually need whoami support? I don't think any part of hadoop-proper actually does that anymore, just some test cases that likely haven't been touched in a while. (Although we should probably remove that in a follow-up) Also: RE: ifconfig It most definitely needs to be unqualified in order for it to work across more than just Linux. Additionally, any switch to ip would need to be in a Linux-specific block.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks John Zhuge for the new rev and Allen Wittenauer for the review.

          One comment: this should be in the dbeug code block. +1 after that.

          String[] scmd = new String[] {"/bin/sh", "-c", "ulimit -a"};
              ShellCommandExecutor sce = new ShellCommandExecutor(scmd);
              sce.execute();
          

          Hi Allen Wittenauer, this block of code (including whoami) is only for debugging purpose and they should run on the selected platforms. I do see other code also refers to whoami as you mentioned, I personally think whether/when to drop it belong to a different jira. Agree?

          ind . -name "*java" -exec grep whoami {} \; -print
            public static final String USER_NAME_COMMAND = "whoami";
          ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java
              String qualifiedUsername = Shell.execCommand("whoami").trim();
          ./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestWinUtils.java
              Process pp = Runtime.getRuntime().exec("whoami");
          ./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
              Process pp = Runtime.getRuntime().exec("whoami");
              // On Windows domain joined machine, whoami returns the username
          ./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestProxyUserFromEnv.java
              String whoami = RegistryUtils.getCurrentUsernameUnencoded("drwho");
              assertEquals("drwho", whoami);
              String whoami = RegistryUtils.getCurrentUsernameUnencoded("");
              assertEquals(ugiUser, whoami);
          ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/test/java/org/apache/hadoop/registry/client/binding/TestRegistryOperationUtils.java
          

          Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks John Zhuge for the new rev and Allen Wittenauer for the review. One comment: this should be in the dbeug code block. +1 after that. String [] scmd = new String [] { "/bin/sh" , "-c" , "ulimit -a" }; ShellCommandExecutor sce = new ShellCommandExecutor(scmd); sce.execute(); Hi Allen Wittenauer , this block of code (including whoami) is only for debugging purpose and they should run on the selected platforms. I do see other code also refers to whoami as you mentioned, I personally think whether/when to drop it belong to a different jira. Agree? ind . -name "*java" -exec grep whoami {} \; -print public static final String USER_NAME_COMMAND = "whoami" ; ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java String qualifiedUsername = Shell.execCommand( "whoami" ).trim(); ./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestWinUtils.java Process pp = Runtime .getRuntime().exec( "whoami" ); ./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java Process pp = Runtime .getRuntime().exec( "whoami" ); // On Windows domain joined machine, whoami returns the username ./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestProxyUserFromEnv.java String whoami = RegistryUtils.getCurrentUsernameUnencoded( "drwho" ); assertEquals( "drwho" , whoami); String whoami = RegistryUtils.getCurrentUsernameUnencoded(""); assertEquals(ugiUser, whoami); ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/test/java/org/apache/hadoop/registry/client/binding/TestRegistryOperationUtils.java Thanks.
          Hide
          aw Allen Wittenauer added a comment -

          I do see other code also refers to whoami

          a) All of the other references: all test code. Shell.USER_NAME_COMMAND Is never referenced that I saw. Removing those should definitely be another JIRA. However....

          b) what value does printing out whoami here actually provide? whoami is a BSD command that isn't either installed or in the default path on System V machines. If it actually provides some value, we should replace it with the POSIX friendly id.

          Show
          aw Allen Wittenauer added a comment - I do see other code also refers to whoami a) All of the other references: all test code. Shell.USER_NAME_COMMAND Is never referenced that I saw. Removing those should definitely be another JIRA. However.... b) what value does printing out whoami here actually provide? whoami is a BSD command that isn't either installed or in the default path on System V machines. If it actually provides some value, we should replace it with the POSIX friendly id.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks Allen. My original thinking was, if someone reports that this testcase fails, then we have the log about who has run the test, so we can check out more info of this user's env if needed. It's ok to me to remove the occurrence in this patch.

          Hi John Zhuge, would you please address Allen's comments be dropping the whoami section, in addition to my last comment?

          Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks Allen. My original thinking was, if someone reports that this testcase fails, then we have the log about who has run the test, so we can check out more info of this user's env if needed. It's ok to me to remove the occurrence in this patch. Hi John Zhuge , would you please address Allen's comments be dropping the whoami section, in addition to my last comment? Thanks.
          Hide
          jzhuge John Zhuge added a comment -

          Thanks everyone for the code reviews.

          Incorporate Yongjun's review comment.
          Remove "whoami" section based on Allen's comment.

          Show
          jzhuge John Zhuge added a comment - Thanks everyone for the code reviews. Incorporate Yongjun's review comment. Remove "whoami" section based on Allen's comment.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 21s trunk passed
          +1 compile 0m 46s trunk passed with JDK v1.8.0_66
          +1 compile 0m 44s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 18s trunk passed
          +1 mvnsite 0m 55s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 59s trunk passed
          +1 javadoc 1m 14s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 55s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 53s the patch passed
          +1 compile 0m 44s the patch passed with JDK v1.8.0_66
          +1 javac 0m 44s the patch passed
          +1 compile 0m 45s the patch passed with JDK v1.7.0_85
          +1 javac 0m 45s the patch passed
          +1 checkstyle 0m 16s the patch passed
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 8s the patch passed
          +1 javadoc 1m 11s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 56s the patch passed with JDK v1.7.0_85
          -1 unit 58m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 54m 6s hadoop-hdfs in the patch failed with JDK v1.7.0_85.
          -1 asflicense 0m 19s Patch generated 58 ASF License warnings.
          141m 9s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
            hadoop.hdfs.qjournal.client.TestQuorumJournalManager
            hadoop.security.TestPermission
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
          JDK v1.7.0_85 Failed junit tests hadoop.hdfs.server.namenode.TestBackupNode
            hadoop.security.TestPermission
            hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774185/HDFS-9438-hdfs-9438.004.patch
          JIRA Issue HDFS-9438
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 82d0ed73091f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 78ec38b
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13649/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13649/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13649/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13649/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13649/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13649/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 78MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13649/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 21s trunk passed +1 compile 0m 46s trunk passed with JDK v1.8.0_66 +1 compile 0m 44s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 59s trunk passed +1 javadoc 1m 14s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 55s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 53s the patch passed +1 compile 0m 44s the patch passed with JDK v1.8.0_66 +1 javac 0m 44s the patch passed +1 compile 0m 45s the patch passed with JDK v1.7.0_85 +1 javac 0m 45s the patch passed +1 checkstyle 0m 16s the patch passed +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 8s the patch passed +1 javadoc 1m 11s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 56s the patch passed with JDK v1.7.0_85 -1 unit 58m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 54m 6s hadoop-hdfs in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 19s Patch generated 58 ASF License warnings. 141m 9s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.qjournal.client.TestQuorumJournalManager   hadoop.security.TestPermission   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA JDK v1.7.0_85 Failed junit tests hadoop.hdfs.server.namenode.TestBackupNode   hadoop.security.TestPermission   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774185/HDFS-9438-hdfs-9438.004.patch JIRA Issue HDFS-9438 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 82d0ed73091f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 78ec38b findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13649/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13649/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13649/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13649/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13649/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13649/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 78MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13649/console This message was automatically generated.
          Hide
          yzhangal Yongjun Zhang added a comment -

          +1 on rev 005, will commit soon. Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - +1 on rev 005, will commit soon. Thanks.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 9m 5s trunk passed
          +1 compile 0m 52s trunk passed with JDK v1.8.0_66
          +1 compile 0m 47s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 19s trunk passed
          +1 mvnsite 1m 0s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 2m 11s trunk passed
          +1 javadoc 1m 17s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 7s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 56s the patch passed
          +1 compile 0m 48s the patch passed with JDK v1.8.0_66
          +1 javac 0m 48s the patch passed
          +1 compile 0m 47s the patch passed with JDK v1.7.0_85
          +1 javac 0m 47s the patch passed
          +1 checkstyle 0m 18s the patch passed
          +1 mvnsite 0m 59s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 2m 23s the patch passed
          +1 javadoc 1m 18s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 3s the patch passed with JDK v1.7.0_85
          -1 unit 62m 42s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 58m 5s hadoop-hdfs in the patch failed with JDK v1.7.0_85.
          -1 asflicense 0m 21s Patch generated 56 ASF License warnings.
          152m 0s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestRollingUpgrade
            hadoop.security.TestPermission
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.TestReadStripedFileWithDecoding
            hadoop.hdfs.TestEncryptionZones
          JDK v1.7.0_85 Failed junit tests hadoop.hdfs.TestRollingUpgrade
            hadoop.security.TestPermission
            hadoop.hdfs.server.namenode.TestDecommissioningStatus



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774232/HDFS-9438-hdfs-9438.005.patch
          JIRA Issue HDFS-9438
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 9332541ad9d0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b4c6b51
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13653/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13653/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13653/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13653/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13653/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13653/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13653/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13653/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 5s trunk passed +1 compile 0m 52s trunk passed with JDK v1.8.0_66 +1 compile 0m 47s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 19s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 11s trunk passed +1 javadoc 1m 17s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 7s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 56s the patch passed +1 compile 0m 48s the patch passed with JDK v1.8.0_66 +1 javac 0m 48s the patch passed +1 compile 0m 47s the patch passed with JDK v1.7.0_85 +1 javac 0m 47s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 15s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 2m 23s the patch passed +1 javadoc 1m 18s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 3s the patch passed with JDK v1.7.0_85 -1 unit 62m 42s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 58m 5s hadoop-hdfs in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 21s Patch generated 56 ASF License warnings. 152m 0s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestRollingUpgrade   hadoop.security.TestPermission   hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.TestEncryptionZones JDK v1.7.0_85 Failed junit tests hadoop.hdfs.TestRollingUpgrade   hadoop.security.TestPermission   hadoop.hdfs.server.namenode.TestDecommissioningStatus Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774232/HDFS-9438-hdfs-9438.005.patch JIRA Issue HDFS-9438 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9332541ad9d0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b4c6b51 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13653/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13653/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13653/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13653/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13653/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13653/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13653/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13653/console This message was automatically generated.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8885 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8885/)
          HDFS-9438. TestPipelinesFailover assumes Linux ifconfig. (John Zhuge via (yzhang: rev 8176ea7dc694841a993f2bfc30669fe22f9ec1d2)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8885 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8885/ ) HDFS-9438 . TestPipelinesFailover assumes Linux ifconfig. (John Zhuge via (yzhang: rev 8176ea7dc694841a993f2bfc30669fe22f9ec1d2) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          yzhangal Yongjun Zhang added a comment -

          Committed to trunk and branch-2. Thanks John for the contribution and all for the review.

          BTW, I cherry-picked HDFS-6694 changes to branch too.

          Show
          yzhangal Yongjun Zhang added a comment - Committed to trunk and branch-2. Thanks John for the contribution and all for the review. BTW, I cherry-picked HDFS-6694 changes to branch too.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2664 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2664/)
          HDFS-9438. TestPipelinesFailover assumes Linux ifconfig. (John Zhuge via (yzhang: rev 8176ea7dc694841a993f2bfc30669fe22f9ec1d2)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2664 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2664/ ) HDFS-9438 . TestPipelinesFailover assumes Linux ifconfig. (John Zhuge via (yzhang: rev 8176ea7dc694841a993f2bfc30669fe22f9ec1d2) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #733 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/733/)
          HDFS-9438. TestPipelinesFailover assumes Linux ifconfig. (John Zhuge via (yzhang: rev 8176ea7dc694841a993f2bfc30669fe22f9ec1d2)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #733 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/733/ ) HDFS-9438 . TestPipelinesFailover assumes Linux ifconfig. (John Zhuge via (yzhang: rev 8176ea7dc694841a993f2bfc30669fe22f9ec1d2) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1454 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1454/)
          HDFS-9438. TestPipelinesFailover assumes Linux ifconfig. (John Zhuge via (yzhang: rev 8176ea7dc694841a993f2bfc30669fe22f9ec1d2)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1454 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1454/ ) HDFS-9438 . TestPipelinesFailover assumes Linux ifconfig. (John Zhuge via (yzhang: rev 8176ea7dc694841a993f2bfc30669fe22f9ec1d2) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #722 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/722/)
          HDFS-9438. TestPipelinesFailover assumes Linux ifconfig. (John Zhuge via (yzhang: rev 8176ea7dc694841a993f2bfc30669fe22f9ec1d2)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #722 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/722/ ) HDFS-9438 . TestPipelinesFailover assumes Linux ifconfig. (John Zhuge via (yzhang: rev 8176ea7dc694841a993f2bfc30669fe22f9ec1d2) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #643 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/643/)
          HDFS-9438. TestPipelinesFailover assumes Linux ifconfig. (John Zhuge via (yzhang: rev 8176ea7dc694841a993f2bfc30669fe22f9ec1d2)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #643 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/643/ ) HDFS-9438 . TestPipelinesFailover assumes Linux ifconfig. (John Zhuge via (yzhang: rev 8176ea7dc694841a993f2bfc30669fe22f9ec1d2) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2580 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2580/)
          HDFS-9438. TestPipelinesFailover assumes Linux ifconfig. (John Zhuge via (yzhang: rev 8176ea7dc694841a993f2bfc30669fe22f9ec1d2)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2580 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2580/ ) HDFS-9438 . TestPipelinesFailover assumes Linux ifconfig. (John Zhuge via (yzhang: rev 8176ea7dc694841a993f2bfc30669fe22f9ec1d2) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

            People

            • Assignee:
              jzhuge John Zhuge
              Reporter:
              alanburlison Alan Burlison
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development