Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      This is a follow-up of HDFS-9379.

      Though for actual benchmarking the defaults are rarely used, it would be good to change the default for numThreads as a >=10 value and may be numOpsRequired in BlockReportStats just to make sure the condition in HDFS-9379 is tested in the future.

      1. HDFS-9436.002.patch
        1 kB
        Mingliang Liu
      2. HDFS-9436.001.patch
        1 kB
        Mingliang Liu
      3. HDFS-9436.000.patch
        1 kB
        Mingliang Liu

        Issue Links

          Activity

          Hide
          liuml07 Mingliang Liu added a comment -

          The v0 patch makes number of datanodes in BlockReportStat 10 by default. This is only to test more cases, especially brought by HDFS-9379.

          The default value should be rarely used. Meanwhile, the nameNodeProto and dataNodeProto are static members of the benchmark, thus running multiple operation tests with different arguments (e.g. number of datanodes) may get unexpected result. Because of this, the default number of datanodes in ReplicationReportStat is also changed as 10.

          Show
          liuml07 Mingliang Liu added a comment - The v0 patch makes number of datanodes in BlockReportStat 10 by default. This is only to test more cases, especially brought by HDFS-9379 . The default value should be rarely used. Meanwhile, the nameNodeProto and dataNodeProto are static members of the benchmark, thus running multiple operation tests with different arguments (e.g. number of datanodes) may get unexpected result. Because of this, the default number of datanodes in ReplicationReportStat is also changed as 10.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 21s trunk passed
          +1 compile 0m 47s trunk passed with JDK v1.8.0_66
          +1 compile 0m 45s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 16s trunk passed
          +1 mvnsite 0m 56s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 2m 4s trunk passed
          +1 javadoc 1m 8s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 54s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 54s the patch passed
          +1 compile 0m 45s the patch passed with JDK v1.8.0_66
          +1 javac 0m 45s the patch passed
          +1 compile 0m 46s the patch passed with JDK v1.7.0_85
          +1 javac 0m 46s the patch passed
          +1 checkstyle 0m 18s the patch passed
          +1 mvnsite 1m 0s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 15s the patch passed
          +1 javadoc 1m 9s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 56s the patch passed with JDK v1.7.0_85
          -1 unit 58m 22s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 54m 50s hadoop-hdfs in the patch failed with JDK v1.7.0_85.
          -1 asflicense 0m 20s Patch generated 58 ASF License warnings.
          142m 6s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.server.namenode.TestBackupNode
          JDK v1.7.0_85 Failed junit tests hadoop.hdfs.TestDFSClientRetries



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773631/HDFS-9436.000.patch
          JIRA Issue HDFS-9436
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c252138eabf6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a30eccb
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13592/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13592/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13592/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13592/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13592/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13592/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 75MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13592/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 21s trunk passed +1 compile 0m 47s trunk passed with JDK v1.8.0_66 +1 compile 0m 45s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 2m 4s trunk passed +1 javadoc 1m 8s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 54s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 54s the patch passed +1 compile 0m 45s the patch passed with JDK v1.8.0_66 +1 javac 0m 45s the patch passed +1 compile 0m 46s the patch passed with JDK v1.7.0_85 +1 javac 0m 46s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 15s the patch passed +1 javadoc 1m 9s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 56s the patch passed with JDK v1.7.0_85 -1 unit 58m 22s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 54m 50s hadoop-hdfs in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 20s Patch generated 58 ASF License warnings. 142m 6s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.namenode.TestBackupNode JDK v1.7.0_85 Failed junit tests hadoop.hdfs.TestDFSClientRetries Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773631/HDFS-9436.000.patch JIRA Issue HDFS-9436 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c252138eabf6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a30eccb findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13592/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13592/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13592/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13592/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13592/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13592/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13592/console This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          Failing tests and ASF license warnings are not related to this change.

          Show
          liuml07 Mingliang Liu added a comment - Failing tests and ASF license warnings are not related to this change.
          Hide
          shv Konstantin Shvachko added a comment -

          Hey Mingliang, I thought you will increase the default only for BlockReportStats, but you made the change in OperationStatsBase, which changes the default for all other ops as well. I don't know if it is needed. Was it intentional?

          Show
          shv Konstantin Shvachko added a comment - Hey Mingliang, I thought you will increase the default only for BlockReportStats , but you made the change in OperationStatsBase , which changes the default for all other ops as well. I don't know if it is needed. Was it intentional?
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks for your review and comment.

          No, the change was not intentional. Actually I should have been more careful when I made the change. I was thinking the overall overhead to run the tests is very small even if all ops have a larger default scale.

          I don't think they all need this change. The v1 patch is to change the BlockReportStats only.

          While debugging the code, I've no idea how numOpsRequired is explained in BlockReportStats (perhaps a bad design). When addBlock() adds blocks in datanode, the TinyDatanode is not really updating the blocks list (perhaps a bug). Moreover, the blockReportList is not built using the blocks either, so the block report will be empty (I comment in HDFS-7435). All the above makes the BlockReportStats dubious to me, though this patch seems independent.

          Show
          liuml07 Mingliang Liu added a comment - Thanks for your review and comment. No, the change was not intentional. Actually I should have been more careful when I made the change. I was thinking the overall overhead to run the tests is very small even if all ops have a larger default scale. I don't think they all need this change. The v1 patch is to change the BlockReportStats only. While debugging the code, I've no idea how numOpsRequired is explained in BlockReportStats (perhaps a bad design). When addBlock() adds blocks in datanode, the TinyDatanode is not really updating the blocks list (perhaps a bug). Moreover, the blockReportList is not built using the blocks either, so the block report will be empty (I comment in HDFS-7435 ). All the above makes the BlockReportStats dubious to me, though this patch seems independent.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 12m 6s trunk passed
          +1 compile 1m 29s trunk passed with JDK v1.8.0_66
          +1 compile 1m 17s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 1m 31s trunk passed
          +1 mvneclipse 0m 22s trunk passed
          +1 findbugs 3m 7s trunk passed
          +1 javadoc 2m 16s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 24s trunk passed with JDK v1.7.0_85
          +1 mvninstall 1m 31s the patch passed
          +1 compile 1m 47s the patch passed with JDK v1.8.0_66
          -1 javac 12m 6s hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 33, now 33).
          +1 javac 1m 47s the patch passed
          +1 compile 1m 22s the patch passed with JDK v1.7.0_85
          -1 javac 13m 29s hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 35, now 35).
          +1 javac 1m 22s the patch passed
          +1 checkstyle 0m 28s the patch passed
          +1 mvnsite 1m 37s the patch passed
          +1 mvneclipse 0m 23s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 38s the patch passed
          +1 javadoc 2m 18s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 15s the patch passed with JDK v1.7.0_85
          -1 unit 94m 20s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 96m 32s hadoop-hdfs in the patch failed with JDK v1.7.0_85.
          -1 asflicense 0m 26s Patch generated 56 ASF License warnings.
          238m 54s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.web.TestWebHdfsTimeouts
            hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
            hadoop.hdfs.server.namenode.TestQuotaByStorageType
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
            hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider
            hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks
            hadoop.security.TestPermission
            hadoop.hdfs.server.datanode.TestDirectoryScanner
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.TestEncryptionZones
            org.apache.hadoop.hdfs.TestRenameWhileOpen
            org.apache.hadoop.hdfs.TestParallelShortCircuitReadUnCached
          JDK v1.7.0_85 Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
            hadoop.hdfs.server.balancer.TestBalancerWithSaslDataTransfer
            hadoop.hdfs.server.namenode.TestAuditLogs
            hadoop.hdfs.TestReadStripedFileWithDecoding
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.TestReplication
            hadoop.security.TestPermission
            hadoop.hdfs.server.datanode.TestDirectoryScanner



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774209/HDFS-9436.001.patch
          JIRA Issue HDFS-9436
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 323e75b90a91 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 23c625e
          findbugs v3.0.0
          javac hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HDFS-Build/13652/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          javac hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-HDFS-Build/13652/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13652/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13652/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13652/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13652/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13652/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13652/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 75MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13652/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 12m 6s trunk passed +1 compile 1m 29s trunk passed with JDK v1.8.0_66 +1 compile 1m 17s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 26s trunk passed +1 mvnsite 1m 31s trunk passed +1 mvneclipse 0m 22s trunk passed +1 findbugs 3m 7s trunk passed +1 javadoc 2m 16s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 24s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 31s the patch passed +1 compile 1m 47s the patch passed with JDK v1.8.0_66 -1 javac 12m 6s hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 33, now 33). +1 javac 1m 47s the patch passed +1 compile 1m 22s the patch passed with JDK v1.7.0_85 -1 javac 13m 29s hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 35, now 35). +1 javac 1m 22s the patch passed +1 checkstyle 0m 28s the patch passed +1 mvnsite 1m 37s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 38s the patch passed +1 javadoc 2m 18s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 15s the patch passed with JDK v1.7.0_85 -1 unit 94m 20s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 96m 32s hadoop-hdfs in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 26s Patch generated 56 ASF License warnings. 238m 54s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.web.TestWebHdfsTimeouts   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.server.namenode.TestQuotaByStorageType   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider   hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks   hadoop.security.TestPermission   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.TestEncryptionZones   org.apache.hadoop.hdfs.TestRenameWhileOpen   org.apache.hadoop.hdfs.TestParallelShortCircuitReadUnCached JDK v1.7.0_85 Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.server.balancer.TestBalancerWithSaslDataTransfer   hadoop.hdfs.server.namenode.TestAuditLogs   hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.TestReplication   hadoop.security.TestPermission   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774209/HDFS-9436.001.patch JIRA Issue HDFS-9436 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 323e75b90a91 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 23c625e findbugs v3.0.0 javac hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HDFS-Build/13652/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt javac hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-HDFS-Build/13652/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13652/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13652/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13652/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13652/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13652/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13652/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13652/console This message was automatically generated.
          Hide
          shv Konstantin Shvachko added a comment -

          In BlockReportStats

          • numOpsRequired means the total number of block reports processed by NN from all DNs
          • numThreads is the number of DNs, sending the reports, each as a separate thread
          • addBlock() appends a new block to the list of blocks, which represents replicas to be reported. The list is formed from "real" blocks first and then padded by fake ones.
          • blockReportList is a sequence of longs, representing the actual report of all the replicas in blocks, which is sent to the NN

          Hope this clarifies. A better JavaDoc is always welcome.

          I think everything works as expected, except the EMPTY array introduced as you mentioned by HDFS-7435. We should fix it in a different jira.

          Show
          shv Konstantin Shvachko added a comment - In BlockReportStats numOpsRequired means the total number of block reports processed by NN from all DNs numThreads is the number of DNs, sending the reports, each as a separate thread addBlock() appends a new block to the list of blocks , which represents replicas to be reported. The list is formed from "real" blocks first and then padded by fake ones. blockReportList is a sequence of longs, representing the actual report of all the replicas in blocks , which is sent to the NN Hope this clarifies. A better JavaDoc is always welcome. I think everything works as expected, except the EMPTY array introduced as you mentioned by HDFS-7435 . We should fix it in a different jira.
          Hide
          liuml07 Mingliang Liu added a comment -

          Thank you very much for the detailed explanation. This is very helpful to me to understand the benchmark.

          1. The numOpsRequired default value 10 and number of datanodes default 10 together seem OK. So perhaps we don't need to change numOpsRequired here?
          2. My second concern in last comment was that TinyDatanode#blocks is an empty ArrayList with initial capacity. In TinyDatanode#addBlock() first statement, the if(nrBlocks == blocks.size()) { will always be true. I believe this is wrong in current trunk code. We should either fill the blocks with dummy report in TinyDatanode() constructor, or use initial capacity instead of blocks.size() in the above if statement (we should replace ArrayList#set with ArrayList#add as well). The overall change is like following (not tested):
            diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java
            index 4db4da0..0ff7893 100644
            --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java
            +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java
            @@ -929,6 +929,7 @@ long executeOp(int daemonId, int inputIdx, String ignore)
                 int nrBlocks; // actual number of blocks
                 BlockListAsLongs blockReportList;
                 final int dnIdx;
            +    private final int blockCapacity;
            
                 private static int getNodePort(int num) throws IOException {
                   int port = 1 + num;
            @@ -939,6 +940,7 @@ private static int getNodePort(int num) throws IOException {
                 TinyDatanode(int dnIdx, int blockCapacity) throws IOException {
                   this.dnIdx = dnIdx;
                   this.blocks = new ArrayList<BlockReportReplica>(blockCapacity);
            +      this.blockCapacity = blockCapacity;
                   this.nrBlocks = 0;
                 }
            
            @@ -996,22 +998,22 @@ void sendHeartbeat() throws IOException {
                 }
            
                 boolean addBlock(Block blk) {
            -      if(nrBlocks == blocks.size()) {
            +      if(nrBlocks == blockCapacity) {
                     if(LOG.isDebugEnabled()) {
                       LOG.debug("Cannot add block: datanode capacity = " + blocks.size());
                     }
                     return false;
                   }
            -      blocks.set(nrBlocks, new BlockReportReplica(blk));
            +      blocks.add(new BlockReportReplica(blk));
                   nrBlocks++;
                   return true;
                 }
            
                 void formBlockReport() {
                   // fill remaining slots with blocks that do not exist
            -      for (int idx = blocks.size()-1; idx >= nrBlocks; idx--) {
            +      for (int idx = blockCapacity - 1; idx >= nrBlocks; idx--) {
                     Block block = new Block(blocks.size() - idx, 0, 0);
            -        blocks.set(idx, new BlockReportReplica(block));
            +        blocks.add(new BlockReportReplica(block));
                   }
                   blockReportList = BlockListAsLongs.EMPTY;
                 }
            

            Scroll down if not fully shown.

          Show
          liuml07 Mingliang Liu added a comment - Thank you very much for the detailed explanation. This is very helpful to me to understand the benchmark. The numOpsRequired default value 10 and number of datanodes default 10 together seem OK. So perhaps we don't need to change numOpsRequired here? My second concern in last comment was that TinyDatanode#blocks is an empty ArrayList with initial capacity. In TinyDatanode#addBlock() first statement, the if(nrBlocks == blocks.size()) { will always be true. I believe this is wrong in current trunk code. We should either fill the blocks with dummy report in TinyDatanode() constructor, or use initial capacity instead of blocks.size() in the above if statement (we should replace ArrayList#set with ArrayList#add as well). The overall change is like following (not tested): diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java index 4db4da0..0ff7893 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java @@ -929,6 +929,7 @@ long executeOp( int daemonId, int inputIdx, String ignore) int nrBlocks; // actual number of blocks BlockListAsLongs blockReportList; final int dnIdx; + private final int blockCapacity; private static int getNodePort( int num) throws IOException { int port = 1 + num; @@ -939,6 +940,7 @@ private static int getNodePort( int num) throws IOException { TinyDatanode( int dnIdx, int blockCapacity) throws IOException { this .dnIdx = dnIdx; this .blocks = new ArrayList<BlockReportReplica>(blockCapacity); + this .blockCapacity = blockCapacity; this .nrBlocks = 0; } @@ -996,22 +998,22 @@ void sendHeartbeat() throws IOException { } boolean addBlock(Block blk) { - if (nrBlocks == blocks.size()) { + if (nrBlocks == blockCapacity) { if (LOG.isDebugEnabled()) { LOG.debug( "Cannot add block: datanode capacity = " + blocks.size()); } return false ; } - blocks.set(nrBlocks, new BlockReportReplica(blk)); + blocks.add( new BlockReportReplica(blk)); nrBlocks++; return true ; } void formBlockReport() { // fill remaining slots with blocks that do not exist - for ( int idx = blocks.size()-1; idx >= nrBlocks; idx--) { + for ( int idx = blockCapacity - 1; idx >= nrBlocks; idx--) { Block block = new Block(blocks.size() - idx, 0, 0); - blocks.set(idx, new BlockReportReplica(block)); + blocks.add( new BlockReportReplica(block)); } blockReportList = BlockListAsLongs.EMPTY; } Scroll down if not fully shown.
          Hide
          liuml07 Mingliang Liu added a comment -

          I updated the JIRA HDFS-9484 to track the effort of fixing the potential bugs. Let's work on default 10 datanodes for test here.

          Show
          liuml07 Mingliang Liu added a comment - I updated the JIRA HDFS-9484 to track the effort of fixing the potential bugs. Let's work on default 10 datanodes for test here.
          Hide
          shv Konstantin Shvachko added a comment -

          numOpsRequired = 10 and the nuDatanodes = 10 implies that each DN sends exactly one block report. I'd probably prefer a couple of block reports per DN for better testing, but it's up to you.
          Otherwise patch looks good.

          Show
          shv Konstantin Shvachko added a comment - numOpsRequired = 10 and the nuDatanodes = 10 implies that each DN sends exactly one block report. I'd probably prefer a couple of block reports per DN for better testing, but it's up to you. Otherwise patch looks good.
          Hide
          liuml07 Mingliang Liu added a comment -

          Thank you very much Konstantin Shvachko for your review. Sending a couple of block reports makes perfect sense to me. The v2 patch is to address.

          Show
          liuml07 Mingliang Liu added a comment - Thank you very much Konstantin Shvachko for your review. Sending a couple of block reports makes perfect sense to me. The v2 patch is to address.
          Hide
          shv Konstantin Shvachko added a comment -

          Three is better.
          +1

          Show
          shv Konstantin Shvachko added a comment - Three is better. +1
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 10m 27s trunk passed
          +1 compile 1m 3s trunk passed with JDK v1.8.0_66
          +1 compile 0m 59s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 1m 17s trunk passed
          +1 mvneclipse 0m 21s trunk passed
          +1 findbugs 2m 42s trunk passed
          +1 javadoc 1m 39s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 35s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 11s the patch passed
          +1 compile 1m 6s the patch passed with JDK v1.8.0_66
          -1 javac 9m 13s hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 33, now 33).
          +1 javac 1m 6s the patch passed
          +1 compile 1m 0s the patch passed with JDK v1.7.0_91
          -1 javac 10m 14s hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 35, now 35).
          +1 javac 1m 0s the patch passed
          +1 checkstyle 0m 21s the patch passed
          +1 mvnsite 1m 13s the patch passed
          +1 mvneclipse 0m 19s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 45s the patch passed
          +1 javadoc 1m 32s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 31s the patch passed with JDK v1.7.0_91
          -1 unit 89m 27s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 88m 5s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 24s Patch generated 56 ASF License warnings.
          215m 12s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.datanode.TestDirectoryScanner
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.web.TestWebHDFS



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775437/HDFS-9436.002.patch
          JIRA Issue HDFS-9436
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ec291a421dfe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6b9a5be
          findbugs v3.0.0
          javac hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HDFS-Build/13743/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          javac hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HDFS-Build/13743/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13743/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13743/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13743/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13743/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13743/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13743/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13743/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 10m 27s trunk passed +1 compile 1m 3s trunk passed with JDK v1.8.0_66 +1 compile 0m 59s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 17s trunk passed +1 mvneclipse 0m 21s trunk passed +1 findbugs 2m 42s trunk passed +1 javadoc 1m 39s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 35s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 11s the patch passed +1 compile 1m 6s the patch passed with JDK v1.8.0_66 -1 javac 9m 13s hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 33, now 33). +1 javac 1m 6s the patch passed +1 compile 1m 0s the patch passed with JDK v1.7.0_91 -1 javac 10m 14s hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 35, now 35). +1 javac 1m 0s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 1m 13s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 45s the patch passed +1 javadoc 1m 32s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 31s the patch passed with JDK v1.7.0_91 -1 unit 89m 27s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 88m 5s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 24s Patch generated 56 ASF License warnings. 215m 12s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.web.TestWebHDFS Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775437/HDFS-9436.002.patch JIRA Issue HDFS-9436 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ec291a421dfe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6b9a5be findbugs v3.0.0 javac hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HDFS-Build/13743/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt javac hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HDFS-Build/13743/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13743/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13743/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13743/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13743/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13743/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13743/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13743/console This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          The failing tests seem unrelated.

          Specially, hadoop.hdfs.server.datanode.TestDirectoryScanner is tracked by HDFS-9300, TestShortCircuitCache#testDataXceiverCleansUpSlotsOnFailure tracked by HDFS-9466. Other failing tests can be investigated separately.

          Show
          liuml07 Mingliang Liu added a comment - The failing tests seem unrelated. Specially, hadoop.hdfs.server.datanode.TestDirectoryScanner is tracked by HDFS-9300 , TestShortCircuitCache#testDataXceiverCleansUpSlotsOnFailure tracked by HDFS-9466 . Other failing tests can be investigated separately.
          Hide
          shv Konstantin Shvachko added a comment -

          I just committed this. Thank you Mingliang Liu.

          Show
          shv Konstantin Shvachko added a comment - I just committed this. Thank you Mingliang Liu .
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks for suggesting this jira, reviewing and committing the patch.

          Show
          liuml07 Mingliang Liu added a comment - Thanks for suggesting this jira, reviewing and committing the patch.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8916 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8916/)
          HDFS-9436. Make NNThroughputBenchmark$BlockReportStats run with 10 (shv: rev e71aa717d42f6472dab8eb98930df26a9025a012)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8916 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8916/ ) HDFS-9436 . Make NNThroughputBenchmark$BlockReportStats run with 10 (shv: rev e71aa717d42f6472dab8eb98930df26a9025a012) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #663 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/663/)
          HDFS-9436. Make NNThroughputBenchmark$BlockReportStats run with 10 (shv: rev e71aa717d42f6472dab8eb98930df26a9025a012)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #663 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/663/ ) HDFS-9436 . Make NNThroughputBenchmark$BlockReportStats run with 10 (shv: rev e71aa717d42f6472dab8eb98930df26a9025a012) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          leftnoteasy Wangda Tan added a comment -

          Committed to branch-2.8.

          Show
          leftnoteasy Wangda Tan added a comment - Committed to branch-2.8.

            People

            • Assignee:
              liuml07 Mingliang Liu
              Reporter:
              liuml07 Mingliang Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development