Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9393

After choosing favored nodes, choosing nodes for remaining replicas should go through BlockPlacementPolicy

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Current Behavior is :
      After choosing replicas from passed favored nodes , choosing nodes for remaining replica does not go through BlockPlacementPolicy.

      Hence eventhough there is a local client datanode is available and not passed as part of favored nodes , probability for choosing local datanode is less.

      1. HDFS-9393.3.patch
        6 kB
        J.Andreina
      2. HDFS-9393.2.patch
        6 kB
        J.Andreina
      3. HDFS-9393.1.patch
        7 kB
        J.Andreina

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8995 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8995/)
        HDFS-9393. After choosing favored nodes, choosing nodes for remaining (vinayakumarb: rev bfadf11b36e9d97e03d6ed1e71829907c2301412)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestReplicationPolicy.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestReplicationPolicyWithNodeGroup.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyDefault.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8995 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8995/ ) HDFS-9393 . After choosing favored nodes, choosing nodes for remaining (vinayakumarb: rev bfadf11b36e9d97e03d6ed1e71829907c2301412) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestReplicationPolicy.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestReplicationPolicyWithNodeGroup.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyDefault.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        vinayrpet Vinayakumar B added a comment -

        Committed to trunk,branch-2 and branch-2.8
        Thanks J.Andreina for the contribution.
        Thanks Kihwal Lee for the review.

        Show
        vinayrpet Vinayakumar B added a comment - Committed to trunk,branch-2 and branch-2.8 Thanks J.Andreina for the contribution. Thanks Kihwal Lee for the review.
        Hide
        kihwal Kihwal Lee added a comment -

        +1 from me too.

        Show
        kihwal Kihwal Lee added a comment - +1 from me too.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 8m 24s trunk passed
        +1 compile 0m 46s trunk passed with JDK v1.8.0_66
        +1 compile 0m 47s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 17s trunk passed
        +1 mvnsite 1m 1s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 2m 7s trunk passed
        +1 javadoc 1m 13s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 56s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 52s the patch passed
        +1 compile 0m 42s the patch passed with JDK v1.8.0_66
        +1 javac 0m 42s the patch passed
        +1 compile 0m 48s the patch passed with JDK v1.7.0_91
        +1 javac 0m 48s the patch passed
        +1 checkstyle 0m 17s the patch passed
        +1 mvnsite 0m 59s the patch passed
        +1 mvneclipse 0m 16s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 17s the patch passed
        +1 javadoc 1m 13s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 56s the patch passed with JDK v1.7.0_91
        -1 unit 73m 2s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        +1 unit 69m 42s hadoop-hdfs in the patch passed with JDK v1.7.0_91.
        -1 asflicense 0m 25s Patch generated 58 ASF License warnings.
        172m 14s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.TestDatanodeRegistration
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777919/HDFS-9393.3.patch
        JIRA Issue HDFS-9393
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 1bca70e810eb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f741476
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13912/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13912/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13912/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13912/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13912/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 24s trunk passed +1 compile 0m 46s trunk passed with JDK v1.8.0_66 +1 compile 0m 47s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 17s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 7s trunk passed +1 javadoc 1m 13s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 56s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 52s the patch passed +1 compile 0m 42s the patch passed with JDK v1.8.0_66 +1 javac 0m 42s the patch passed +1 compile 0m 48s the patch passed with JDK v1.7.0_91 +1 javac 0m 48s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 17s the patch passed +1 javadoc 1m 13s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 56s the patch passed with JDK v1.7.0_91 -1 unit 73m 2s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 69m 42s hadoop-hdfs in the patch passed with JDK v1.7.0_91. -1 asflicense 0m 25s Patch generated 58 ASF License warnings. 172m 14s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.TestDatanodeRegistration   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777919/HDFS-9393.3.patch JIRA Issue HDFS-9393 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1bca70e810eb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f741476 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13912/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13912/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13912/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13912/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13912/console This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Thanks J.Andreina for the patch.
        Changes looks good.

        Jenkins report looks flaky.
        Kicked one more build, will wait for the report.

        Show
        vinayrpet Vinayakumar B added a comment - Thanks J.Andreina for the patch. Changes looks good. Jenkins report looks flaky. Kicked one more build, will wait for the report.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 1s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 26m 20s trunk passed
        +1 compile 3m 42s trunk passed with JDK v1.8.0_66
        +1 compile 2m 20s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 52s trunk passed
        +1 mvnsite 3m 12s trunk passed
        +1 mvneclipse 0m 48s trunk passed
        +1 findbugs 6m 16s trunk passed
        +1 javadoc 3m 24s trunk passed with JDK v1.8.0_66
        +1 javadoc 4m 33s trunk passed with JDK v1.7.0_91
        +1 mvninstall 2m 32s the patch passed
        +1 compile 2m 58s the patch passed with JDK v1.8.0_66
        +1 javac 2m 58s the patch passed
        +1 compile 2m 6s the patch passed with JDK v1.7.0_91
        +1 javac 2m 6s the patch passed
        +1 checkstyle 0m 38s the patch passed
        +1 mvnsite 2m 30s the patch passed
        +1 mvneclipse 0m 35s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 5m 11s the patch passed
        +1 javadoc 2m 54s the patch passed with JDK v1.8.0_66
        +1 javadoc 4m 26s the patch passed with JDK v1.7.0_91
        -1 unit 187m 13s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 159m 2s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        -1 asflicense 1m 1s Patch generated 56 ASF License warnings.
        430m 35s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
          hadoop.hdfs.TestWriteConfigurationToDFS
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.tracing.TestTracing
          hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
          hadoop.hdfs.TestDFSUpgrade
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure120
          hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140
          hadoop.hdfs.TestLocalDFS
          hadoop.hdfs.TestReadStripedFileWithDecoding
          hadoop.hdfs.server.namenode.TestMetadataVersionOutput
          hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
          hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
          hadoop.hdfs.tools.TestDFSAdminWithHA
          hadoop.hdfs.TestDistributedFileSystem
          hadoop.hdfs.server.namenode.TestSecurityTokenEditLog
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.fs.TestSymlinkHdfsFileContext
          hadoop.fs.TestSymlinkHdfsFileSystem
          hadoop.hdfs.qjournal.TestSecureNNWithQJM
          hadoop.hdfs.server.namenode.TestFileTruncate
          hadoop.hdfs.TestEncryptionZones
          hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider
          hadoop.hdfs.server.datanode.TestDirectoryScanner
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.TestPersistBlocks
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140
          hadoop.hdfs.TestLocalDFS
          hadoop.hdfs.server.namenode.TestMetadataVersionOutput
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.namenode.TestBackupNode
          hadoop.hdfs.TestDistributedFileSystem
          hadoop.hdfs.server.namenode.TestSecurityTokenEditLog
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.server.namenode.TestDecommissioningStatus
          hadoop.hdfs.qjournal.TestSecureNNWithQJM
          hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
          hadoop.hdfs.server.namenode.TestFileTruncate
          hadoop.hdfs.TestEncryptionZones
          hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider
          hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure190



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777919/HDFS-9393.3.patch
        JIRA Issue HDFS-9393
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 7eaee3467aa9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ae67c84
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13889/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13889/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13889/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13889/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13889/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13889/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 75MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13889/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 1s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 26m 20s trunk passed +1 compile 3m 42s trunk passed with JDK v1.8.0_66 +1 compile 2m 20s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 52s trunk passed +1 mvnsite 3m 12s trunk passed +1 mvneclipse 0m 48s trunk passed +1 findbugs 6m 16s trunk passed +1 javadoc 3m 24s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 33s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 32s the patch passed +1 compile 2m 58s the patch passed with JDK v1.8.0_66 +1 javac 2m 58s the patch passed +1 compile 2m 6s the patch passed with JDK v1.7.0_91 +1 javac 2m 6s the patch passed +1 checkstyle 0m 38s the patch passed +1 mvnsite 2m 30s the patch passed +1 mvneclipse 0m 35s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 5m 11s the patch passed +1 javadoc 2m 54s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 26s the patch passed with JDK v1.7.0_91 -1 unit 187m 13s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 159m 2s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 1m 1s Patch generated 56 ASF License warnings. 430m 35s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure   hadoop.hdfs.TestWriteConfigurationToDFS   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.tracing.TestTracing   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.TestDFSUpgrade   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure120   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140   hadoop.hdfs.TestLocalDFS   hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.server.namenode.TestMetadataVersionOutput   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.tools.TestDFSAdminWithHA   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.server.namenode.TestSecurityTokenEditLog   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.fs.TestSymlinkHdfsFileSystem   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140   hadoop.hdfs.TestLocalDFS   hadoop.hdfs.server.namenode.TestMetadataVersionOutput   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.TestBackupNode   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.server.namenode.TestSecurityTokenEditLog   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure190 Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777919/HDFS-9393.3.patch JIRA Issue HDFS-9393 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7eaee3467aa9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ae67c84 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13889/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13889/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13889/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13889/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13889/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13889/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13889/console This message was automatically generated.
        Hide
        andreina J.Andreina added a comment -

        Updated the patch fixing whitespace.
        Testcase failures are unrelated
        Please review.

        Show
        andreina J.Andreina added a comment - Updated the patch fixing whitespace. Testcase failures are unrelated Please review.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 7m 32s trunk passed
        +1 compile 0m 38s trunk passed with JDK v1.8.0_66
        +1 compile 0m 41s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 15s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 49s trunk passed
        +1 javadoc 1m 6s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 43s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 48s the patch passed
        +1 compile 0m 41s the patch passed with JDK v1.8.0_66
        +1 javac 0m 41s the patch passed
        +1 compile 0m 40s the patch passed with JDK v1.7.0_91
        +1 javac 0m 40s the patch passed
        +1 checkstyle 0m 15s the patch passed
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 2m 2s the patch passed
        +1 javadoc 1m 7s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 46s the patch passed with JDK v1.7.0_91
        -1 unit 61m 6s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 52m 54s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        -1 asflicense 0m 19s Patch generated 58 ASF License warnings.
        140m 27s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
          hadoop.hdfs.server.namenode.TestFileTruncate
          hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.datanode.TestBlockScanner
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestBlockReplacement



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777687/HDFS-9393.2.patch
        JIRA Issue HDFS-9393
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 91e2ebd8e081 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5b7078d
        findbugs v3.0.0
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13875/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13875/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13875/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13875/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13875/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13875/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13875/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 75MB
        Powered by Apache Yetus 0.1.0 http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13875/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 32s trunk passed +1 compile 0m 38s trunk passed with JDK v1.8.0_66 +1 compile 0m 41s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 49s trunk passed +1 javadoc 1m 6s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 43s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 48s the patch passed +1 compile 0m 41s the patch passed with JDK v1.8.0_66 +1 javac 0m 41s the patch passed +1 compile 0m 40s the patch passed with JDK v1.7.0_91 +1 javac 0m 40s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 2m 2s the patch passed +1 javadoc 1m 7s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 46s the patch passed with JDK v1.7.0_91 -1 unit 61m 6s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 52m 54s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 19s Patch generated 58 ASF License warnings. 140m 27s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.datanode.TestBlockScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestBlockReplacement Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777687/HDFS-9393.2.patch JIRA Issue HDFS-9393 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 91e2ebd8e081 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5b7078d findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13875/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13875/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13875/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13875/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13875/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13875/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13875/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 75MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13875/console This message was automatically generated.
        Hide
        andreina J.Andreina added a comment -

        Updated the patch with latest code.
        Please review.

        Show
        andreina J.Andreina added a comment - Updated the patch with latest code. Please review.
        Hide
        andreina J.Andreina added a comment -

        Testcase failures are unrelated.
        Please review.

        Show
        andreina J.Andreina added a comment - Testcase failures are unrelated. Please review.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 9m 33s trunk passed
        +1 compile 0m 57s trunk passed with JDK v1.8.0_66
        +1 compile 0m 53s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 19s trunk passed
        +1 mvnsite 1m 6s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        +1 findbugs 2m 28s trunk passed
        +1 javadoc 1m 27s trunk passed with JDK v1.8.0_66
        +1 javadoc 2m 19s trunk passed with JDK v1.7.0_91
        +1 mvninstall 1m 3s the patch passed
        +1 compile 0m 57s the patch passed with JDK v1.8.0_66
        +1 javac 0m 57s the patch passed
        +1 compile 0m 55s the patch passed with JDK v1.7.0_91
        +1 javac 0m 55s the patch passed
        +1 checkstyle 0m 20s the patch passed
        +1 mvnsite 1m 8s the patch passed
        +1 mvneclipse 0m 18s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 40s the patch passed
        +1 javadoc 1m 33s the patch passed with JDK v1.8.0_66
        +1 javadoc 2m 38s the patch passed with JDK v1.7.0_91
        -1 unit 86m 37s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 84m 6s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        -1 asflicense 0m 25s Patch generated 56 ASF License warnings.
        207m 16s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.shortcircuit.TestShortCircuitCache
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.server.namenode.TestBackupNode
          hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
          hadoop.hdfs.server.mover.TestStorageMover
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
          hadoop.hdfs.server.namenode.ha.TestHAAppend
          hadoop.hdfs.server.namenode.TestDecommissioningStatus
          hadoop.hdfs.server.datanode.TestDirectoryScanner
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
          hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.datanode.TestDirectoryScanner



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775226/HDFS-9393.1.patch
        JIRA Issue HDFS-9393
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 049d46b86b24 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 3c4a34e
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13730/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13730/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13730/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13730/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13730/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13730/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 76MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13730/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 9m 33s trunk passed +1 compile 0m 57s trunk passed with JDK v1.8.0_66 +1 compile 0m 53s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 19s trunk passed +1 mvnsite 1m 6s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 2m 28s trunk passed +1 javadoc 1m 27s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 19s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 3s the patch passed +1 compile 0m 57s the patch passed with JDK v1.8.0_66 +1 javac 0m 57s the patch passed +1 compile 0m 55s the patch passed with JDK v1.7.0_91 +1 javac 0m 55s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 1m 8s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 40s the patch passed +1 javadoc 1m 33s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 38s the patch passed with JDK v1.7.0_91 -1 unit 86m 37s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 84m 6s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 25s Patch generated 56 ASF License warnings. 207m 16s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.namenode.TestBackupNode   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.server.mover.TestStorageMover   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775226/HDFS-9393.1.patch JIRA Issue HDFS-9393 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 049d46b86b24 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3c4a34e findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13730/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13730/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13730/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13730/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13730/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13730/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13730/console This message was automatically generated.
        Hide
        andreina J.Andreina added a comment -

        uploaded a patch , where changes are done by passing a fresh chosenNodes to choose targets if no enough favored nodes.
        This would help in not avoiding to choose local node as a target if not part of favored nodes (will go through block placement policy if there is no enough favored nodes).

        Please review.

        Show
        andreina J.Andreina added a comment - uploaded a patch , where changes are done by passing a fresh chosenNodes to choose targets if no enough favored nodes. This would help in not avoiding to choose local node as a target if not part of favored nodes (will go through block placement policy if there is no enough favored nodes). Please review.

          People

          • Assignee:
            andreina J.Andreina
            Reporter:
            andreina J.Andreina
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development