[HDFS-9387] Fix namenodeUri parameter parsing in NNThroughputBenchmark

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: test
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Mingliang Liu
• Reporter: Mingliang Liu
• Created: 05/Nov/15 23:19
• Updated: 30/Aug/16 01:23
• Resolved: 17/Nov/15 00:34

Description

In NNThroughputBenchmark$OperationStatsBase#verifyOpArgument(), the namenodeUri is always parsed from -namenode argument. This works just fine if the -op parameter is not all, as the single benchmark will need to parse the namenodeUri from args anyway.

When the -op is all, namely all sub-benchmark will run, multiple sub-benchmark will call the verifyOpArgument() method. In this case, the first sub-benchmark reads the namenode argument and removes it from args. The other sub-benchmarks will thereafter read null value since the argument is removed. This contradicts the intension of providing namenode for all sub-benchmarks.

current code

      try {
        namenodeUri = StringUtils.popOptionWithArgument("-namenode", args);
      } catch (IllegalArgumentException iae) {
        printUsage();
      }

The fix is to parse the namenodeUri, which is shared by all sub-benchmarks, from -namenode argument only once. This follows the convention of parsing other global arguments in OperationStatsBase#verifyOpArgument().

simple fix

      if (args.indexOf("-namenode") >= 0) {
        try {
          namenodeUri = StringUtils.popOptionWithArgument("-namenode", args);
        } catch (IllegalArgumentException iae) {
          printUsage();
        }
      }

Issue Links

• is related to: HDFS-9421 NNThroughputBenchmark replication test NPE with -namenode option