Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9365

Balancer does not work with the HDFS-6376 HA setup

    Details

    • Hadoop Flags:
      Reviewed

      Description

      HDFS-6376 added support for DistCp between two HA clusters. After the change, Balaner will use all the NN from both the local and the remote clusters.

      1. h9365_20160523.patch
        23 kB
        Tsz Wo Nicholas Sze
      2. h9365_20151120.patch
        24 kB
        Tsz Wo Nicholas Sze
      3. h9365_20151119.patch
        24 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Revised summary and description.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Revised summary and description.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          h9365_20151119.patch: changes balancer and mover to call getInternalNameServiceUris.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - h9365_20151119.patch: changes balancer and mover to call getInternalNameServiceUris.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
          +1 mvninstall 7m 36s trunk passed
          +1 compile 0m 38s trunk passed with JDK v1.8.0_66
          +1 compile 0m 41s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 15s trunk passed
          +1 mvnsite 0m 52s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 55s trunk passed
          +1 javadoc 1m 8s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 46s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 47s the patch passed
          +1 compile 0m 37s the patch passed with JDK v1.8.0_66
          +1 javac 0m 37s the patch passed
          +1 compile 0m 44s the patch passed with JDK v1.7.0_85
          +1 javac 0m 44s the patch passed
          -1 checkstyle 0m 15s Patch generated 2 new checkstyle issues in hadoop-hdfs-project/hadoop-hdfs (total was 110, now 109).
          +1 mvnsite 0m 51s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 4s the patch passed
          +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 52s the patch passed with JDK v1.7.0_85
          -1 unit 51m 59s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 49m 46s hadoop-hdfs in the patch failed with JDK v1.7.0_85.
          -1 asflicense 0m 20s Patch generated 58 ASF License warnings.
          128m 21s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestLeaseRecovery2
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.TestRecoverStripedFile
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.TestReplaceDatanodeOnFailure
          JDK v1.7.0_85 Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2015-11-20
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773427/h9365_20151119.patch
          JIRA Issue HDFS-9365
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0ed864245045 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build@2/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh
          git revision trunk / 4539131
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13573/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13573/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13573/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13573/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13573/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13573/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13573/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 77MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13573/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files. +1 mvninstall 7m 36s trunk passed +1 compile 0m 38s trunk passed with JDK v1.8.0_66 +1 compile 0m 41s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 55s trunk passed +1 javadoc 1m 8s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 46s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 47s the patch passed +1 compile 0m 37s the patch passed with JDK v1.8.0_66 +1 javac 0m 37s the patch passed +1 compile 0m 44s the patch passed with JDK v1.7.0_85 +1 javac 0m 44s the patch passed -1 checkstyle 0m 15s Patch generated 2 new checkstyle issues in hadoop-hdfs-project/hadoop-hdfs (total was 110, now 109). +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 4s the patch passed +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 52s the patch passed with JDK v1.7.0_85 -1 unit 51m 59s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 49m 46s hadoop-hdfs in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 20s Patch generated 58 ASF License warnings. 128m 21s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestLeaseRecovery2   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.TestReplaceDatanodeOnFailure JDK v1.7.0_85 Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure Subsystem Report/Notes Docker Image:yetus/hadoop:date2015-11-20 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773427/h9365_20151119.patch JIRA Issue HDFS-9365 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0ed864245045 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build@2/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh git revision trunk / 4539131 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13573/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13573/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13573/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13573/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13573/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13573/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13573/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13573/console This message was automatically generated.
          Hide
          rakeshr Rakesh R added a comment -

          Thanks Tsz Wo Nicholas Sze for the patch. Few minor comments, apart from that it looks fine for me.

          1. DFSUtil#getInternalNameServiceIds - javadoc is missing. Also, it would be good to revisit the javadocs of other APIs which are using InternalNameServices.
          2. Incorrect format.
            !ids.isEmpty()? ids:  DFSUtilClient.getNameServiceIds(conf);
            
          3. Please take a look at the checkstyle warnings related to the patch.
          Show
          rakeshr Rakesh R added a comment - Thanks Tsz Wo Nicholas Sze for the patch. Few minor comments, apart from that it looks fine for me. DFSUtil#getInternalNameServiceIds - javadoc is missing. Also, it would be good to revisit the javadocs of other APIs which are using InternalNameServices. Incorrect format. !ids.isEmpty()? ids: DFSUtilClient.getNameServiceIds(conf); Please take a look at the checkstyle warnings related to the patch.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          h9365_20151120.patch: addresses Rakesh's comment.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - h9365_20151120.patch: addresses Rakesh's comment.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
          +1 mvninstall 9m 51s trunk passed
          +1 compile 1m 3s trunk passed with JDK v1.8.0_66
          +1 compile 0m 55s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 20s trunk passed
          +1 mvnsite 1m 9s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 2m 32s trunk passed
          +1 javadoc 1m 30s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 23s trunk passed with JDK v1.7.0_85
          +1 mvninstall 1m 3s the patch passed
          +1 compile 1m 4s the patch passed with JDK v1.8.0_66
          +1 javac 1m 4s the patch passed
          +1 compile 0m 55s the patch passed with JDK v1.7.0_85
          +1 javac 0m 55s the patch passed
          +1 checkstyle 0m 20s the patch passed
          +1 mvnsite 1m 8s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 45s the patch passed
          +1 javadoc 1m 30s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 24s the patch passed with JDK v1.7.0_85
          -1 unit 93m 50s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 94m 59s hadoop-hdfs in the patch failed with JDK v1.7.0_85.
          -1 asflicense 0m 29s Patch generated 56 ASF License warnings.
          240m 2s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.TestPersistBlocks
            hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.datanode.TestDirectoryScanner
          JDK v1.7.0_85 Failed junit tests hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.TestLocalDFS
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.TestSafeModeWithStripedFile
            hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.server.datanode.TestBPOfferService
            hadoop.hdfs.server.datanode.TestDirectoryScanner



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773635/h9365_20151120.patch
          JIRA Issue HDFS-9365
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0cb972d95d8b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a30eccb
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13593/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13593/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13593/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13593/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13593/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13593/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13593/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files. +1 mvninstall 9m 51s trunk passed +1 compile 1m 3s trunk passed with JDK v1.8.0_66 +1 compile 0m 55s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 20s trunk passed +1 mvnsite 1m 9s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 32s trunk passed +1 javadoc 1m 30s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 23s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 3s the patch passed +1 compile 1m 4s the patch passed with JDK v1.8.0_66 +1 javac 1m 4s the patch passed +1 compile 0m 55s the patch passed with JDK v1.7.0_85 +1 javac 0m 55s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 1m 8s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 45s the patch passed +1 javadoc 1m 30s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 24s the patch passed with JDK v1.7.0_85 -1 unit 93m 50s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 94m 59s hadoop-hdfs in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 29s Patch generated 56 ASF License warnings. 240m 2s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_85 Failed junit tests hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestLocalDFS   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.TestSafeModeWithStripedFile   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.datanode.TestBPOfferService   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773635/h9365_20151120.patch JIRA Issue HDFS-9365 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0cb972d95d8b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a30eccb findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13593/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13593/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13593/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13593/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13593/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13593/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13593/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
          +1 mvninstall 8m 12s trunk passed
          +1 compile 0m 47s trunk passed with JDK v1.8.0_66
          +1 compile 0m 45s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 18s trunk passed
          +1 mvnsite 0m 55s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 2m 4s trunk passed
          +1 javadoc 1m 11s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 59s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 52s the patch passed
          +1 compile 0m 44s the patch passed with JDK v1.8.0_66
          +1 javac 0m 44s the patch passed
          +1 compile 0m 46s the patch passed with JDK v1.7.0_85
          +1 javac 0m 46s the patch passed
          +1 checkstyle 0m 17s the patch passed
          +1 mvnsite 0m 58s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 14s the patch passed
          +1 javadoc 1m 10s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 58s the patch passed with JDK v1.7.0_85
          -1 unit 56m 13s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 52m 43s hadoop-hdfs in the patch failed with JDK v1.7.0_85.
          -1 asflicense 0m 19s Patch generated 58 ASF License warnings.
          137m 42s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestDFSClientRetries
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork
            hadoop.hdfs.server.datanode.TestBlockScanner
          JDK v1.7.0_85 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773635/h9365_20151120.patch
          JIRA Issue HDFS-9365
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 9e495f2e2ec9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9b8e50b
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13692/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13692/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13692/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13692/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13692/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13692/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13692/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files. +1 mvninstall 8m 12s trunk passed +1 compile 0m 47s trunk passed with JDK v1.8.0_66 +1 compile 0m 45s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 2m 4s trunk passed +1 javadoc 1m 11s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 59s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 52s the patch passed +1 compile 0m 44s the patch passed with JDK v1.8.0_66 +1 javac 0m 44s the patch passed +1 compile 0m 46s the patch passed with JDK v1.7.0_85 +1 javac 0m 46s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 14s the patch passed +1 javadoc 1m 10s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 58s the patch passed with JDK v1.7.0_85 -1 unit 56m 13s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 52m 43s hadoop-hdfs in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 19s Patch generated 58 ASF License warnings. 137m 42s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork   hadoop.hdfs.server.datanode.TestBlockScanner JDK v1.7.0_85 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040 Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773635/h9365_20151120.patch JIRA Issue HDFS-9365 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9e495f2e2ec9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9b8e50b findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13692/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13692/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13692/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13692/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13692/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13692/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13692/console This message was automatically generated.
          Hide
          wheat9 Haohui Mai added a comment -
          -  public static Collection<URI> getNsServiceRpcUris(Configuration conf) {
          -    return getNameServiceUris(conf,
          +  public static Collection<URI> getInternalNsRpcUris(Configuration conf) {
          

          DFSConfigKeys.DFS_NAMENODE_SERVICE_RPC_ADDRESS_KEY contains both the external and the internal services name. Thus this might be problematic?

          Show
          wheat9 Haohui Mai added a comment - - public static Collection<URI> getNsServiceRpcUris(Configuration conf) { - return getNameServiceUris(conf, + public static Collection<URI> getInternalNsRpcUris(Configuration conf) { DFSConfigKeys.DFS_NAMENODE_SERVICE_RPC_ADDRESS_KEY contains both the external and the internal services name. Thus this might be problematic?
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          DFS_NAMENODE_SERVICE_RPC_ADDRESS_KEY (dfs.namenode.servicerpc-address) should contain only one address for the local service rpc server (for separating client and datanode traffic). It cannot contain more than one address. No?

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - DFS_NAMENODE_SERVICE_RPC_ADDRESS_KEY (dfs.namenode.servicerpc-address) should contain only one address for the local service rpc server (for separating client and datanode traffic). It cannot contain more than one address. No?
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Actually, do you mean combined keys DFSUtilClient.concatSuffixes(key, nsId)? The nsId is an internal ns after the patch. So I think it is fine.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Actually, do you mean combined keys DFSUtilClient.concatSuffixes(key, nsId)? The nsId is an internal ns after the patch. So I think it is fine.
          Hide
          jingzhao Jing Zhao added a comment -

          The patch looks good to me. It needs a minor rebase. Also maybe we can add a new unit test in TestDFSUtil for the scenario where more than 1 name services are passed to getNameServiceUris.

          +1 after addressing the comment.

          Show
          jingzhao Jing Zhao added a comment - The patch looks good to me. It needs a minor rebase. Also maybe we can add a new unit test in TestDFSUtil for the scenario where more than 1 name services are passed to getNameServiceUris . +1 after addressing the comment.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 4s HDFS-9365 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773635/h9365_20151120.patch
          JIRA Issue HDFS-9365
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15529/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HDFS-9365 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773635/h9365_20151120.patch JIRA Issue HDFS-9365 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15529/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          > ... Also maybe we can add a new unit test in TestDFSUtil for the scenario where more than 1 name services are passed to getNameServiceUris.

          testGetNNServiceRpcAddressesForNsIds is already changed in h9365_20151120.patch to test 2 name services. Is it the same test case you suggested?

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - > ... Also maybe we can add a new unit test in TestDFSUtil for the scenario where more than 1 name services are passed to getNameServiceUris. testGetNNServiceRpcAddressesForNsIds is already changed in h9365_20151120.patch to test 2 name services. Is it the same test case you suggested?
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          h9365_20160523.patch: sync'ed with trunk.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - h9365_20160523.patch: sync'ed with trunk.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
          +1 mvninstall 6m 56s trunk passed
          +1 compile 0m 50s trunk passed
          +1 checkstyle 0m 35s trunk passed
          +1 mvnsite 0m 59s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 55s trunk passed
          +1 javadoc 1m 10s trunk passed
          +1 mvninstall 0m 53s the patch passed
          +1 compile 0m 42s the patch passed
          +1 javac 0m 42s the patch passed
          -1 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: patch generated 2 new + 513 unchanged - 1 fixed = 515 total (was 514)
          +1 mvnsite 0m 48s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 5s the patch passed
          +1 javadoc 1m 0s the patch passed
          +1 unit 59m 28s hadoop-hdfs in the patch passed.
          +1 asflicense 0m 39s Patch does not generate ASF License warnings.
          80m 33s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805804/h9365_20160523.patch
          JIRA Issue HDFS-9365
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e9f537d2211f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b4078bd
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15533/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15533/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15533/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files. +1 mvninstall 6m 56s trunk passed +1 compile 0m 50s trunk passed +1 checkstyle 0m 35s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 55s trunk passed +1 javadoc 1m 10s trunk passed +1 mvninstall 0m 53s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed -1 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: patch generated 2 new + 513 unchanged - 1 fixed = 515 total (was 514) +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 5s the patch passed +1 javadoc 1m 0s the patch passed +1 unit 59m 28s hadoop-hdfs in the patch passed. +1 asflicense 0m 39s Patch does not generate ASF License warnings. 80m 33s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805804/h9365_20160523.patch JIRA Issue HDFS-9365 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e9f537d2211f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b4078bd Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15533/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15533/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15533/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jingzhao Jing Zhao added a comment -

          testGetNNServiceRpcAddressesForNsIds is already changed in h9365_20151120.patch to test 2 name services. Is it the same test case you suggested?

          Yes! Sorry I missed this. +1 on the latest patch.

          Show
          jingzhao Jing Zhao added a comment - testGetNNServiceRpcAddressesForNsIds is already changed in h9365_20151120.patch to test 2 name services. Is it the same test case you suggested? Yes! Sorry I missed this. +1 on the latest patch.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9849 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9849/)
          HDFS-9365. Balaner does not work with the HDFS-6376 HA setup. (szetszwo: rev 15ed080e3610b7526eff12391de780948a75fa7b)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithNodeGroup.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithHANameNodes.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestStorageMover.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9849 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9849/ ) HDFS-9365 . Balaner does not work with the HDFS-6376 HA setup. (szetszwo: rev 15ed080e3610b7526eff12391de780948a75fa7b) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithNodeGroup.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithHANameNodes.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestStorageMover.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Thanks Rakesh, Haohui and Jing for the review comments.

          I have committed this.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Thanks Rakesh, Haohui and Jing for the review comments. I have committed this.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Closing the JIRA as part of 2.7.3 release.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.
          Hide
          sjlee0 Sangjin Lee added a comment -

          Cherry-picked it to 2.6.5 with minor merge conflict resolutions.

          Show
          sjlee0 Sangjin Lee added a comment - Cherry-picked it to 2.6.5 with minor merge conflict resolutions.

            People

            • Assignee:
              szetszwo Tsz Wo Nicholas Sze
              Reporter:
              szetszwo Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development