Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9299

Give ReplicationMonitor a readable thread name

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: namenode
    • Labels:
      None
    • Target Version/s:

      Description

      Currently the log output from the Replication Monitor is the class name, by setting the name on the thread the output will be easier to read.

      Current
      2015-10-23 11:07:53,344 [org.apache.hadoop.hdfs.server.blockmanagement.BlockManager$ReplicationMonitor@2fbdc5dd] INFO blockmanagement.BlockManager (BlockManager.java:run(4125)) - Stopping ReplicationMonitor.

      After
      2015-10-23 11:07:53,344 [ReplicationMonitor] INFO blockmanagement.BlockManager (BlockManager.java:run(4125)) - Stopping ReplicationMonitor.

      1. HDFS-9299.001.patch
        0.9 kB
        Staffan Friberg

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #592 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/592/)
        HDFS-9299. Give ReplicationMonitor a readable thread name (Staffan (cmccabe: rev fe93577faf49ceb2ee47a7762a61625313ea773b)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #592 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/592/ ) HDFS-9299 . Give ReplicationMonitor a readable thread name (Staffan (cmccabe: rev fe93577faf49ceb2ee47a7762a61625313ea773b) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #605 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/605/)
        HDFS-9299. Give ReplicationMonitor a readable thread name (Staffan (cmccabe: rev fe93577faf49ceb2ee47a7762a61625313ea773b)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #605 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/605/ ) HDFS-9299 . Give ReplicationMonitor a readable thread name (Staffan (cmccabe: rev fe93577faf49ceb2ee47a7762a61625313ea773b) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #544 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/544/)
        HDFS-9299. Give ReplicationMonitor a readable thread name (Staffan (cmccabe: rev fe93577faf49ceb2ee47a7762a61625313ea773b)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #544 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/544/ ) HDFS-9299 . Give ReplicationMonitor a readable thread name (Staffan (cmccabe: rev fe93577faf49ceb2ee47a7762a61625313ea773b) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1328 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1328/)
        HDFS-9299. Give ReplicationMonitor a readable thread name (Staffan (cmccabe: rev fe93577faf49ceb2ee47a7762a61625313ea773b)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1328 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1328/ ) HDFS-9299 . Give ReplicationMonitor a readable thread name (Staffan (cmccabe: rev fe93577faf49ceb2ee47a7762a61625313ea773b) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2481 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2481/)
        HDFS-9299. Give ReplicationMonitor a readable thread name (Staffan (cmccabe: rev fe93577faf49ceb2ee47a7762a61625313ea773b)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2481 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2481/ ) HDFS-9299 . Give ReplicationMonitor a readable thread name (Staffan (cmccabe: rev fe93577faf49ceb2ee47a7762a61625313ea773b) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2535 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2535/)
        HDFS-9299. Give ReplicationMonitor a readable thread name (Staffan (cmccabe: rev fe93577faf49ceb2ee47a7762a61625313ea773b)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2535 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2535/ ) HDFS-9299 . Give ReplicationMonitor a readable thread name (Staffan (cmccabe: rev fe93577faf49ceb2ee47a7762a61625313ea773b) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #8716 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8716/)
        HDFS-9299. Give ReplicationMonitor a readable thread name (Staffan (cmccabe: rev fe93577faf49ceb2ee47a7762a61625313ea773b)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #8716 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8716/ ) HDFS-9299 . Give ReplicationMonitor a readable thread name (Staffan (cmccabe: rev fe93577faf49ceb2ee47a7762a61625313ea773b) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        cmccabe Colin P. McCabe added a comment -

        committed to 2.8. thanks, Staffan Friberg

        Show
        cmccabe Colin P. McCabe added a comment - committed to 2.8. thanks, Staffan Friberg
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 18m 31s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 8m 8s There were no new javac warning messages.
        +1 javadoc 10m 29s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 23s The applied patch generated 1 new checkstyle issues (total was 161, now 161).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 2m 36s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 19s Pre-build of native portion
        -1 hdfs tests 63m 48s Tests failed in hadoop-hdfs.
            110m 53s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.ha.TestStandbyIsHot
          hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
          hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
          hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
          hadoop.hdfs.TestAppendSnapshotTruncate
        Timed out tests org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12768380/HDFS-9299.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 37bf614
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13204/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13204/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13204/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13204/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13204/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 31s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 8s There were no new javac warning messages. +1 javadoc 10m 29s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 23s The applied patch generated 1 new checkstyle issues (total was 161, now 161). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 36s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 19s Pre-build of native portion -1 hdfs tests 63m 48s Tests failed in hadoop-hdfs.     110m 53s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestStandbyIsHot   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication   hadoop.hdfs.TestAppendSnapshotTruncate Timed out tests org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12768380/HDFS-9299.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 37bf614 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13204/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13204/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13204/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13204/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13204/console This message was automatically generated.
        Hide
        cmccabe Colin P. McCabe added a comment -

        +1 pending jenkins.

        Show
        cmccabe Colin P. McCabe added a comment - +1 pending jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 18m 41s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 9m 2s There were no new javac warning messages.
        +1 javadoc 11m 47s There were no new javadoc warning messages.
        +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 37s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 53s mvn install still works.
        +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse.
        -1 findbugs 2m 58s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
        +1 native 3m 38s Pre-build of native portion
        -1 hdfs tests 56m 4s Tests failed in hadoop-hdfs.
            105m 48s  



        Reason Tests
        FindBugs module:hadoop-hdfs
        Failed unit tests hadoop.hdfs.qjournal.client.TestQJMWithFaults
          hadoop.hdfs.TestReadStripedFileWithDecoding
          hadoop.hdfs.TestFileAppend4
          hadoop.hdfs.TestDFSClientFailover
          hadoop.hdfs.server.blockmanagement.TestNodeCount



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12768380/HDFS-9299.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 15eb84b
        Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13166/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13166/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13166/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13166/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 41s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 9m 2s There were no new javac warning messages. +1 javadoc 11m 47s There were no new javadoc warning messages. +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 37s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 53s mvn install still works. +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse. -1 findbugs 2m 58s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. +1 native 3m 38s Pre-build of native portion -1 hdfs tests 56m 4s Tests failed in hadoop-hdfs.     105m 48s   Reason Tests FindBugs module:hadoop-hdfs Failed unit tests hadoop.hdfs.qjournal.client.TestQJMWithFaults   hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.TestFileAppend4   hadoop.hdfs.TestDFSClientFailover   hadoop.hdfs.server.blockmanagement.TestNodeCount Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12768380/HDFS-9299.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 15eb84b Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13166/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13166/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13166/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13166/console This message was automatically generated.
        Hide
        jingzhao Jing Zhao added a comment -

        +1 pending Jenkins.

        Show
        jingzhao Jing Zhao added a comment - +1 pending Jenkins.
        Hide
        anu Anu Engineer added a comment -

        +1 (Non-binding)

        Show
        anu Anu Engineer added a comment - +1 (Non-binding)

          People

          • Assignee:
            sfriberg Staffan Friberg
            Reporter:
            sfriberg Staffan Friberg
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development