Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9292

Make TestFileConcorruption independent to underlying FsDataset Implementation.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      TestFileCorruption manipulates the block data by directly accessing the block files on disk. MiniDFSCluster has already offered ways to corrupt data. We can use that to make TestFileCorruption agnostic to the implementation.

        Activity

        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        This patch:

        • Get block info on a DataNode through the block report
        • Delete block file though MiniDFSCluster.
        Show
        eddyxu Lei (Eddy) Xu added a comment - This patch: Get block info on a DataNode through the block report Delete block file though MiniDFSCluster .
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 10m 44s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 11m 34s There were no new javac warning messages.
        +1 release audit 0m 36s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 0s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 2m 19s mvn install still works.
        +1 eclipse:eclipse 0m 45s The patch built with eclipse:eclipse.
        +1 findbugs 4m 12s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 1m 12s Pre-build of native portion
        -1 hdfs tests 66m 57s Tests failed in hadoop-hdfs.
            100m 25s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestReplaceDatanodeOnFailure
          hadoop.hdfs.TestHFlush
          hadoop.hdfs.server.namenode.TestRecoverStripedBlocks
        Timed out tests org.apache.hadoop.hdfs.server.namenode.TestSecurityTokenEditLog
          org.apache.hadoop.hdfs.server.namenode.TestFsck
          org.apache.hadoop.hdfs.server.namenode.TestMetaSave
          org.apache.hadoop.hdfs.server.namenode.TestCheckpoint



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12768146/HDFS-9292.00.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / 124a412
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13142/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13142/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13142/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13142/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 10m 44s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 11m 34s There were no new javac warning messages. +1 release audit 0m 36s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 0s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 2m 19s mvn install still works. +1 eclipse:eclipse 0m 45s The patch built with eclipse:eclipse. +1 findbugs 4m 12s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 12s Pre-build of native portion -1 hdfs tests 66m 57s Tests failed in hadoop-hdfs.     100m 25s   Reason Tests Failed unit tests hadoop.hdfs.TestReplaceDatanodeOnFailure   hadoop.hdfs.TestHFlush   hadoop.hdfs.server.namenode.TestRecoverStripedBlocks Timed out tests org.apache.hadoop.hdfs.server.namenode.TestSecurityTokenEditLog   org.apache.hadoop.hdfs.server.namenode.TestFsck   org.apache.hadoop.hdfs.server.namenode.TestMetaSave   org.apache.hadoop.hdfs.server.namenode.TestCheckpoint Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12768146/HDFS-9292.00.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 124a412 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13142/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13142/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13142/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13142/console This message was automatically generated.
        Hide
        cmccabe Colin P. McCabe added a comment -
        81	          System.out.println("Deliberately removing block "
        82	              + brr.getBlockName());
        

        While we're refactoring this, can we change this to a LOG message?

        +1 once that's addressed

        Show
        cmccabe Colin P. McCabe added a comment - 81 System .out.println( "Deliberately removing block " 82 + brr.getBlockName()); While we're refactoring this, can we change this to a LOG message? +1 once that's addressed
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Thanks for the suggestions, Colin P. McCabe.

        Fixed based on your comments and committed.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Thanks for the suggestions, Colin P. McCabe . Fixed based on your comments and committed.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8711 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8711/)
        HDFS-9292. Make TestFileConcorruption independent to underlying (lei: rev 399ad009158cbc6aca179396d390fe770801420f)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCorruption.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8711 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8711/ ) HDFS-9292 . Make TestFileConcorruption independent to underlying (lei: rev 399ad009158cbc6aca179396d390fe770801420f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCorruption.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #588 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/588/)
        HDFS-9292. Make TestFileConcorruption independent to underlying (lei: rev 399ad009158cbc6aca179396d390fe770801420f)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCorruption.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #588 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/588/ ) HDFS-9292 . Make TestFileConcorruption independent to underlying (lei: rev 399ad009158cbc6aca179396d390fe770801420f) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCorruption.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #600 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/600/)
        HDFS-9292. Make TestFileConcorruption independent to underlying (lei: rev 399ad009158cbc6aca179396d390fe770801420f)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCorruption.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #600 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/600/ ) HDFS-9292 . Make TestFileConcorruption independent to underlying (lei: rev 399ad009158cbc6aca179396d390fe770801420f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCorruption.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1324 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1324/)
        HDFS-9292. Make TestFileConcorruption independent to underlying (lei: rev 399ad009158cbc6aca179396d390fe770801420f)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCorruption.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1324 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1324/ ) HDFS-9292 . Make TestFileConcorruption independent to underlying (lei: rev 399ad009158cbc6aca179396d390fe770801420f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCorruption.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2478 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2478/)
        HDFS-9292. Make TestFileConcorruption independent to underlying (lei: rev 399ad009158cbc6aca179396d390fe770801420f)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCorruption.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2478 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2478/ ) HDFS-9292 . Make TestFileConcorruption independent to underlying (lei: rev 399ad009158cbc6aca179396d390fe770801420f) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCorruption.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2531 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2531/)
        HDFS-9292. Make TestFileConcorruption independent to underlying (lei: rev 399ad009158cbc6aca179396d390fe770801420f)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCorruption.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2531 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2531/ ) HDFS-9292 . Make TestFileConcorruption independent to underlying (lei: rev 399ad009158cbc6aca179396d390fe770801420f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCorruption.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #541 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/541/)
        HDFS-9292. Make TestFileConcorruption independent to underlying (lei: rev 399ad009158cbc6aca179396d390fe770801420f)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCorruption.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #541 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/541/ ) HDFS-9292 . Make TestFileConcorruption independent to underlying (lei: rev 399ad009158cbc6aca179396d390fe770801420f) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCorruption.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          People

          • Assignee:
            eddyxu Lei (Eddy) Xu
            Reporter:
            eddyxu Lei (Eddy) Xu
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development