Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9264

Minor cleanup of operations on FsVolumeList#volumes

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      We can use CopyOnWriteArrayList to simplify the operations on FsVolumeList#volumes

      1. HDFS-9264.02.patch
        9 kB
        Walter Su
      2. HDFS-9264.01.patch
        9 kB
        Walter Su

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2467 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2467/)
        HDFS-9264. Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2467 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2467/ ) HDFS-9264 . Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #531 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/531/)
        HDFS-9264. Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #531 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/531/ ) HDFS-9264 . Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2521 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2521/)
        HDFS-9264. Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2521 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2521/ ) HDFS-9264 . Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1312 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1312/)
        HDFS-9264. Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1312 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1312/ ) HDFS-9264 . Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #589 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/589/)
        HDFS-9264. Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #589 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/589/ ) HDFS-9264 . Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #576 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/576/)
        HDFS-9264. Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #576 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/576/ ) HDFS-9264 . Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8697 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8697/)
        HDFS-9264. Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8697 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8697/ ) HDFS-9264 . Minor cleanup of operations on FsVolumeList#volumes. (Walter (lei: rev 533a2be5ac7c7f0473fdd24d6201582d08964e21) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Thanks a lot for working on this, Walter Su

        TestReplaceDatanodeOnFailure test failure is due to HDFS-6101, thus is not relevant. Committed to trunk and branch-2.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Thanks a lot for working on this, Walter Su TestReplaceDatanodeOnFailure test failure is due to HDFS-6101 , thus is not relevant. Committed to trunk and branch-2 .
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Thanks a lot for cleanup the code. It LGTM. +1

        Show
        eddyxu Lei (Eddy) Xu added a comment - Thanks a lot for cleanup the code. It LGTM. +1
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 20m 27s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 9m 0s There were no new javac warning messages.
        +1 javadoc 11m 55s There were no new javadoc warning messages.
        +1 release audit 0m 29s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 44s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 43s mvn install still works.
        +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse.
        +1 findbugs 2m 48s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 32s Pre-build of native portion
        -1 hdfs tests 55m 15s Tests failed in hadoop-hdfs.
            107m 38s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestDFSUpgradeFromImage
          hadoop.hdfs.TestReplaceDatanodeOnFailure



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12767524/HDFS-9264.02.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 7e2837f
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13069/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13069/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13069/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13069/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 20m 27s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 9m 0s There were no new javac warning messages. +1 javadoc 11m 55s There were no new javadoc warning messages. +1 release audit 0m 29s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 44s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 43s mvn install still works. +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse. +1 findbugs 2m 48s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 32s Pre-build of native portion -1 hdfs tests 55m 15s Tests failed in hadoop-hdfs.     107m 38s   Reason Tests Failed unit tests hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.TestReplaceDatanodeOnFailure Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767524/HDFS-9264.02.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7e2837f Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13069/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13069/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13069/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13069/console This message was automatically generated.
        Hide
        walter.k.su Walter Su added a comment -

        02 patch fix checkstyles

        Show
        walter.k.su Walter Su added a comment - 02 patch fix checkstyles
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 18m 39s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        -1 javac 7m 54s The applied patch generated 1 additional warning messages.
        +1 javadoc 10m 24s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 24s The applied patch generated 10 new checkstyle issues (total was 6, now 15).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 28s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 13s Pre-build of native portion
        -1 hdfs tests 48m 51s Tests failed in hadoop-hdfs.
            95m 31s  



        Reason Tests
        Timed out tests org.apache.hadoop.hdfs.server.namenode.TestFileTruncate
          org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
          org.apache.hadoop.hdfs.server.namenode.TestMetaSave
          org.apache.hadoop.hdfs.server.namenode.TestAddStripedBlocks



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12767368/HDFS-9264.01.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 7f0e1eb
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13049/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/13049/artifact/patchprocess/diffJavacWarnings.txt
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13049/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13049/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13049/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13049/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 39s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javac 7m 54s The applied patch generated 1 additional warning messages. +1 javadoc 10m 24s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 24s The applied patch generated 10 new checkstyle issues (total was 6, now 15). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 13s Pre-build of native portion -1 hdfs tests 48m 51s Tests failed in hadoop-hdfs.     95m 31s   Reason Tests Timed out tests org.apache.hadoop.hdfs.server.namenode.TestFileTruncate   org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   org.apache.hadoop.hdfs.server.namenode.TestMetaSave   org.apache.hadoop.hdfs.server.namenode.TestAddStripedBlocks Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767368/HDFS-9264.01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7f0e1eb Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13049/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html javac https://builds.apache.org/job/PreCommit-HDFS-Build/13049/artifact/patchprocess/diffJavacWarnings.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13049/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13049/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13049/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13049/console This message was automatically generated.

          People

          • Assignee:
            walter.k.su Walter Su
            Reporter:
            walter.k.su Walter Su
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development