Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9257

improve error message for "Absolute path required" in INode.java to contain the rejected path

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      throw new AssertionError("Absolute path required");
      message should also show the path to help debugging.

      1. HDFS-9257.000.patch
        0.9 kB
        Marcell Szabo

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 17m 49s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 53s There were no new javac warning messages.
        +1 javadoc 10m 17s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 22s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 28s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 9s Pre-build of native portion
        -1 hdfs tests 51m 44s Tests failed in hadoop-hdfs.
            97m 9s  



        Reason Tests
        Failed unit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache
          hadoop.hdfs.server.blockmanagement.TestNodeCount



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12767066/HDFS-9257.000.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / cf23f2c
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13031/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13031/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13031/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13031/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 17m 49s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 53s There were no new javac warning messages. +1 javadoc 10m 17s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 22s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 9s Pre-build of native portion -1 hdfs tests 51m 44s Tests failed in hadoop-hdfs.     97m 9s   Reason Tests Failed unit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.blockmanagement.TestNodeCount Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767066/HDFS-9257.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / cf23f2c Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13031/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13031/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13031/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13031/console This message was automatically generated.
        Hide
        qwertymaniac Harsh J added a comment -

        +1, failed tests are unrelated. Tests shouldn't be necessary for the trivial message improvement. Committing shortly.

        Show
        qwertymaniac Harsh J added a comment - +1, failed tests are unrelated. Tests shouldn't be necessary for the trivial message improvement. Committing shortly.
        Hide
        qwertymaniac Harsh J added a comment -

        Committed to trunk and branch-2. Thank you for the improvement contribution Marcell, hope to see more!

        Show
        qwertymaniac Harsh J added a comment - Committed to trunk and branch-2. Thank you for the improvement contribution Marcell, hope to see more!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8651 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8651/)
        HDFS-9257. improve error message for "Absolute path required" in (harsh: rev 52ac73f344e822e41457582f82abb4f35eba9dec)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8651 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8651/ ) HDFS-9257 . improve error message for "Absolute path required" in (harsh: rev 52ac73f344e822e41457582f82abb4f35eba9dec) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1278 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1278/)
        HDFS-9257. improve error message for "Absolute path required" in (harsh: rev 52ac73f344e822e41457582f82abb4f35eba9dec)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1278 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1278/ ) HDFS-9257 . improve error message for "Absolute path required" in (harsh: rev 52ac73f344e822e41457582f82abb4f35eba9dec) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #557 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/557/)
        HDFS-9257. improve error message for "Absolute path required" in (harsh: rev 52ac73f344e822e41457582f82abb4f35eba9dec)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #557 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/557/ ) HDFS-9257 . improve error message for "Absolute path required" in (harsh: rev 52ac73f344e822e41457582f82abb4f35eba9dec) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #542 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/542/)
        HDFS-9257. improve error message for "Absolute path required" in (harsh: rev 52ac73f344e822e41457582f82abb4f35eba9dec)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #542 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/542/ ) HDFS-9257 . improve error message for "Absolute path required" in (harsh: rev 52ac73f344e822e41457582f82abb4f35eba9dec) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2491 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2491/)
        HDFS-9257. improve error message for "Absolute path required" in (harsh: rev 52ac73f344e822e41457582f82abb4f35eba9dec)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2491 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2491/ ) HDFS-9257 . improve error message for "Absolute path required" in (harsh: rev 52ac73f344e822e41457582f82abb4f35eba9dec) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2443 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2443/)
        HDFS-9257. improve error message for "Absolute path required" in (harsh: rev 52ac73f344e822e41457582f82abb4f35eba9dec)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2443 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2443/ ) HDFS-9257 . improve error message for "Absolute path required" in (harsh: rev 52ac73f344e822e41457582f82abb4f35eba9dec) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #506 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/506/)
        HDFS-9257. improve error message for "Absolute path required" in (harsh: rev 52ac73f344e822e41457582f82abb4f35eba9dec)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #506 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/506/ ) HDFS-9257 . improve error message for "Absolute path required" in (harsh: rev 52ac73f344e822e41457582f82abb4f35eba9dec) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          People

          • Assignee:
            szama Marcell Szabo
            Reporter:
            szama Marcell Szabo
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development