Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9210

Fix some misuse of %n in VolumeScanner#printStats

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Found 2 extra "%n" in the VolumeScanner report and lines not well formatted below. This JIRA is opened to fix the format issue.

      Block scanner information for volume DS-93fb2503-de00-4f98-a8bc-c2bc13b8f0f7 with base path /hadoop/hdfs/data%nBytes verified in last hour       :                                                 136882014
      Blocks scanned in current period  :                                                         5
      Blocks scanned since restart      :                                                         5
      Block pool scans since restart    :                                                         0
      Block scan errors since restart   :                                                         0
      Hours until next block pool scan  :                                                   476.000
      Last block scanned                : BP-1792969149-192.168.70.101-1444150984999:blk_1073742088_1274
      More blocks to scan in period     :                                                     false
      %n
      
      1. HDFS-9210.02.patch
        1 kB
        Xiaoyu Yao
      2. HDFS-9210.01.patch
        1 kB
        Xiaoyu Yao
      3. HDFS-9210.00.patch
        1 kB
        Xiaoyu Yao

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9216 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9216/)
        HDFS-9210. Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev b11008d54d8aa3eb9c7c10c3a0734d95b9ef41e9)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9216 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9216/ ) HDFS-9210 . Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev b11008d54d8aa3eb9c7c10c3a0734d95b9ef41e9) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks all for the reviews. I've commit the patch to trunk, branch-2 and branch-2.8.

        Show
        xyao Xiaoyu Yao added a comment - Thanks all for the reviews. I've commit the patch to trunk, branch-2 and branch-2.8.
        Hide
        templedf Daniel Templeton added a comment -

        They are, but line separator() doesn't require string parsing to
        interpret.

        Show
        templedf Daniel Templeton added a comment - They are, but line separator() doesn't require string parsing to interpret.
        Hide
        andrew.wang Andrew Wang added a comment -

        LGTM +1, though aren't lineSeparator and "%n" the same? Formatter javadoc under "Line Separator" says n is same as System.getProperty("line.separator"): http://docs.oracle.com/javase/1.5.0/docs/api/java/util/Formatter.html#syntax

        Show
        andrew.wang Andrew Wang added a comment - LGTM +1, though aren't lineSeparator and "%n" the same? Formatter javadoc under "Line Separator" says n is same as System.getProperty("line.separator") : http://docs.oracle.com/javase/1.5.0/docs/api/java/util/Formatter.html#syntax
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 54s trunk passed
        +1 compile 0m 42s trunk passed with JDK v1.8.0_66
        +1 compile 0m 41s trunk passed with JDK v1.7.0_85
        +1 checkstyle 0m 16s trunk passed
        +1 mvnsite 0m 52s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 54s trunk passed
        +1 javadoc 1m 5s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 47s trunk passed with JDK v1.7.0_85
        +1 mvninstall 0m 48s the patch passed
        +1 compile 0m 42s the patch passed with JDK v1.8.0_66
        +1 javac 0m 42s the patch passed
        +1 compile 0m 41s the patch passed with JDK v1.7.0_85
        +1 javac 0m 41s the patch passed
        +1 checkstyle 0m 15s the patch passed
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 1s the patch passed
        +1 javadoc 1m 8s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 47s the patch passed with JDK v1.7.0_85
        -1 unit 52m 10s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 55m 11s hadoop-hdfs in the patch failed with JDK v1.7.0_85.
        -1 asflicense 0m 19s Patch generated 58 ASF License warnings.
        134m 13s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.security.TestPermission
          hadoop.hdfs.server.namenode.TestCacheDirectives
        JDK v1.7.0_85 Failed junit tests hadoop.security.TestPermission
          hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
        JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.hdfs.web.TestWebHDFSAcl



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774411/HDFS-9210.02.patch
        JIRA Issue HDFS-9210
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux db0a602fc1bb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 95d5227
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13664/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13664/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13664/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13664/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13664/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13664/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 75MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13664/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 54s trunk passed +1 compile 0m 42s trunk passed with JDK v1.8.0_66 +1 compile 0m 41s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 54s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 47s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 48s the patch passed +1 compile 0m 42s the patch passed with JDK v1.8.0_66 +1 javac 0m 42s the patch passed +1 compile 0m 41s the patch passed with JDK v1.7.0_85 +1 javac 0m 41s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 1s the patch passed +1 javadoc 1m 8s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 47s the patch passed with JDK v1.7.0_85 -1 unit 52m 10s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 55m 11s hadoop-hdfs in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 19s Patch generated 58 ASF License warnings. 134m 13s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.security.TestPermission   hadoop.hdfs.server.namenode.TestCacheDirectives JDK v1.7.0_85 Failed junit tests hadoop.security.TestPermission   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.hdfs.web.TestWebHDFSAcl Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774411/HDFS-9210.02.patch JIRA Issue HDFS-9210 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux db0a602fc1bb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 95d5227 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13664/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13664/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13664/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13664/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13664/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13664/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13664/console This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        Thanks, Xiaoyu Yao! +1 (non-binding). Andrew Wang?

        Show
        templedf Daniel Templeton added a comment - Thanks, Xiaoyu Yao ! +1 (non-binding). Andrew Wang ?
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Daniel Templeton for the review!
        Attached a patch using System.LineSeparator().

        Show
        xyao Xiaoyu Yao added a comment - Thanks Daniel Templeton for the review! Attached a patch using System.LineSeparator().
        Hide
        templedf Daniel Templeton added a comment -

        Looks good! Should the String.format("%n") be System.getProperty("line.separator") instead?

        Show
        templedf Daniel Templeton added a comment - Looks good! Should the String.format("%n") be System.getProperty("line.separator") instead?
        Hide
        xyao Xiaoyu Yao added a comment -

        Andrew Wang, Daniel Templeton, can you help reviewing the patch v02 that fixes the issue Daniel Templeton pointed out?

        Show
        xyao Xiaoyu Yao added a comment - Andrew Wang , Daniel Templeton , can you help reviewing the patch v02 that fixes the issue Daniel Templeton pointed out?
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2435 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2435/)
        HDFS-9210. Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev 3d5085595286c0231f66543d1509247ad4bb5739)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Revert "HDFS-9210. Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev a8070259f8384021bd6196e7343f1cc23de89b1c)
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2435 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2435/ ) HDFS-9210 . Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev 3d5085595286c0231f66543d1509247ad4bb5739) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Revert " HDFS-9210 . Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev a8070259f8384021bd6196e7343f1cc23de89b1c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2481 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2481/)
        Revert "HDFS-9210. Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev a8070259f8384021bd6196e7343f1cc23de89b1c)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2481 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2481/ ) Revert " HDFS-9210 . Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev a8070259f8384021bd6196e7343f1cc23de89b1c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #497 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/497/)
        HDFS-9210. Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev 3d5085595286c0231f66543d1509247ad4bb5739)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
          Revert "HDFS-9210. Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev a8070259f8384021bd6196e7343f1cc23de89b1c)
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #497 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/497/ ) HDFS-9210 . Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev 3d5085595286c0231f66543d1509247ad4bb5739) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java Revert " HDFS-9210 . Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev a8070259f8384021bd6196e7343f1cc23de89b1c) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 18m 30s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 8m 5s There were no new javac warning messages.
        +1 javadoc 10m 34s There were no new javadoc warning messages.
        -1 release audit 0m 17s The applied patch generated 1 release audit warnings.
        +1 checkstyle 1m 25s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 28s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 24s Pre-build of native portion
        -1 hdfs tests 53m 14s Tests failed in hadoop-hdfs.
            100m 3s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestLeaseRecovery2
          hadoop.fs.TestGlobPaths
          hadoop.hdfs.server.namenode.TestFileTruncate
          hadoop.hdfs.server.blockmanagement.TestNodeCount



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12766652/HDFS-9210.01.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / be7a0ad
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12992/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12992/artifact/patchprocess/patchReleaseAuditProblems.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12992/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12992/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12992/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 30s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 5s There were no new javac warning messages. +1 javadoc 10m 34s There were no new javadoc warning messages. -1 release audit 0m 17s The applied patch generated 1 release audit warnings. +1 checkstyle 1m 25s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 24s Pre-build of native portion -1 hdfs tests 53m 14s Tests failed in hadoop-hdfs.     100m 3s   Reason Tests Failed unit tests hadoop.hdfs.TestLeaseRecovery2   hadoop.fs.TestGlobPaths   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.server.blockmanagement.TestNodeCount Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766652/HDFS-9210.01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / be7a0ad Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12992/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12992/artifact/patchprocess/patchReleaseAuditProblems.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12992/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12992/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12992/console This message was automatically generated.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1268 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1268/)
        Revert "HDFS-9210. Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev a8070259f8384021bd6196e7343f1cc23de89b1c)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1268 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1268/ ) Revert " HDFS-9210 . Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev a8070259f8384021bd6196e7343f1cc23de89b1c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2480 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2480/)
        HDFS-9210. Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev 3d5085595286c0231f66543d1509247ad4bb5739)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2480 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2480/ ) HDFS-9210 . Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev 3d5085595286c0231f66543d1509247ad4bb5739) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #531 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/531/)
        HDFS-9210. Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev 3d5085595286c0231f66543d1509247ad4bb5739)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
          Revert "HDFS-9210. Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev a8070259f8384021bd6196e7343f1cc23de89b1c)
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #531 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/531/ ) HDFS-9210 . Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev 3d5085595286c0231f66543d1509247ad4bb5739) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java Revert " HDFS-9210 . Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev a8070259f8384021bd6196e7343f1cc23de89b1c) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1267 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1267/)
        HDFS-9210. Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev 3d5085595286c0231f66543d1509247ad4bb5739)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1267 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1267/ ) HDFS-9210 . Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev 3d5085595286c0231f66543d1509247ad4bb5739) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #544 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/544/)
        HDFS-9210. Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev 3d5085595286c0231f66543d1509247ad4bb5739)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
          Revert "HDFS-9210. Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev a8070259f8384021bd6196e7343f1cc23de89b1c)
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #544 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/544/ ) HDFS-9210 . Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev 3d5085595286c0231f66543d1509247ad4bb5739) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java Revert " HDFS-9210 . Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev a8070259f8384021bd6196e7343f1cc23de89b1c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8637 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8637/)
        HDFS-9210. Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev 3d5085595286c0231f66543d1509247ad4bb5739)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Revert "HDFS-9210. Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev a8070259f8384021bd6196e7343f1cc23de89b1c)
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8637 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8637/ ) HDFS-9210 . Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev 3d5085595286c0231f66543d1509247ad4bb5739) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Revert " HDFS-9210 . Fix some misuse of %n in VolumeScanner#printStats. (xyao: rev a8070259f8384021bd6196e7343f1cc23de89b1c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Daniel Templeton, I will revert the commit and fix it.

        Show
        xyao Xiaoyu Yao added a comment - Thanks Daniel Templeton , I will revert the commit and fix it.
        Hide
        templedf Daniel Templeton added a comment -

        I'm confused. Looking at the patch, this:

        p.append(String.format("Block scanner information for volume %s with base" +
            " path %s%n" + volume.getStorageID(), volume.getBasePath()));
        

        doesn't work. It should be:

        p.append(String.format("Block scanner information for volume %s with base" +
            " path %s%n", volume.getStorageID(), volume.getBasePath()));
        

        How is the patch not causing a java.util.MissingFormatArgumentException to be thrown?

        Show
        templedf Daniel Templeton added a comment - I'm confused. Looking at the patch, this: p.append( String .format( "Block scanner information for volume %s with base" + " path %s%n" + volume.getStorageID(), volume.getBasePath())); doesn't work. It should be: p.append( String .format( "Block scanner information for volume %s with base" + " path %s%n" , volume.getStorageID(), volume.getBasePath())); How is the patch not causing a java.util.MissingFormatArgumentException to be thrown?
        Hide
        xyao Xiaoyu Yao added a comment -

        The test failures are unrelated. Thanks Andrew Wang for the review!
        Commit it to trunk and branch-2 based on his +1.

        Show
        xyao Xiaoyu Yao added a comment - The test failures are unrelated. Thanks Andrew Wang for the review! Commit it to trunk and branch-2 based on his +1.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 23s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 8m 11s There were no new javac warning messages.
        +1 javadoc 10m 22s There were no new javadoc warning messages.
        -1 release audit 0m 20s The applied patch generated 1 release audit warnings.
        +1 checkstyle 1m 29s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 41s mvn install still works.
        +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse.
        +1 findbugs 2m 35s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 16s Pre-build of native portion
        -1 hdfs tests 188m 27s Tests failed in hadoop-hdfs.
            235m 25s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestReadStripedFileWithDecoding
          hadoop.hdfs.TestLeaseRecovery2



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12765487/HDFS-9210.00.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / fde729f
        Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12846/artifact/patchprocess/patchReleaseAuditProblems.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12846/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12846/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12846/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 23s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 11s There were no new javac warning messages. +1 javadoc 10m 22s There were no new javadoc warning messages. -1 release audit 0m 20s The applied patch generated 1 release audit warnings. +1 checkstyle 1m 29s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 41s mvn install still works. +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse. +1 findbugs 2m 35s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 16s Pre-build of native portion -1 hdfs tests 188m 27s Tests failed in hadoop-hdfs.     235m 25s   Reason Tests Failed unit tests hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12765487/HDFS-9210.00.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / fde729f Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12846/artifact/patchprocess/patchReleaseAuditProblems.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12846/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12846/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12846/console This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        +1 pending, thanks Xiaoyu

        Show
        andrew.wang Andrew Wang added a comment - +1 pending, thanks Xiaoyu

          People

          • Assignee:
            xyao Xiaoyu Yao
            Reporter:
            xyao Xiaoyu Yao
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development