[HDFS-9157] [OEV and OIV] : Unnecessary parsing for mandatory arguements if "-h" option is specified as the only option

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Hadoop Flags: Reviewed
• Assignee: nijel
• Reporter: nijel
• Created: 28/Sep/15 07:55
• Updated: 30/Aug/16 01:26
• Resolved: 15/Oct/15 12:10

Description

In both tools, if "-h" is specified as the only option, it throws error as input and output not specified.

master:/home/nijel/hadoop-3.0.0-SNAPSHOT/bin # ./hdfs oev -h
Error parsing command-line options: Missing required options: o, i
Usage: bin/hdfs oev [OPTIONS] -i INPUT_FILE -o OUTPUT_FILE

In code the parsing is happening before the "-h" option is verified
Can add code to return after initial check.

    if (argv.length == 1 && argv[1] == "-h") {
      printHelp();
      return 0;
    }