Details
-
Type:
Sub-task
-
Status: Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 2.8.0, 3.0.0-alpha1
-
Component/s: None
-
Labels:None
-
Hadoop Flags:Reviewed
Description
In both tools, if "-h" is specified as the only option, it throws error as input and output not specified.
master:/home/nijel/hadoop-3.0.0-SNAPSHOT/bin # ./hdfs oev -h Error parsing command-line options: Missing required options: o, i Usage: bin/hdfs oev [OPTIONS] -i INPUT_FILE -o OUTPUT_FILE
In code the parsing is happening before the "-h" option is verified
Can add code to return after initial check.
if (argv.length == 1 && argv[1] == "-h") {
printHelp();
return 0;
}
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
 -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | pre-patch | 18m 39s | Pre-patch trunk compilation is healthy. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 | tests included | 0m 0s | The patch appears to include 2 new or modified test files. |
| +1 | javac | 7m 53s | There were no new javac warning messages. |
| +1 | javadoc | 10m 11s | There were no new javadoc warning messages. |
| -1 | release audit | 0m 19s | The applied patch generated 1 release audit warnings. |
| +1 | checkstyle | 1m 23s | There were no new checkstyle issues. |
| +1 | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
| +1 | install | 1m 30s | mvn install still works. |
| +1 | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. |
| +1 | findbugs | 2m 29s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| +1 | native | 3m 9s | Pre-build of native portion |
| -1 | hdfs tests | 136m 2s | Tests failed in hadoop-hdfs. |
| 182m 11s |
| Reason | Tests |
|---|---|
| Failed unit tests | hadoop.hdfs.server.blockmanagement.TestNodeCount |
| hadoop.hdfs.TestLeaseRecovery2 | |
| hadoop.hdfs.web.TestWebHDFSOAuth2 | |
| Timed out tests | org.apache.hadoop.hdfs.server.namenode.TestCheckpoint |
| org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner |
| Subsystem | Report/Notes |
|---|---|
| Patch URL | http://issues.apache.org/jira/secure/attachment/12765581/HDFS-9157_1.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 1107bd3 |
| Release Audit | https://builds.apache.org/job/PreCommit-HDFS-Build/12862/artifact/patchprocess/patchReleaseAuditProblems.txt |
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12862/artifact/patchprocess/testrun_hadoop-hdfs.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12862/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12862/console |
This message was automatically generated.
-1 release audit
Not related to this patch
-1 hdfs tests
As per my analysis, these are not related to the patch
thanks
Thanks for the patch.
The patch overall looks good. Two comments.
- To construct a new String, there is no need to call new String(object.toString)
+ String errorValue = new String(bytes.toString());
- It's good if you can add test case for newly changed behavior as well, if "-h" shows up with other options together
+ if (cmd.hasOption("h")) { + // print help and exit with non zero exit code since + // it is not expected to give help and other options together. printUsage(); - return 0; + return -1;
thanks Mingliang Liu for the comments
Updated patch with the comments
New assertion added in testOfflineImageViewerHelpMessage.
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | pre-patch | 18m 15s | Pre-patch trunk compilation is healthy. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 | tests included | 0m 0s | The patch appears to include 2 new or modified test files. |
| +1 | javac | 7m 50s | There were no new javac warning messages. |
| +1 | javadoc | 10m 29s | There were no new javadoc warning messages. |
| -1 | release audit | 0m 19s | The applied patch generated 1 release audit warnings. |
| +1 | checkstyle | 1m 24s | There were no new checkstyle issues. |
| -1 | whitespace | 0m 1s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. |
| +1 | install | 1m 32s | mvn install still works. |
| +1 | eclipse:eclipse | 0m 31s | The patch built with eclipse:eclipse. |
| +1 | findbugs | 2m 29s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| +1 | native | 3m 12s | Pre-build of native portion |
| -1 | hdfs tests | 16m 25s | Tests failed in hadoop-hdfs. |
| 62m 31s |
| Reason | Tests |
|---|---|
| Failed build | hadoop-hdfs |
| Subsystem | Report/Notes |
|---|---|
| Patch URL | http://issues.apache.org/jira/secure/attachment/12765962/HDFS-9157_2.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / def374e |
| Release Audit | https://builds.apache.org/job/PreCommit-HDFS-Build/12912/artifact/patchprocess/patchReleaseAuditProblems.txt |
| whitespace | https://builds.apache.org/job/PreCommit-HDFS-Build/12912/artifact/patchprocess/whitespace.txt |
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12912/artifact/patchprocess/testrun_hadoop-hdfs.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12912/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12912/console |
This message was automatically generated.
Patch updated to remove white space
Removed unwanted file in patch
please review
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | pre-patch | 18m 25s | Pre-patch trunk compilation is healthy. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 | tests included | 0m 0s | The patch appears to include 2 new or modified test files. |
| +1 | javac | 8m 5s | There were no new javac warning messages. |
| +1 | javadoc | 10m 18s | There were no new javadoc warning messages. |
| -1 | release audit | 0m 19s | The applied patch generated 1 release audit warnings. |
| +1 | checkstyle | 1m 25s | There were no new checkstyle issues. |
| +1 | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
| +1 | install | 1m 29s | mvn install still works. |
| +1 | eclipse:eclipse | 0m 34s | The patch built with eclipse:eclipse. |
| +1 | findbugs | 2m 33s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| +1 | native | 3m 11s | Pre-build of native portion |
| -1 | hdfs tests | 194m 36s | Tests failed in hadoop-hdfs. |
| 240m 58s |
| Reason | Tests |
|---|---|
| Timed out tests | org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010 |
| Subsystem | Report/Notes |
|---|---|
| Patch URL | http://issues.apache.org/jira/secure/attachment/12765971/HDFS-9157_3.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / fa5a54c |
| Release Audit | https://builds.apache.org/job/PreCommit-HDFS-Build/12918/artifact/patchprocess/patchReleaseAuditProblems.txt |
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12918/artifact/patchprocess/testrun_hadoop-hdfs.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12918/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12918/console |
This message was automatically generated.
-1 release audit
As per my analysis this is not related to this patch.
-1 hdfs tests
skipped tests are not related to this patch
thanks
Thanks nijel for the update on the patch.
Have few nits.
1. In OEV, redundant comment can be removed, similar to OIV change.
- if(cmd.hasOption("h")) { // print help and exit + if (cmd.hasOption("h")) { // print help and exit + // print help and exit with non zero exit code since + // it is not expected to give help and other options together. printHelp();
2. isHelpOption(..) it would look better, if this method can take only one option as input instead of array.
I noticed that return code is changed to 0 in OEV when no args passed. This behaviour is similar to OIV. IMO this is fine.
Rest all is fine.
+1 once above nits addressed
thanks Vinayakumar B for the review
Updated patch with the comments
Please have a look.
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | pre-patch | 20m 31s | Pre-patch trunk compilation is healthy. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 | tests included | 0m 0s | The patch appears to include 2 new or modified test files. |
| +1 | javac | 8m 48s | There were no new javac warning messages. |
| +1 | javadoc | 11m 29s | There were no new javadoc warning messages. |
| +1 | release audit | 0m 27s | The applied patch does not increase the total number of release audit warnings. |
| +1 | checkstyle | 1m 35s | There were no new checkstyle issues. |
| -1 | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. |
| +1 | install | 1m 37s | mvn install still works. |
| +1 | eclipse:eclipse | 0m 35s | The patch built with eclipse:eclipse. |
| +1 | findbugs | 2m 48s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| +1 | native | 3m 35s | Pre-build of native portion |
| -1 | hdfs tests | 54m 12s | Tests failed in hadoop-hdfs. |
| 105m 42s |
| Reason | Tests |
|---|---|
| Failed unit tests | hadoop.hdfs.TestReplaceDatanodeOnFailure |
| hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer |
| Subsystem | Report/Notes |
|---|---|
| Patch URL | http://issues.apache.org/jira/secure/attachment/12766345/HDFS-9157_4.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 5b43db4 |
| whitespace | https://builds.apache.org/job/PreCommit-HDFS-Build/12952/artifact/patchprocess/whitespace.txt |
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12952/artifact/patchprocess/testrun_hadoop-hdfs.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12952/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12952/console |
This message was automatically generated.
patch to fix white space
Test fails are not related to this patch
thanks
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| -1 | pre-patch | 20m 11s | Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 | tests included | 0m 0s | The patch appears to include 2 new or modified test files. |
| +1 | javac | 8m 46s | There were no new javac warning messages. |
| +1 | javadoc | 11m 17s | There were no new javadoc warning messages. |
| +1 | release audit | 0m 25s | The applied patch does not increase the total number of release audit warnings. |
| +1 | checkstyle | 1m 36s | There were no new checkstyle issues. |
| +1 | whitespace | 0m 1s | The patch has no lines that end in whitespace. |
| +1 | install | 1m 39s | mvn install still works. |
| +1 | eclipse:eclipse | 0m 38s | The patch built with eclipse:eclipse. |
| +1 | findbugs | 2m 39s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| +1 | native | 3m 43s | Pre-build of native portion |
| -1 | hdfs tests | 66m 52s | Tests failed in hadoop-hdfs. |
| 117m 52s |
| Reason | Tests |
|---|---|
| Failed unit tests | hadoop.hdfs.TestReplaceDatanodeOnFailure |
| hadoop.hdfs.server.datanode.TestBpServiceActorScheduler | |
| hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer | |
| hadoop.hdfs.server.blockmanagement.TestBlockManager | |
| hadoop.hdfs.server.namenode.TestSecondaryNameNodeUpgrade | |
| hadoop.hdfs.server.namenode.TestFileTruncate |
| Subsystem | Report/Notes |
|---|---|
| Patch URL | http://issues.apache.org/jira/secure/attachment/12766460/HDFS-9157_5.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 40cac59 |
| Pre-patch Findbugs warnings | https://builds.apache.org/job/PreCommit-HDFS-Build/12970/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html |
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12970/artifact/patchprocess/testrun_hadoop-hdfs.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12970/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12970/console |
This message was automatically generated.
One test fail is due to patch
Sorry for the wrong analysis
Updated the patch
thanks
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| -1 | pre-patch | 20m 19s | Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 | tests included | 0m 0s | The patch appears to include 2 new or modified test files. |
| +1 | javac | 8m 55s | There were no new javac warning messages. |
| +1 | javadoc | 11m 30s | There were no new javadoc warning messages. |
| +1 | release audit | 0m 27s | The applied patch does not increase the total number of release audit warnings. |
| +1 | checkstyle | 1m 36s | There were no new checkstyle issues. |
| +1 | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
| +1 | install | 1m 39s | mvn install still works. |
| +1 | eclipse:eclipse | 0m 40s | The patch built with eclipse:eclipse. |
| +1 | findbugs | 2m 41s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| +1 | native | 3m 29s | Pre-build of native portion |
| -1 | hdfs tests | 57m 5s | Tests failed in hadoop-hdfs. |
| 108m 26s |
| Reason | Tests |
|---|---|
| Failed unit tests | hadoop.hdfs.TestLeaseRecovery2 |
| hadoop.hdfs.TestReplaceDatanodeOnFailure | |
| Timed out tests | org.apache.hadoop.hdfs.server.blockmanagement.TestPendingReplication |
| Subsystem | Report/Notes |
|---|---|
| Patch URL | http://issues.apache.org/jira/secure/attachment/12766523/HDFS-9157_6.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / d6c8bad |
| Pre-patch Findbugs warnings | https://builds.apache.org/job/PreCommit-HDFS-Build/12977/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html |
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12977/artifact/patchprocess/testrun_hadoop-hdfs.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12977/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12977/console |
This message was automatically generated.
-1 hdfs tests
The test fails are un related to patch.
please review
+1 for latest patch.
Committed to trunk and branch-2.
Thanks nijel for the contribution
Thanks Mingliang Liu for the reviews.
FAILURE: Integrated in Hadoop-trunk-Commit #8643 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8643/)
HDFS-9157. [OEV and OIV] : Unnecessary parsing for mandatory arguements (vinayakumarb: rev 08f5de1ef55f637b3bbde0ace28b42f155e285a1)
- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java
- hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java
- hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
FAILURE: Integrated in Hadoop-Hdfs-trunk #2438 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2438/)
HDFS-9157. [OEV and OIV] : Unnecessary parsing for mandatory arguements (vinayakumarb: rev 08f5de1ef55f637b3bbde0ace28b42f155e285a1)
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java
- hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java
- hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #549 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/549/)
HDFS-9157. [OEV and OIV] : Unnecessary parsing for mandatory arguements (vinayakumarb: rev 08f5de1ef55f637b3bbde0ace28b42f155e285a1)
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
- hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java
- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java
- hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #536 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/536/)
HDFS-9157. [OEV and OIV] : Unnecessary parsing for mandatory arguements (vinayakumarb: rev 08f5de1ef55f637b3bbde0ace28b42f155e285a1)
- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
- hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
- hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java
SUCCESS: Integrated in Hadoop-Yarn-trunk #1272 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1272/)
HDFS-9157. [OEV and OIV] : Unnecessary parsing for mandatory arguements (vinayakumarb: rev 08f5de1ef55f637b3bbde0ace28b42f155e285a1)
- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
- hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java
- hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2485 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2485/)
HDFS-9157. [OEV and OIV] : Unnecessary parsing for mandatory arguements (vinayakumarb: rev 08f5de1ef55f637b3bbde0ace28b42f155e285a1)
- hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
- hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java
- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #501 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/501/)
HDFS-9157. [OEV and OIV] : Unnecessary parsing for mandatory arguements (vinayakumarb: rev 08f5de1ef55f637b3bbde0ace28b42f155e285a1)
- hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java
- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
- hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java
Attatched the changes.
Please review