Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      As in document and help

      -i,--inputFile <arg>   edits file to process, xml (*case
                             insensitive*) extension means XML format,
      

      But if i give the file with "XML" extension it falls back to binary processing.
      This issue is due the code

       int org.apache.hadoop.hdfs.tools.offlineEditsViewer.OfflineEditsViewer.go()
      .....
      boolean xmlInput = inputFileName.endsWith(".xml");
      
      

      Here need to check the xml after converting the file name to lower case

        Issue Links

          Activity

          Hide
          nijel nijel added a comment -

          updated the change.
          please review

          Show
          nijel nijel added a comment - updated the change. please review
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 17m 52s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 56s There were no new javac warning messages.
          +1 javadoc 10m 7s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 23s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 2m 34s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 16s Pre-build of native portion
          -1 hdfs tests 166m 7s Tests failed in hadoop-hdfs.
              211m 45s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.blockmanagement.TestBlockManager



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12764049/HDFS-9155_01.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / fb2e525
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12715/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12715/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12715/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12715/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 17m 52s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 56s There were no new javac warning messages. +1 javadoc 10m 7s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 23s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 34s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 16s Pre-build of native portion -1 hdfs tests 166m 7s Tests failed in hadoop-hdfs.     211m 45s   Reason Tests Failed unit tests hadoop.hdfs.server.blockmanagement.TestBlockManager Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764049/HDFS-9155_01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / fb2e525 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12715/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12715/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12715/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12715/console This message was automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          +1. Thanks, nijel

          Show
          cmccabe Colin P. McCabe added a comment - +1. Thanks, nijel
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8571 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8571/)
          HDFS-9155. OEV should treat .XML files as XML even when the file name (cmccabe: rev 2fc2b50534c2052ed3f6f38f30d29d98d99fd10a)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8571 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8571/ ) HDFS-9155 . OEV should treat .XML files as XML even when the file name (cmccabe: rev 2fc2b50534c2052ed3f6f38f30d29d98d99fd10a) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #490 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/490/)
          HDFS-9155. OEV should treat .XML files as XML even when the file name (cmccabe: rev 2fc2b50534c2052ed3f6f38f30d29d98d99fd10a)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #490 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/490/ ) HDFS-9155 . OEV should treat .XML files as XML even when the file name (cmccabe: rev 2fc2b50534c2052ed3f6f38f30d29d98d99fd10a) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1221 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1221/)
          HDFS-9155. OEV should treat .XML files as XML even when the file name (cmccabe: rev 2fc2b50534c2052ed3f6f38f30d29d98d99fd10a)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1221 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1221/ ) HDFS-9155 . OEV should treat .XML files as XML even when the file name (cmccabe: rev 2fc2b50534c2052ed3f6f38f30d29d98d99fd10a) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #482 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/482/)
          HDFS-9155. OEV should treat .XML files as XML even when the file name (cmccabe: rev 2fc2b50534c2052ed3f6f38f30d29d98d99fd10a)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #482 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/482/ ) HDFS-9155 . OEV should treat .XML files as XML even when the file name (cmccabe: rev 2fc2b50534c2052ed3f6f38f30d29d98d99fd10a) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2426 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2426/)
          HDFS-9155. OEV should treat .XML files as XML even when the file name (cmccabe: rev 2fc2b50534c2052ed3f6f38f30d29d98d99fd10a)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2426 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2426/ ) HDFS-9155 . OEV should treat .XML files as XML even when the file name (cmccabe: rev 2fc2b50534c2052ed3f6f38f30d29d98d99fd10a) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #457 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/457/)
          HDFS-9155. OEV should treat .XML files as XML even when the file name (cmccabe: rev 2fc2b50534c2052ed3f6f38f30d29d98d99fd10a)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #457 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/457/ ) HDFS-9155 . OEV should treat .XML files as XML even when the file name (cmccabe: rev 2fc2b50534c2052ed3f6f38f30d29d98d99fd10a) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2397 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2397/)
          HDFS-9155. OEV should treat .XML files as XML even when the file name (cmccabe: rev 2fc2b50534c2052ed3f6f38f30d29d98d99fd10a)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2397 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2397/ ) HDFS-9155 . OEV should treat .XML files as XML even when the file name (cmccabe: rev 2fc2b50534c2052ed3f6f38f30d29d98d99fd10a) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java
          Hide
          nijel nijel added a comment -

          thank Colin P. McCabe for the review and commit

          Show
          nijel nijel added a comment - thank Colin P. McCabe for the review and commit

            People

            • Assignee:
              nijel nijel
              Reporter:
              nijel nijel
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development