Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      NameNode.getUri() method is deprecated in HDFS-9022. We should use DFSUtilClient.getNNUri() instead to get the name node URI given NN address. After MAPREDUCE-6483, there is no usages of NameNode.getUri() in code trunk.

      This jira tracks the effort of removing the deprecated static helper method.

      1. HDFS-9101.000.patch
        0.9 kB
        Mingliang Liu

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 53s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          -1 javac 5m 5s The patch appears to cause the build to fail.



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12757186/HDFS-9101.000.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 6b97fa6
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12528/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 53s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javac 5m 5s The patch appears to cause the build to fail. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12757186/HDFS-9101.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6b97fa6 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12528/console This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          According to the issue links (see above), I shall submit patch after MAPREDUCE-6483 is in the trunk.

          Show
          liuml07 Mingliang Liu added a comment - According to the issue links (see above), I shall submit patch after MAPREDUCE-6483 is in the trunk.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 15m 59s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 58s There were no new javac warning messages.
          +1 javadoc 10m 21s There were no new javadoc warning messages.
          +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 30s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 36s mvn install still works.
          +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
          +1 findbugs 2m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 16s Pre-build of native portion
          +1 hdfs tests 162m 37s Tests passed in hadoop-hdfs.
              205m 47s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12757186/HDFS-9101.000.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 94dec5a
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12551/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12551/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12551/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 59s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 58s There were no new javac warning messages. +1 javadoc 10m 21s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 30s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 2m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 16s Pre-build of native portion +1 hdfs tests 162m 37s Tests passed in hadoop-hdfs.     205m 47s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12757186/HDFS-9101.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 94dec5a hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12551/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12551/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12551/console This message was automatically generated.
          Hide
          wheat9 Haohui Mai added a comment -

          +1

          Show
          wheat9 Haohui Mai added a comment - +1
          Hide
          wheat9 Haohui Mai added a comment -

          I've committed the patch to trunk and branch-2. Thanks Mingliang Liu for the contribution.

          Show
          wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Mingliang Liu for the contribution.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8490 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8490/)
          HDFS-9101. Remove deprecated NameNode.getUri() static helper method. Contributed by Mingliang Liu. (wheat9: rev 66b46d0885f7049d0485e0d08b5e7af9762f0a59)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8490 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8490/ ) HDFS-9101 . Remove deprecated NameNode.getUri() static helper method. Contributed by Mingliang Liu. (wheat9: rev 66b46d0885f7049d0485e0d08b5e7af9762f0a59) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #422 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/422/)
          HDFS-9101. Remove deprecated NameNode.getUri() static helper method. Contributed by Mingliang Liu. (wheat9: rev 66b46d0885f7049d0485e0d08b5e7af9762f0a59)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #422 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/422/ ) HDFS-9101 . Remove deprecated NameNode.getUri() static helper method. Contributed by Mingliang Liu. (wheat9: rev 66b46d0885f7049d0485e0d08b5e7af9762f0a59) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #414 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/414/)
          HDFS-9101. Remove deprecated NameNode.getUri() static helper method. Contributed by Mingliang Liu. (wheat9: rev 66b46d0885f7049d0485e0d08b5e7af9762f0a59)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #414 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/414/ ) HDFS-9101 . Remove deprecated NameNode.getUri() static helper method. Contributed by Mingliang Liu. (wheat9: rev 66b46d0885f7049d0485e0d08b5e7af9762f0a59) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1154 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1154/)
          HDFS-9101. Remove deprecated NameNode.getUri() static helper method. Contributed by Mingliang Liu. (wheat9: rev 66b46d0885f7049d0485e0d08b5e7af9762f0a59)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1154 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1154/ ) HDFS-9101 . Remove deprecated NameNode.getUri() static helper method. Contributed by Mingliang Liu. (wheat9: rev 66b46d0885f7049d0485e0d08b5e7af9762f0a59) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2360 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2360/)
          HDFS-9101. Remove deprecated NameNode.getUri() static helper method. Contributed by Mingliang Liu. (wheat9: rev 66b46d0885f7049d0485e0d08b5e7af9762f0a59)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2360 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2360/ ) HDFS-9101 . Remove deprecated NameNode.getUri() static helper method. Contributed by Mingliang Liu. (wheat9: rev 66b46d0885f7049d0485e0d08b5e7af9762f0a59) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2333 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2333/)
          HDFS-9101. Remove deprecated NameNode.getUri() static helper method. Contributed by Mingliang Liu. (wheat9: rev 66b46d0885f7049d0485e0d08b5e7af9762f0a59)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2333 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2333/ ) HDFS-9101 . Remove deprecated NameNode.getUri() static helper method. Contributed by Mingliang Liu. (wheat9: rev 66b46d0885f7049d0485e0d08b5e7af9762f0a59) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #395 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/395/)
          HDFS-9101. Remove deprecated NameNode.getUri() static helper method. Contributed by Mingliang Liu. (wheat9: rev 66b46d0885f7049d0485e0d08b5e7af9762f0a59)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #395 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/395/ ) HDFS-9101 . Remove deprecated NameNode.getUri() static helper method. Contributed by Mingliang Liu. (wheat9: rev 66b46d0885f7049d0485e0d08b5e7af9762f0a59) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

            People

            • Assignee:
              liuml07 Mingliang Liu
              Reporter:
              liuml07 Mingliang Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development