Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9076

Log full path instead of inodeId in DFSClient#closeAllFilesBeingWritten()

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: hdfs-client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

             try {
                if (abort) {
                  out.abort();
                } else {
                  out.close();
                }
              } catch(IOException ie) {
                LOG.error("Failed to " + (abort? "abort": "close") +
                        " inode " + inodeId, ie);
              }
      
      1. HDFS-9076.01.patch
        2 kB
        Surendra Singh Lilhore
      2. HDFS-9076.02.patch
        2 kB
        Surendra Singh Lilhore
      3. HDFS-9076.patch
        2 kB
        Surendra Singh Lilhore

        Activity

        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Attached patch.
        Please review .

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Attached patch. Please review .
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 38s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 47s There were no new javac warning messages.
        +1 javadoc 10m 0s There were no new javadoc warning messages.
        +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 19s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 27s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 2m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 9s Pre-build of native portion
        -1 hdfs tests 164m 12s Tests failed in hadoop-hdfs.
            209m 0s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistLockedMemory
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter
          hadoop.tools.TestJMXGet
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaPlacement



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12755786/HDFS-9076.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 6955771
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12430/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12430/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12430/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 38s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 47s There were no new javac warning messages. +1 javadoc 10m 0s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 19s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 9s Pre-build of native portion -1 hdfs tests 164m 12s Tests failed in hadoop-hdfs.     209m 0s   Reason Tests Failed unit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistLockedMemory   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter   hadoop.tools.TestJMXGet   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaPlacement Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12755786/HDFS-9076.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6955771 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12430/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12430/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12430/console This message was automatically generated.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Failed test cases are related to HDFS-9067..

        Please review..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Failed test cases are related to HDFS-9067 .. Please review..
        Hide
        vinayrpet Vinayakumar B added a comment -

        Thanks Surendra Singh Lilhore
        Some nits/suggestions.

        1. IMO, you can change getSource() to getSrc() Just to be consistent with name.

        2. Remove 'public' access modifier.

        3. You can still include fileId along with 'src' in log message. It will be helpful IMO.

        Show
        vinayrpet Vinayakumar B added a comment - Thanks Surendra Singh Lilhore Some nits/suggestions. 1. IMO, you can change getSource() to getSrc() Just to be consistent with name. 2. Remove 'public' access modifier. 3. You can still include fileId along with 'src' in log message. It will be helpful IMO.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Thanks Vinayakumar B for review,
        Attached updated patch, Please review...

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Thanks Vinayakumar B for review, Attached updated patch, Please review...
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 21m 15s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 59s There were no new javac warning messages.
        +1 javadoc 11m 34s There were no new javadoc warning messages.
        +1 release audit 0m 34s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 36s The applied patch generated 1 new checkstyle issues (total was 152, now 152).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 57s mvn install still works.
        +1 eclipse:eclipse 0m 43s The patch built with eclipse:eclipse.
        +1 findbugs 3m 45s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 4m 24s Pre-build of native portion
        -1 hdfs tests 64m 55s Tests failed in hadoop-hdfs.
            118m 46s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.TestHDFSConcat
          hadoop.hdfs.server.namenode.TestFSNamesystemMBean
          hadoop.hdfs.TestDFSStorageStateRecovery
          hadoop.hdfs.TestHdfsAdmin
          hadoop.hdfs.tools.TestDFSZKFailoverController
          hadoop.hdfs.TestDFSUtil
          hadoop.hdfs.server.namenode.TestStartup
          hadoop.hdfs.web.TestWebHdfsTokens
          hadoop.hdfs.TestDisableConnCache
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotListing
          hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
          hadoop.hdfs.server.namenode.TestAclConfigFlag
          hadoop.hdfs.server.namenode.TestBlockUnderConstruction
          hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
          hadoop.hdfs.TestWriteConfigurationToDFS
          hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
          hadoop.hdfs.server.namenode.TestSecondaryNameNodeUpgrade
          hadoop.hdfs.web.TestWebHdfsWithAuthenticationFilter
          hadoop.hdfs.TestListFilesInDFS
          hadoop.hdfs.server.namenode.TestNameNodeMXBean
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport
          hadoop.hdfs.TestDFSRename
          hadoop.hdfs.server.namenode.TestNameNodeAcl
          hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant
          hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
          hadoop.hdfs.web.TestFSMainOperationsWebHdfs
          hadoop.hdfs.server.namenode.TestNamenodeRetryCache
          hadoop.hdfs.server.namenode.snapshot.TestSetQuotaWithSnapshot
          hadoop.hdfs.TestInjectionForSimulatedStorage
          hadoop.hdfs.server.namenode.TestDecommissioningStatus
          hadoop.security.TestPermissionSymlinks
          hadoop.hdfs.TestFileCorruption
          hadoop.hdfs.TestDecommission
          hadoop.hdfs.server.namenode.TestFileContextAcl
          hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
          hadoop.hdfs.TestBlockReaderLocal
          hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
          hadoop.hdfs.TestFileAppend3
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotNameWithInvalidCharacters
          hadoop.hdfs.TestBlockReaderLocalLegacy
          hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot
          hadoop.hdfs.TestDFSPermission
          hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes
          hadoop.hdfs.TestPread
          hadoop.hdfs.TestFileAppend2
          hadoop.hdfs.server.namenode.TestNameEditsConfigs
          hadoop.hdfs.server.namenode.TestBackupNode
          hadoop.hdfs.TestBlocksScheduledCounter
          hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir
          hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot
          hadoop.hdfs.server.namenode.TestEditLog
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotMetrics
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap
          hadoop.hdfs.server.namenode.TestSnapshotPathINodes
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename
          hadoop.hdfs.TestDFSOutputStream
          hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl
          hadoop.hdfs.TestFileConcurrentReader
          hadoop.hdfs.TestFsShellPermission
          hadoop.hdfs.web.TestWebHDFSAcl
          hadoop.hdfs.server.namenode.snapshot.TestFileContextSnapshot
          hadoop.cli.TestDeleteCLI
          hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
          hadoop.hdfs.TestParallelShortCircuitReadUnCached
          hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
          hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          hadoop.hdfs.server.namenode.ha.TestEditLogsDuringFailover
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion
          hadoop.hdfs.TestSetrepDecreasing
          hadoop.hdfs.web.TestJsonUtil
          hadoop.hdfs.shortcircuit.TestShortCircuitCache
          hadoop.hdfs.web.TestHttpsFileSystem
          hadoop.hdfs.server.namenode.TestAuditLogs
          hadoop.hdfs.server.namenode.TestMetaSave
          hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages
          hadoop.hdfs.server.namenode.TestProcessCorruptBlocks
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotStatsMXBean
          hadoop.hdfs.server.namenode.snapshot.TestDisallowModifyROSnapshot
          hadoop.hdfs.TestWriteBlockGetsBlockLengthHint
          hadoop.hdfs.server.namenode.TestEditLogJournalFailures
          hadoop.hdfs.web.TestWebHDFSForHA
          hadoop.hdfs.TestRemoteBlockReader2
          hadoop.cli.TestAclCLI
          hadoop.hdfs.server.namenode.TestXAttrConfigFlag
          hadoop.hdfs.server.namenode.TestINodeAttributeProvider
          hadoop.hdfs.TestReplication
          hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
          hadoop.hdfs.server.namenode.snapshot.TestUpdatePipelineWithSnapshots
          hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps
          hadoop.hdfs.tools.TestStoragePolicyCommands
          hadoop.hdfs.server.namenode.ha.TestStandbyIsHot
          hadoop.hdfs.tools.TestDebugAdmin
          hadoop.hdfs.web.TestWebHdfsFileSystemContract
          hadoop.hdfs.TestDistributedFileSystem
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength
          hadoop.hdfs.server.namenode.snapshot.TestXAttrWithSnapshot
          hadoop.hdfs.TestParallelShortCircuitRead
          hadoop.hdfs.web.TestWebHDFSXAttr
          hadoop.hdfs.TestGetFileChecksum
          hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots
          hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForContentSummary
          hadoop.hdfs.TestDFSClientFailover
          hadoop.hdfs.TestDFSClientExcludedNodes
          hadoop.hdfs.server.namenode.TestCheckpoint
          hadoop.hdfs.server.namenode.TestAddBlock
          hadoop.hdfs.server.namenode.snapshot.TestSnapshot
          hadoop.hdfs.server.namenode.snapshot.TestGetContentSummaryWithSnapshot
          hadoop.hdfs.server.namenode.TestFSDirectory
          hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForXAttr
          hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
          hadoop.hdfs.TestRemoteBlockReader
          hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality
          hadoop.hdfs.server.namenode.TestHostsFiles
          hadoop.hdfs.server.namenode.TestCacheDirectives
          hadoop.cli.TestHDFSCLI
          hadoop.hdfs.server.namenode.TestFileContextXAttr
          hadoop.hdfs.TestMissingBlocksAlert
          hadoop.hdfs.server.namenode.snapshot.TestSnapshottableDirListing
          hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
          hadoop.hdfs.web.TestWebHDFS
          hadoop.hdfs.TestEncryptedTransfer
          hadoop.hdfs.server.namenode.TestFSImage
        Timed out tests org.apache.hadoop.fs.TestHDFSFileContextMainOperations
          org.apache.hadoop.cli.TestXAttrCLI
          org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12761678/HDFS-9076.01.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / cc2b473
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12600/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12600/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12600/testReport/
        Java 1.7.0_55
        uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12600/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 21m 15s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 59s There were no new javac warning messages. +1 javadoc 11m 34s There were no new javadoc warning messages. +1 release audit 0m 34s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 36s The applied patch generated 1 new checkstyle issues (total was 152, now 152). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 57s mvn install still works. +1 eclipse:eclipse 0m 43s The patch built with eclipse:eclipse. +1 findbugs 3m 45s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 4m 24s Pre-build of native portion -1 hdfs tests 64m 55s Tests failed in hadoop-hdfs.     118m 46s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestHDFSConcat   hadoop.hdfs.server.namenode.TestFSNamesystemMBean   hadoop.hdfs.TestDFSStorageStateRecovery   hadoop.hdfs.TestHdfsAdmin   hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.hdfs.TestDFSUtil   hadoop.hdfs.server.namenode.TestStartup   hadoop.hdfs.web.TestWebHdfsTokens   hadoop.hdfs.TestDisableConnCache   hadoop.hdfs.server.namenode.snapshot.TestSnapshotListing   hadoop.hdfs.server.namenode.TestLargeDirectoryDelete   hadoop.hdfs.server.namenode.TestAclConfigFlag   hadoop.hdfs.server.namenode.TestBlockUnderConstruction   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.TestWriteConfigurationToDFS   hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics   hadoop.hdfs.server.namenode.TestSecondaryNameNodeUpgrade   hadoop.hdfs.web.TestWebHdfsWithAuthenticationFilter   hadoop.hdfs.TestListFilesInDFS   hadoop.hdfs.server.namenode.TestNameNodeMXBean   hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport   hadoop.hdfs.TestDFSRename   hadoop.hdfs.server.namenode.TestNameNodeAcl   hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant   hadoop.hdfs.server.namenode.TestFSImageWithSnapshot   hadoop.hdfs.web.TestFSMainOperationsWebHdfs   hadoop.hdfs.server.namenode.TestNamenodeRetryCache   hadoop.hdfs.server.namenode.snapshot.TestSetQuotaWithSnapshot   hadoop.hdfs.TestInjectionForSimulatedStorage   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.security.TestPermissionSymlinks   hadoop.hdfs.TestFileCorruption   hadoop.hdfs.TestDecommission   hadoop.hdfs.server.namenode.TestFileContextAcl   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer   hadoop.hdfs.TestBlockReaderLocal   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.TestFileAppend3   hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication   hadoop.hdfs.server.namenode.snapshot.TestSnapshotNameWithInvalidCharacters   hadoop.hdfs.TestBlockReaderLocalLegacy   hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot   hadoop.hdfs.TestDFSPermission   hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes   hadoop.hdfs.TestPread   hadoop.hdfs.TestFileAppend2   hadoop.hdfs.server.namenode.TestNameEditsConfigs   hadoop.hdfs.server.namenode.TestBackupNode   hadoop.hdfs.TestBlocksScheduledCounter   hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir   hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot   hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.server.namenode.snapshot.TestSnapshotMetrics   hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap   hadoop.hdfs.server.namenode.TestSnapshotPathINodes   hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename   hadoop.hdfs.TestDFSOutputStream   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl   hadoop.hdfs.TestFileConcurrentReader   hadoop.hdfs.TestFsShellPermission   hadoop.hdfs.web.TestWebHDFSAcl   hadoop.hdfs.server.namenode.snapshot.TestFileContextSnapshot   hadoop.cli.TestDeleteCLI   hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots   hadoop.hdfs.TestParallelShortCircuitReadUnCached   hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.namenode.ha.TestEditLogsDuringFailover   hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion   hadoop.hdfs.TestSetrepDecreasing   hadoop.hdfs.web.TestJsonUtil   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.web.TestHttpsFileSystem   hadoop.hdfs.server.namenode.TestAuditLogs   hadoop.hdfs.server.namenode.TestMetaSave   hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages   hadoop.hdfs.server.namenode.TestProcessCorruptBlocks   hadoop.hdfs.server.namenode.snapshot.TestSnapshotStatsMXBean   hadoop.hdfs.server.namenode.snapshot.TestDisallowModifyROSnapshot   hadoop.hdfs.TestWriteBlockGetsBlockLengthHint   hadoop.hdfs.server.namenode.TestEditLogJournalFailures   hadoop.hdfs.web.TestWebHDFSForHA   hadoop.hdfs.TestRemoteBlockReader2   hadoop.cli.TestAclCLI   hadoop.hdfs.server.namenode.TestXAttrConfigFlag   hadoop.hdfs.server.namenode.TestINodeAttributeProvider   hadoop.hdfs.TestReplication   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.namenode.snapshot.TestUpdatePipelineWithSnapshots   hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps   hadoop.hdfs.tools.TestStoragePolicyCommands   hadoop.hdfs.server.namenode.ha.TestStandbyIsHot   hadoop.hdfs.tools.TestDebugAdmin   hadoop.hdfs.web.TestWebHdfsFileSystemContract   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength   hadoop.hdfs.server.namenode.snapshot.TestXAttrWithSnapshot   hadoop.hdfs.TestParallelShortCircuitRead   hadoop.hdfs.web.TestWebHDFSXAttr   hadoop.hdfs.TestGetFileChecksum   hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForContentSummary   hadoop.hdfs.TestDFSClientFailover   hadoop.hdfs.TestDFSClientExcludedNodes   hadoop.hdfs.server.namenode.TestCheckpoint   hadoop.hdfs.server.namenode.TestAddBlock   hadoop.hdfs.server.namenode.snapshot.TestSnapshot   hadoop.hdfs.server.namenode.snapshot.TestGetContentSummaryWithSnapshot   hadoop.hdfs.server.namenode.TestFSDirectory   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForXAttr   hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer   hadoop.hdfs.TestRemoteBlockReader   hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality   hadoop.hdfs.server.namenode.TestHostsFiles   hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.cli.TestHDFSCLI   hadoop.hdfs.server.namenode.TestFileContextXAttr   hadoop.hdfs.TestMissingBlocksAlert   hadoop.hdfs.server.namenode.snapshot.TestSnapshottableDirListing   hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead   hadoop.hdfs.web.TestWebHDFS   hadoop.hdfs.TestEncryptedTransfer   hadoop.hdfs.server.namenode.TestFSImage Timed out tests org.apache.hadoop.fs.TestHDFSFileContextMainOperations   org.apache.hadoop.cli.TestXAttrCLI   org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12761678/HDFS-9076.01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / cc2b473 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12600/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12600/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12600/testReport/ Java 1.7.0_55 uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12600/console This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Can you please update the Log message as below. ?

                  LOG.error("Failed to " + (abort ? "abort" : "close") + " file: "
                      + out.getSrc() + " with inode: " + inodeId, ie);
        Show
        vinayrpet Vinayakumar B added a comment - Can you please update the Log message as below. ? LOG.error( "Failed to " + (abort ? "abort" : "close" ) + " file: " + out.getSrc() + " with inode: " + inodeId, ie);
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Thanks Vinayakumar B for review..
        Attached updated patch, please review...

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Thanks Vinayakumar B for review.. Attached updated patch, please review...
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 8s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 58s There were no new javac warning messages.
        +1 javadoc 11m 16s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 24s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 26s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 2m 29s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 8s Pre-build of native portion
        -1 hdfs tests 170m 9s Tests failed in hadoop-hdfs.
            216m 59s  



        Reason Tests
        Failed unit tests hadoop.hdfs.web.TestWebHDFSOAuth2
        Timed out tests org.apache.hadoop.hdfs.TestPread



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12762050/HDFS-9076.02.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 06d1c90
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12652/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12652/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12652/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 8s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 58s There were no new javac warning messages. +1 javadoc 11m 16s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 24s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 26s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 29s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 8s Pre-build of native portion -1 hdfs tests 170m 9s Tests failed in hadoop-hdfs.     216m 59s   Reason Tests Failed unit tests hadoop.hdfs.web.TestWebHDFSOAuth2 Timed out tests org.apache.hadoop.hdfs.TestPread Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12762050/HDFS-9076.02.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 06d1c90 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12652/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12652/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12652/console This message was automatically generated.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Failed test cases are unrelated..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Failed test cases are unrelated..
        Hide
        vinayrpet Vinayakumar B added a comment -

        test failures are unrelated.
        As this is log message change, no need of test.

        +1.

        Show
        vinayrpet Vinayakumar B added a comment - test failures are unrelated. As this is log message change, no need of test. +1.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Committed to trunk and branch-2.
        Thanks Surendra Singh Lilhore

        Show
        vinayrpet Vinayakumar B added a comment - Committed to trunk and branch-2. Thanks Surendra Singh Lilhore
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8512 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8512/)
        HDFS-9076. Log full path instead of inodeId in DFSClient#closeAllFilesBeingWritten() (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev e52bc697f8f9c255dfc4d01b71272931153721c9)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8512 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8512/ ) HDFS-9076 . Log full path instead of inodeId in DFSClient#closeAllFilesBeingWritten() (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev e52bc697f8f9c255dfc4d01b71272931153721c9) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #441 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/441/)
        HDFS-9076. Log full path instead of inodeId in DFSClient#closeAllFilesBeingWritten() (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev e52bc697f8f9c255dfc4d01b71272931153721c9)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #441 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/441/ ) HDFS-9076 . Log full path instead of inodeId in DFSClient#closeAllFilesBeingWritten() (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev e52bc697f8f9c255dfc4d01b71272931153721c9) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2379 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2379/)
        HDFS-9076. Log full path instead of inodeId in DFSClient#closeAllFilesBeingWritten() (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev e52bc697f8f9c255dfc4d01b71272931153721c9)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2379 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2379/ ) HDFS-9076 . Log full path instead of inodeId in DFSClient#closeAllFilesBeingWritten() (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev e52bc697f8f9c255dfc4d01b71272931153721c9) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #434 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/434/)
        HDFS-9076. Log full path instead of inodeId in DFSClient#closeAllFilesBeingWritten() (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev e52bc697f8f9c255dfc4d01b71272931153721c9)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #434 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/434/ ) HDFS-9076 . Log full path instead of inodeId in DFSClient#closeAllFilesBeingWritten() (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev e52bc697f8f9c255dfc4d01b71272931153721c9) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1174 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1174/)
        HDFS-9076. Log full path instead of inodeId in DFSClient#closeAllFilesBeingWritten() (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev e52bc697f8f9c255dfc4d01b71272931153721c9)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1174 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1174/ ) HDFS-9076 . Log full path instead of inodeId in DFSClient#closeAllFilesBeingWritten() (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev e52bc697f8f9c255dfc4d01b71272931153721c9) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #413 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/413/)
        HDFS-9076. Log full path instead of inodeId in DFSClient#closeAllFilesBeingWritten() (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev e52bc697f8f9c255dfc4d01b71272931153721c9)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #413 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/413/ ) HDFS-9076 . Log full path instead of inodeId in DFSClient#closeAllFilesBeingWritten() (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev e52bc697f8f9c255dfc4d01b71272931153721c9) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2352 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2352/)
        HDFS-9076. Log full path instead of inodeId in DFSClient#closeAllFilesBeingWritten() (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev e52bc697f8f9c255dfc4d01b71272931153721c9)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2352 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2352/ ) HDFS-9076 . Log full path instead of inodeId in DFSClient#closeAllFilesBeingWritten() (Contributed by Surendra Singh Lilhore) (vinayakumarb: rev e52bc697f8f9c255dfc4d01b71272931153721c9) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Thanks Vinayakumar B for review and commit..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Thanks Vinayakumar B for review and commit..

          People

          • Assignee:
            surendrasingh Surendra Singh Lilhore
            Reporter:
            surendrasingh Surendra Singh Lilhore
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development