Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9072

Fix random failures in TestJMXGet

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Critical
        • Resolution: Fixed
        • Affects Version/s: 2.8.0, 3.0.0-alpha1
        • Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
        • Component/s: test
        • Labels:
          None

          Description

          There is a slight delay in updating the jmx values after HDFS operations. But assertions are done even that . Hence following testcases fails.

          TestJMXGet#testNameNode()
          TestJMXGet#testDataNode()

          1. Text File
            HDFS-9072-01.patch
            1 kB
            J.Andreina
          2. Text File
            HDFS-9072-br27.patch
            4 kB
            Kihwal Lee

            Issue Links

            breaks

            Bug - A problem which impairs or prevents the functions of the product. HADOOP-12419 branch-2 stopped compiling; DfsTestUtils not found from TestJMXGet

            • Blocker - Blocks development and/or testing work, production could not run
            • Resolved

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              stevel@apache.org Steve Loughran added a comment -

              uprating to critical as it is breaking jenkins.

              patch welcome and I'll try to review fast

              Show
              stevel@apache.org Steve Loughran added a comment - uprating to critical as it is breaking jenkins. patch welcome and I'll try to review fast
              Hide
              Permalink
              andreina J.Andreina added a comment -

              Updated the patch.
              Please review.

              Show
              andreina J.Andreina added a comment - Updated the patch. Please review.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -



              -1 overall



              Vote Subsystem Runtime Comment
              0 pre-patch 7m 57s Pre-patch trunk compilation is healthy.
              +1 @author 0m 0s The patch does not contain any @author tags.
              +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
              +1 javac 7m 55s There were no new javac warning messages.
              +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
              +1 checkstyle 1m 20s There were no new checkstyle issues.
              +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              +1 install 1m 26s mvn install still works.
              +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
              +1 findbugs 2m 26s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
              +1 native 1m 13s Pre-build of native portion
              -1 hdfs tests 169m 18s Tests failed in hadoop-hdfs.
                  192m 33s  



              Reason Tests
              Failed unit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaPlacement
                hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistLockedMemory
                hadoop.hdfs.TestDistributedFileSystem
                hadoop.hdfs.security.TestDelegationToken
                hadoop.hdfs.server.namenode.TestFsck



              Subsystem Report/Notes
              Patch URL http://issues.apache.org/jira/secure/attachment/12756025/HDFS-9072-01.patch
              Optional Tests javac unit findbugs checkstyle
              git revision trunk / 73e3a49
              hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12450/artifact/patchprocess/testrun_hadoop-hdfs.txt
              Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12450/testReport/
              Java 1.7.0_55
              uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12450/console

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 7m 57s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 55s There were no new javac warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 20s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 26s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 26s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 13s Pre-build of native portion -1 hdfs tests 169m 18s Tests failed in hadoop-hdfs.     192m 33s   Reason Tests Failed unit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaPlacement   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistLockedMemory   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.security.TestDelegationToken   hadoop.hdfs.server.namenode.TestFsck Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12756025/HDFS-9072-01.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 73e3a49 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12450/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12450/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12450/console This message was automatically generated.
              Hide
              Permalink
              andreina J.Andreina added a comment -

              Testcases failures in TestLazyPersistLockedMemory , TestLazyPersistReplicaPlacement class will be fixed in HDFS-9073.
              Rest of the testcase failures are unrelated.
              Please review.

              Show
              andreina J.Andreina added a comment - Testcases failures in TestLazyPersistLockedMemory , TestLazyPersistReplicaPlacement class will be fixed in HDFS-9073 . Rest of the testcase failures are unrelated. Please review.
              Hide
              Permalink
              stevel@apache.org Steve Loughran added a comment -

              +1, committed —thanks!

              Show
              stevel@apache.org Steve Loughran added a comment - +1, committed —thanks!
              Hide
              Permalink
              andreina J.Andreina added a comment -

              Thanks Steve Loughran for the commit

              Show
              andreina J.Andreina added a comment - Thanks Steve Loughran for the commit
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-trunk-Commit #8465 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8465/)
              HDFS-9072. Fix random failures in TestJMXGet. (J.Andreina via stevel) (stevel: rev 44776437493db3dc7796fcd23a0301bc48a1781c)

              • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestJMXGet.java
              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8465 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8465/ ) HDFS-9072 . Fix random failures in TestJMXGet. (J.Andreina via stevel) (stevel: rev 44776437493db3dc7796fcd23a0301bc48a1781c) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestJMXGet.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Hide
              Permalink
              hudson Hudson added a comment -

              SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #403 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/403/)
              HDFS-9072. Fix random failures in TestJMXGet. (J.Andreina via stevel) (stevel: rev 44776437493db3dc7796fcd23a0301bc48a1781c)

              • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestJMXGet.java
              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Show
              hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #403 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/403/ ) HDFS-9072 . Fix random failures in TestJMXGet. (J.Andreina via stevel) (stevel: rev 44776437493db3dc7796fcd23a0301bc48a1781c) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestJMXGet.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-Yarn-trunk #1137 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1137/)
              HDFS-9072. Fix random failures in TestJMXGet. (J.Andreina via stevel) (stevel: rev 44776437493db3dc7796fcd23a0301bc48a1781c)

              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestJMXGet.java
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1137 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1137/ ) HDFS-9072 . Fix random failures in TestJMXGet. (J.Andreina via stevel) (stevel: rev 44776437493db3dc7796fcd23a0301bc48a1781c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestJMXGet.java
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-Mapreduce-trunk #2343 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2343/)
              HDFS-9072. Fix random failures in TestJMXGet. (J.Andreina via stevel) (stevel: rev 44776437493db3dc7796fcd23a0301bc48a1781c)

              • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestJMXGet.java
              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2343 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2343/ ) HDFS-9072 . Fix random failures in TestJMXGet. (J.Andreina via stevel) (stevel: rev 44776437493db3dc7796fcd23a0301bc48a1781c) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestJMXGet.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-Hdfs-trunk #2318 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2318/)
              HDFS-9072. Fix random failures in TestJMXGet. (J.Andreina via stevel) (stevel: rev 44776437493db3dc7796fcd23a0301bc48a1781c)

              • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestJMXGet.java
              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2318 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2318/ ) HDFS-9072 . Fix random failures in TestJMXGet. (J.Andreina via stevel) (stevel: rev 44776437493db3dc7796fcd23a0301bc48a1781c) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestJMXGet.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #396 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/396/)
              HDFS-9072. Fix random failures in TestJMXGet. (J.Andreina via stevel) (stevel: rev 44776437493db3dc7796fcd23a0301bc48a1781c)

              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestJMXGet.java
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #396 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/396/ ) HDFS-9072 . Fix random failures in TestJMXGet. (J.Andreina via stevel) (stevel: rev 44776437493db3dc7796fcd23a0301bc48a1781c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestJMXGet.java
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #379 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/379/)
              HDFS-9072. Fix random failures in TestJMXGet. (J.Andreina via stevel) (stevel: rev 44776437493db3dc7796fcd23a0301bc48a1781c)

              • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestJMXGet.java
              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #379 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/379/ ) HDFS-9072 . Fix random failures in TestJMXGet. (J.Andreina via stevel) (stevel: rev 44776437493db3dc7796fcd23a0301bc48a1781c) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestJMXGet.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Hide
              Permalink
              atm Aaron T. Myers added a comment -

              Hey Steve Loughran, it looks to me like this commit broke branch-2 compilation due to a missing import of DFSTestUtil. I just pushed a little commit to fix branch-2 compilation (e533555b577c3678aa7a430c6b084973187de18a) and was hoping you could take a look at it when you get a chance.

              Show
              atm Aaron T. Myers added a comment - Hey Steve Loughran , it looks to me like this commit broke branch-2 compilation due to a missing import of DFSTestUtil . I just pushed a little commit to fix branch-2 compilation (e533555b577c3678aa7a430c6b084973187de18a) and was hoping you could take a look at it when you get a chance.
              Hide
              Permalink
              kihwal Kihwal Lee added a comment -

              The two test cases are also failing in branch-2.7. The trunk patch applies, but its dependency, HDFS-9067, is not applicable to 2.7 as it is patching the non-existant TestLazyWriter as well.

              I am attaching the patch that includes DFSTestUtil.waitForMetric().

              Show
              kihwal Kihwal Lee added a comment - The two test cases are also failing in branch-2.7. The trunk patch applies, but its dependency, HDFS-9067 , is not applicable to 2.7 as it is patching the non-existant TestLazyWriter as well. I am attaching the patch that includes DFSTestUtil.waitForMetric() .
              Hide
              Permalink
              daryn Daryn Sharp added a comment -

              +1 but please file a new jira since this appears to loop forever waiting for the metric. the 1s delay probably wastes a lot of runtime in the tests...

              Show
              daryn Daryn Sharp added a comment - +1 but please file a new jira since this appears to loop forever waiting for the metric. the 1s delay probably wastes a lot of runtime in the tests...
              Hide
              Permalink
              kihwal Kihwal Lee added a comment -

              please file a new jira since this appears to loop forever waiting for the metric

              Filed HDFS-9740.

              Show
              kihwal Kihwal Lee added a comment - please file a new jira since this appears to loop forever waiting for the metric Filed HDFS-9740 .
              Hide
              Permalink
              kihwal Kihwal Lee added a comment -

              Committed the patch to 2.7.

              Show
              kihwal Kihwal Lee added a comment - Committed the patch to 2.7.
              Hide
              Permalink
              vinodkv Vinod Kumar Vavilapalli added a comment -

              Closing the JIRA as part of 2.7.3 release.

              Show
              vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

                People

                • Assignee:
                  andreina J.Andreina
                  Reporter:
                  andreina J.Andreina
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  8 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development